karafka 2.3.0 → 2.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bceb8995575bd7c51d4fa6df9905619082080c932b5295749d9562fb53eba2a7
-  data.tar.gz: d16247c466fe08f6a671e48e8b25af7edcf2c32d769a497a46245773a66794de
+  metadata.gz: 9d28565a68d29a1f8f14be1878bf3a1f41611028069586fb4ece1572b8eb72eb
+  data.tar.gz: 8c7f6ea1ec67e07ed107c7347d594a26ba923cecc7282c346eb24863e0324412
 SHA512:
-  metadata.gz: 3367c6bace7ab7a1ed7c6ef04e41eefa40c6fef7baf41d0e8e32bb891e1f2799e1564a6ee36b38735b5d514272c88c62e90bcbb54ffa45f175e80b888837d1e5
-  data.tar.gz: 2d31b87c97ce9deb3d47c0332782ad116dbcf4661a7ea55b35ac04a0e87003a8eb73a5b50f7fc9a21eb1ad288eaafff0528b95133fe58f97ada832526959b628
+  metadata.gz: 73d43079b8e83babe2f722acdd11a67d6a5c361998ffada9b46b0f28b3ebc9c430d7b28cf56cb2aba808e25c234fffc7b2ee945e9e265160fb7cba6f821fcc70
+  data.tar.gz: 465b1088763ddc3ea63e53ef92765ae5719d6d1a83522288976321d1a64d24616b06d6571ce11425fd8a0dbf36d8c595871b92abfc8de8bcecc444181afe5123

checksums.yaml.gz.sig

@@ -1,3 +1,4 @@
-B|�gb�B��Lz�9؋���E��SlU�Ȇ�)ݦ�M���ZG
-�N�I��3��s��w�h��j81�ҳ�	���\�pt�p�B����P�h�jr����
�
-����~
+�QW�,A�՞`z��D��}���������Zt��j��͡$�p�;ܹY��
�w���	2�¨�a��z������M�]�q]�o!,\d������G��_e{�.�({S�
+ƅ����Jg3kJ��K6��������k2�	�Hc��Ѭ�9JfH���Yj������+!b\�%�h��
+|Z��t\I�,�X���o��
+^K���Vja��������@�9���P@ax߯u�>n�-�@�"JT�aR�?� -S��T�!~�ѿ��y��l�XJ�G�6n���0��j@�h/*̵R�����w�<E��[o~gE�+%m��}Ҥ���N�Գ�D��pi���J��Q���˜Z�X"��I����xK=�q�

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Karafka framework changelog
 
+## 2.3.1 (2024-02-08)
+- [Refactor] Ensure that `Karafka::Helpers::Async#async_call` can run from multiple threads.
+
 ## 2.3.0 (2024-01-26)
 - **[Feature]** Introduce Exactly-Once Semantics within consumers `#transaction` block (Pro)
 - **[Feature]** Provide ability to multiplex subscription groups (Pro)

data/Gemfile

@@ -10,7 +10,7 @@ gemspec
 # They are added here because they are part of the integration suite
 group :integrations do
   gem 'activejob'
-  gem 'karafka-web', '>= 0.8.0.rc1'
+  gem 'karafka-web', '>= 0.8.0'
 end
 
 group :test do

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    karafka (2.3.0)
+    karafka (2.3.1)
       karafka-core (>= 2.3.0, < 2.4.0)
       waterdrop (>= 2.6.12, < 3.0.0)
       zeitwerk (~> 2.3)
@@ -27,7 +27,7 @@ GEM
     byebug (11.1.3)
     concurrent-ruby (1.2.3)
     connection_pool (2.4.1)
-    diff-lcs (1.5.0)
+    diff-lcs (1.5.1)
     docile (1.4.0)
     drb (2.2.0)
       ruby2_keywords
@@ -41,36 +41,36 @@ GEM
       concurrent-ruby (~> 1.0)
     karafka-core (2.3.0)
       karafka-rdkafka (>= 0.14.8, < 0.15.0)
-    karafka-rdkafka (0.14.8)
+    karafka-rdkafka (0.14.9)
       ffi (~> 1.15)
       mini_portile2 (~> 2.6)
       rake (> 12)
-    karafka-web (0.8.0.rc1)
+    karafka-web (0.8.1)
       erubi (~> 1.4)
-      karafka (>= 2.3.0.rc1, < 2.4.0)
-      karafka-core (>= 2.3.0.rc1, < 2.4.0)
+      karafka (>= 2.3.0, < 2.4.0)
+      karafka-core (>= 2.3.0, < 2.4.0)
       roda (~> 3.68, >= 3.69)
       tilt (~> 2.0)
     mini_portile2 (2.8.5)
     minitest (5.21.2)
     mutex_m (0.2.0)
-    rack (3.0.8)
+    rack (3.0.9)
     rake (13.1.0)
     roda (3.76.0)
       rack
-    rspec (3.12.0)
-      rspec-core (~> 3.12.0)
-      rspec-expectations (~> 3.12.0)
-      rspec-mocks (~> 3.12.0)
-    rspec-core (3.12.2)
-      rspec-support (~> 3.12.0)
-    rspec-expectations (3.12.3)
+    rspec (3.13.0)
+      rspec-core (~> 3.13.0)
+      rspec-expectations (~> 3.13.0)
+      rspec-mocks (~> 3.13.0)
+    rspec-core (3.13.0)
+      rspec-support (~> 3.13.0)
+    rspec-expectations (3.13.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.12.0)
-    rspec-mocks (3.12.6)
+      rspec-support (~> 3.13.0)
+    rspec-mocks (3.13.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.12.0)
-    rspec-support (3.12.1)
+      rspec-support (~> 3.13.0)
+    rspec-support (3.13.0)
     ruby2_keywords (0.0.5)
     simplecov (0.22.0)
       docile (~> 1.1)
@@ -81,7 +81,7 @@ GEM
     tilt (2.3.0)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    waterdrop (2.6.12)
+    waterdrop (2.6.13)
       karafka-core (>= 2.2.3, < 3.0.0)
       zeitwerk (~> 2.3)
     zeitwerk (2.6.12)
@@ -95,7 +95,7 @@ DEPENDENCIES
   byebug
   factory_bot
   karafka!
-  karafka-web (>= 0.8.0.rc1)
+  karafka-web (>= 0.8.0)
   rspec
   simplecov
 

data/README.md

@@ -57,8 +57,8 @@ We also maintain many [integration specs](https://github.com/karafka/karafka/tre
 1. Add and install Karafka:
 
 ```bash
-# Make sure to install Karafka 2.2
-bundle add karafka --version ">= 2.2.10"
+# Make sure to install Karafka 2.3
+bundle add karafka --version ">= 2.3.0"
 
 bundle exec karafka install
 ```

data/lib/karafka/helpers/async.rb

@@ -8,6 +8,12 @@ module Karafka
     # @note Thread running code needs to manage it's own exceptions. If they leak out, they will
     #   abort thread on exception.
     module Async
+      # Mutex used to ensure we do not create multiple threads if we decide to run this
+      # in parallel on multiple threads
+      MUTEX = Mutex.new
+
+      private_constant :MUTEX
+
       class << self
         # Adds forwardable to redirect thread-based control methods to the underlying thread that
         # runs the async operations
@@ -22,10 +28,14 @@ module Karafka
 
       # Runs the `#call` method in a new thread
       def async_call
-        @thread = Thread.new do
-          Thread.current.abort_on_exception = true
+        MUTEX.synchronize do
+          return if @thread&.alive?
+
+          @thread = Thread.new do
+            Thread.current.abort_on_exception = true
 
-          call
+            call
+          end
         end
       end
     end

data/lib/karafka/runner.rb

@@ -18,6 +18,10 @@ module Karafka
       workers = Processing::WorkersBatch.new(jobs_queue)
       listeners = Connection::ListenersBatch.new(jobs_queue)
 
+      # We mark it prior to delegating to the manager as manager will have to start at least one
+      # connection to Kafka, hence running
+      Karafka::App.run!
+
       # Register all the listeners so they can be started and managed
       @manager.register(listeners)
 

data/lib/karafka/server.rb

@@ -61,10 +61,9 @@ module Karafka
       end
 
       # Starts Karafka with a supervision
-      # @note We don't need to sleep because Karafka::Fetcher is locking and waiting to
-      # finish loop (and it won't happen until we explicitly want to stop)
+      # @note We don't need to sleep because Karafka::Runner is locking and waiting to finish loop
+      # (and it won't happen until we explicitly want to stop)
       def start
-        Karafka::App.run!
         Karafka::Runner.new.call
       end
 

data/lib/karafka/templates/karafka.rb.erb

@@ -73,5 +73,3 @@ end
 # Visit the setup documentation to get started and enhance your experience.
 #
 # https://karafka.io/docs/Web-UI-Getting-Started
-#
-# Karafka::Web.enable!

data/lib/karafka/version.rb

@@ -3,5 +3,5 @@
 # Main module namespace
 module Karafka
   # Current Karafka version
-  VERSION = '2.3.0'
+  VERSION = '2.3.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: karafka
 version: !ruby/object:Gem::Version
-  version: 2.3.0
+  version: 2.3.1
 platform: ruby
 authors:
 - Maciej Mensfeld
@@ -35,7 +35,7 @@ cert_chain:
   AnG1dJU+yL2BK7vaVytLTstJME5mepSZ46qqIJXMuWob/YPDmVaBF39TDSG9e34s
   msG3BiCqgOgHAnL23+CN3Rt8MsuRfEtoTKpJVcCfoEoNHOkc
   -----END CERTIFICATE-----
-date: 2024-01-26 00:00:00.000000000 Z
+date: 2024-02-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: karafka-core