karafka 2.2.0 → 2.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6ca6426dc8527aac122a1d9ebcaccf33a4eff1608133b210e68e66d3a5f5c2c7
-  data.tar.gz: 85233cc04e591e5a96d53b3b9d3fe203b4b56bbde24c564ffa3663daeb3673c6
+  metadata.gz: a96aaf1f1cc1fadbeb09477a107efc11319f288b0e5d94f959813d7f85d295bf
+  data.tar.gz: b0db0711ceb51856771ba6906c0868f51637d78bd785c25005408449d32a3302
 SHA512:
-  metadata.gz: e89b72adccdb6a622d571ab9c580191e725cdb98d88f5d86f59d9e4a9900eff74fa438b3838cfe104f7259c0c4cee0dc60f7fb6d16cf14b59ff9229170bae504
-  data.tar.gz: a8ba4b92e1002c6d1112837e1b96706208ba0d55fa39feaadaa4f04f4c616095eb406d72bffa50bd346fb1daff7ca45951efd2237a71c25a7539be5a4397a781
+  metadata.gz: 7c37db7c2de5b131f34c08fe73e4453ea81d0ec99b4a5764b41ca98c7c8ff064b1b9f8bfee5e26bbae267ca77b3b5e72d72d90c9b4e034c6ead0d90b931f1fa9
+  data.tar.gz: 55131983670c0454f3f5a23df2b0d90b8718455f8f331ee660cd20dd3f131540188149f36efbb7842fe1561de4cb7f85d8892477deefbd1eb0c071722f2ffa72

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Karafka framework changelog
 
+## 2.2.1 (2023-09-01)
+- [Fix] Fix insufficient validation of named patterns
+- [Maintenance] Rely on `2.2.x` `karafka-core`.
+
 ## 2.2.0 (2023-09-01)
 - **[Feature]** Introduce dynamic topic subscriptions based on patterns [Pro].
 - [Enhancement] Allow for `Karafka::Admin` setup reconfiguration via `config.admin` scope.

data/Gemfile.lock

@@ -1,8 +1,8 @@
 PATH
   remote: .
   specs:
-    karafka (2.2.0)
-      karafka-core (>= 2.1.1, < 2.2.0)
+    karafka (2.2.1)
+      karafka-core (>= 2.2.0, < 2.3.0)
       thor (>= 0.20)
       waterdrop (>= 2.6.6, < 3.0.0)
       zeitwerk (~> 2.3)
@@ -23,14 +23,14 @@ GEM
     diff-lcs (1.5.0)
     docile (1.4.0)
     erubi (1.12.0)
-    factory_bot (6.2.1)
+    factory_bot (6.3.0)
       activesupport (>= 5.0.0)
     ffi (1.15.5)
     globalid (1.1.0)
       activesupport (>= 5.0)
     i18n (1.14.1)
       concurrent-ruby (~> 1.0)
-    karafka-core (2.1.1)
+    karafka-core (2.2.0)
       concurrent-ruby (>= 1.1)
       karafka-rdkafka (>= 0.13.1, < 0.14.0)
     karafka-rdkafka (0.13.4)

data/karafka.gemspec

@@ -21,7 +21,7 @@ Gem::Specification.new do |spec|
     without having to focus on things that are not your business domain.
   DESC
 
-  spec.add_dependency 'karafka-core', '>= 2.1.1', '< 2.2.0'
+  spec.add_dependency 'karafka-core', '>= 2.2.0', '< 2.3.0'
   spec.add_dependency 'thor', '>= 0.20'
   spec.add_dependency 'waterdrop', '>= 2.6.6', '< 3.0.0'
   spec.add_dependency 'zeitwerk', '~> 2.3'

data/lib/karafka/pro/routing/features/patterns/pattern.rb

@@ -53,7 +53,7 @@ module Karafka
               # topic but this minimizes simple mistakes
               #
               # This sub-part of sh1 should be unique enough and short-enough to use it here
-              digest = Digest::SHA1.hexdigest(regexp.source)[8..16]
+              digest = Digest::SHA1.hexdigest(safe_regexp.source)[8..16]
               @name = name ? name.to_s : "karafka-pattern-#{digest}"
               @config = config
             end
@@ -62,7 +62,7 @@ module Karafka
             #   librdkafka expectations. We use it as a subscription name for initial patterns
             #   subscription start.
             def regexp_string
-              "^#{regexp.source}"
+              "^#{safe_regexp.source}"
             end
 
             # @return [Hash] hash representation of this routing pattern
@@ -73,6 +73,20 @@ module Karafka
                 regexp_string: regexp_string
               }.freeze
             end
+
+            private
+
+            # Since pattern building happens before validations and we rely internally on the fact
+            # that regexp is provided and nothing else, we here "sanitize" the regexp for our
+            # internal usage. Karafka will not run anyhow because our post-routing contracts will
+            # prevent it from running but internally in this component we need to ensure, that
+            # prior to the validations we operate on a regexp
+            #
+            # @return [Regexp] returns a regexp always even if what we've received was not a regexp
+            def safe_regexp
+              # This regexp will never match anything
+              regexp.is_a?(Regexp) ? regexp : /$a/
+            end
           end
         end
       end

data/lib/karafka/version.rb

@@ -3,5 +3,5 @@
 # Main module namespace
 module Karafka
   # Current Karafka version
-  VERSION = '2.2.0'
+  VERSION = '2.2.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: karafka
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.2.1
 platform: ruby
 authors:
 - Maciej Mensfeld
@@ -43,20 +43,20 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.1.1
+        version: 2.2.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 2.2.0
+        version: 2.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.1.1
+        version: 2.2.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 2.2.0
+        version: 2.3.0
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement