karafka 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ffe10d1ca48b0b218191231ec6969f3a767f5a1a4010dca0ef00fa44c2eaab67
-  data.tar.gz: 27d1b52ba3782b562176b7a6de73563bdd48c250bc0576a1821c55bfcec07bff
+  metadata.gz: 5ac8399f2185d0bb8068800b27b4f354b6ff9daa02dff11436eead93c2f7bc87
+  data.tar.gz: f6c27fa56b658887f2cf9e2ceb6f735889f86b41291ea123cca354a37f42fa27
 SHA512:
-  metadata.gz: 85bdedfe0791c7d17abbc54ed49df83e2c9cbfb048124107d403559e72b2884909bcc5974c98a738744f80184315b2ee31cc8bd1048cc5a10230e6b6f0184e3d
-  data.tar.gz: 382074bee041ed27776571816a982fbd7f0af6b6f9cfa8fa393113acf1c2d4cbfb0a7573d2bcd16f2662667d1b8175546e281deb5a7b66ce30b5d9c4c19d005d
+  metadata.gz: 489b6f20d26d55d67aef878ede57180f369107a1f77c8fe765acfc6d3005a31f21f9ce0677336efcc7df903b9525851c64303906778ca5192b415d83998b4273
+  data.tar.gz: 57e2c3dc857b942808e1969feb97c386f4b2c3ee44ad6e34568d1ee2bb58b3fe857ebb8ae1d6e5293c4d76f30cdcb3424fe6a31f6efda70651e90abff4cc54d3

data/.ruby-version

@@ -1 +1 @@
-2.6.3
+2.6.5

data/.travis.yml

@@ -19,13 +19,13 @@ test: &test
 jobs:
   include:
     - <<: *test
-      rvm: 2.6.3
+      rvm: 2.6.5
     - <<: *test
       rvm: 2.5.5
 
     - stage: coditsu
       language: ruby
-      rvm: 2.6.3
+      rvm: 2.6.5
       before_install:
         - gem update --system
         - gem install bundler

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Karafka framework changelog
 
+## Unreleased (master)
+
+## 1.3.1 (2019-11-11)
+- #545 - Makes sure the log directory exists when is possible (robertomiranda)
+- Ruby 2.6.5 support
+- #551 - add support for DSA keys
+- #549 - Missing directories after `karafka install` (nijikon)
+
 ## 1.3.0 (2019-09-09)
 - Drop support for Ruby 2.4
 - YARD docs tags cleanup

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    karafka (1.3.0)
+    karafka (1.3.1)
       dry-configurable (~> 0.8)
       dry-inflector (~> 0.1)
       dry-monitor (~> 0.3)
@@ -18,12 +18,12 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.0.0)
+    activesupport (6.0.1)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 0.7, < 2)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
-      zeitwerk (~> 2.1, >= 2.1.8)
+      zeitwerk (~> 2.2)
     byebug (11.0.1)
     concurrent-ruby (1.1.5)
     delivery_boy (0.2.8)
@@ -32,7 +32,7 @@ GEM
     diff-lcs (1.3)
     digest-crc (0.4.1)
     docile (1.3.2)
-    dry-configurable (0.8.3)
+    dry-configurable (0.9.0)
       concurrent-ruby (~> 1.0)
       dry-core (~> 0.4, >= 0.4.7)
     dry-container (0.7.2)
@@ -40,14 +40,14 @@ GEM
       dry-configurable (~> 0.1, >= 0.1.3)
     dry-core (0.4.9)
       concurrent-ruby (~> 1.0)
-    dry-equalizer (0.2.2)
+    dry-equalizer (0.3.0)
     dry-events (0.2.0)
       concurrent-ruby (~> 1.0)
       dry-core (~> 0.4)
       dry-equalizer (~> 0.2)
-    dry-inflector (0.1.2)
-    dry-initializer (3.0.1)
-    dry-logic (1.0.3)
+    dry-inflector (0.2.0)
+    dry-initializer (3.0.2)
+    dry-logic (1.0.5)
       concurrent-ruby (~> 1.0)
       dry-core (~> 0.2)
       dry-equalizer (~> 0.2)
@@ -56,15 +56,15 @@ GEM
       dry-core (~> 0.4)
       dry-equalizer (~> 0.2)
       dry-events (~> 0.1)
-    dry-schema (1.3.3)
+    dry-schema (1.4.1)
       concurrent-ruby (~> 1.0)
       dry-configurable (~> 0.8, >= 0.8.3)
       dry-core (~> 0.4)
       dry-equalizer (~> 0.2)
       dry-initializer (~> 3.0)
       dry-logic (~> 1.0)
-      dry-types (~> 1.0)
-    dry-types (1.1.1)
+      dry-types (~> 1.2)
+    dry-types (1.2.1)
       concurrent-ruby (~> 1.0)
       dry-container (~> 0.3)
       dry-core (~> 0.4, >= 0.4.4)
@@ -80,32 +80,32 @@ GEM
       dry-schema (~> 1.0, >= 1.3.1)
     envlogic (1.1.0)
       dry-inflector (~> 0.1)
-    factory_bot (5.0.2)
+    factory_bot (5.1.1)
       activesupport (>= 4.2.0)
-    i18n (1.6.0)
+    i18n (1.7.0)
       concurrent-ruby (~> 1.0)
     irb (1.0.0)
     json (2.2.0)
     king_konf (0.3.7)
-    minitest (5.11.3)
-    multi_json (1.13.1)
-    rake (12.3.3)
-    rspec (3.8.0)
-      rspec-core (~> 3.8.0)
-      rspec-expectations (~> 3.8.0)
-      rspec-mocks (~> 3.8.0)
-    rspec-core (3.8.2)
-      rspec-support (~> 3.8.0)
-    rspec-expectations (3.8.4)
+    minitest (5.13.0)
+    multi_json (1.14.1)
+    rake (13.0.0)
+    rspec (3.9.0)
+      rspec-core (~> 3.9.0)
+      rspec-expectations (~> 3.9.0)
+      rspec-mocks (~> 3.9.0)
+    rspec-core (3.9.0)
+      rspec-support (~> 3.9.0)
+    rspec-expectations (3.9.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-mocks (3.8.1)
+      rspec-support (~> 3.9.0)
+    rspec-mocks (3.9.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-support (3.8.2)
+      rspec-support (~> 3.9.0)
+    rspec-support (3.9.0)
     ruby-kafka (0.7.10)
       digest-crc
-    simplecov (0.17.0)
+    simplecov (0.17.1)
       docile (~> 1.1)
       json (>= 1.8, < 3)
       simplecov-html (~> 0.10.0)
@@ -114,14 +114,14 @@ GEM
     thread_safe (0.3.6)
     tzinfo (1.2.5)
       thread_safe (~> 0.1)
-    waterdrop (1.3.0)
+    waterdrop (1.3.1)
       delivery_boy (~> 0.2)
       dry-configurable (~> 0.8)
       dry-monitor (~> 0.3)
       dry-validation (~> 1.2)
       ruby-kafka (>= 0.7.8)
       zeitwerk (~> 2.1)
-    zeitwerk (2.1.10)
+    zeitwerk (2.2.1)
 
 PLATFORMS
   ruby

data/README.md

@@ -2,10 +2,10 @@
 
 [![Build Status](https://travis-ci.org/karafka/karafka.svg?branch=master)](https://travis-ci.org/karafka/karafka)
 
-## New release in progress!
-
 **Note**: Documentation presented here refers to Karafka `1.3.0`.
 
+If you're upgrading from `1.2.0`, please refer to our [Upgrade Notes article](https://mensfeld.pl/2019/09/karafka-framework-1-3-0-release-notes-ruby-kafka/).
+
 If you are looking for the documentation for Karafka `1.2.*`, it can be found [here](https://github.com/karafka/wiki/tree/1.2).
 
 ## About Karafka

data/karafka.gemspec

@@ -30,7 +30,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'waterdrop', '~> 1.3.0'
   spec.add_dependency 'zeitwerk', '~> 2.1'
 
-  spec.required_ruby_version = '>= 2.4.0'
+  spec.required_ruby_version = '>= 2.5.0'
 
   if $PROGRAM_NAME.end_with?('gem')
     spec.signing_key = File.expand_path('~/.ssh/gem-private_key.pem')

data/lib/karafka/cli/install.rb

@@ -13,7 +13,9 @@ module Karafka
       INSTALL_DIRS = %w[
         app/consumers
         app/responders
+        app/workers
         config
+        lib
         log
         tmp/pids
       ].freeze

data/lib/karafka/connection/listener.rb

@@ -47,10 +47,10 @@ module Karafka
           end
         end
         # This is on purpose - see the notes for this method
-        # rubocop:disable RescueException
+        # rubocop:disable Lint/RescueException
       rescue Exception => e
         Karafka.monitor.instrument('connection.listener.fetch_loop.error', caller: self, error: e)
-        # rubocop:enable RescueException
+        # rubocop:enable Lint/RescueException
         # We can stop client without a problem, as it will reinitialize itself when running the
         # `fetch_loop` again
         @client.stop

data/lib/karafka/contracts/consumer_group.rb

@@ -178,9 +178,9 @@ module Karafka
       # @param value [String] potential RSA key value
       # @return [Boolean] is the given string a valid RSA key
       def valid_private_key?(value)
-        OpenSSL::PKey::RSA.new(value)
+        OpenSSL::PKey.read(value)
         true
-      rescue OpenSSL::PKey::RSAError
+      rescue OpenSSL::PKey::PKeyError
         false
       end
 

data/lib/karafka/instrumentation/logger.rb

@@ -36,10 +36,11 @@ module Karafka
           .to(STDOUT, file)
       end
 
-      # Makes sure the log directory exists
+      # Makes sure the log directory exists as long as we can write to it
       def ensure_dir_exists
-        dir = File.dirname(log_path)
-        FileUtils.mkdir_p(dir) unless Dir.exist?(dir)
+        FileUtils.mkdir_p(File.dirname(log_path))
+      rescue Errno::EACCES
+        nil
       end
 
       # @return [Pathname] Path to a file to which we should log

data/lib/karafka/version.rb

@@ -3,5 +3,5 @@
 # Main module namespace
 module Karafka
   # Current Karafka version
-  VERSION = '1.3.0'
+  VERSION = '1.3.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: karafka
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Maciej Mensfeld
@@ -36,7 +36,7 @@ cert_chain:
   KJG/fhg1JV5vVDdVy6x+tv5SQ5ctU0feCsVfESi3rE3zRd+nvzE9HcZ5aXeL1UtJ
   nT5Xrioegu2w1jPyVEgyZgTZC5rvD0nNS5sFNQ==
   -----END CERTIFICATE-----
-date: 2019-09-09 00:00:00.000000000 Z
+date: 2019-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-configurable
@@ -322,7 +322,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.4.0
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="