karafka 1.2.8 → 1.2.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7a4b14c619edcab5a576a211ec9e7a791ebca8e200ee82dccf21d41a9546dcc7
-  data.tar.gz: 67916109c7f400f6be77eef19cbc7f059ed99c77d9e4e6554abe8925cba2b1e5
+  metadata.gz: 6ad76c21da97059ec8cdea2f33bd7c3cb665031c79b8416572931c36df824259
+  data.tar.gz: 593b9af1ae8ff861b2f89a5fbf9b31ca0091fc1926eefe3e7f740ff0076c9ac0
 SHA512:
-  metadata.gz: 46311d0b624a9c4b0859fd79fcbe05a3bef67aa33f1eed53ea9a70f114531775e176b5acce4aa2295960c2180e74060f4f77e2bd49f42e1474f00664996ab4fa
-  data.tar.gz: 02f3933639045e38b88d23bf811cc7c5e870cc5e76e8e315cb5fa860833f4a2474c99919d74e073588dca957bc2e6f8832c35db9d580d0edb31df1417a7a3712
+  metadata.gz: d08b6d28e177f7bee7651df80deb9367d9a76f9068d437f43848375b3bdfa5af7a3178efe9f5b78ce943462af79a44d3c585aeb4a90c78854aed454194f7fef1
+  data.tar.gz: c9d02a670504327c3a187b39c27fbfb9d9c21b09d491340536ee65736204b350fec1f3f7d28fbe968ebbe4bb08e018e5ca3cdebfb42e49aadbcdf9b2a18bbe83

data/.ruby-version

@@ -1 +1 @@
-2.5.1
+2.5.3

data/.travis.yml

@@ -4,15 +4,10 @@ language: ruby
 cache: bundler
 
 rvm:
-  - 2.3.7
-  - 2.4.4
-  - 2.5.1
+  - 2.3.8
+  - 2.4.5
+  - 2.5.3
   - ruby-head
-  - jruby-9.2.0.0
-
-env:
-  global:
-    - JRUBY_OPTS='--debug'
 
 before_install:
   - gem install bundler

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Karafka framework changelog
 
+## 1.2.9 Unreleased
+- Critical exceptions now will cause consumer to stop instead of retrying without a break
+- #412 - Fix dry-inflector dependency lock in gemspec
+- #414 - Backport to 1.2 the delayed retry upon failure
+- #437 - Raw message is no longer added to params after ParserError raised
+
 ## 1.2.8
 - #408 - Responder Topic Lookup Bug on Heroku
 

data/Gemfile.lock

@@ -1,10 +1,10 @@
 PATH
   remote: .
   specs:
-    karafka (1.2.8)
+    karafka (1.2.9)
       activesupport (>= 4.0)
       dry-configurable (~> 0.7)
-      dry-inflector (~> 0.1.1)
+      dry-inflector (~> 0.1)
       dry-monitor (~> 0.1)
       dry-validation (~> 0.11)
       envlogic (~> 1.0)
@@ -18,13 +18,13 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (5.2.1)
+    activesupport (5.2.2)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 0.7, < 2)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
     benchmark-ips (2.7.2)
-    concurrent-ruby (1.0.5)
+    concurrent-ruby (1.1.3)
     delivery_boy (0.2.7)
       king_konf (~> 0.2)
       ruby-kafka (~> 0.5)
@@ -53,7 +53,7 @@ GEM
       dry-equalizer (~> 0.2)
       dry-events (~> 0.1)
       rouge (~> 2.0, >= 2.2.1)
-    dry-types (0.13.2)
+    dry-types (0.13.3)
       concurrent-ruby (~> 1.0)
       dry-container (~> 0.3)
       dry-core (~> 0.4, >= 0.4.4)
@@ -69,11 +69,10 @@ GEM
       dry-types (~> 0.13.1)
     envlogic (1.1.0)
       dry-inflector (~> 0.1)
-    i18n (1.1.0)
+    i18n (1.1.1)
       concurrent-ruby (~> 1.0)
     json (2.1.0)
-    json (2.1.0-java)
-    king_konf (0.3.6)
+    king_konf (0.3.7)
     minitest (5.11.3)
     multi_json (1.13.1)
     null-logger (0.1.5)
@@ -86,21 +85,21 @@ GEM
       rspec-mocks (~> 3.8.0)
     rspec-core (3.8.0)
       rspec-support (~> 3.8.0)
-    rspec-expectations (3.8.1)
+    rspec-expectations (3.8.2)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.8.0)
     rspec-mocks (3.8.0)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.8.0)
     rspec-support (3.8.0)
-    ruby-kafka (0.7.2)
+    ruby-kafka (0.7.4)
       digest-crc
     simplecov (0.16.1)
       docile (~> 1.1)
       json (>= 1.8, < 3)
       simplecov-html (~> 0.10.0)
     simplecov-html (0.10.2)
-    thor (0.20.0)
+    thor (0.20.3)
     thread_safe (0.3.6)
     timecop (0.9.1)
     tzinfo (1.2.5)
@@ -114,7 +113,6 @@ GEM
       ruby-kafka (>= 0.6)
 
 PLATFORMS
-  java
   ruby
 
 DEPENDENCIES
@@ -125,4 +123,4 @@ DEPENDENCIES
   timecop
 
 BUNDLED WITH
-   1.16.5
+   1.17.1

data/karafka.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency 'activesupport', '>= 4.0'
   spec.add_dependency 'dry-configurable', '~> 0.7'
-  spec.add_dependency 'dry-inflector', '~> 0.1.1'
+  spec.add_dependency 'dry-inflector', '~> 0.1'
   spec.add_dependency 'dry-monitor', '~> 0.1'
   spec.add_dependency 'dry-validation', '~> 0.11'
   spec.add_dependency 'envlogic', '~> 1.0'

data/lib/karafka/connection/client.rb

@@ -41,16 +41,6 @@ module Karafka
         )
         pause(error.topic, error.partition)
         retry
-        # This is on purpose - see the notes for this method
-        # rubocop:disable RescueException
-      rescue Exception => error
-        # rubocop:enable RescueException
-        Karafka.monitor.instrument(
-          'connection.client.fetch_loop.error',
-          caller: self,
-          error: error
-        )
-        retry
       end
 
       # Gracefuly stops topic consumption

data/lib/karafka/connection/listener.rb

@@ -46,8 +46,8 @@ module Karafka
       rescue Exception => e
         Karafka.monitor.instrument('connection.listener.fetch_loop.error', caller: self, error: e)
         # rubocop:enable RescueException
-        @client&.stop
-        retry if @client
+        @client.stop
+        sleep(@consumer_group.reconnect_timeout) && retry
       end
 
       # @return [Karafka::Connection::Client] wrapped kafka consuming client for a given topic

data/lib/karafka/params/dsl.rb

@@ -93,7 +93,9 @@ module Karafka
         return self if self['parsed']
         self['parsed'] = true
 
-        merge!(parse(delete('value')))
+        parsed_data = parse(self['value'])
+        delete('value')
+        merge!(parsed_data)
       end
 
       # Includes and extends the base params klass with everything that is needed by Karafka to

data/lib/karafka/version.rb

@@ -3,5 +3,5 @@
 # Main module namespace
 module Karafka
   # Current Karafka version
-  VERSION = '1.2.8'
+  VERSION = '1.2.9'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: karafka
 version: !ruby/object:Gem::Version
-  version: 1.2.8
+  version: 1.2.9
 platform: ruby
 authors:
 - Maciej Mensfeld
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-01 00:00:00.000000000 Z
+date: 2018-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -46,14 +46,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.1
+        version: '0.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.1
+        version: '0.1'
 - !ruby/object:Gem::Dependency
   name: dry-monitor
   requirement: !ruby/object:Gem::Requirement
@@ -296,7 +296,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.4
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Ruby based framework for working with Apache Kafka