kanban 0.5.1 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5571f4ff8d96226cd84855428ad20f875669991f
-  data.tar.gz: 3ef547ba9f47b0dd43ef43e851052848374e8197
+  metadata.gz: f6f0f321b90145bc913fab9ee5b932908d16d2e8
+  data.tar.gz: 8f015ee628cc53a95d702f646a15ec6d7a47188c
 SHA512:
-  metadata.gz: fbf31b07bfbbcc2a3fd32d4096c0a082c52d880eca58fd7cd041d3deee1f2ebab7448ba1a94eac68c8fb0ac9967ac5d2b42e45fc0102b1b25d1e00364937e2ee
-  data.tar.gz: 08a57add1ad3040481c6ce516ed90ecbbccf2df861038f311f82fec3e3e0557c9e49497c2f69d4d85730e095c3349ee50cbb1e8dfbfd1bbc61488be127a00855
+  metadata.gz: 9f51ccf582a838859c987187938554200e9a5ac471221a9928994cf46e370b8b1174ba4d168831ed6f1b3a55e77aabbf31727419bc1c2b4122830f9af62eb064
+  data.tar.gz: 796f6ca6814a854ac62163a3142daff394bde399b12280594f9cb7d3583f45d443c76f56ba0d17cf8d970142217b29f980da3969097fcbed2a68daef2bdfe9af

data/VERSION

@@ -1 +1 @@
-0.5.1
+0.7.0

data/kanban.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: kanban 0.5.1 ruby lib
+# stub: kanban 0.7.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "kanban"
-  s.version = "0.5.1"
+  s.version = "0.7.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Chris Olstrom"]
-  s.date = "2015-05-28"
+  s.date = "2015-05-30"
   s.description = "Because your code totally needed an Agile Workflow"
   s.email = "chris@olstrom.com"
   s.extra_rdoc_files = [

data/lib/kanban.rb

@@ -60,5 +60,31 @@ module Kanban
     def completed?(id)
       @backend.getbit("#{@queue}:completed", id) == 1
     end
+
+    def unworkable(id)
+      @backend.setbit("#{@queue}:unworkable", id, 1).zero?
+    end
+
+    def unworkable?(id)
+      @backend.getbit("#{@queue}:unworkable", id) == 1
+    end
+
+    def done?(id)
+      completed?(id) || unworkable?(id)
+    end
+
+    def release(id)
+      expire_claim id
+      @backend.lrem("#{@queue}:doing", 0, id) > 0
+    end
+
+    def expire_claim(id)
+      @backend.expire "#{@item}:#{id}:claimed", 0
+    end
+
+    def requeue(id)
+      release id
+      @backend.lpush("#{@queue}:todo", id) > 0
+    end
   end
 end

data/spec/kanban_spec.rb

@@ -4,6 +4,8 @@ require 'timeout'
 describe 'Backlog' do
   before do
     @backlog = Kanban::Backlog.new backend: Redis.new, namespace: 'kanban:test'
+    task = { 'test' => 'data' }
+    5.times { @backlog.add(task) }
   end
 
   after(:all) do
@@ -81,15 +83,13 @@ describe 'Backlog' do
 
   it 'should track the claim separately from the queue it is in' do
     id = @backlog.claim
-    redis = Redis.new
-    expect(redis.exists("#{@backlog.item}:#{id}:claimed")).to be true
+    expect(@backlog.claimed?(id)).to be true
   end
 
   it 'should allow claims to expire' do
     id = @backlog.claim(duration: 1)
     sleep 1.1
-    redis = Redis.new
-    expect(redis.exists("#{@backlog.item}:#{id}:claimed")).to be false
+    expect(@backlog.claimed?(id)).to be false
   end
 
   it 'should block if there are no pending tasks' do
@@ -103,8 +103,6 @@ describe 'Backlog' do
   end
 
   it 'should report if a task is claimed' do
-    task = { 'test' => 'data' }
-    5.times { @backlog.add(task) }
     id = @backlog.claim
     expect(@backlog.claimed?(id)).to be true
     expect(@backlog.claimed?(0)).to be false
@@ -125,4 +123,51 @@ describe 'Backlog' do
     @backlog.complete 2
     expect(@backlog.completed?(2)).to be true
   end
+
+  it 'should allow indicating a task should not be retried' do
+    expect(@backlog.unworkable(3)).to be true
+    expect(@backlog.unworkable(3)).to be false
+  end
+
+  it 'should check if a task is unworkable' do
+    expect(@backlog.unworkable?(4)).to be false
+    @backlog.unworkable 4
+    expect(@backlog.unworkable?(4)).to be true
+  end
+
+  it 'should consider a task that is completed or unworkable to be done' do
+    expect(@backlog.done?(0)).to be false
+    @backlog.complete(5)
+    expect(@backlog.done?(5)).to be true
+    @backlog.unworkable(6)
+    expect(@backlog.done?(6)).to be true
+  end
+
+  it 'should be able to release a task from being in progress' do
+    id = @backlog.claim
+    expect(@backlog.release(id)).to be true
+    expect(@backlog.release(id)).to be false
+    expect(@backlog.doing).to_not include(id)
+  end
+
+  it 'should be able to forcibly expire a claim' do
+    expect(@backlog.expire_claim(0)).to be false
+    id = @backlog.claim
+    expect(@backlog.expire_claim(id)).to be true
+    expect(@backlog.claimed?(id)).to be false
+  end
+
+  it 'should expire any active claims when a task is released' do
+    id = @backlog.claim
+    expect(@backlog.claimed?(id)).to be true
+    @backlog.release(id)
+    expect(@backlog.claimed?(id)).to be false
+  end
+
+  it 'should be able to requeue a task' do
+    id = @backlog.claim
+    expect(@backlog.requeue(id)).to be true
+    expect(@backlog.todo).to include(id)
+    expect(@backlog.doing).to_not include(id)
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kanban
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.7.0
 platform: ruby
 authors:
 - Chris Olstrom
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-28 00:00:00.000000000 Z
+date: 2015-05-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis