kalibro_gem 0.0.1.rc9 → 0.0.1.rc10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 98324243147f112a11c973aff84d4379d6223207
-  data.tar.gz: a1246a5e641e80c207e1d7df671f18a5e8b03946
+  metadata.gz: b74a2dd28b6faf6f01029dab0d3f6816c75b8f04
+  data.tar.gz: 77223e018fd676454c43ec7684754968b73e4147
 SHA512:
-  metadata.gz: 7f907be250a925f385eb5ed28e5abd9ea178f347c250245df5ee8e695f168ff3b20099cab403565ccdd8b69c703546045a07af8b888e29eaf076b3cfb26e33bf
-  data.tar.gz: 5686b1aa2beff3402d7c9d6e1c49ba2cdd2db7d04f96a2f2e4cd068c4473f747bd3756cd3dfa3f6bf32cbb531f36f7e6ca6ec67596a0c47518043840c835a70a
+  metadata.gz: 1346e136af91f908fed3e995d81d86036ef53ecf5a58715e2487180e602975d90822a707d64d65d7e18bed44aa3264f1a22c617ff37b02e5fd2b0c1f69c7972c
+  data.tar.gz: 4ec72af2c75b49ca60e6fc850db59f36adbfc82a5321812d979562dc2de2c863ec9ceb4292579bdc81ed638e6d93aa1c70e325d47a35dc6b52b50e2512d6e026

data/features/range/all.feature

@@ -0,0 +1,14 @@
+Feature: Range listing
+  In order to be able to get all the ranges
+  As a developer
+  I want to see all the ranges
+
+  @kalibro_restart
+  Scenario: When there are ranges
+    Given I have a configuration with name "Java"
+    And I have a reading group with name "Group"
+    And I have a metric configuration within the given configuration
+    And I have a reading within the given reading group
+    And I have a range within the given reading
+    When I ask for all the ranges
+    Then I should not get an empty list

data/features/range/exists.feature

@@ -0,0 +1,13 @@
+Feature: Exists
+  In order to be able to have ranges
+  As a developer
+  I want to find wich range exists
+
+@kalibro_restart
+Scenario: find a valid range
+    Given I have a configuration with name "Java"
+    And I have a reading group with name "Group"
+    And I have a metric configuration within the given configuration
+    And I have a reading within the given reading group
+    And I have a range within the given reading
+    Then the range should exist

data/features/range/find.feature

@@ -0,0 +1,14 @@
+Feature: Find
+  In order to be able to have ranges
+  As a developer
+  I want to find ranges
+
+@kalibro_restart
+Scenario: find a valid range
+    Given I have a configuration with name "Java"
+    And I have a reading group with name "Group"
+    And I have a metric configuration within the given configuration
+    And I have a reading within the given reading group
+    And I have a range within the given reading
+    When I search a range with the same id of the given range
+    Then it should return the same range as the given one

data/features/reading/all.feature

@@ -0,0 +1,13 @@
+Feature: Reading listing
+  In order to be able to visualize readings
+  As a developer
+  I want to see all the readings on the service
+
+  @kalibro_restart
+  Scenario: With existing reading group reading
+    Given I have a reading group with name "Kalibro"
+    And the given reading group has the following readings:
+      |   label   | grade |     color    |
+      | "Awesome" |  10   |     3333FF   |
+    When I ask for all the readings
+    Then the response should contain the given reading

data/features/reading/exists.feature

@@ -0,0 +1,13 @@
+Feature: Reading listing
+  In order to be able to check know if a reading still exists
+  As a developer
+  I want to check that on the service
+
+  @kalibro_restart
+  Scenario: With existing reading group reading
+    Given I have a reading group with name "RG"
+    And the given reading group has the following readings:
+      |   label   | grade |     color    |
+      | "Awesome" |  10   |     3333FF   |
+    When I ask to check if the given reading exists
+    Then I should get true

data/features/step_definitions/range_steps.rb

@@ -23,10 +23,22 @@ When(/^I ask ranges of the given metric configuration$/) do
   @response = KalibroGem::Entities::Range.ranges_of @metric_configuration.id
 end
 
+When(/^I ask for all the ranges$/) do
+  @response = KalibroGem::Entities::Range.all
+end
+
+When(/^I search a range with the same id of the given range$/) do
+  @found_range = KalibroGem::Entities::Range.find(@range.id.to_i)
+end
+
 Then(/^I should get an empty list$/) do
   @response.should eq([])
 end
 
+Then(/^I should not get an empty list$/) do
+  @response.should_not eq([])
+end
+
 Then(/^I should get a list with the given range$/) do
   @response.size.should eq(1)
   @response.first.comments.should eq(@range.comments)
@@ -38,4 +50,12 @@ end
 
 Then(/^the id of the given range should be set$/) do
  @range.id.should_not eq(0)
+end
+
+Then(/^it should return the same range as the given one$/) do
+  @found_range == @range
+end
+
+Then(/^the range should exist$/) do
+  KalibroGem::Entities::Range.exists?(@range.id)
 end

data/features/step_definitions/reading_steps.rb

@@ -1,7 +1,19 @@
+Given(/^the given reading group has the following readings:$/) do |table|
+  hash = table.hashes.first
+  hash[:group_id] = @reading_group.id
+  hash[:id] = nil
+
+  @reading = FactoryGirl.create(:reading, hash)
+end
+
 Given(/^I have a reading within the given reading group$/) do
   @reading = FactoryGirl.create(:reading, {id: nil, group_id: @reading_group.id})
 end
 
+When(/^I ask for all the readings$/) do
+  @all_readings = KalibroGem::Entities::Reading.all
+end
+
 When(/^I ask for a reading with the same id of the given reading$/) do
   @found_reading = KalibroGem::Entities::Reading.find @reading.id
 end
@@ -10,6 +22,10 @@ When(/^I ask for the readings of the given reading group$/) do
   @found_readings = KalibroGem::Entities::Reading.readings_of @reading_group.id
 end
 
+When(/^I ask to check if the given reading exists$/) do
+  @response = KalibroGem::Entities::Reading.exists?(@reading.id)
+end
+
 Then(/^I should get the given reading$/) do
   @found_reading == @reading
 end
@@ -18,3 +34,6 @@ Then(/^I should get a list with the given reading$/) do
   @found_readings.first == @reading
 end
 
+Then(/^the response should contain the given reading$/) do
+  @all_readings.first == @reading
+end

data/kalibro_gem.gemspec

@@ -43,6 +43,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "factory_girl", "~> 4.3.0"
   spec.add_development_dependency 'coveralls'
 
-  spec.add_dependency "savon", "~> 2.3.2"
-  spec.add_dependency "activesupport", "~> 4.0.1"
+  spec.add_dependency "savon", "~> 2.3.3"
+  spec.add_dependency "activesupport", "~> 4.0.2"
 end

data/lib/kalibro_gem/entities/range.rb

@@ -70,6 +70,37 @@ module KalibroGem
         @reading ||= KalibroGem::Entities::Reading.find(reading_id)
         @reading
       end
+
+      def self.all
+        metric_configurations = []
+        ranges = []
+        configurations = Configuration.all
+
+        configurations.each do |config|
+          metric_configurations.concat(MetricConfiguration.metric_configurations_of(config.id))
+        end
+
+        metric_configurations.each do |metric_config|
+          ranges.concat(self.ranges_of(metric_config.id))
+        end
+
+        return ranges
+      end
+
+      def self.find(id)
+        self.all.each do |range|
+          return range if range.id == id
+        end 
+        raise KalibroGem::Errors::RecordNotFound
+      end
+
+      def self.exists?(id)
+        begin
+          return true unless self.find(id).nil?
+        rescue KalibroGem::Errors::RecordNotFound
+          return false
+        end
+      end
     end
   end
 end

data/lib/kalibro_gem/entities/reading.rb

@@ -47,10 +47,17 @@ module KalibroGem
         reading_groups.each do |reading_group|
           readings.concat(readings_of(reading_group.id))
         end
-
         return readings
       end
 
+      def self.exists?(id)
+        begin
+          return true unless find(id).nil?
+        rescue KalibroGem::Errors::RecordNotFound
+          return false
+        end
+      end
+
       private
 
       def save_params

data/lib/kalibro_gem/version.rb

@@ -15,5 +15,5 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 module KalibroGem
-  VERSION = "0.0.1.rc9"
+  VERSION = "0.0.1.rc10"
 end

data/spec/entities/range_spec.rb

@@ -58,7 +58,6 @@ describe KalibroGem::Entities::Range do
   end
 
   describe 'getting reading attribute' do
-    subject { FactoryGirl.build(:range) }
     let(:reading) { FactoryGirl.build(:reading) }
 
     before :each do
@@ -178,4 +177,76 @@ describe KalibroGem::Entities::Range do
       end
     end
   end
+
+  describe 'exists?' do
+    context 'when the range exists' do
+      before :each do
+        KalibroGem::Entities::Range.expects(:find).with(subject.id).returns(subject)
+      end
+
+      it 'should return true' do
+        KalibroGem::Entities::Range.exists?(subject.id).should be_true
+      end
+    end
+
+    context 'when the range does not exists' do
+      before :each do
+        KalibroGem::Entities::Range.expects(:find).with(subject.id).raises(KalibroGem::Errors::RecordNotFound)
+      end
+
+      it 'should return false' do
+        KalibroGem::Entities::Range.exists?(subject.id).should be_false
+      end
+    end
+  end
+
+  describe 'find' do
+    context 'when the range exists' do
+      before :each do
+        KalibroGem::Entities::Range.
+          expects(:all).
+          returns([subject])
+      end
+
+      it 'should return the range' do
+        KalibroGem::Entities::Range.find(subject.id).should eq(subject)
+      end
+    end
+
+    context "when the range doesn't exists" do
+      before :each do
+        KalibroGem::Entities::Range.
+          expects(:all).
+          returns([FactoryGirl.build(:another_range)])
+      end
+
+      it 'should raise a RecordNotFound error' do
+        expect { KalibroGem::Entities::Range.find(subject.id) }.
+          to raise_error(KalibroGem::Errors::RecordNotFound)
+      end
+    end
+  end
+
+  describe 'all' do
+    let(:configuration) { FactoryGirl.build(:configuration) }
+    let(:metric_configuration) { FactoryGirl.build(:metric_configuration) } 
+
+    before :each do
+      KalibroGem::Entities::Configuration.
+        expects(:all).
+        returns([configuration])
+      KalibroGem::Entities::MetricConfiguration.
+        expects(:metric_configurations_of).
+        with(configuration.id).
+        returns([metric_configuration])
+      KalibroGem::Entities::Range.
+        expects(:ranges_of).
+        with(metric_configuration.id).
+        returns([subject])
+    end
+
+    it 'should list all the ranges' do
+      KalibroGem::Entities::Range.all.should include(subject)
+    end
+  end
 end

data/spec/entities/reading_spec.rb

@@ -121,4 +121,28 @@ describe KalibroGem::Entities::Reading do
       reading.kalibro_errors.should be_empty
     end
   end
+
+  describe 'exists?' do
+    subject {FactoryGirl.build(:reading)}
+
+    context 'when the reading exists' do
+      before :each do
+        KalibroGem::Entities::Reading.expects(:find).with(subject.id).returns(subject)
+      end
+
+      it 'should return true' do
+        KalibroGem::Entities::Reading.exists?(subject.id).should be_true
+      end
+    end
+
+    context 'when the reading does not exists' do
+      before :each do
+        KalibroGem::Entities::Reading.expects(:find).with(subject.id).raises(KalibroGem::Errors::RecordNotFound)
+      end
+
+      it 'should return false' do
+        KalibroGem::Entities::Reading.exists?(subject.id).should be_false
+      end
+    end
+  end
 end

data/spec/factories/ranges.rb

@@ -16,6 +16,7 @@
 
 FactoryGirl.define do
   factory :range, class: KalibroGem::Entities::Range do
+    id 1
     beginning 1.1 
     self.end 5.1 
     reading_id 3
@@ -25,6 +26,10 @@ FactoryGirl.define do
       comments "Another Comment"
     end
 
-    factory :another_range, traits: [:another_comment]
+    trait :another_id do
+      id 2
+    end
+
+    factory :another_range, traits: [:another_comment, :another_id]
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: kalibro_gem
 version: !ruby/object:Gem::Version
-  version: 0.0.1.rc9
+  version: 0.0.1.rc10
 platform: ruby
 authors:
 - Carlos Morais
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-06 00:00:00.000000000 Z
+date: 2014-01-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -135,28 +135,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.2
+        version: 2.3.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.2
+        version: 2.3.3
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.0.1
+        version: 4.0.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.0.1
+        version: 4.0.2
 description: KalibroGem is a Ruby gem intended to be an interface for Ruby applications
   who want to use the open source code analysis webservice Kalibro (http://gitorious.org/kalibro/kalibro).
 email:
@@ -211,8 +211,13 @@ files:
 - features/project/destroy.feature
 - features/project/exists.feature
 - features/project/find.feature
+- features/range/all.feature
+- features/range/exists.feature
+- features/range/find.feature
 - features/range/ranges_of.feature
 - features/range/save.feature
+- features/reading/all.feature
+- features/reading/exists.feature
 - features/reading/find.feature
 - features/reading/readings_of.feature
 - features/reading_group/all.feature
@@ -383,8 +388,13 @@ test_files:
 - features/project/destroy.feature
 - features/project/exists.feature
 - features/project/find.feature
+- features/range/all.feature
+- features/range/exists.feature
+- features/range/find.feature
 - features/range/ranges_of.feature
 - features/range/save.feature
+- features/reading/all.feature
+- features/reading/exists.feature
 - features/reading/find.feature
 - features/reading/readings_of.feature
 - features/reading_group/all.feature