jyske_bank_record 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 467a5a01905f99c60469c9e831a61b81fd2cd529
-  data.tar.gz: 720ededf62f83da2363e204d230baa96a3a4e395
+  metadata.gz: da2285b140349c32da2af5bee28ee2bc9caf90fa
+  data.tar.gz: bec76bdc3edb461d1fd1286eb6524de423becc45
 SHA512:
-  metadata.gz: 5debcfc09d0ec94dfee0a0aa703f47ed42269b3ce3119bd7b822ba3e32562987fad438864730bf353f8e95fb91e54863b4fc737da51391201017fdbf887e8b2b
-  data.tar.gz: 95714cba058b55cce6c245ef7ce4bc4cbfa261ad4ef0045410d649855073fa6bf237b31bed57479411c8837e10d7bb621b2c277df9866bbd630e5182141542db
+  metadata.gz: daa9fb4f47c7ca54a74d60217579b10e116f57907e504d85aee1521ee8a2b97e0a8278eed0bbeadfab06a9dd5dd450deed64f427dad91fa46fed003be5f5cea5
+  data.tar.gz: 6550254c585f9fea7e42856556b033428f0c2e140303db930fc0832e94274e69d1d85da80cd691d172c95e616f2767b606c7553c1151549163910ebfea798675

data/README.md

@@ -6,6 +6,11 @@ ruby library for generating bank record files for Jyske Bank
 
 - Validate inputs (length, etc)
 
+# RECORD FORMAT
+
+- English: http://www.jyskebank.dk/wps/wcm/connect/274e6433-8d6f-4369-9c8a-ad86e1254c2a/Record+description_Accounts+and+payments.pdf?MOD=AJPERES
+- Danish: http://www.jyskebank.dk/wps/wcm/connect/1ccdeb0d-9587-44cd-87bb-f5b245e2cceb/Recordbeskrivelser_indl%C3%A6s.pdf?MOD=AJPERES
+
 # LICENSE
 
 The MIT License (MIT)

data/lib/jyske_bank_record.rb

@@ -1,3 +1,5 @@
+require 'active_model'
+
 module JyskeBankRecord
   DATE_FORMAT = "%Y%m%d"
 
@@ -27,6 +29,18 @@ module JyskeBankRecord
     CHEQUE = '2'
   end
 
+  # Encode variables given binding and set as instance variables
+  module EncodeCp1252AndSet
+    # @param [Binding] _binding binding for getting value of instance variables
+    # @param [Enumerable] names parameter names to encode and set
+      def encode_and_set(_binding, names)
+        names.each do |name|
+          value = _binding.local_variable_get name
+          instance_variable_set ('@' + name.to_s).to_sym, value.to_s.encode!(Encoding::CP1252)
+        end
+      end
+  end
+
   NEWLINE = "\r\n"
 
   # Format a string of bank records, with correct encoding
@@ -69,12 +83,12 @@ module JyskeBankRecord
   PaymentStartRecord = Struct.new(:creation_date) do
     def fields
       [
-        'IB000000000000',
-        creation_date.strftime(DATE_FORMAT),
-        ' ' * 90,
-        ' ' * 255,
-        ' ' * 255,
-        ' ' * 255,
+          'IB000000000000',
+          creation_date.strftime(DATE_FORMAT),
+          ' ' * 90,
+          ' ' * 255,
+          ' ' * 255,
+          ' ' * 255,
       ]
     end
 
@@ -86,14 +100,14 @@ module JyskeBankRecord
   PaymentEndRecord = Struct.new(:creation_date, :transactions) do
     def fields
       [
-        'IB999999999999',
-        creation_date.strftime(DATE_FORMAT),
-        transactions.length.to_s.rjust(6, '0'),
-        transactions.map(&:amount).reduce(:+).to_s.rjust(13, '0') + '+',
-        ' ' * 64,
-        ' ' * 255,
-        ' ' * 255,
-        ' ' * 255,
+          'IB999999999999',
+          creation_date.strftime(DATE_FORMAT),
+          transactions.length.to_s.rjust(6, '0'),
+          transactions.map(&:amount).reduce(:+).to_s.rjust(13, '0') + '+',
+          ' ' * 64,
+          ' ' * 255,
+          ' ' * 255,
+          ' ' * 255,
       ]
     end
 
@@ -102,9 +116,74 @@ module JyskeBankRecord
     end
   end
 
-  Recipient = Struct.new(:registration_number, :account_number, :name, :address, :address2, :zip_code, :city)
+  # Recipient = Struct.new(:registration_number, :account_number, :name, :address, :address2, :zip_code, :city)
+  class Recipient
+    include ActiveModel::Validations
+    include JyskeBankRecord::EncodeCp1252AndSet
+
+    @@parameters = [:registration_number, :account_number, :name, :address, :address2, :zip_code, :city]
+
+    attr_reader *@@parameters
+
+    validates_presence_of *@@parameters, {allow_blank: true, allow_nil: false}
+    validates_length_of :registration_number, is: 4
+    validates :account_number, presence: true, length: {is: 10}
+
+    validates_length_of :name, :address, :address2, :city, {maximum: 32}
+    validates_length_of :zip_code, maximum: 4
+
+    # @param [String] registration_number 4 characters
+    # @param [String] account_number 10 characters
+    # @param [String] name
+    # @param [String] address
+    # @param [String] address2
+    # @param [String] zip_code
+    # @param [String] city
+    def initialize(registration_number, account_number, name: '', address: '', address2: '', zip_code: '', city: '')
+
+      # Encode and save parameters
+      encode_and_set binding, @@parameters
+    end
+  end
+
+  class PaymentRecord
+    include ActiveModel::Validations
+    include JyskeBankRecord::EncodeCp1252AndSet
+
+    @@parameters = [:sender_account_number, :entry_text, :reference, :notice]
+
+    attr_reader *@@parameters
+    attr_reader :processing_date, :amount, :recipient
+
+    validates_presence_of *@@parameters, {allow_blank: true, allow_nil: false}
+    validates_each :processing_date do |record, attr, value|
+      record.errors.add(attr, 'must respond to strftime') unless value.respond_to? :strftime
+    end
+    validates_numericality_of :amount
+    validates_each :amount do |record, attr, value|
+      record.errors.add(attr, 'must be a Fixnum') unless value.instance_of? Fixnum
+    end
+    validates_length_of :sender_account_number, is: 15
+    validates_length_of :entry_text, :reference, maximum: 35
+
+    # Validate notice for 9 lines, each less than or equal to 35 chars
+    validates_each :notice do |record, attr, value|
+      lines = value.lines
+      record.errors.add(attr, 'must have a maximum of 9 lines') if lines.length > 9
+      lines.each_with_index do |line, i|
+        if line.length > 35
+          record.errors.add(attr, "must have lines at most 35 (cp1252) chars of length, line #{i+1} is #{line.length} chars long")
+        end
+      end
+    end
+
+    def initialize(processing_date, amount, sender_account_number, recipient, entry_text: '', reference: '', notice: '')
+      encode_and_set binding, @@parameters
+      @processing_date = processing_date
+      @amount = amount
+      @recipient = recipient
+    end
 
-  PaymentRecord = Struct.new(:processing_date, :amount, :sender_account_number, :recipient, :entry_text, :reference, :notice) do
     def fields
       start_fields = [
           Type::DOMESTIC_RECORD,

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: jyske_bank_record
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Thomas B Homburg