just-retry 0.1.3 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6923f70aaf3debcee318fed8a0fef4673ae364c9
-  data.tar.gz: f4c7c2ebca157bc784c631723d76625012a66e27
+  metadata.gz: 5c22743aab9c834710d3217c306cb0088e2dc9ce
+  data.tar.gz: 2163b00419075b3ea14889f3e1334fb5a7b44c0c
 SHA512:
-  metadata.gz: bf4854695de57e5abc3361fe0fcf2cbb130e298bb353295ea36dc6750f480badb36f38419440a9d618b874817e652ca807c86cc151bf95467f654220105933c9
-  data.tar.gz: 35fb20b6467ba1a8d6d4db2bae805c1c691fce590294ba012ec55f27cc0b157fad51edce48ec738bcbbe6946fdba9acceacf6ae08a8a1b193b19741ad4205d19
+  metadata.gz: 4318cdc6e3797bef27e28c6a6bcd98f7b30a99169fb06f0f15c4eaf1af8eaced9c05c81300e519cca236fea4b2a78c828d9703bdb42fb722c89bb6459ec42824
+  data.tar.gz: 13192123e8fb586bdfacb959d73d43753e3248781fb59c27fefdf865380bab4e071224e02190a7ab64b5ed04fcecdd50a7855c57e4a07d6380ea19f9b9c25941

data/README.md

@@ -30,7 +30,7 @@ Just::retry do
 end
 ```
 
-You can limit which exceptions are rescued.
+You can specify which exception is rescued.
 
 ```ruby
 Just::retry on: exception do

data/just-retry.gemspec

@@ -8,8 +8,8 @@ Gem::Specification.new do |spec|
   spec.version       = Just::Retry::VERSION
   spec.authors       = ["Michael Greenly"]
   spec.email         = ["mgreenly@gmail.com"]
-  spec.description   = %q{Provides a counted retry machanism}
   spec.summary       = %q{Provides a counted retry mechansim}
+  spec.description   = spec.summary
   spec.homepage      = "https://github.com/mgreenly/just-retry"
   spec.license       = "MIT"
 
@@ -20,4 +20,5 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
+  spec.add_development_dependency "rspec"
 end

data/lib/just/retry/version.rb

@@ -1,5 +1,5 @@
 module Just
   module Retry
-    VERSION = "0.1.3"
+    VERSION = "0.2.0"
   end
 end

data/lib/just/retry.rb

@@ -2,12 +2,12 @@ require "just/retry/version"
 
 module Just
   def retry(opts={})
-    opts = { :delay => 0.0, :tries => 2, :exception => Exception }.merge(opts)
-    delay, tries, exception, logger = opts[:delay], opts[:tries], opts[:exception], opts[:logger]
+    opts = {delay: 0.0, on: StandardError, tries: 2}.merge(opts)
+    delay, tries, exception, logger = opts[:delay], opts[:tries], opts[:on], opts[:logger]
     count = 0
     begin
       count += 1
-      return yield
+      yield
     rescue exception => e
       if count < tries
         if logger
@@ -19,7 +19,7 @@ module Just
         end
         retry
       else
-        raise
+        raise e
       end
     end
   end

data/spec/retry_spec.rb

@@ -0,0 +1,70 @@
+require 'just/retry'
+
+describe "Just::retry" do
+
+  it "The block is only called once if it succeeds" do
+    object = Object.new
+    object.should_receive(:ping).once.and_return(:success)
+    expect {
+      Just::retry do
+        object.ping
+      end
+    }.not_to raise_error(Exception)
+  end
+
+  it "The block is called twice by default if it fails" do
+    object = Object.new
+    object.should_receive(:ping).twice { raise StandardError }
+    expect {
+      Just::retry do
+        object.ping
+      end
+    }.to raise_error(StandardError)
+  end
+
+  it "The block is called n times when a try count is specified" do
+    object = Object.new
+    n = 5
+    object.should_receive(:ping).exactly(n).times { raise StandardError }
+    expect {
+      Just::retry tries: n do
+        object.ping
+      end
+    }.to raise_error(StandardError)
+  end
+
+  it "Unexpected exceptions are reraised" do
+    object = Object.new
+    object.should_receive(:ping).once { raise StandardError }
+    expect {
+      Just::retry on: IOError do
+        object.ping
+      end
+    }.to raise_error(StandardError)
+  end
+
+  it "sleep is called if it's provided" do
+    object = Object.new
+    object.should_receive(:ping).twice { raise StandardError }
+    Just.stub!(:sleep)
+    Just.should_receive(:sleep).once.with(30)
+    expect {
+      Just::retry delay: 30 do
+        object.ping
+      end
+    }.to raise_error(StandardError)
+  end
+
+  it "the retry is logged if a log is provided" do
+    object = Object.new
+    object.should_receive(:ping).twice { raise StandardError }
+    logger = Object.new
+    logger.should_receive(:error).with(any_args)
+    logger.should_receive(:debug).with(any_args)
+    expect {
+      Just::retry logger: logger do
+        object.ping
+      end
+    }.to raise_error(StandardError)
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: just-retry
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.2.0
 platform: ruby
 authors:
 - Michael Greenly
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-01 00:00:00.000000000 Z
+date: 2013-06-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -38,7 +38,21 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-description: Provides a counted retry machanism
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+description: Provides a counted retry mechansim
 email:
 - mgreenly@gmail.com
 executables: []
@@ -53,6 +67,7 @@ files:
 - just-retry.gemspec
 - lib/just/retry.rb
 - lib/just/retry/version.rb
+- spec/retry_spec.rb
 homepage: https://github.com/mgreenly/just-retry
 licenses:
 - MIT
@@ -77,4 +92,5 @@ rubygems_version: 2.0.3
 signing_key: 
 specification_version: 4
 summary: Provides a counted retry mechansim
-test_files: []
+test_files:
+- spec/retry_spec.rb