judge 3.0.0 → 3.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0b0741ccd453132180a996df4d09f44547df293e
-  data.tar.gz: 3e0dc614b53717b745891d68ab496eeabada29a0
+  metadata.gz: dca4cf9efce355af38a266acbebedbf4e9a248bc
+  data.tar.gz: 8d7c349e62de4f849f624a4ad752c15ca5ea4697
 SHA512:
-  metadata.gz: 488b9fabe5582a64cf36c4093e183e721ec30ed0c94af54e4818a1a31260b74c154e12f4f5b4c1f45111734f28cb5eb8cbf29afe90f02b22700fa2a838b83cc6
-  data.tar.gz: fe944398c1c1affc47c04747329c078f7cc8d41686bdc1819660e74b7b1d51e17730668beb367a2b04290596fc154cb404ca5b3a12bd547b39c6e7ce3760080e
+  metadata.gz: a86cf16382daebc3d30cb73b27505f388d48dda9129c9e599c626d2672b89df8ba1bb9839562951dd6015e943a1ddb2f77ae597308cef7162862b9ad0a8b42a7
+  data.tar.gz: a7bf16c54d06e2546a7dbc7b4b069e37fdcfcaf3a555812e07bf7ea9fa64799dad5cc438994d562046e4205444fa717a247a850a4510cb272ce57029fb679afb

data/app/assets/config/manifest.js

@@ -0,0 +1 @@
+//= link javascripts/judge.js

data/lib/judge/config.rb

@@ -6,6 +6,7 @@ module Judge
 
     @@exposed = {}
     @@ignore_unsupported_validators = false
+    @@use_association_name_for_validations = false
 
     def expose(klass, *attributes)
       attrs = (@@exposed[klass.name] ||= [])
@@ -36,6 +37,14 @@ module Judge
     def ignore_unsupported_validators?
       @@ignore_unsupported_validators
     end
+
+    def use_association_name_for_validations(status)
+      @@use_association_name_for_validations = status
+    end
+
+    def use_association_name_for_validations?
+      @@use_association_name_for_validations
+    end
   end
 
   def self.config

data/lib/judge/controller.rb

@@ -1,5 +1,3 @@
-require 'uri'
-
 module Judge
   module Controller
 
@@ -41,9 +39,9 @@ module Judge
         params = params.dup.keep_if {|k| REQUIRED_PARAMS.include?(k) || (k == 'original_value' && params[:kind] == 'uniqueness')}
         params[:klass]     = find_klass(params[:klass]) if params[:klass]
         params[:attribute] = params[:attribute].to_sym  if params[:attribute]
-        params[:value]     = URI.decode(params[:value]) if params[:value]
+        params[:value]     = CGI::unescape(params[:value]) if params[:value]
         params[:kind]      = params[:kind].to_sym       if params[:kind]
-        params[:original_value] = URI.decode(params[:original_value]) if params[:original_value]
+        params[:original_value] = CGI::unescape(params[:original_value]) if params[:original_value]
         params
       end
 

data/lib/judge/validator_collection.rb

@@ -33,7 +33,23 @@ module Judge
       #   unsupported by Judge
       # if it's a confirmation field, an AM::V like class is added to handle the confirmation validations
       def amvs
-        amvs = object.class.validators_on(method)
+        method_to_search = method
+        
+        if Judge.config.use_association_name_for_validations?
+          # since the method that gets passed in here for associations comes in the form of the generated form attribute 
+          # i.e. :wine_id or :acclaim_ids
+          # object.class.validators_on(:wine_id) will fail if the active model validation is on the association directly
+          # this ensures that validations defined as 'validates :wine, presence: true' still get applied 
+          # and client side error messages get generated 
+          regex_for_assocations = /_id|_ids/
+          if method.to_s =~ regex_for_assocations
+            parsed_method = method.to_s.gsub(regex_for_assocations, '');
+            reflection = find_association_reflection(parsed_method)
+            method_to_search = reflection.name if reflection
+          end
+        end
+
+        amvs = object.class.validators_on(method_to_search)
         amvs = amvs.reject { |amv| reject?(amv) || amv.class.name['ConfirmationValidator'] }
         amvs = amvs.reject { |amv| unsupported_options?(amv) && reject?(amv) != false } if Judge.config.ignore_unsupported_validators?
         amvs << Judge::ConfirmationValidator.new(object, method) if is_confirmation?
@@ -41,6 +57,12 @@ module Judge
         amvs
       end
 
+      def find_association_reflection(association)
+        if object.class.respond_to?(:reflect_on_association)
+          object.class.reflect_on_association(association) || object.class.reflect_on_association(association.pluralize)
+        end
+      end
+
       def unsupported_options?(amv)
         unsupported = !(amv.options.keys & UNSUPPORTED_OPTIONS).empty?
         return false unless unsupported

data/lib/judge/version.rb

@@ -1,3 +1,3 @@
 module Judge
-  VERSION = '3.0.0'
+  VERSION = '3.1.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: judge
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.1.0
 platform: ruby
 authors:
 - Joe Corcoran
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-18 00:00:00.000000000 Z
+date: 2023-02-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: 4.0.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: 4.0.1
 - !ruby/object:Gem::Dependency
   name: rspec-extra-formatters
   requirement: !ruby/object:Gem::Requirement
@@ -116,6 +116,7 @@ extra_rdoc_files: []
 files:
 - LICENSE.txt
 - README.md
+- app/assets/config/manifest.js
 - app/assets/javascripts/judge.js
 - app/controllers/judge/validations_controller.rb
 - config/routes.rb
@@ -158,7 +159,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.5.2.3
 signing_key: 
 specification_version: 4
 summary: Client side validation for Rails