jsonrpc-rails 0.5.0 → 0.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 439108bab45d71dabc7ca40fa35042cdaecd7f3dc6988bc3a13fb0d825ef38ac
-  data.tar.gz: 34142d82edff4b8099610d44ca19bc039571fbcc0651a44c24588047a141838a
+  metadata.gz: 017eda83610eb76324999392d1f824fbc274f5182a3a1412ac3aaef19e9beaa8
+  data.tar.gz: 22f7ee6229d94a2f1dce2f03c7205d6c855b37b359a31b3ff6402e6c2fb40e4f
 SHA512:
-  metadata.gz: a9b228edf10da4b05019c87643079e3ebe673fb98913dfba6567877293c28e8d2fd3a6507174d2aec8010d8254bab551631b38ac20e3784281773b4546bafb16
-  data.tar.gz: 3a4cbec99a1dd380a32263d6db57b4550f030aa50c67f29af3b8b25f827dc7d8a5c2be600e282426f36b826a82d393d2a61adda782040aeb0a44f76a455d96ba
+  metadata.gz: dac03145eeddd7906005c9ad1770b745b6f6e8a4fd5185b7146b9adc9787cc21fa18697922063ba94e2ae5b3ab64839da27f4fa88fdfbe47c6cd88cb86b93b8e
+  data.tar.gz: 298e2f0955364e3175332f0288cffea4646afc410f73393c97573d1f3054fac105563af655a78a768e6ca3f69a920454dd6c3e7a859232df30fe93b9827e4fbc

data/README.md

@@ -111,9 +111,9 @@ In your controller action, you can access the validated payload like this:
 class MyApiController < ApplicationController
   # POST /rpc
   def process
-    if jsonrpc_batch?
+    if jsonrpc_params_batch?
       # ── batch ───────────────────────────────────────────────────────────────
-      responses = jsonrpc.filter_map { |req| handle_single_request(req) } # strip nil (notifications)
+      responses = jsonrpc_params.filter_map { |req| handle_single_request(req) } # strip nil (notifications)
 
       if responses.empty?
         head :no_content
@@ -123,7 +123,7 @@ class MyApiController < ApplicationController
       end
     else
       # ── single ──────────────────────────────────────────────────────────────
-      response = handle_single_request(jsonrpc)
+      response = handle_single_request(jsonrpc_params)
 
       if response # request (has id)
         render jsonrpc:  response.result,

data/lib/json_rpc/response.rb

@@ -9,14 +9,25 @@ module JSON_RPC
     # @param result [Object, nil] The result data (if successful).
     # @param error [Hash, JSON_RPC::JsonRpcError, Symbol, nil] The error object/symbol (if failed).
     # @raise [ArgumentError] if both result and error are provided, or neither is provided for non-null id.
-    def initialize(id:, result: nil, error: nil)
-      validate_response(id, result, error)
+    def initialize(id:, **kwargs)
+      # Check which parameters were actually provided
+      has_result = kwargs.key?(:result)
+      has_error = kwargs.key?(:error)
+
+      result = kwargs[:result]
+      error = kwargs[:error]
+
+      validate_response(id, has_result, has_error, result, error)
       error_obj = process_error(error)
+
       super(id: id, result: result, error: error_obj)
     end
 
     def self.from_h(h)
-      new(id: h["id"], result: h["result"], error: h["error"])
+      args = { id: h["id"] }
+      args[:result] = h["result"] if h.key?("result")
+      args[:error] = h["error"] if h.key?("error")
+      new(**args)
     end
 
     # Returns a hash representation of the response, ready for JSON serialization.
@@ -40,22 +51,21 @@ module JSON_RPC
     # Validates the response structure according to JSON-RPC 2.0 spec.
     #
     # @param id [Object] The request ID.
+    # @param has_result [Boolean] Whether result was provided.
+    # @param has_error [Boolean] Whether error was provided.
     # @param result [Object] The result data.
     # @param error_input [Object] The error data/object/symbol.
     # @raise [ArgumentError] for invalid combinations.
-    def validate_response(id, result, error_input)
-      # ID must be present (can be null) in a response matching a request.
-
-      raise ArgumentError, "Response cannot contain both 'result' and 'error'" if !error_input.nil? && !result.nil?
-
-      # If id is not null, either result or error MUST be present.
-      return unless !id.nil? && error_input.nil? && result.nil?
+    def validate_response(id, has_result, has_error, result, error_input)
+      # Cannot have both result and error
+      if has_result && has_error
+        raise ArgumentError, "Response cannot contain both 'result' and 'error'"
+      end
 
-      # This check assumes if both are nil, it's invalid for non-null id.
-      # `result: nil` is a valid success response. The check should ideally know
-      # if `result` was explicitly passed as nil vs not passed at all.
-      # Data.define might make this tricky. Let's keep the original logic for now.
-      raise ArgumentError, "Response with non-null ID must contain either 'result' or 'error'"
+      # If id is not null, either result or error MUST be present
+      if !id.nil? && !has_result && !has_error
+        raise ArgumentError, "Response with non-null ID must contain either 'result' or 'error'"
+      end
     end
 
     # Processes the error input into a standard error hash.
@@ -72,11 +82,11 @@ module JSON_RPC
         # Assume it's already a valid JSON-RPC error object hash
         error_input
       when Symbol
-        # Build from a standard error symbol
+        # Build from a standard error symbol (build returns a hash)
         JSON_RPC::JsonRpcError.build(error_input)
       else
         # Fallback to internal error if the format is unexpected
-        JSON_RPC::JsonRpcError.build(:internal_error, message: "Invalid error format provided").to_h
+        JSON_RPC::JsonRpcError.build(:internal_error, message: "Invalid error format provided")
       end
     end
   end

data/lib/jsonrpc_rails/controller_helpers.rb

@@ -7,13 +7,13 @@ module JSONRPC_Rails
     included do
       # Returns a JSON_RPC::Request / Notification / Response
       # or an Array of them for batch calls.
-      def jsonrpc
+      def jsonrpc_params
         request.env[:jsonrpc]
       end
 
       # Convenience boolean
-      def jsonrpc_batch?
-        jsonrpc.is_a?(Array)
+      def jsonrpc_params_batch?
+        jsonrpc_params.is_a?(Array)
       end
     end
   end

data/lib/jsonrpc_rails/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module JSONRPC_Rails
-  VERSION = "0.5.0"
+  VERSION = "0.5.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: jsonrpc-rails
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.2
 platform: ruby
 authors:
 - Abdelkader Boudih
@@ -67,7 +67,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.7
+rubygems_version: 3.6.9
 specification_version: 4
 summary: A Railtie-based gem that brings JSON-RPC 2.0 support to your Rails application.
 test_files: []