jsoner 0.0.3 → 0.0.4

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NjZiMGZjNWIxMzhjMmFkMzRlYTJiYTIyYjdiMjY5ZTc5YzM2MDI4MA==
+    ZjUyODljYzQ2MjJhZjdlNTVjM2FkN2EwYjQ1MmMwYzQzZmQ2YTgzYg==
   data.tar.gz: !binary |-
-    YWMyZjYzNzNkZGYzNDA3NjkwMDlkNTMzNmJkMTYwMmU1NGNkNWQ0OQ==
+    NDY2NTIxOWFiZjVkNmU1M2M3NmE0OWY2Mjc1MTM2MGZiZTM4OTA5NQ==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    ZTMxNGU2NjU2NzA4YzRiN2RlYTcyOWIxMGQyMDlhYzNkY2I4YzJjYmEwMzhj
-    ZWZhM2FhODg1MTc1NWY4OGEyZjg5NTgyMGVlMmM2YzUxZjdhMjE5YTA3YmU0
-    NGM4NzQ3ZTU4YTljNzYzZmY0MGFkMWZmNDk2ZTYxNzg1NmRkMjE=
+    M2UwZTJjNTQzZDZiZGExNTZmOThlYzA3MDUzMzE2YTY4YWU0Yzk2NmY4ZWY2
+    ZDA1ZTNhOTllZDRhYjZlM2RkZDE2NGMxY2U1MmRkMDNmYzFhZjQ4NDIwYTM5
+    ZWY4NGQxYTdjNzAwOWExNWJjYjczMzA2ZjE1Njg0ZWE3NjZjYTM=
   data.tar.gz: !binary |-
-    NWMxNjkyMjQ1Y2YwZTkwODhhYTgyNmQwM2UxMzMxM2Y4Y2EzYTIyNjgxNGM3
-    MDIzZDdkODliNDY4ZjQwYzE0NmJiMzQ4YTUyMWFkYzAzOTM3ZjYzNDI2NDUw
-    YTQwM2Y0YjQ0MTAzNTE3YTFiZTgyNDZjZDY1NTJhMGY2MjQyZTg=
+    NjQ4YjJmMTk0Y2E4YTdjZDU3ZDcyY2YwNGRlMTlkMTZkNzZlZDM3NTJkMGY2
+    ODY1MjZjNzllODY5ZGQ2M2ZiZmY0MTFhMzNjYTNjOGZjOTUyOTRhOTgyOTY4
+    NTlhMDFjZDc0OGRkOTc3ODg2N2MxNWRkMmY0Nzg2OGFkNDBkNTQ=

data/CHANGELOG.md

@@ -3,5 +3,10 @@
 * Get first table element when having more than two in parsed HTML
 
 ## v0.0.3
-* parse HTML file including HTML Table
-* fixing file is empty or have no table element
+* Parse HTML file including HTML Table
+* Fixing file is empty or have no table element
+
+## v0.0.4
+* Add rspec test of checking integrity of HTML table
+* Supply exception message of NotFullTable
+* Parse Link including HTML Table

data/README.md

@@ -61,7 +61,34 @@ json = Jsoner.parse(html)
 #     {"First Name"=>"Adam", "Last Name"=>"Johnson", "Points"=>"67"} ]
 
 ```
+Or, `Jsoner` can parse HTML file including HTML table
 
+```ruby
+require 'open-uri'
+# you must have table.html file and assign file path correctly.
+
+table = Jsoner.parse(open('table.html'))
+
+# output json => 
+# 
+#   [ {"First Name"=>"Jill", "Last Name"=>"Smith",   "Points"=>"50"},
+#     {"First Name"=>"Eve",  "Last Name"=>"Jackson", "Points"=>"94"},
+#     {"First Name"=>"John", "Last Name"=>"Doe",     "Points"=>"80"},
+#     {"First Name"=>"Adam", "Last Name"=>"Johnson", "Points"=>"67"} ]
+
+```
+
+Or you can open Link
+
+```ruby
+require 'open-uri'
+
+table = Jsoner.parse(open('http://www.w3school.com.cn/tiy/t.asp?f=html_table_header'))
+
+# output json => 
+#
+# [{"姓名"=>"Bill Gates", "电话"=>"555 77 855"}]
+```
 ## THANKS
 
 [table-to-json](https://github.com/lightswitch05/table-to-json) written by [@lightswitch05](https://github.com/lightswitch05) in JavaScript.

data/lib/jsoner.rb

@@ -7,14 +7,17 @@ require 'nokogiri'
 module Jsoner
 
   class NotFullTable < StandardError
+    def message
+      'Incomplete HTML Table'
+    end
   end
 
   class << self
 
     def parse(html)
-      html = filter(html)
-      if factory = Jsoner::TableFactory.check(Nokogiri::HTML.parse(html))
-        Jsoner::Table.new(factory).to_json
+#     html = filter(html)
+      if factory = TableFactory.check(Nokogiri::HTML.parse(html))
+        Table.new(factory).to_json
       end
     end
    

data/lib/jsoner/table_factory.rb

@@ -37,7 +37,7 @@ module Jsoner
       unless table.search('tr').empty? || table.search('td').empty? || table.search('th').empty?
         TableFactory.new doc
       else
-	raise Jsoner::NotFullTable
+	raise Jsoner::NotFullTable 
       end
     end
 

data/lib/jsoner/version.rb

@@ -1,3 +1,3 @@
 module Jsoner
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/fixtures/table_extend.rb

@@ -32,3 +32,49 @@ def table_extend_str
 </body>
   eohtml
 end
+
+def no_td_table
+  <<-eohtml
+<table id='example-table'>
+  <thead>
+    <tr>
+      <th>First Name</th>
+      <th>Last Name</th>
+      <th data-override="Score">Points</th></tr>
+  </thead>
+</table>
+  eohtml
+end
+
+def no_tr_table
+  <<-eohtml
+<table id='example-table'>
+</table>
+  eohtml
+end
+
+def no_th_table
+  <<-eohtml
+<table id='example-table'>
+  <tbody>
+    <tr>
+      <td>Jill</td>
+      <td>Smith</td>
+      <td data-override="disqualified">50</td></tr>
+    <tr>
+      <td>Eve</td>
+      <td>Jackson</td>
+      <td>94</td></tr>
+    <tr>
+      <td>John</td>
+      <td>Doe</td>
+      <td>80</td></tr>
+    <tr>
+      <td>Adam</td>
+      <td>Johnson</td>
+      <td>67</td></tr>
+  </tbody>
+</table>
+  eohtml
+end
+

data/spec/jsoner/table_factory_spec.rb

@@ -52,6 +52,29 @@ describe 'build Hash below from doc parsed by Nokogiki' do
      # TODO testing when having no header in table
   end
 
+  context "check integrity of HTML table" do
+
+    it "when having no tr element" do
+      doc = Nokogiri::HTML.parse(no_tr_table)
+      expect{ Jsoner::TableFactory.check(doc) }.to raise_error Jsoner::NotFullTable
+    end
+
+    it "when having no td element" do
+      doc = Nokogiri::HTML.parse(no_td_table)
+      expect{ Jsoner::TableFactory.check(doc) }.to raise_error Jsoner::NotFullTable
+    end
+
+    it "when having no th element" do
+      doc = Nokogiri::HTML.parse(no_th_table)
+      expect{ Jsoner::TableFactory.check(doc) }.to raise_error Jsoner::NotFullTable
+    end
+
+    it "should return factory if integrity" do
+      doc = Nokogiri::HTML.parse(table_str)
+      Jsoner::TableFactory.check(doc).should be_instance_of Jsoner::TableFactory
+    end
+  end
+
   context "filter HTML" do
     
     before :each do

data/spec/jsoner_spec.rb

@@ -1,6 +1,10 @@
+# encoding: utf-8
 Dir["#{File.dirname(__FILE__)}/fixtures/*.rb"].each {|file| require file }
 require "#{File.dirname(__FILE__)}/../lib/jsoner"
 
+require 'open-uri'
+require 'json'
+
 describe Jsoner do
   
   it "should match data from json of fixtures" do
@@ -8,10 +12,26 @@ describe Jsoner do
   end
 
   it "should parse file including table" do
-    Jsoner.parse("#{File.dirname(__FILE__)}/fixtures/table.html").should == json
+    Jsoner.parse(open("#{File.dirname(__FILE__)}/fixtures/table.html")).should == json
   end
 
   it "should raise error when having no full table in HTML file" do
-    expect{ Jsoner.parse("#{File.dirname(__FILE__)}/fixtures/table_extend.html")}.to raise_error Jsoner::NotFullTable
+    expect{ Jsoner.parse(open("#{File.dirname(__FILE__)}/fixtures/table_extend.html"))}.to raise_error Jsoner::NotFullTable
+  end
+
+  # http://www.w3school.com.cn/tiy/t.asp?f=html_table_headers
+  it "should parse Link include table" do
+    json = Jsoner.parse(open("http://www.w3school.com.cn/tiy/t.asp?f=html_table_headers"))
+    JSON.parse(json).should == [{"姓名"=>"Bill Gates", "电话"=>"555 77 855"}]
+  end
+
+  context "data parsed" do
+    it "it is HTML file" do
+      Jsoner.filter(open("#{File.dirname(__FILE__)}/fixtures/table.html")).should == table_str
+    end
+
+    it "it is  String" do
+      Jsoner.filter("<table></table>").should == "<table></table>"
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: jsoner
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - simlegate
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-29 00:00:00.000000000 Z
+date: 2013-08-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler