jsonapi-realizer 4.3.0 → 4.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7fd1601642408028cb8b64b1f8a9276a13e1a4bd415eba396d7241477e2c7f05
-  data.tar.gz: f541b582a1efe495e91c34a110cc7ad937651b29043daa7c1fe5780ae814361c
+  metadata.gz: 6a8bebae1837baec43c16e73cc362203f65387459f992a81732d035ffdb0c61e
+  data.tar.gz: dad4dfe6f56dd8c85f35c9e3f829939d5278e652f7489d9a01958d15071e3aa8
 SHA512:
-  metadata.gz: 730abd038c5ec82727e7e332b7304fb43c45bc471d84466294f0d686d32e2f2e692e5b1959f2bfe288ef5564ae7939659a9732cec4fb17dd02db4ed55820d2a5
-  data.tar.gz: c60aa2e21f4a0e75d394e6ebcdbe46a30a00afd21cb3df6c0db6f05b759e951c643f3b3e4da38319ecb628e7984d6c3c9cc71b8c5a80bd5035036f27c188d73c
+  metadata.gz: 101883f640d8a56b561212abc84fd4cdf34613b41a0f14e6d8625eb6439b31c1e236eece7663366aa1ba6b7660279da05547d1f9eba9050ded2a12c04aa4fec4
+  data.tar.gz: cb0f5eb6555aa35c64e7b8bafbeced9bad365ff337bd26ea5a023e26e529a6ecd3b3c2f4cde93de4090f9243d31df486b28a2f59dd99c02dac73f9c6488ca60c

data/README.md

@@ -135,7 +135,7 @@ class PhotosController < ApplicationController
       policy(Photo).sanitize(:index, params),
       headers: request.headers,
       type: :posts,
-      relation: policy_scope(Photo)
+      scope: policy_scope(Photo)
     )
 
     # See: pundit for `authorize()`

data/lib/jsonapi/realizer.rb

@@ -13,26 +13,6 @@ module JSONAPI
     require_relative "realizer/adapter"
     require_relative "realizer/resource"
 
-    def self.register(resource_class:, model_class:, adapter:, type:)
-      @mapping ||= Set.new
-      @mapping << OpenStruct.new({
-        resource_class: resource_class,
-        model_class: model_class,
-        adapter: adapter,
-        type: type.dasherize,
-        attributes: OpenStruct.new({}),
-        relationships: OpenStruct.new({})
-       })
-    end
-
-    def self.resource_mapping
-      @mapping.index_by(&:resource_class)
-    end
-
-    def self.type_mapping
-      @mapping.index_by(&:type)
-    end
-
     def self.create(payload, headers:, scope: nil)
       enact(Action::Create.new(payload: payload, headers: headers, scope: scope))
     end

data/lib/jsonapi/realizer/action.rb

@@ -94,7 +94,7 @@ module JSONAPI
           end
         else
           data = value.fetch("data")
-          mapping = JSONAPI::Realizer.type_mapping.fetch(data.fetch("type"))
+          mapping = JSONAPI::Realizer::Resource.type_mapping.fetch(data.fetch("type"))
           mapping.adapter.find_via_call(
             mapping.model_class,
             data.fetch("id")
@@ -120,7 +120,7 @@ module JSONAPI
             chain.reduce(resource_class) do |last_resource_class, key|
               break unless last_resource_class
 
-              JSONAPI::Realizer.type_mapping.fetch(last_resource_class.relationship(key).as).resource_class if last_resource_class.valid_includes?(key)
+              JSONAPI::Realizer::Resource.type_mapping.fetch(last_resource_class.relationship(key).as).resource_class if last_resource_class.valid_includes?(key)
             end
           end
           # [["carts", "cart_items", "product"], ["payments"]]
@@ -145,7 +145,7 @@ module JSONAPI
               break unless last_resource_class
 
               if last_resource_class.valid_includes?(key)
-                JSONAPI::Realizer.type_mapping.fetch(last_resource_class.relationship(key).as).resource_class
+                JSONAPI::Realizer::Resource.type_mapping.fetch(last_resource_class.relationship(key).as).resource_class
               elsif last_resource_class.valid_sparse_field?(key)
                 last_resource_class
               end
@@ -155,7 +155,7 @@ module JSONAPI
       end
 
       private def configuration
-        JSONAPI::Realizer.type_mapping.fetch(type) if type
+        JSONAPI::Realizer::Resource.type_mapping.fetch(type) if type
       end
     end
   end

data/lib/jsonapi/realizer/adapter_spec.rb

@@ -1,30 +1,4 @@
 require "spec_helper"
 
 RSpec.describe JSONAPI::Realizer::Adapter do
-  describe ".adapt" do
-    context "for the active_record mapped alias" do
-      it "defines the find_via_call instance variable as a anonymous function"
-      it "defines the find_via_call instance variable as a anonymous function"
-    end
-
-    context "for a mapped alias that doesn't exist" do
-
-    end
-
-    context "for a block defintion" do
-
-    end
-
-    context "for an alias and block defintion" do
-
-    end
-
-    context "when the find_via interface isn't defined" do
-
-    end
-
-    context "when the assign_attributes_via interface isn't defined" do
-
-    end
-  end
 end

data/lib/jsonapi/realizer/error.rb

@@ -9,6 +9,7 @@ module JSONAPI
       require_relative "error/missing_content_type_header"
       require_relative "error/missing_root_property"
       require_relative "error/missing_type_resource_property"
+      require_relative "error/duplicate_registration"
     end
   end
 end

data/lib/jsonapi/realizer/error/duplicate_registration.rb

@@ -0,0 +1,9 @@
+module JSONAPI
+  module Realizer
+    class Error
+      class DuplicateRegistration < Error
+
+      end
+    end
+  end
+end

data/lib/jsonapi/realizer/resource.rb

@@ -5,6 +5,27 @@ module JSONAPI
 
       attr_reader :model
 
+      def self.register(resource_class:, model_class:, adapter:, type:)
+        @mapping ||= Set.new
+        raise JSONAPI::Realizer::Error::DuplicateRegistration if @mapping.any? { |realizer| realizer.type == type }
+        @mapping << OpenStruct.new({
+          resource_class: resource_class,
+          model_class: model_class,
+          adapter: adapter,
+          type: type.dasherize,
+          attributes: OpenStruct.new({}),
+          relationships: OpenStruct.new({})
+         })
+      end
+
+      def self.resource_mapping
+        @mapping.index_by(&:resource_class)
+      end
+
+      def self.type_mapping
+        @mapping.index_by(&:type)
+      end
+
       def initialize(model)
         @model = model
       end
@@ -91,7 +112,7 @@ module JSONAPI
         end
 
         def register(type, class_name:, adapter:)
-          JSONAPI::Realizer.register(
+          JSONAPI::Realizer::Resource.register(
             resource_class: self,
             model_class: class_name.constantize,
             adapter: JSONAPI::Realizer::Adapter.new(adapter),
@@ -100,7 +121,7 @@ module JSONAPI
         end
 
         def configuration
-          JSONAPI::Realizer.resource_mapping.fetch(self)
+          JSONAPI::Realizer::Resource.resource_mapping.fetch(self)
         end
       end
     end

data/lib/jsonapi/realizer/resource_spec.rb

@@ -0,0 +1,16 @@
+require "spec_helper"
+
+RSpec.describe JSONAPI::Realizer do
+  describe ".register" do
+    subject {JSONAPI::Realizer::Resource.register(resource_class: "Test", model_class: "test", adapter: :a, type: "a")}
+    context "with something already owning that type" do
+      before do
+        JSONAPI::Realizer::Resource.register(resource_class: "Test", model_class: "test", adapter: :a, type: "a")
+      end
+
+      it "raises an exception" do
+        expect {subject}.to(raise_exception(JSONAPI::Realizer::Error::DuplicateRegistration))
+      end
+    end
+  end
+end

data/lib/jsonapi/realizer/version.rb

@@ -1,5 +1,5 @@
 module JSONAPI
   module Realizer
-    VERSION = "4.3.0"
+    VERSION = "4.4.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: jsonapi-realizer
 version: !ruby/object:Gem::Version
-  version: 4.3.0
+  version: 4.4.0
 platform: ruby
 authors:
 - Kurtis Rainbolt-Greene
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-07-30 00:00:00.000000000 Z
+date: 2018-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -204,6 +204,7 @@ files:
 - lib/jsonapi/realizer/adapter/memory.rb
 - lib/jsonapi/realizer/adapter_spec.rb
 - lib/jsonapi/realizer/error.rb
+- lib/jsonapi/realizer/error/duplicate_registration.rb
 - lib/jsonapi/realizer/error/include_without_data_property.rb
 - lib/jsonapi/realizer/error/invalid_accept_header.rb
 - lib/jsonapi/realizer/error/invalid_content_type_header.rb
@@ -213,6 +214,7 @@ files:
 - lib/jsonapi/realizer/error/missing_root_property.rb
 - lib/jsonapi/realizer/error/missing_type_resource_property.rb
 - lib/jsonapi/realizer/resource.rb
+- lib/jsonapi/realizer/resource_spec.rb
 - lib/jsonapi/realizer/version.rb
 - lib/jsonapi/realizer/version_spec.rb
 - lib/jsonapi/realizer_spec.rb