jsonapi-consumer 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2ebd6ed496bf4e33e58103e89a8ea1f8ec65e49c
-  data.tar.gz: 4de1a846349a7e3606f45573fa70dd8c2b60bbdd
+  metadata.gz: 0279cf38de5603887f2d3f092240e8e687321ca9
+  data.tar.gz: 7b34f561d00437e45054114cc6f1b81177e30129
 SHA512:
-  metadata.gz: f90b5cf975914fdc9dced9176b48e8705f98c3ee8b423c653629aa76513e11b3615ed7e771f4bd54c58416198ad5073198b955a9bd8e379672c5fde8b5fa9ec6
-  data.tar.gz: 25da9ee3afd9b759a001834fb4989aeb73c1e6a8c0cfc59cecd51bd09fa1a17ac33350618db264089108a9fa7cacd68aef81f2a6f5c79fa0e602aab0cd5bb32b
+  metadata.gz: 598a4b6321e2e7d742f8d781b095fb9f9eb2ade74eadf1035b110c8cbbef244d7a34c256a6a50e15850e3d3177038b5bb0d6549ce5eb81a4239a2f2d17754833
+  data.tar.gz: e1068ea2f333ca27a0f536628e2c3165f2af473703a71331553d579b62994045d7d6533bc30b9f841d59c987e290a0224d6ed168b1d88fa1ced9dffbd81ae4b7

data/CHANGELOG.md

@@ -1,4 +1,10 @@
 
+0.1.1 / 2015-01-23
+==================
+
+  * Add internal helper #remove_links? for association payloads
+  * Do not send `links: {}` if new object, and empty associations
+
 0.1.0 / 2014-12-03
 ==================
 

data/lib/jsonapi/consumer/resource/serializer_concern.rb

@@ -7,15 +7,13 @@ module JSONAPI::Consumer::Resource
 
       self.each_association do |name, association, options|
         @hash[:links] ||= {}
-        # unless options[:embed] == :ids
-          # @hash[:linked] ||= {}
-        # end
 
-        if association.respond_to?(:each)
+        if association.respond_to?(:each) or _association_type(name) == :has_many
           add_links(name, association, options)
         else
           add_link(name, association, options)
         end
+        @hash.delete(:links) if remove_links?
       end
 
       @hash
@@ -23,7 +21,7 @@ module JSONAPI::Consumer::Resource
 
     def add_links(name, association, options)
       @hash[:links][name] ||= []
-      @hash[:links][name] += association.map do |obj|
+      @hash[:links][name] += (association || []).map do |obj|
         case obj.class
         when String, Integer
           obj
@@ -31,11 +29,6 @@ module JSONAPI::Consumer::Resource
           obj.to_param
         end
       end
-
-      # unless options[:embed] == :ids
-        # @hash[:linked][name] ||= []
-        # @hash[:linked][name] += association.map { |item| item.attributes(options) }
-      # end
     end
 
     def add_link(name, association, options)
@@ -47,18 +40,24 @@ module JSONAPI::Consumer::Resource
                             else
                               association.to_param
                             end
-
-      # unless options[:embed] == :ids
-        # plural_name = name.to_s.pluralize.to_sym
-
-        # @hash[:linked][plural_name] ||= []
-        # @hash[:linked][plural_name].push association.attributes(options)
-      # end
     end
 
     def to_json(options={})
       serializable_hash(options).to_json
     end
 
+  private
+
+    def remove_links?
+      if persisted?
+        false
+      else # not persisted, new object
+        if @hash[:links].length == 0 or @hash[:links].values.flatten.empty?
+          true
+        else
+          false
+        end
+      end
+    end
   end
 end

data/lib/jsonapi/consumer/version.rb

@@ -1,5 +1,5 @@
 module Jsonapi
   module Consumer
-    VERSION = "0.1.0"
+    VERSION = "0.1.1"
   end
 end

data/spec/jsonapi/consumer/associations_spec.rb

@@ -48,8 +48,33 @@ RSpec.describe 'Associations', 'has_many' do
   describe 'the links payload' do
     subject(:payload_hash) { user_instance.serializable_hash }
 
-    it 'has links in output' do
-      expect(payload_hash).to have_key(:links)
+    describe 'when populated' do
+      before do
+        user_instance.posts = ['1']
+      end
+
+      it 'has links in output, if present' do
+        expect(payload_hash).to have_key(:links)
+        expect(payload_hash[:links]).to eql({posts: ['1']})
+        expect(payload_hash[:links][:posts]).to eql(["1"])
+      end
+    end
+
+    describe 'when empty' do
+      it 'has no links in output' do
+        expect(payload_hash).to_not have_key(:links)
+      end
+    end
+
+    describe 'when persisted and empty' do
+      before do
+        allow(user_instance).to receive(:persisted?).and_return(true)
+      end
+
+      it 'has a links hash in the output' do
+        expect(payload_hash).to have_key(:links)
+        expect(payload_hash[:links]).to eql({posts: []})
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: jsonapi-consumer
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Justin Smestad
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-03 00:00:00.000000000 Z
+date: 2015-01-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel