json_schema_power_validator 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 217f235573a81f3d22ebb64633f775e1fbe3a9f9
-  data.tar.gz: a0b7ac78f8beac81d279b74729b555299c279bec
+  metadata.gz: f0aa3c0a867fb7090ea55bc8394aec11648134e8
+  data.tar.gz: 8af17a444810c2985a3bfa37bb15346b34f207a0
 SHA512:
-  metadata.gz: 260a86c6ffa094e83778a21349db4697f55d942b6954dda5e3bcc9b7f1cb03fc1e445e3aa9656d36ebd05940b6cae6805e5af5f56f13289c5fa9179f6fda2641
-  data.tar.gz: fd07b1aa717066dba3b93fb87220e01b3634c957e8ed236f84a860eab3ab6fefebb6417139c97a7759f35f63c56f90928a8ad7a20d37ed015550718d447d884d
+  metadata.gz: 403d86358cd540f07c53603e6fafa83f9356f47105d3d99b0da652ac04c4cc7176abee593068ca5bdd6b94a90a759f7f37ad40101aafc2769928bdf4e6189dcd
+  data.tar.gz: 06121b18d0b7a07876732d85bd0f9a34177c4727ec6f8a385a8f77b0502904e4f0ea16d24ef891244e006b8347a0cdafa9b2b580776e2a009dd5988df6f4d338

data/lib/json_schema_power_validator.rb

@@ -17,7 +17,7 @@ module JsonSchema
     end
 
     def ok?
-      @raw_results.all? { |result| result == "Success" }
+      @raw_results.all? { |result| result == success }
     end
 
     private
@@ -28,9 +28,9 @@ module JsonSchema
       @suites["examples"].each do |suite|
         begin
           JSON::Validator.validate!(@schema, suite["values"])
-          suite["expect"] == "valid" ? @raw_results.push("Success") : @raw_results.push("A validation passed, but it opposites the expectation.")
+          verify_result_and_expectation(suite, valid, valid_but_unexpected_error)
         rescue JSON::Schema::ValidationError
-          suite["expect"] == "invalid" ? @raw_results.push("Success") : @raw_results.push($!.message)
+          verify_result_and_expectation(suite, invalid, $!.message)
         end
       end
 
@@ -38,15 +38,11 @@ module JsonSchema
     end
 
     def verify_suite_parameters
-      unless @suites["examples"]
-        raise ParseSuiteError.new("examples for a test suite is undefined, or format is invalid.")
-      end
+      raise ParseSuiteError.new(example_is_undefined_error) unless @suites["examples"]
       
       @suites["examples"].each do |suite|
-        ["context", "description", "expect", "values"].each do |param|
-          if suite[param].nil?
-            raise ParseSuiteError.new("#{param} for a test suite is undefined.")
-          end          
+        suite_params.each do |param|          
+          raise ParseSuiteError.new(test_suite_is_undefined_error) unless suite[param]
         end
       end
     end
@@ -61,5 +57,39 @@ module JsonSchema
       }
       {results: @result_json}
     end
+
+    def verify_result_and_expectation(suite, expectation, error_message)
+      suite["expect"] == expectation ? @raw_results.push(success) : @raw_results.push(error_message)
+    end
+
+    def test_suite_is_undefined_error(param)
+      "#{param} for a test suite is undefined."
+    end
+
+    # Constants
+
+    def success
+      "Success"
+    end
+
+    def suite_params
+      ["context", "description", "expect", "values"]
+    end
+
+    def valid
+      "valid"
+    end
+
+    def invalid
+      "invalid"
+    end
+    
+    def valid_but_unexpected_error
+      "A validation passed, but it opposites the expectation."
+    end
+
+    def example_is_undefined_error
+      "examples for a test suite is undefined, or format is invalid."
+    end
   end
 end

data/lib/json_schema_power_validator/version.rb

@@ -1,3 +1,3 @@
 module JsonSchema
-  VERSION = "0.4.0"
+  VERSION = "0.4.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: json_schema_power_validator
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - timakin
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2015-07-25 00:00:00.000000000 Z
+date: 2015-07-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler