json_roa-client 1.0.0.pre.beta.2 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 46382a4f2f15aff6db0a65d35cf46f7a6dab4ccc
-  data.tar.gz: f64826275e7ce06c69deac16ddaad67b997fe103
+  metadata.gz: 9b48bd9fee8fa88a388136211e2b6fcadbb635ba
+  data.tar.gz: 487226246eb7481ccbefd741c5d35dbc2c4cd3db
 SHA512:
-  metadata.gz: 70cd3d8b62f0ad4d6557cdbb635b9487ccca60868c3d17002552b343967ce16041fa1da3d5b734d539d8a47d25e3983ee2b590a18903bf8183bcc27c2bdd2934
-  data.tar.gz: 804362c743bef126bf91fc7b5bd8726d239caa5aca1e07a2f4aa3824df9e4ad1e9a1366d7b845da9d578317d1e7f0c4f32ef08e4f9a334e6315c96d32c3ea249
+  metadata.gz: 289c5648a42ddcc4a39a7b3b606d233a7560c53c054703869721731acb2af6a71f196d6b194f988605af0886e3a5c40ef2092e270cbe3632ead68a186b28d1bc
+  data.tar.gz: d713aab8bf657eafc4f7fbf1d4b5147d29dce8c46e055cf3352a08f1f0efb90e2c17b370cfab1e792e538e36614c53857772e72a9beef160823de9002f6fddf4

data/.rubocop.yml

@@ -0,0 +1,179 @@
+AllCops:
+  Exclude:
+    - 'db/**/*'
+    - 'config/**/*'
+    - 'Gemfile'
+  RunRailsCops: true
+
+Lint/AmbiguousOperator:
+  Enabled: false
+
+Lint/AmbiguousRegexpLiteral:
+  Enabled: false
+
+Lint/AssignmentInCondition:
+  Enabled: false
+
+Lint/DeprecatedClassMethods:
+  Enabled: false
+
+Lint/ParenthesesAsGroupedExpression:
+  Enabled: false
+
+Lint/RescueException:
+  Enabled: false
+
+Lint/ShadowingOuterLocalVariable:
+  Enabled: false
+
+# Cop supports --auto-correct.
+Lint/UnusedBlockArgument:
+  Enabled: false
+
+Metrics/AbcSize:
+  Max: 136
+
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 128
+
+Metrics/CyclomaticComplexity:
+  Max: 10
+
+# Configuration parameters: AllowURI, URISchemes.
+Metrics/LineLength:
+  Max: 81
+
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 124
+
+Metrics/PerceivedComplexity:
+  Max: 11
+
+Style/AccessorMethodName:
+  Enabled: false
+
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/AndOr:
+  Enabled: false
+
+Style/AsciiComments:
+  Enabled: false
+
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/ClassAndModuleChildren:
+  Enabled: false
+
+# Cop supports --auto-correct.
+Style/ColonMethodCall:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/EmptyLinesAroundBlockBody:
+  Enabled: false
+
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/EmptyLinesAroundClassBody:
+  Enabled: false
+
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/EmptyLinesAroundModuleBody:
+  Enabled: false
+
+# Configuration parameters: Exclude.
+Style/FileName:
+  Enabled: false
+
+Style/GuardClause:
+  Enabled: false
+
+# Configuration parameters: MaxLineLength.
+Style/IfUnlessModifier:
+  Enabled: false
+
+# Cop supports --auto-correct.
+# Configuration parameters: Width.
+Style/IndentationWidth:
+  Enabled: false
+
+Style/MultilineBlockChain:
+  Enabled: false
+
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/MultilineOperationIndentation:
+  Enabled: false
+
+# Cop supports --auto-correct.
+Style/Not:
+  Enabled: false
+
+# Cop supports --auto-correct.
+Style/NumericLiterals:
+  MinDigits: 7
+
+# Cop supports --auto-correct.
+# Configuration parameters: AllowSafeAssignment.
+Style/ParenthesesAroundCondition:
+  Enabled: false
+
+# Cop supports --auto-correct.
+Style/RedundantBegin:
+  Enabled: false
+
+# Cop supports --auto-correct.
+Style/RedundantSelf:
+  Enabled: false
+
+Style/RescueModifier:
+  Enabled: false
+
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/SignalException:
+  Enabled: false
+
+# Cop supports --auto-correct.
+Style/SpecialGlobalVars:
+  Enabled: false
+
+Style/UnlessElse:
+  Enabled: false
+
+# Cop supports --auto-correct.
+# Configuration parameters: WordRegex.
+Style/WordArray:
+  MinSize: 2
+
+# Configuration parameters: Include.
+Rails/HasAndBelongsToMany:
+  Enabled: false
+
+# Configuration parameters: Include.
+Rails/Output:
+  Enabled: false
+
+# Configuration parameters: Include.
+Rails/ReadWriteAttribute:
+  Enabled: false
+
+# Configuration parameters: Include.
+Rails/Validation:
+  Enabled: false
+
+
+# Offense count: 6
+Style/ClassAndModuleCamelCase:
+  Enabled: false
+
+# Offense count: 2
+Style/RegexpLiteral:
+  MaxSlashes: 0

data/README.md

@@ -2,34 +2,12 @@
 
 A ruby client for `JSON-ROA`.
 
-## Semantic Versioning and Rubygems Versioning
+## State
 
-This library is _BETA_ because the [JSON-ROA specifciation][] itself is
-_BETA_. This library uses [Semantic Versioning][] and the current version
-is [1.0.0-beta.2](./lib/json_roa/client/version.rb).
+[![Code Climate][]][]
 
-The rubygems system [claims also to use semantic versioning][] and even *urges
-gem developers to follow it*. Rubygems transforms the version as given above
-into `1.0.0.pre.beta.1`. Any work using this library should specify the
-following in the Gemfile 
-
-    gem 'json_roa-client', '= 1.0.0.pre.beta.2' 
-
-or the following in the gemspec 
-
-    spec.add_runtime_dependency 'json_roa-client', '= 1.0.0.pre.beta.2'
-
-In the latter case, building the gem will result in a warning because of the
-prerelease. You can safely ignore this warning. It is in the context of
-semantic versioning misleading. However, it is important to fix the dependency
-by using the `=` sign. In this case, violation would warrant a warning. 
-
-
-
-
-  [JSON-ROA specifciation]: http://json-roa.github.io/specification.html
-  [Semantic Versioning]: http://semver.org/
-  [claims also to use semantic versioning]: http://guides.rubygems.org/patterns/#semantic-versioning
+  [Code Climate]: https://codeclimate.com/github/json-roa/json-roa_ruby-client/badges/gpa.svg
+  [![Code Climate][]]: https://codeclimate.com/github/json-roa/json-roa_ruby-client
 
 ## Usage
 
@@ -97,3 +75,34 @@ end
   [URI Template]: http://tools.ietf.org/html/rfc6570
   [Faraday]: https://github.com/lostisland/faraday
 
+
+
+## Semantic Versioning and Rubygems Versioning
+
+This library is _BETA_ because the [JSON-ROA specifciation][] itself is
+_BETA_. This library uses [Semantic Versioning][] and the current version
+is [1.0.0-beta.2](./lib/json_roa/client/version.rb).
+
+The rubygems system [claims also to use semantic versioning][] and even *urges
+gem developers to follow it*. Rubygems transforms the version as given above
+into `1.0.0.pre.beta.1`. Any work using this library should specify the
+following in the Gemfile 
+
+    gem 'json_roa-client', '= 1.0.0.pre.beta.2' 
+
+or the following in the gemspec 
+
+    spec.add_runtime_dependency 'json_roa-client', '= 1.0.0.pre.beta.2'
+
+In the latter case, building the gem will result in a warning because of the
+prerelease. You can safely ignore this warning. It is in the context of
+semantic versioning misleading. However, it is important to fix the dependency
+by using the `=` sign. In this case, violation would warrant a warning. 
+
+
+
+
+  [JSON-ROA specifciation]: http://json-roa.github.io/specification.html
+  [Semantic Versioning]: http://semver.org/
+  [claims also to use semantic versioning]: http://guides.rubygems.org/patterns/#semantic-versioning
+

data/Rakefile

@@ -1,2 +1 @@
-require "bundler/gem_tasks"
-
+require 'bundler/gem_tasks'

data/json_roa-client.gemspec

@@ -4,25 +4,27 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'json_roa/client/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "json_roa-client"
+  spec.name          = 'json_roa-client'
   spec.version       = JSON_ROA::Client::VERSION
-  spec.authors       = ["Thomas Schank"]
-  spec.email         = ["DrTom@schank.ch"]
-  spec.summary       = "The Ruby JSON-ROA Client Reference Implementation"
-  spec.description   = ""
-  spec.homepage      = ""
-  spec.license       = "MIT"
+  spec.authors       = ['Thomas Schank']
+  spec.email         = ['DrTom@schank.ch']
+  spec.summary       = 'The Ruby JSON-ROA Client Reference Implementation'
+  spec.description   = ''
+  spec.homepage      = ''
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_development_dependency "bundler", "~> 1.6"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "pry", '~> 0.10'
-  spec.add_development_dependency 'simplecov', '~> 0.9' 
+  spec.add_development_dependency 'bundler', '~> 1.6'
+  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'pry', '~> 0.10'
+  spec.add_development_dependency 'simplecov', '~> 0.9'
   spec.add_development_dependency 'rspec', '~> 3'
+  spec.add_development_dependency 'cider_ci-support', '= 1.1.0.pre.beta.3'
+  spec.add_development_dependency 'rubocop'
 
   spec.add_dependency 'addressable', '~> 2'
   spec.add_dependency 'faraday', '~> 0.9'

data/lib/json_roa/client.rb

@@ -1,5 +1,5 @@
-require "json_roa/client/version"
-require "json_roa/client/resource"
+require 'json_roa/client/version'
+require 'json_roa/client/resource'
 require 'faraday'
 require 'faraday_middleware'
 
@@ -11,33 +11,32 @@ module JSON_ROA
         env.class.class_eval do |klass|
           attr_accessor :json_roa_data
         end
-        env.json_roa_data= env.body.delete("_json-roa")
+        env.json_roa_data = env.body.delete('_json-roa')
       end
     end
   end
 
   module Client
 
-    class << self 
+    class << self
 
-      def connect url, &block 
-
-        @conn= Faraday.new(url: url,
-                              headers: {accept: "application/json-roa+json"}) do |conn|
-          conn.use ::JSON_ROA::Middleware
-          conn.response :json, :content_type => /\bjson$/
-          conn.request :retry
-          conn.use Faraday::Response::RaiseError
-          conn.adapter Faraday.default_adapter  
-        end
+      def connect(url, &_block)
+        @conn = Faraday.new(
+          url: url,
+          headers: { accept: 'application/json-roa+json' }) do |conn|
+            conn.use ::JSON_ROA::Middleware
+            conn.response :json, content_type: /\bjson$/
+            conn.request :retry
+            conn.use Faraday::Response::RaiseError
+            conn.adapter Faraday.default_adapter
+          end
 
         yield @conn if block_given?
-
-        Relation.new @conn, "root", {"href" => url}
-
+        Relation.new @conn, 'root', 'href' => url
       end
 
     end
+
   end
 
 end

data/lib/json_roa/client/collection.rb

@@ -4,32 +4,39 @@ module JSON_ROA
     class Collection
       include Enumerable
 
-      def initialize conn, resource
-        @conn= conn
-        @resource= resource
+      def initialize(conn, resource)
+        @conn = conn
+        @resource = resource
       end
 
-      def each &block
+      def each(&_block)
+        loop do
 
-        while true do 
-
-          relations= @resource.json_roa_data['collection']['relations'] rescue []
+          relations = collection_data['relations'] rescue []
 
           relations.each do |key, data|
-            yield Relation.new(@conn,key,data) if block_given? 
+            yield Relation.new(@conn, key, data) if block_given?
           end
 
-          next_val= @resource.json_roa_data['collection']['next'] rescue nil
+          next_val = collection_data['next'] rescue nil
 
           if relations.empty? or (not next_val)
-            break 
+            break
           else
-            @resource= Relation.new(@conn,"next",next_val).get()
+            @resource = Relation.new(@conn, 'next', next_val).get
           end
 
         end
+      end
 
+      def collection_data
+        @resource.json_roa_data['collection']
       end
+
+      def to_s
+        "#{self.class.name}: #{collection_data}"
+      end
+
     end
 
   end

data/lib/json_roa/client/relation.rb

@@ -8,10 +8,10 @@ module JSON_ROA
       attr_reader :data
       attr_reader :key
 
-      def initialize conn, key, data 
-        @conn= conn
-        @key= key
-        @data= data
+      def initialize(conn, key, data)
+        @conn = conn
+        @key = key
+        @data = data
 
         Faraday::Connection::METHODS.intersection(available_methods) \
           .each do |method_name|
@@ -19,41 +19,44 @@ module JSON_ROA
           end
       end
 
-      def define_http_method method_name
+      def define_http_method(method_name)
         define_singleton_method method_name \
-          do |query_parameters={}, body=nil, headers=nil, &block|
+          do |query_parameters = {}, body = nil, headers = nil, &block|
         run_request method_name, query_parameters, body, headers, &block
         end
       end
 
-      def assert_proper_query_parameters! query_parameters, template
+      def assert_proper_query_parameters!(query_parameters, template)
         unless Set.new(query_parameters.keys).subset? Set.new(template.keys)
-          raise StandardError, ["query_parameters", query_parameters.keys.to_s,
-                                "do not match template parameters",
-                                template.keys.to_s].join(" ") 
+          raise StandardError, ['query_parameters', query_parameters.keys.to_s,
+                                'do not match template parameters',
+                                template.keys.to_s].join(' ')
         end
       end
 
-      def run_request method, query_parameters, body, headers, &block
-        href= @data['href']
-        template= ::Addressable::Template.new(href) 
+      def run_request(method, query_parameters, body, headers, &block)
+        href = @data['href']
+        template = ::Addressable::Template.new(href)
         assert_proper_query_parameters! query_parameters, template
-        expanded_url= template.expand(query_parameters)
-        response=@conn.run_request( \
+        expanded_url = template.expand(query_parameters)
+        response = @conn.run_request( \
           method.to_sym, expanded_url, body, headers, &block)
-        ::JSON_ROA::Client::Resource.new(@conn,response)
+        ::JSON_ROA::Client::Resource.new(@conn, response)
       end
 
       def available_methods_data
-        @data['methods'] ||= {"get" => {}}
+        @data['methods'] ||= { 'get' => {} }
       end
 
       def available_methods
         available_methods_data.keys.map(&:to_sym)
       end
 
+      def to_s
+        "#{self.class.name}:  #{@data}"
+      end
+
     end
 
   end
 end
-

data/lib/json_roa/client/resource.rb

@@ -1,5 +1,5 @@
-require "json_roa/client/relation"
-require "json_roa/client/collection"
+require 'json_roa/client/relation'
+require 'json_roa/client/collection'
 
 module JSON_ROA
   module Client
@@ -8,19 +8,19 @@ module JSON_ROA
 
       attr_reader :response
 
-      def initialize conn, response = nil
-        @conn= conn
-        @response= response || conn.get
+      def initialize(conn, response = nil)
+        @conn = conn
+        @response = response || conn.get
       end
 
-      def relation key
-        relhash= json_roa_data['relations'][key]
+      def relation(key)
+        relhash = json_roa_data['relations'][key]
         ::JSON_ROA::Client::Relation.new @conn, key, relhash
       end
 
       def self_relation
         ::JSON_ROA::Client::Relation.new( \
-          @conn, "self", json_roa_data['self_relation']) rescue nil
+          @conn, 'self', json_roa_data['self_relation']) rescue nil
       end
 
       def data
@@ -32,10 +32,14 @@ module JSON_ROA
       end
 
       def collection
-        ::JSON_ROA::Client::Collection.new @conn, self 
+        ::JSON_ROA::Client::Collection.new @conn, self
       end
+
+      def to_s
+        "#{self.class.name}: #{data} #{json_roa_data}"
+      end
+
     end
 
   end
 end
-

data/lib/json_roa/client/version.rb

@@ -1,5 +1,5 @@
 module JSON_ROA
   module Client
-    VERSION = "1.0.0-beta.2"
+    VERSION = '1.0.0'
   end
 end

data/spec/api_query_spec.rb

@@ -1,39 +1,38 @@
 require_relative 'spec_helper.rb'
 
+describe 'API: traversing from root to resource to some relation'  do
 
-describe "API: traversing from root to resource to some relation"  do
+  describe 'root relation' do
 
-  describe "root relation" do
-
-    let :root_relation do 
-      JSON_ROA::Client.connect("/")
+    let :root_relation do
+      JSON_ROA::Client.connect('/')
     end
 
-    describe "root_resource via get"  do
+    describe 'root_resource via get'  do
 
-      subject(:root_resource) {root_relation.get() }
+      subject(:root_resource) { root_relation.get }
 
-      it do 
-        expect(root_resource.class).to be== JSON_ROA::Client::Resource
+      it do
+        expect(root_resource.class).to be == JSON_ROA::Client::Resource
       end
 
-      describe "data" do
-        subject(:data) {root_resource.data}
+      describe 'data' do
+        subject(:data) { root_resource.data }
 
-       it do
-         expect(data).to be== {"x" => 42}
-       end
+        it do
+          expect(data).to be == { 'x' => 42 }
+        end
 
       end
 
-      describe "task relation " do
-        subject(:task_relation) { root_resource.relation('task')}
+      describe 'task relation ' do
+        subject(:task_relation) { root_resource.relation('task') }
 
-        it "is of class Relation" do
-          expect(task_relation.class).to be== JSON_ROA::Client::Relation
+        it 'is of class Relation' do
+          expect(task_relation.class).to be == JSON_ROA::Client::Relation
         end
-        
-        it "responds to get" do
+
+        it 'responds to get' do
           expect(task_relation.respond_to? :get).to be
         end
 

data/spec/collection_spec.rb

@@ -2,41 +2,41 @@ require_relative 'spec_helper.rb'
 
 describe JSON_ROA::Client::Collection do
 
-  let :root_relation do 
-    JSON_ROA::Client.connect("/")
+  let :root_relation do
+    JSON_ROA::Client.connect('/')
   end
 
-  describe "tasks resource via get" do
-    subject(:tasks_resource) {root_relation.get().relation('tasks').get() }
+  describe 'tasks resource via get' do
+    subject(:tasks_resource) { root_relation.get.relation('tasks').get }
 
-    it "is a resource" do
-      expect(tasks_resource.class).to be== JSON_ROA::Client::Resource
+    it 'is a resource' do
+      expect(tasks_resource.class).to be == JSON_ROA::Client::Resource
     end
 
-    it "responds to collection" do
+    it 'responds to collection' do
       expect(tasks_resource.respond_to? :collection).to be
     end
 
-    describe "tasks collection" do
-      subject(:tasks_collection) {tasks_resource.collection}
+    describe 'tasks collection' do
+      subject(:tasks_collection) { tasks_resource.collection }
 
-      it "is a collection" do
-        expect(tasks_collection.class).to be== JSON_ROA::Client::Collection
+      it 'is a collection' do
+        expect(tasks_collection.class).to be == JSON_ROA::Client::Collection
       end
 
-      it "has exactly one element" do 
-        expect(tasks_collection.count).to be== 1
+      it 'has exactly one element' do
+        expect(tasks_collection.count).to be == 1
       end
 
-      describe "the first task" do
-        subject(:first_task) {tasks_collection.first}
+      describe 'the first task' do
+        subject(:first_task) { tasks_collection.first }
 
-        it "is a relation" do
-          expect(first_task.class).to be== JSON_ROA::Client::Relation
+        it 'is a relation' do
+          expect(first_task.class).to be == JSON_ROA::Client::Relation
         end
 
-        it "leads to /task/t1" do
-          expect(first_task.data["href"]).to be== "/tasks/t1"
+        it 'leads to /task/t1' do
+          expect(first_task.data['href']).to be == '/tasks/t1'
         end
 
       end
@@ -46,4 +46,3 @@ describe JSON_ROA::Client::Collection do
   end
 
 end
-

data/spec/connect_spec.rb

@@ -3,19 +3,18 @@ require 'json_roa/client'
 require 'pry'
 
 describe JSON_ROA::Client do
-  context "when calling connect" do
+  context 'when calling connect' do
 
-    it "returns an instance of JSON_ROA::Client::Relation" do
-      expect(JSON_ROA::Client.connect("http://example.com").class).to \
-        be== JSON_ROA::Client::Relation
+    it 'returns an instance of JSON_ROA::Client::Relation' do
+      expect(JSON_ROA::Client.connect('http://example.com').class).to \
+        be == JSON_ROA::Client::Relation
     end
 
-    it "exposes Faraday::Connection via the block" do
-      JSON_ROA::Client.connect("http://example.com") do |conn|
-        expect(conn.class).to be== Faraday::Connection
+    it 'exposes Faraday::Connection via the block' do
+      JSON_ROA::Client.connect('http://example.com') do |conn|
+        expect(conn.class).to be == Faraday::Connection
       end
     end
 
   end
 end
-

data/spec/methods_spec.rb

@@ -1,30 +1,28 @@
 require_relative 'spec_helper.rb'
 
-describe "methods of the relation /tasks/t1" do
+describe 'methods of the relation /tasks/t1' do
 
-  let :root_relation do 
-    JSON_ROA::Client.connect("/")
+  let :root_relation do
+    JSON_ROA::Client.connect('/')
   end
 
   subject(:task1_self_relation) \
-    {root_relation.get().relation("task").get("id" => "t1").self_relation}
+    { root_relation.get.relation('task').get('id' => 't1').self_relation }
 
-  it "is a relation" do 
-    expect(task1_self_relation.class).to be== JSON_ROA::Client::Relation
+  it 'is a relation' do
+    expect(task1_self_relation.class).to be == JSON_ROA::Client::Relation
   end
 
-  describe "defined get" do
-    it "does not raise" do
-      expect{task1_self_relation.get()}.not_to raise_error
+  describe 'defined get' do
+    it 'does not raise' do
+      expect { task1_self_relation.get }.not_to raise_error
     end
   end
 
-  describe "not defined post" do
-    it "does raise" do
-      expect{task1_self_relation.post()}.to raise_error
+  describe 'not defined post' do
+    it 'does raise' do
+      expect { task1_self_relation.post }.to raise_error
     end
   end
 
 end
-
-

data/spec/spec_helper.rb

@@ -17,9 +17,9 @@ module JSON_ROA
     class << self
       alias_method :original_connect, :connect
 
-      def connect url, &block
-        res= original_connect url, &block
-        res.conn= test_api
+      def connect(url, &block)
+        res = original_connect url, &block
+        res.conn = test_api
         res
       end
 
@@ -27,39 +27,47 @@ module JSON_ROA
   end
 end
 
-
-def root_data 
-  YAML.load_file(File.expand_path("./data/root.yml",
+def root_data
+  YAML.load_file(File.expand_path('./data/root.yml',
                                   File.dirname(__FILE__)))
 end
 
-def tasks_page0_data 
-  YAML.load_file( File.expand_path("./data/tasks_page0.yml",
-                                   File.dirname(__FILE__)))
+def tasks_page0_data
+  YAML.load_file(File.expand_path('./data/tasks_page0.yml',
+                                  File.dirname(__FILE__)))
 end
 
 def tasks_page1_data
-  YAML.load_file( File.expand_path("./data/tasks_page1.yml",
-                                   File.dirname(__FILE__)))
+  YAML.load_file(File.expand_path('./data/tasks_page1.yml',
+                                  File.dirname(__FILE__)))
 end
 
-def task1_data 
-  YAML.load_file( File.expand_path("./data/task1.yml",
-                                   File.dirname(__FILE__)))
+def task1_data
+  YAML.load_file(File.expand_path('./data/task1.yml',
+                                  File.dirname(__FILE__)))
 end
 
-
 def test_api
   Faraday.new do |conn|
-    headers= {content_type: "application/json-roa+json"}
+    headers = { content_type: 'application/json-roa+json' }
     conn.use ::JSON_ROA::Middleware
-    conn.response :json, :content_type => /\bjson$/
+    conn.response :json, content_type: /\bjson$/
     conn.adapter :test do |stub|
-      stub.get('/') { |env| [ 200, headers, root_data.to_json]}
-      stub.get('/tasks/') { |env| [ 200, headers, tasks_page0_data.to_json]}
-      stub.get('/tasks/?page=0') { |env| [ 200, headers, tasks_page0_data.to_json]}
-      stub.get('/tasks/?page=1') { |env| [ 200, headers, tasks_page1_data.to_json]}
-      stub.get('/tasks/t1') { |env| [ 200, headers, task1_data.to_json]}
+      stub.get('/') do |env|
+        [200, headers, root_data.to_json]
+      end
+      stub.get('/tasks/') do |env|
+        [200, headers, tasks_page0_data.to_json]
+      end
+      stub.get('/tasks/?page=0') do |env|
+        [200, headers, tasks_page0_data.to_json]
+      end
+      stub.get('/tasks/?page=1') do |env|
+        [200, headers, tasks_page1_data.to_json]
+      end
+      stub.get('/tasks/t1') do |env|
+        [200, headers, task1_data.to_json]
+      end
     end
   end
 end

data/spec/template_expansion_spec.rb

@@ -1,55 +1,55 @@
 require_relative 'spec_helper.rb'
 
-describe "template expansion" do
+describe 'template expansion' do
 
-  let :root_relation do 
-    JSON_ROA::Client.connect("/")
+  let :root_relation do
+    JSON_ROA::Client.connect('/')
   end
 
-  context "task relation" do
+  context 'task relation' do
 
-    subject(:task_relation) {root_relation.get().relation("task")}
+    subject(:task_relation) { root_relation.get.relation('task') }
 
-    it "is a relation" do 
-      expect(task_relation.class).to be== JSON_ROA::Client::Relation
+    it 'is a relation' do
+      expect(task_relation.class).to be == JSON_ROA::Client::Relation
     end
 
-    it "is templated" do
-      expect(task_relation.data['href']).to be== "/tasks/{id}"
+    it 'is templated' do
+      expect(task_relation.data['href']).to be == '/tasks/{id}'
     end
 
-    describe "get with parameter to expand" do
-      subject(:task_resource){task_relation.get("id" => "t1")}
+    describe 'get with parameter to expand' do
+      subject(:task_resource) { task_relation.get('id' => 't1') }
 
-      it "is a resource of t1" do
-        expect(task_resource.class).to be== JSON_ROA::Client::Resource
-        expect(task_resource.self_relation.data["href"]).to be== "/tasks/t1"
+      it 'is a resource of t1' do
+        expect(task_resource.class).to be == JSON_ROA::Client::Resource
+        expect(task_resource.self_relation.data['href']).to be == '/tasks/t1'
       end
 
     end
 
   end
 
-  context "tasks relation" do
+  context 'tasks relation' do
 
-    subject(:tasks_relation) {root_relation.get().relation("tasks")}
+    subject(:tasks_relation) { root_relation.get.relation('tasks') }
 
-    describe "get with existing parameter to expand" do
-      it "does not raise an error" do
-        expect{ tasks_relation.get("x" => "foo")
-        }.not_to raise_error 
+    describe 'get with existing parameter to expand' do
+      it 'does not raise an error' do
+        expect do
+          tasks_relation.get('x' => 'foo')
+        end.not_to raise_error
       end
     end
 
-    describe "get with a non-existing parameter to expand" do
-      it "raises an error" do
-        expect{ tasks_relation.get("non_existing_query_parameter" => "foo")
-        }.to raise_error /query_parameters .* do not match template parameters/
+    describe 'get with a non-existing parameter to expand' do
+      it 'raises an error' do
+        expect do
+          tasks_relation.get('non_existing_query_parameter' => 'foo')
+        end.to raise_error /query_parameters .* do not match template parameters/
       end
     end
 
   end
 
 end
-
-

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: json_roa-client
 version: !ruby/object:Gem::Version
-  version: 1.0.0.pre.beta.2
+  version: 1.0.0
 platform: ruby
 authors:
 - Thomas Schank
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-16 00:00:00.000000000 Z
+date: 2015-01-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -80,6 +80,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3'
+- !ruby/object:Gem::Dependency
+  name: cider_ci-support
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.1.0.pre.beta.3
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.1.0.pre.beta.3
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: addressable
   requirement: !ruby/object:Gem::Requirement
@@ -131,6 +159,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -166,9 +195,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.2.2