json-crud-api 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fc410c49c2e6a7721caefeaf56701e7ffc074e51
-  data.tar.gz: b93070f2495112662568de6719abd6a62e67a860
+  metadata.gz: 783895fbee97ba45427d51d8f0220e3aee4a60b9
+  data.tar.gz: 311de6db45e1d3db7bd3ac7108577d5f8fba1577
 SHA512:
-  metadata.gz: c8e8b68269544a177a403737cb22fd933bc04f1ecaf2f722fa185e8e1795d5df474bafe6e0382d182c63bb5b9251f9473d2ca8ebe1c6a43bf45b5adc836163a4
-  data.tar.gz: 3f269d7e5000223850301da05ac2fa96584aa8d83e8f7157b660f5acbaa3bc8d05d5304808d1834fa6f2b8094873556dc80ecf994834a9ba03bdedeab556602b
+  metadata.gz: 77dab5ab969c0a1450baa4933bddd00222cf5967cc2fd46d9ef6337d9d1935f2baccbc5fcd20f3b9e29dd6d2a1f318ce7705586cd4b430f10ef4c25ad34913af
+  data.tar.gz: 7d4bb5bedaaab7decf7876b8cdd846457ea669bdf820af2c889dff24c8842e20e1c541042bd5c13f2972d3e9e7a5c81e8b34ca8cb9d85357ac8abb291a3d3da4

data/lib/json-crud-api/crud.rb

@@ -26,8 +26,9 @@ module JsonCrudApi
       service = settings.services[key]
       presenter = settings.presenters[key]
       return fail_unauthorized unless service.user_authorized_for? :create
-      entity = service.create(presenter.parse(@payload, :post))
-
+      post_data = presenter.parse @payload, :post
+      return fail_with_errors unless service.is_valid? post_data, :create, self
+      entity = service.create post_data 
       JSON.fast_generate presenter.render(entity, :post)
     end
 
@@ -35,8 +36,10 @@ module JsonCrudApi
       service = settings.services[key]
       presenter = settings.presenters[key]
       return fail_unauthorized unless service.user_authorized_for? :update
-      return fail_not_found unless service.update(params["id"], presenter.parse(@payload, :put))
-      entity = service.get(params["id"])
+      put_data = presenter.parse @payload, :put
+      return fail_with_errors unless service.is_valid? put_data, :update, self
+      return fail_not_found unless service.update params["id"], put_data
+      entity = service.get params["id"]
       JSON.fast_generate presenter.render(entity, :put)
     end
 
@@ -44,7 +47,7 @@ module JsonCrudApi
       service = settings.services[key]
       presenter = settings.presenters[key]
       return fail_unauthorized unless service.user_authorized_for? :delete
-      return fail_not_found unless service.delete(params["id"])
+      return fail_not_found unless service.delete params["id"]
       204
     end
   end

data/lib/json-crud-api/service.rb

@@ -62,6 +62,11 @@ module JsonCrudApi
       @user_scopes = user_scopes
     end
 
+    # Find if the params are valid for an operation (defaults to true)
+    def valid_for?(params, operation, api_instance)
+      true
+    end
+
     # Determine if the current user is authorized for the given operation
     def user_authorized_for?(operation)
       # Auth is disabled if scope map is nil

data/spec/unit/crud_extension_spec.rb

@@ -0,0 +1,76 @@
+require "spec_helper"
+
+describe JsonCrudApi::CrudExtension do
+  before(:each) do
+    class CrudTest
+      attr_accessor :test_settings, :test_params, :payload
+      include JsonCrudApi::CrudExtension
+
+      def settings
+        @test_settings
+      end
+
+      def params
+        @test_params
+      end
+    end
+
+    @test = CrudTest.new
+  end
+
+  describe '#crud_api' do
+    it 'should enable get_all if configured' do
+      expect(@test).to receive(:get).with('/test')
+
+      expect(@test).not_to receive(:get)
+      expect(@test).not_to receive(:post)
+      expect(@test).not_to receive(:put)
+      expect(@test).not_to receive(:delete)
+
+      @test.crud_api('/test',:one, [:disable_write,:disable_get])
+    end
+
+    it 'should enable get if configured' do
+      expect(@test).to receive(:get).with('/test/:id')
+
+      expect(@test).not_to receive(:get).with('/test')
+      expect(@test).not_to receive(:post)
+      expect(@test).not_to receive(:put)
+      expect(@test).not_to receive(:delete)
+
+      @test.crud_api('/test',:one, [:disable_write,:disable_get_all])
+    end
+
+    it 'should enable post if configured' do
+      expect(@test).to receive(:post).with('/test')
+
+      expect(@test).not_to receive(:get)
+      expect(@test).not_to receive(:post)
+      expect(@test).not_to receive(:put)
+      expect(@test).not_to receive(:delete)
+
+      @test.crud_api('/test',:one, [:disable_put,:disable_delete,:disable_read])
+    end
+
+    it 'should enable put if configured' do
+      expect(@test).to receive(:put).with('/test/:id')
+
+      expect(@test).not_to receive(:get)
+      expect(@test).not_to receive(:post)
+      expect(@test).not_to receive(:delete)
+
+      @test.crud_api('/test',:one, [:disable_post,:disable_delete,:disable_read])
+    end
+
+    it 'should enable delete if configured' do
+      expect(@test).to receive(:delete).with('/test/:id')
+
+      expect(@test).not_to receive(:get)
+      expect(@test).not_to receive(:post)
+      expect(@test).not_to receive(:put)
+
+      @test.crud_api('/test',:one, [:disable_post,:disable_put,:disable_read])
+    end
+
+  end
+end

data/spec/unit/crud_spec.rb

@@ -143,6 +143,7 @@ describe JsonCrudApi::AuthClient do
       expect(@test.test_settings.presenters).to receive(:[]).with('thekey').and_return(@presenter)
 
       expect(@service).to receive(:user_authorized_for?).with(:create).and_return(true)
+      expect(@service).to receive(:is_valid?).with({ :test_output => 12398}, :create, @test).and_return(true)
       expect(@service).to receive(:create).with({ :test_output => 12398}).and_return({ :test_output => 77234})
 
       expect(@presenter).to receive(:parse).with(@test.payload, :post).and_return({ :test_output => 12398})
@@ -151,6 +152,23 @@ describe JsonCrudApi::AuthClient do
       expect(@test.send(:crud_post,'thekey')).to eq '{"test_output":12313}'
     end
 
+    it 'should fail with 422 if service is_valid? fails' do
+      expect(@test.test_settings.services).to receive(:[]).with('thekey').and_return(@service)
+      expect(@test.test_settings.presenters).to receive(:[]).with('thekey').and_return(@presenter)
+
+      expect(@service).to receive(:user_authorized_for?).with(:create).and_return(true)
+      expect(@service).to receive(:is_valid?).with({ :test_output => 12398}, :create, @test).and_return(false)
+      
+      expect(@presenter).to receive(:parse).with(@test.payload, :post).and_return({ :test_output => 12398})
+
+      expect(@test).to receive(:fail_with_errors)
+
+      expect(@service).not_to receive(:create)
+      expect(@presenter).not_to receive(:render)
+
+      @test.send(:crud_post,'thekey')
+    end
+
     it 'should fail_unauthorized if not authorized for create' do
       expect(@test.test_settings.services).to receive(:[]).with('thekey').and_return(@service)
       expect(@test.test_settings.presenters).to receive(:[]).with('thekey').and_return(@presenter)
@@ -184,20 +202,36 @@ describe JsonCrudApi::AuthClient do
       expect(@test.test_settings.presenters).to receive(:[]).with('thekey').and_return(@presenter)
 
       expect(@service).to receive(:user_authorized_for?).with(:update).and_return(true)
+      expect(@presenter).to receive(:parse).with(@test.payload, :put).and_return({ :test_output => 12398})
+      expect(@service).to receive(:is_valid?).with({ :test_output => 12398},:update,@test).and_return(true)
       expect(@service).to receive(:update).with(7345, { :test_output => 12398}).and_return(true)
       expect(@service).to receive(:get).with(7345).and_return({ :test_output => 77234})
 
-      expect(@presenter).to receive(:parse).with(@test.payload, :put).and_return({ :test_output => 12398})
       expect(@presenter).to receive(:render).with({ :test_output => 77234}, :put).and_return({ :test_output => 12313})
 
       expect(@test.send(:crud_put,'thekey')).to eq '{"test_output":12313}'
     end
 
+    it 'should fail_with_errors if service is_valid? fails' do
+      expect(@test.test_settings.services).to receive(:[]).with('thekey').and_return(@service)
+      expect(@test.test_settings.presenters).to receive(:[]).with('thekey').and_return(@presenter)
+
+      expect(@service).to receive(:user_authorized_for?).with(:update).and_return(true)
+      expect(@presenter).to receive(:parse).with(@test.payload, :put).and_return({ :test_output => 12398})
+      expect(@service).to receive(:is_valid?).with({ :test_output => 12398},:update,@test).and_return(false)
+      expect(@presenter).not_to receive(:render)
+
+      expect(@test).to receive(:fail_with_errors)
+
+      expect(@test.send(:crud_put,'thekey'))
+    end
+
     it 'should fail_not_found if service update returned false' do
       expect(@test.test_settings.services).to receive(:[]).with('thekey').and_return(@service)
       expect(@test.test_settings.presenters).to receive(:[]).with('thekey').and_return(@presenter)
 
       expect(@service).to receive(:user_authorized_for?).with(:update).and_return(true)
+      expect(@service).to receive(:is_valid?).with({ :test_output => 12398},:update,@test).and_return(true)
       expect(@service).to receive(:update).with(7345, { :test_output => 12398}).and_return(false)
 
       expect(@test).to receive(:fail_not_found)

data/spec/unit/service_spec.rb

@@ -160,6 +160,12 @@ describe JsonCrudApi::Service do
     end
   end
 
+  describe '#valid_for?' do
+    it 'should return true' do
+      expect(@service.valid_for?(nil,nil,nil)).to be true
+    end
+  end
+
   describe '#user_authorized_for?' do
     it 'should return true if scope_map is nil' do
       @service.scope_map = nil

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: json-crud-api
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - Tom Cully
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-30 00:00:00.000000000 Z
+date: 2014-06-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -159,6 +159,7 @@ files:
 - spec/spec_helper.rb
 - spec/unit/api_spec.rb
 - spec/unit/auth_client_spec.rb
+- spec/unit/crud_extension_spec.rb
 - spec/unit/crud_spec.rb
 - spec/unit/json_errors_spec.rb
 - spec/unit/json_payload_spec.rb
@@ -193,6 +194,7 @@ test_files:
 - spec/spec_helper.rb
 - spec/unit/api_spec.rb
 - spec/unit/auth_client_spec.rb
+- spec/unit/crud_extension_spec.rb
 - spec/unit/crud_spec.rb
 - spec/unit/json_errors_spec.rb
 - spec/unit/json_payload_spec.rb