json-crud-api 0.0.10 → 0.0.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6729e49ff86fc11ee1d2983ad50f51882271dc17
-  data.tar.gz: 635e5569006dfa942d6f1b1e090f1326e085f19c
+  metadata.gz: 0423b4c02c64dcc84ecb43145267e8ad6b157716
+  data.tar.gz: 18b29475bb8fe29e75c6d9ac97e78a46643087b2
 SHA512:
-  metadata.gz: b64f144c33f2ef911b0e84752d1dfb2e09edd28a890cf49052c5dd54bd060c57b299863ab3f959cf119d65d2e27e11485cb40ed13afc3d07638cd0e28c922e52
-  data.tar.gz: 5a489916c393614074d6941038167691a49335566fbae2aba9c884f443219c6fe88e1fc2279d8fdc510c3a369662d9594bf12b43a9a1be92d2adf0375fc92b9f
+  metadata.gz: 73526f31ac42f5986f80754daad727b0d9fc5c1c8bcc43f36f22445282613388cef0e45f69953486919d55b4b6208f9d629251dc20f276681dd2c19c222f8c27
+  data.tar.gz: 2dc288144b95ccc849b14a51818ed8eccdf1dc298e51b37c70eea2f28da9375f4c581da9478fc01f54b3d0640303810e4f779c528cadd0c057139a40ada91349

data/lib/json-crud-api/api.rb

@@ -33,7 +33,11 @@ module JsonCrudApi
     end
 
     not_found do
-      fail_not_found
+      add_error 'NOT_FOUND','The resource cannot be found.'
+      halt status, JSON.fast_generate({
+        :success => false,
+        :errors => @errors
+      })
     end
 
     error do

data/lib/json-crud-api/crud.rb

@@ -5,7 +5,7 @@ module JsonCrudApi
     def crud_get_all(key)
       service = settings.services[key]
       presenter = settings.presenters[key]
-      return fail_unauthorized unless service.user_authorized_for? :get_all
+      return fail_forbidden unless service.user_authorized_for? :get_all
       entities = service.get_all
       return fail_not_found if entities.nil?
 
@@ -15,7 +15,7 @@ module JsonCrudApi
     def crud_get(key)
       service = settings.services[key]
       presenter = settings.presenters[key]
-      return fail_unauthorized unless service.user_authorized_for? :get
+      return fail_forbidden unless service.user_authorized_for? :get
       entity = service.get(params["id"])
       return fail_not_found if entity.nil?
 
@@ -25,7 +25,7 @@ module JsonCrudApi
     def crud_post(key)
       service = settings.services[key]
       presenter = settings.presenters[key]
-      return fail_unauthorized unless service.user_authorized_for? :create
+      return fail_forbidden unless service.user_authorized_for? :create
       post_data = presenter.parse @payload, :post
       return fail_with_errors unless service.valid_for? post_data, :create, self
       entity = service.create post_data 
@@ -35,7 +35,7 @@ module JsonCrudApi
     def crud_put(key)
       service = settings.services[key]
       presenter = settings.presenters[key]
-      return fail_unauthorized unless service.user_authorized_for? :update
+      return fail_forbidden unless service.user_authorized_for? :update
       put_data = presenter.parse @payload, :put
       return fail_with_errors unless service.valid_for? put_data, :update, self
       return fail_not_found unless service.update params["id"], put_data
@@ -46,7 +46,7 @@ module JsonCrudApi
     def crud_delete(key)
       service = settings.services[key]
       presenter = settings.presenters[key]
-      return fail_unauthorized unless service.user_authorized_for? :delete
+      return fail_forbidden unless service.user_authorized_for? :delete
       return fail_not_found unless service.delete params["id"]
       204
     end

data/lib/json-crud-api/json_errors.rb

@@ -31,7 +31,7 @@ module JsonCrudApi
     end
 
     def fail_not_found
-      fail_with_error 404, 'NOT_FOUND','The resource cannot be found.'
+      fail_with_errors 404
     end
 
     def fail_unauthorized

data/spec/unit/crud_spec.rb

@@ -42,13 +42,13 @@ describe JsonCrudApi::AuthClient do
       expect(@test.send(:crud_get_all,'thekey')).to eq '{"test_output":1}'
     end
 
-    it 'should fail_unauthorized if not authorized for get_all' do
+    it 'should fail_forbidden if not authorized for get_all' do
       expect(@test.test_settings.services).to receive(:[]).with('thekey').and_return(@service)
       expect(@test.test_settings.presenters).to receive(:[]).with('thekey').and_return(@presenter)
 
       expect(@service).to receive(:user_authorized_for?).with(:get_all).and_return(false)
 
-      expect(@test).to receive(:fail_unauthorized)
+      expect(@test).to receive(:fail_forbidden)
 
       expect(@service).not_to receive(:get_all)
       expect(@presenter).not_to receive(:render)
@@ -96,13 +96,13 @@ describe JsonCrudApi::AuthClient do
       expect(@test.send(:crud_get,'thekey')).to eq '{"test_output":56}'
     end
 
-    it 'should fail_unauthorized if not authorized for get' do
+    it 'should fail_forbidden if not authorized for get' do
       expect(@test.test_settings.services).to receive(:[]).with('thekey').and_return(@service)
       expect(@test.test_settings.presenters).to receive(:[]).with('thekey').and_return(@presenter)
 
       expect(@service).to receive(:user_authorized_for?).with(:get).and_return(false)
 
-      expect(@test).to receive(:fail_unauthorized)
+      expect(@test).to receive(:fail_forbidden)
 
       expect(@service).not_to receive(:get)
       expect(@presenter).not_to receive(:render)
@@ -169,13 +169,13 @@ describe JsonCrudApi::AuthClient do
       @test.send(:crud_post,'thekey')
     end
 
-    it 'should fail_unauthorized if not authorized for create' do
+    it 'should fail_forbidden if not authorized for create' do
       expect(@test.test_settings.services).to receive(:[]).with('thekey').and_return(@service)
       expect(@test.test_settings.presenters).to receive(:[]).with('thekey').and_return(@presenter)
 
       expect(@service).to receive(:user_authorized_for?).with(:create).and_return(false)
 
-      expect(@test).to receive(:fail_unauthorized)
+      expect(@test).to receive(:fail_forbidden)
 
       expect(@service).not_to receive(:create)
       expect(@presenter).not_to receive(:render)
@@ -242,13 +242,13 @@ describe JsonCrudApi::AuthClient do
       @test.send(:crud_put,'thekey')
     end
 
-    it 'should fail_unauthorized if not authorized for update' do
+    it 'should fail_forbidden if not authorized for update' do
       expect(@test.test_settings.services).to receive(:[]).with('thekey').and_return(@service)
       expect(@test.test_settings.presenters).to receive(:[]).with('thekey').and_return(@presenter)
 
       expect(@service).to receive(:user_authorized_for?).with(:update).and_return(false)
 
-      expect(@test).to receive(:fail_unauthorized)
+      expect(@test).to receive(:fail_forbidden)
 
       expect(@service).not_to receive(:update)
       expect(@service).not_to receive(:get)
@@ -280,13 +280,13 @@ describe JsonCrudApi::AuthClient do
       expect(@test.send(:crud_delete,'thekey')).to eq 204
     end
 
-    it 'should fail_unauthorized if not authorized for delete' do
+    it 'should fail_forbidden if not authorized for delete' do
       expect(@test.test_settings.services).to receive(:[]).with('thekey').and_return(@service)
       expect(@test.test_settings.presenters).to receive(:[]).with('thekey').and_return(@presenter)
 
       expect(@service).to receive(:user_authorized_for?).with(:delete).and_return(false)
 
-      expect(@test).to receive(:fail_unauthorized)
+      expect(@test).to receive(:fail_forbidden)
 
       expect(@service).not_to receive(:delete)
 

data/spec/unit/json_errors_spec.rb

@@ -99,7 +99,7 @@ describe JsonCrudApi::JsonErrors do
 
   describe '#fail_not_found' do
     it 'should call fail_not_found with 404 and message' do
-      expect(@test).to receive(:fail_with_error).with(404, 'NOT_FOUND','The resource cannot be found.')
+      expect(@test).to receive(:fail_with_errors).with(404)
       @test.fail_not_found
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: json-crud-api
 version: !ruby/object:Gem::Version
-  version: 0.0.10
+  version: 0.0.11
 platform: ruby
 authors:
 - Tom Cully