jsl-myzofeedtosis 0.0.1.4 → 0.0.1.5

data/README.rdoc

@@ -131,6 +131,11 @@ Myzofeedtosis doesn't do anything about feed sanitizing, as other libraries have
 been built for this purpose. FeedNormalizer has methods for escaping entries,
 but to strip HTML I suggest that you look at the Ruby gem "sanitize".
 
+== Credits
+
+Thanks to Sander Hartlage (GitHub: Sander6) for useful feedback early in the 
+development of Myzofeedtosis.
+
 == Feedback
 
 Please let me know if you have any problems with or questions about

data/lib/myzofeedtosis/client.rb

@@ -24,14 +24,10 @@ module Myzofeedtosis
                     @options[:backend].except(:moneta_klass) )
     end
     
-    # Retrieves the latest entries from this feed.  Returns a 
-    # Feednormalizer::Feed object with method +new_entries+ if the response was 
-    # successful, otherwise returns the Curl::Easy object that we used to 
-    # retrieve this resource.  Note that we also return this object if the 
-    # request resulted in a 304 (Not Modified) response code since we don't have 
-    # any new results.  Depending on your business logic, you may want to do 
-    # something in this case, such as putting this resource in a lower-priority 
-    # queue if it is not frequently updated.
+    # Retrieves the latest entries from this feed.  Returns a Myzofeedtosis::Result
+    # object which delegates methods to the Curl::Easy object making the request
+    # and the FeedNormalizer::Feed object that may have been created from the 
+    # HTTP response body.
     def fetch
       curl = build_curl_easy
       curl.perform

data/lib/myzofeedtosis/result.rb

@@ -5,7 +5,7 @@ module Myzofeedtosis
   # method calls to the correct object.  If FeedNormalizer wasn't able to process
   # the response, calls which would be delegated to this object return nil.  In
   # these cases, depending on your business logic you may want to inspect the 
-  # state of the Curl::Easy object.
+  # state of the Curl::Easy object by using methods forwarded to it.
   class Result
     
     # Methods which should be delegated to the FeedNormalizer::Feed object.
@@ -14,21 +14,26 @@ module Myzofeedtosis
       :new_entries, :channel, :ttl, :skip_hours, :skip_days 
     ] unless defined?(FEED_METHODS)
     
+    # Precompiled regexp for detecting removing setter methods from collection 
+    # of methods to be delegated to the Curl::Easy object.
+    SETTER_METHOD_RE = /=$/o unless defined?(SETTER_METHOD_RE)
+    
     def initialize(curl, feed)
       @curl = curl
       @feed = feed
       
       raise ArgumentError, "Curl object must not be nil" if curl.nil?
-      
-      # See what the Curl::Easy object responds to, and send any appropriate
-      # messages its way.
-      @curl.public_methods(false).each do |meth|
-        (class << self; self; end).class_eval do
-          define_method meth do |*args|
-            @curl.send(meth, *args)
-          end
-        end
-      end
+    end
+    
+    # See what the Curl::Easy object responds to, and send any appropriate
+    # messages its way.  We don't worry about setter methods, since those
+    # aren't really useful to delegate.
+    Curl::Easy.instance_methods(false).reject do |m| 
+      m =~ SETTER_METHOD_RE
+    end.each do |meth|
+      define_method meth do |*args|
+        @curl.send(meth, *args)
+      end    
     end
     
     # Send methods through to the feed object unless it is nil.  If feed

data/myzofeedtosis.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name = %q{myzofeedtosis}
-  s.version = "0.0.1.4"
+  s.version = "0.0.1.5"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Justin Leitgeb"]

data/spec/myzofeedtosis/result_spec.rb

@@ -23,6 +23,10 @@ describe Myzofeedtosis::Result do
     @r.body_str
   end
   
+  it "should not respond to setter methods common in the Curl::Easy class" do
+    @r.should_not respond_to(:encoding=)
+  end
+  
   it "should return nil for author if the Feed is nil" do
     r = Myzofeedtosis::Result.new(@c, nil)
     r.author

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: jsl-myzofeedtosis
 version: !ruby/object:Gem::Version 
-  version: 0.0.1.4
+  version: 0.0.1.5
 platform: ruby
 authors: 
 - Justin Leitgeb