jsl-feedzirra 0.0.12.10 → 0.0.12.12

data/lib/feedzirra/parser/feed_utilities.rb

@@ -3,6 +3,7 @@ module Feedzirra
     UPDATABLE_ATTRIBUTES = %w(title feed_url url last_modified)
     
     attr_writer :updated, :last_modified, :entries
+
     attr_accessor :etag
 
     def initialize
@@ -26,15 +27,15 @@ module Feedzirra
     def updated?
       @updated
     end
-    
+
     def new_entries
       @entries.select{ |e| e.new_entry? }
     end
-    
+
     def has_new_entries?
       new_entries.size > 0
     end
-    
+
     def update_from_feed(feed)
       # Mark all existing entries as old, then add new entries, which are
       # marked as new by default.
@@ -43,41 +44,41 @@ module Feedzirra
       find_new_entries_for(feed).each do |e|
         self.entries << e
       end
-      
-      updated! if UPDATABLE_ATTRIBUTES.any? { |name| update_attribute(feed, name) }
+
+      updated! if UPDATABLE_ATTRIBUTES.map { |name| update_attribute(feed, name) }.any?
     end
-    
+
     def update_attribute(feed, name)
       old_value, new_value = send(name), feed.send(name)
-      
+
       if old_value != new_value
         send("#{name}=", new_value)
       end
     end
-    
+
     def sanitize_entries!
       entries.each {|entry| entry.sanitize!}
     end
-    
+
     private
-    
+
     def updated!
       @updated = true
     end
-    
+
     def find_new_entries_for(feed)
       # This implementation is a hack to get around the fact that not all feeds 
       # have a published date - we exploit the fact that feeds are always 
       # ordered with newest element first to work backwards until we reach feed urls 
-      # that we've already seen.      
-      feed.entries.reverse.inject([]) do |res, entry| 
-        break res if entry.url == self.entries.first.url
-        res << entry
+      # that we've already seen.
+      unless self.entries.first.nil?
+        feed.entries.reverse.inject([]) do |res, entry| 
+          break res if entry.url == self.entries.first.url
+          res << entry
+        end
+      else
+        self.entries
       end
     end
-    
-    def existing_entry?(test_entry)
-      entries.any? { |entry| entry.url == test_entry.url }
-    end
   end
-end
+end

data/lib/feedzirra/parser/itunes_rss_item.rb

@@ -5,7 +5,7 @@ module Feedzirra
     # Source: http://www.apple.com/itunes/whatson/podcasts/specs.html
     class ITunesRSSItem
       include SAXMachine
-      include FeedUtilities
+      include FeedEntryUtilities
       element :author
       element :guid
       element :title

data/spec/feedzirra/{feed_entry_utilities_spec.rb → parser/feed_entry_utilities_spec.rb}

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), %w[.. spec_helper])
+require File.join(File.dirname(__FILE__), %w[.. .. spec_helper])
 
 describe Feedzirra::FeedUtilities do
   before do

data/spec/feedzirra/{feed_utilities_spec.rb → parser/feed_utilities_spec.rb}

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), %w[.. spec_helper])
+require File.join(File.dirname(__FILE__), %w[.. .. spec_helper])
 
 describe Feedzirra::FeedUtilities do
   before do

data/spec/feedzirra/parser/itunes_rss_item_spec.rb

@@ -34,7 +34,7 @@ describe Feedzirra::Parser::ITunesRSSItem do
   end  
 
   it "should parse the published date" do
-    @item.published.should == "Wed, 15 Jun 2005 19:00:00 GMT"
+    @item.published.should == Time.parse('Wed Jun 15 19:00:00 UTC 2005')
   end  
 
   it "should parse the duration" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: jsl-feedzirra
 version: !ruby/object:Gem::Version 
-  version: 0.0.12.10
+  version: 0.0.12.12
 platform: ruby
 authors: 
 - Paul Dix
@@ -13,7 +13,7 @@ date: 2009-05-19 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
-  name: hashback
+  name: jsl-hashback
   type: :runtime
   version_requirement: 
   version_requirements: !ruby/object:Gem::Requirement 
@@ -137,14 +137,14 @@ files:
 - spec/feedzirra/parser/itunes_rss_owner_spec.rb
 - spec/feedzirra/parser/rss_spec.rb
 - spec/feedzirra/parser/rss_entry_spec.rb
-- spec/feedzirra/feed_utilities_spec.rb
-- spec/feedzirra/feed_entry_utilities_spec.rb
+- spec/feedzirra/parser/feed_utilities_spec.rb
+- spec/feedzirra/parser/feed_entry_utilities_spec.rb
 has_rdoc: true
 homepage: http://github.com/jsl/feedzirra
 post_install_message: 
 rdoc_options: 
 - --title
-- HashBack
+- Feedzirra
 - --main
 - README.rdoc
 - --line-numbers