jscruggs-metric_fu 1.1.0 → 1.1.1

data/HISTORY

@@ -1,7 +1,11 @@
+=== MetricFu 1.1.1 / 2009-6-29
+
+* Fix for empty flog files
+
 === MetricFu 1.1.0 / 2009-6-22
 
-* Flog, flay, reek, roodi, and rcov reports now graph progress over time.  Well done Nick Quarantos and Edouard Brière.
-* 'Awesome' template has been brought in so that reports look 90% less 'ghetto.'  Also done by Nick Quarantos and Edouard Brière.
+* Flog, flay, reek, roodi, and rcov reports now graph progress over time.  Well done Nick Quaranto and Edouard Brière.
+* 'Awesome' template has been brought in so that reports look 90% less 'ghetto.'  Also done by Nick Quaranto and Edouard Brière.
 * Added links to TextMate (which keep getting removed.  Probably by me. Sorry.) -- David Chelimsky
 * Fixed a bug for scratch files which have a size of 0 -- Kevin Hall
 * Changed gem dependencies from install-time in gemspec to runtime when each of the generators is loaded.  This allows use of github gems (i.e. relevance-rcov instead of rcov) and also allows you to install only the gems for the metrics you plan on using.  -- Alex Rothenberg

data/lib/generators/flog.rb

@@ -64,10 +64,17 @@ module MetricFu
       total_flog_score = @pages.inject(0) {|total, page| total += page.score}
       sorted_pages = @pages.sort_by {|page| page.score }.reverse 
       {:flog => { :total => total_flog_score,
-                  :average => round_to_tenths(total_flog_score/number_of_methods),
+                  :average => average_score(total_flog_score, number_of_methods),
                   :pages => sorted_pages.map {|page| page.to_h}}}
     end
     
+    private
+    
+    def average_score(total_flog_score, number_of_methods)
+      return 0 if total_flog_score == 0
+      round_to_tenths(total_flog_score/number_of_methods)
+    end
+    
     def flog_results
       Dir.glob("#{metric_directory}/**/*.txt")
     end

data/spec/generators/flog_spec.rb

@@ -178,7 +178,7 @@ describe Flog do
     end
   end
   
-  describe "to_h function" do
+  describe "to_h function with results" do
     before :each do
       MetricFu::Configuration.run {}
       File.stub!(:directory?).and_return(true)
@@ -205,4 +205,15 @@ describe Flog do
       @flog_hash[:flog][:pages].first[:path].should == "/app/controllers/user_controller.rb"
     end
   end
+  
+  describe "to_h function with zero total" do
+    it "should not blow up" do
+      MetricFu::Configuration.run {}
+      File.stub!(:directory?).and_return(true)
+      flog = MetricFu::Flog.new('base_dir')
+      flog.should_receive(:open).and_return("") # some sort of empty or unparsable file
+      Dir.should_receive(:glob).and_return(["empty_file.txt"])
+      flog.analyze
+    end
+  end
 end

data/spec/graphs/flog_grapher_spec.rb

@@ -0,0 +1,15 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+describe MetricFu::FlogGrapher do
+  it "should not fall over when given empty results" do
+    MetricFu::Configuration.run {}
+    
+    gruff_line = Gruff::Line.new(MetricFu.graph_size)
+    gruff_line.stub!(:write)
+    Gruff::Line.stub!(:new).and_return(gruff_line)
+    
+    grapher = FlogGrapher.new()
+    metrics_hash = {:flog => {:average => 0, :pages => [], :total => 0}}
+    grapher.get_metrics(metrics_hash ,"20090629")
+    grapher.graph!
+  end
+end

data/spec/resources/saikuro/app/controllers/sessions_controller.rb_cyclo.html

@@ -0,0 +1,10 @@
+-- START  --
+Type:Global Name: Complexity:0 Lines:1
+-- END  --
+-- START SessionsController --
+Type:Class Name:SessionsController Complexity:6 Lines:40
+Type:Def Name:new Complexity:2 Lines:2
+Type:Def Name:create Complexity:2 Lines:19
+Type:Def Name:destroy Complexity:1 Lines:4
+Type:Def Name:note_failed_signin Complexity:1 Lines:3
+-- END SessionsController --

data/spec/resources/saikuro/app/controllers/users_controller.rb_cyclo.html

@@ -0,0 +1,16 @@
+-- START UsersController --
+Type:Class Name:UsersController Complexity:25 Lines:111
+Type:Def Name:signup Complexity:1 Lines:3
+Type:Def Name:new Complexity:1 Lines:2
+Type:Def Name:edit Complexity:1 Lines:3
+Type:Def Name:update Complexity:2 Lines:8
+Type:Def Name:index Complexity:1 Lines:2
+Type:Def Name:create Complexity:4 Lines:15
+Type:Def Name:thank_you Complexity:2 Lines:10
+Type:Def Name:destroy Complexity:1 Lines:3
+Type:Def Name:add_primary_site Complexity:1 Lines:4
+Type:Def Name:users_have_changed Complexity:3 Lines:8
+Type:Def Name:after_create_page Complexity:2 Lines:6
+Type:Def Name:sanitize_params Complexity:3 Lines:3
+Type:Def Name:authorize_user Complexity:3 Lines:5
+-- END UsersController --

data/spec/resources/saikuro/index_cyclo.html

@@ -0,0 +1,155 @@
+<html><head><title>Index for cyclomatic complexity</title></head>
+<style>
+body {
+	margin: 20px;
+	padding: 0;
+	font-size: 12px;
+	font-family: bitstream vera sans, verdana, arial, sans serif;
+	background-color: #efefef;
+}
+
+table {	
+	border-collapse: collapse;
+	/*border-spacing: 0;*/
+	border: 1px solid #666;
+	background-color: #fff;
+	margin-bottom: 20px;
+}
+
+table, th, th+th, td, td+td  {
+	border: 1px solid #ccc;
+}
+
+table th {
+	font-size: 12px;
+	color: #fc0;
+	padding: 4px 0;
+	background-color: #336;
+}
+
+th, td {
+	padding: 4px 10px;
+}
+
+td {	
+	font-size: 13px;
+}
+
+.class_name {
+	font-size: 17px;
+	margin: 20px 0 0;
+}
+
+.class_complexity {
+margin: 0 auto;
+}
+
+.class_complexity>.class_complexity {
+	margin: 0;
+}
+
+.class_total_complexity, .class_total_lines, .start_token_count, .file_count {
+	font-size: 13px;
+	font-weight: bold;
+}
+
+.class_total_complexity, .class_total_lines {
+	color: #c00;
+}
+
+.start_token_count, .file_count {
+	color: #333;
+}
+
+.warning {
+	background-color: yellow;
+}
+
+.error {
+	background-color: #f00;
+}
+</style>
+
+<body>
+<h1>Index for cyclomatic complexity</h1>
+<h2 class="class_name">Errors and Warnings</h2>
+<table width="100%" border="1">
+<tr><th>Class</th><th>Method</th><th>Complexity</th></tr>
+
+<tr><td><a href="./app/controllers/activity_reports_controller.rb_cyclo.html">ActivityReportsController</a></td><td>authorize_user</td>
+<td class="warning">6</td></tr>
+<tr><td><a href="./app/controllers/primary_sites_controller.rb_cyclo.html">PrimarySitesController</a></td><td>create</td>
+<td class="warning">5</td></tr>
+<tr><td><a href="./app/controllers/primary_sites_controller.rb_cyclo.html">PrimarySitesController</a></td><td>save_link_targets</td>
+<td class="warning">5</td></tr>
+<tr><td><a href="./app/models/link_target.rb_cyclo.html">LinkTarget</a></td><td>update_backlink_status</td>
+<td class="warning">5</td></tr>
+</table>
+<hr/>
+<h2 class="class_name">Analyzed Files</h2>
+<ul>
+<li>
+<p class="file_name"><a href="./app/models/user.rb_cyclo.html">app/models/user.rb</a>
+</li>
+<li>
+<p class="file_name"><a href="./app/models/subscriber.rb_cyclo.html">app/models/subscriber.rb</a>
+</li>
+<li>
+<p class="file_name"><a href="./app/models/primary_site.rb_cyclo.html">app/models/primary_site.rb</a>
+</li>
+<li>
+<p class="file_name"><a href="./app/models/link_target.rb_cyclo.html">app/models/link_target.rb</a>
+</li>
+<li>
+<p class="file_name"><a href="./app/models/comparison_site.rb_cyclo.html">app/models/comparison_site.rb</a>
+</li>
+<li>
+<p class="file_name"><a href="./app/models/backlink_crawl_status.rb_cyclo.html">app/models/backlink_crawl_status.rb</a>
+</li>
+<li>
+<p class="file_name"><a href="./app/models/backlink_crawl_notifier.rb_cyclo.html">app/models/backlink_crawl_notifier.rb</a>
+</li>
+<li>
+<p class="file_name"><a href="./app/models/activity_report_measure.rb_cyclo.html">app/models/activity_report_measure.rb</a>
+</li>
+<li>
+<p class="file_name"><a href="./app/models/activity_report.rb_cyclo.html">app/models/activity_report.rb</a>
+</li>
+<li>
+<p class="file_name"><a href="./app/helpers/users_helper.rb_cyclo.html">app/helpers/users_helper.rb</a>
+</li>
+<li>
+<p class="file_name"><a href="./app/helpers/sessions_helper.rb_cyclo.html">app/helpers/sessions_helper.rb</a>
+</li>
+<li>
+<p class="file_name"><a href="./app/helpers/primary_sites_helper.rb_cyclo.html">app/helpers/primary_sites_helper.rb</a>
+</li>
+<li>
+<p class="file_name"><a href="./app/helpers/link_targets_helper.rb_cyclo.html">app/helpers/link_targets_helper.rb</a>
+</li>
+<li>
+<p class="file_name"><a href="./app/helpers/application_helper.rb_cyclo.html">app/helpers/application_helper.rb</a>
+</li>
+<li>
+<p class="file_name"><a href="./app/controllers/users_controller.rb_cyclo.html">app/controllers/users_controller.rb</a>
+</li>
+<li>
+<p class="file_name"><a href="./app/controllers/sessions_controller.rb_cyclo.html">app/controllers/sessions_controller.rb</a>
+</li>
+<li>
+<p class="file_name"><a href="./app/controllers/primary_sites_controller.rb_cyclo.html">app/controllers/primary_sites_controller.rb</a>
+</li>
+<li>
+<p class="file_name"><a href="./app/controllers/link_targets_controller.rb_cyclo.html">app/controllers/link_targets_controller.rb</a>
+</li>
+<li>
+<p class="file_name"><a href="./app/controllers/bookmarklet_integration_controller.rb_cyclo.html">app/controllers/bookmarklet_integration_controller.rb</a>
+</li>
+<li>
+<p class="file_name"><a href="./app/controllers/application.rb_cyclo.html">app/controllers/application.rb</a>
+</li>
+<li>
+<p class="file_name"><a href="./app/controllers/activity_reports_controller.rb_cyclo.html">app/controllers/activity_reports_controller.rb</a>
+</li>
+</ul>
+</body></html>

data/spec/resources/saikuro_sfiles/thing.rb_cyclo.html

@@ -0,0 +1,10 @@
+-- START Mod --
+Type:Module Name:Mod Complexity:2 Lines:7
+Type:Def Name:self.included Complexity:2 Lines:5
+-- START --
+Type:Class Name: Complexity:0 Lines:1
+-- END --
+-- END Mod --
+-- START Thing --
+Type:Class Name:Thing Complexity:0 Lines:2
+-- END Thing --

data/spec/spec.opts

@@ -0,0 +1,8 @@
+--colour
+--format
+specdoc
+--reverse
+--timeout
+20
+--loadby
+mtime

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: jscruggs-metric_fu
 version: !ruby/object:Gem::Version 
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors: 
 - Jake Scruggs
@@ -170,4 +170,10 @@ test_files:
 - spec/generators/reek_spec.rb
 - spec/generators/saikuro_spec.rb
 - spec/generators/stats_spec.rb
+- spec/graphs/flog_grapher_spec.rb
+- spec/resources/saikuro/app/controllers/sessions_controller.rb_cyclo.html
+- spec/resources/saikuro/app/controllers/users_controller.rb_cyclo.html
+- spec/resources/saikuro/index_cyclo.html
+- spec/resources/saikuro_sfiles/thing.rb_cyclo.html
+- spec/spec.opts
 - spec/spec_helper.rb