js_rails_routes 0.9.0 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ff931b1b9f29b4a86444a8613d653a32961bc378e86d44fdc25cf319bcd9cc86
-  data.tar.gz: ce054504cf1e89cde6d76bca05f5fb03834740e8ff0a2e9acdea76326ef3e8ce
+  metadata.gz: eb3bb6c9a267324041904e5ba8e8418a61e8d64fac6273caaabb1f5c4c9699f4
+  data.tar.gz: d3e2cf66c91f3b3d063127b5d38969d2533fad8b27eb1c7586b1689403936534
 SHA512:
-  metadata.gz: 932d0666655cf343988cdd19730ed038b662d6efa86c36a1e97c63a9f98a7c1cbe51a4abdc5a14903814f6a578e597a123e782ebb85a5c3dfa9e0807f7fbca25
-  data.tar.gz: b6c2ad6c62c1c95b6db17386468801a1fc543c60fed064b253a36458c3b14cb3614b9928c495a1f26d53e02946735a452106388ad5f46ebd8af96b494b5578a6
+  metadata.gz: 1dbfa99a9a37cac5d3f0e6412f29828bff8b0464c52d0e88e4ca7b6c4161e2f785a67b7831bdaecb9eb6c12894e80c6f3a3eae31f5246dede0088e7b2a86537d
+  data.tar.gz: c07b6a657b44e15d84a792fbd5095cc947cd52501d2f862bb5e818ab20a61b12e91ee44be134169dae1826138dbbb1d68e6d820ea6e15adadf0e9999307089d5

data/CHANGELOG.md

@@ -6,6 +6,10 @@ This change log adheres to [keepachangelog.com](http://keepachangelog.com).
 
 ## [Unreleased]
 
+## [0.10.0] - 2018-10-29
+### Added
+- Enable to change route's name
+
 ## [0.9.0] - 2018-08-24
 ### Added
 - Improved TypeScript params typing support
@@ -70,7 +74,8 @@ This change log adheres to [keepachangelog.com](http://keepachangelog.com).
 ### Added
 - Implement "js:rails:routes" task
 
-[Unreleased]: https://github.com/yuku-t/js_rails_routes/compare/v0.9.0...HEAD
+[Unreleased]: https://github.com/yuku-t/js_rails_routes/compare/v0.10.0...HEAD
+[0.10.0]: https://github.com/yuku-t/js_rails_routes/compare/v0.9.0...v0.10.0
 [0.9.0]: https://github.com/yuku-t/js_rails_routes/compare/v0.8.1...v0.9.0
 [0.8.1]: https://github.com/yuku-t/js_rails_routes/compare/v0.8.0...v0.8.1
 [0.8.0]: https://github.com/yuku-t/js_rails_routes/compare/v0.7.1...v0.8.0

data/README.md

@@ -110,6 +110,21 @@ rake js:routes exclude_paths='^/rails'
 
 The command still ignores "/rails" but includes "/sidekiq".
 
+### Rename route
+
+You can rename route in `route_filter`:
+
+```rb
+# Rakefile
+JSRailsRoutes.configure do |c|
+  c.route_filter = -> (route) do
+    # Remove common prefix if route's name starts with it.
+    route.name = route.name[4..-1] if route.name.start_with?('foo_')
+    true
+  end
+end
+```
+
 ## Install
 
 Your Rails Gemfile:

data/js_rails_routes.gemspec

@@ -20,8 +20,8 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler', '~> 1.16'
   spec.add_development_dependency 'codeclimate-test-reporter', '~> 1.0'
   spec.add_development_dependency 'rake', '~> 12.3'
-  spec.add_development_dependency 'rspec', '~> 3.7'
-  spec.add_development_dependency 'rubocop', '~> 0.58.1'
-  spec.add_development_dependency 'rubocop-rspec', '~> 1.27'
+  spec.add_development_dependency 'rspec', '~> 3.8'
+  spec.add_development_dependency 'rubocop', '~> 0.60.0'
+  spec.add_development_dependency 'rubocop-rspec', '~> 1.30.0'
   spec.add_development_dependency 'simplecov', '~> 0.16.1'
 end

data/lib/js_rails_routes/route.rb

@@ -3,8 +3,8 @@
 module JSRailsRoutes
   # Encapsulate a single routing rule
   class Route
-    # @return [String]
-    attr_reader :name
+    # @return [String] route name. It becomes JavaScript function name.
+    attr_accessor :name
 
     # @return [String]
     attr_reader :path
@@ -25,6 +25,7 @@ module JSRailsRoutes
       return false if config.exclude_paths =~ path
       return false if config.include_names !~ name
       return false if config.exclude_names =~ name
+
       config.route_filter.call(self)
     end
 

data/lib/js_rails_routes/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module JSRailsRoutes
-  VERSION = '0.9.0'
+  VERSION = '0.10.0'
 end

data/lib/js_rails_routes.rb

@@ -8,7 +8,7 @@ require 'js_rails_routes/language/javascript'
 require 'js_rails_routes/language/typescript'
 
 module JSRailsRoutes
-  PARAM_REGEXP = %r{:(.*?)(/|$)}
+  PARAM_REGEXP = %r{:(.*?)(/|$)}.freeze
 
   module_function
 
@@ -35,6 +35,7 @@ module JSRailsRoutes
   # @yield
   def sandbox
     raise 'Already in a sandbox' if @sandbox
+
     @sandbox = true
     prev = @config
     @config = Configuration.new

data/spec/js_rails_routes/builder_spec.rb

@@ -31,7 +31,7 @@ RSpec.describe JSRailsRoutes::Builder do
     subject { builder.build }
 
     it 'returns an array of artifacts' do
-      is_expected.to contain_exactly(
+      expect(subject).to contain_exactly(
         an_object_having_attributes(engine_name: rails_route_set.name, body: body),
         an_object_having_attributes(engine_name: engine_route_set.name, body: body)
       )

data/spec/js_rails_routes/language/javascript_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe JSRailsRoutes::Language::JavaScript do
     subject { described_class::PROCESS_FUNC }
 
     it 'returns a javascript function' do
-      is_expected.to eq <<~JAVASCRIPT
+      expect(subject).to eq <<~JAVASCRIPT
         function process(route, params, keys) {
           var query = [];
           for (var param in params) if (params.hasOwnProperty(param)) {
@@ -37,7 +37,7 @@ RSpec.describe JSRailsRoutes::Language::JavaScript do
 
     context 'without camelize option' do
       it 'returns a javascript with snake_case functions' do
-        is_expected.to eq <<~JAVASCRIPT
+        expect(subject).to eq <<~JAVASCRIPT
           #{described_class::PROCESS_FUNC}
           export function articles_path(params) { return process('/articles', params, []); }
           export function new_article_path(params) { return process('/articles/new', params, []); }
@@ -55,7 +55,7 @@ RSpec.describe JSRailsRoutes::Language::JavaScript do
       end
 
       it 'returns a javascript with lowerCamelCase functions' do
-        is_expected.to eq <<~JAVASCRIPT
+        expect(subject).to eq <<~JAVASCRIPT
           #{described_class::PROCESS_FUNC}
           export function articlesPath(params) { return process('/articles', params, []); }
           export function newArticlePath(params) { return process('/articles/new', params, []); }
@@ -73,7 +73,7 @@ RSpec.describe JSRailsRoutes::Language::JavaScript do
       end
 
       it 'returns a javascript with UpperCamelCase functions' do
-        is_expected.to eq <<~JAVASCRIPT
+        expect(subject).to eq <<~JAVASCRIPT
           #{described_class::PROCESS_FUNC}
           export function ArticlesPath(params) { return process('/articles', params, []); }
           export function NewArticlePath(params) { return process('/articles/new', params, []); }
@@ -91,7 +91,7 @@ RSpec.describe JSRailsRoutes::Language::JavaScript do
       end
 
       it 'returns a javascript matching to the regexp' do
-        is_expected.to eq <<~JAVASCRIPT
+        expect(subject).to eq <<~JAVASCRIPT
           #{described_class::PROCESS_FUNC}
           export function new_article_path(params) { return process('/articles/new', params, []); }
         JAVASCRIPT
@@ -106,7 +106,7 @@ RSpec.describe JSRailsRoutes::Language::JavaScript do
       end
 
       it 'returns a javascript not matching to the regexp' do
-        is_expected.to eq <<~JAVASCRIPT
+        expect(subject).to eq <<~JAVASCRIPT
           #{described_class::PROCESS_FUNC}
           export function articles_path(params) { return process('/articles', params, []); }
           export function edit_article_path(params) { return process('/articles/' + params.id + '/edit', params, ['id']); }
@@ -123,7 +123,7 @@ RSpec.describe JSRailsRoutes::Language::JavaScript do
       end
 
       it 'returns a javascript matching to the regexp' do
-        is_expected.to eq <<~JAVASCRIPT
+        expect(subject).to eq <<~JAVASCRIPT
           #{described_class::PROCESS_FUNC}
           export function new_article_path(params) { return process('/articles/new', params, []); }
         JAVASCRIPT
@@ -138,7 +138,7 @@ RSpec.describe JSRailsRoutes::Language::JavaScript do
       end
 
       it 'returns a javascript not matching to the regexp' do
-        is_expected.to eq <<~JAVASCRIPT
+        expect(subject).to eq <<~JAVASCRIPT
           #{described_class::PROCESS_FUNC}
           export function articles_path(params) { return process('/articles', params, []); }
           export function edit_article_path(params) { return process('/articles/' + params.id + '/edit', params, ['id']); }

data/spec/js_rails_routes/language/typescript_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe JSRailsRoutes::Language::TypeScript do
     subject { described_class::PROCESS_FUNC }
 
     it 'returns a typescript function' do
-      is_expected.to eq <<~TYPESCRIPT
+      expect(subject).to eq <<~TYPESCRIPT
         type Value = string | number
         type Params<Keys extends string> = { [key in Keys]: Value } & Record<string, Value>
         function process(route: string, params: Record<string, Value> | undefined, keys: string[]): string {
@@ -40,7 +40,7 @@ RSpec.describe JSRailsRoutes::Language::TypeScript do
 
     context 'without camelize option' do
       it 'returns a typescript with snake_case functions' do
-        is_expected.to eq <<~TYPESCRIPT
+        expect(subject).to eq <<~TYPESCRIPT
           #{described_class::PROCESS_FUNC}
           export function articles_path(params?: Record<string, Value>) { return process('/articles', params, []); }
           export function new_article_path(params?: Record<string, Value>) { return process('/articles/new', params, []); }
@@ -58,7 +58,7 @@ RSpec.describe JSRailsRoutes::Language::TypeScript do
       end
 
       it 'returns a javascript with lowerCamelCase functions' do
-        is_expected.to eq <<~TYPESCRIPT
+        expect(subject).to eq <<~TYPESCRIPT
           #{described_class::PROCESS_FUNC}
           export function articlesPath(params?: Record<string, Value>) { return process('/articles', params, []); }
           export function newArticlePath(params?: Record<string, Value>) { return process('/articles/new', params, []); }
@@ -76,7 +76,7 @@ RSpec.describe JSRailsRoutes::Language::TypeScript do
       end
 
       it 'returns a javascript with UpperCamelCase functions' do
-        is_expected.to eq <<~TYPESCRIPT
+        expect(subject).to eq <<~TYPESCRIPT
           #{described_class::PROCESS_FUNC}
           export function ArticlesPath(params?: Record<string, Value>) { return process('/articles', params, []); }
           export function NewArticlePath(params?: Record<string, Value>) { return process('/articles/new', params, []); }
@@ -94,7 +94,7 @@ RSpec.describe JSRailsRoutes::Language::TypeScript do
       end
 
       it 'returns a javascript matching to the regexp' do
-        is_expected.to eq <<~TYPESCRIPT
+        expect(subject).to eq <<~TYPESCRIPT
           #{described_class::PROCESS_FUNC}
           export function new_article_path(params?: Record<string, Value>) { return process('/articles/new', params, []); }
         TYPESCRIPT
@@ -109,7 +109,7 @@ RSpec.describe JSRailsRoutes::Language::TypeScript do
       end
 
       it 'returns a javascript not matching to the regexp' do
-        is_expected.to eq <<~TYPESCRIPT
+        expect(subject).to eq <<~TYPESCRIPT
           #{described_class::PROCESS_FUNC}
           export function articles_path(params?: Record<string, Value>) { return process('/articles', params, []); }
           export function edit_article_path(params: Params<'id'>) { return process('/articles/' + params.id + '/edit', params, ['id']); }
@@ -126,7 +126,7 @@ RSpec.describe JSRailsRoutes::Language::TypeScript do
       end
 
       it 'returns a javascript matching to the regexp' do
-        is_expected.to eq <<~TYPESCRIPT
+        expect(subject).to eq <<~TYPESCRIPT
           #{described_class::PROCESS_FUNC}
           export function new_article_path(params?: Record<string, Value>) { return process('/articles/new', params, []); }
         TYPESCRIPT
@@ -141,7 +141,7 @@ RSpec.describe JSRailsRoutes::Language::TypeScript do
       end
 
       it 'returns a javascript not matching to the regexp' do
-        is_expected.to eq <<~TYPESCRIPT
+        expect(subject).to eq <<~TYPESCRIPT
           #{described_class::PROCESS_FUNC}
           export function articles_path(params?: Record<string, Value>) { return process('/articles', params, []); }
           export function edit_article_path(params: Params<'id'>) { return process('/articles/' + params.id + '/edit', params, ['id']); }

data/spec/js_rails_routes/route_set_spec.rb

@@ -20,7 +20,7 @@ RSpec.describe JSRailsRoutes::RouteSet do
 
     it 'returns an array of matching route sets' do
       # See spec/support/test_app.rb
-      is_expected.to match [
+      expect(subject).to match [
         be_a(described_class).and(have_attributes(name: 'Rails')).and(be_match),
         be_a(described_class).and(have_attributes(name: 'Admin::Engine')).and(be_match)
       ]
@@ -46,8 +46,8 @@ RSpec.describe JSRailsRoutes::RouteSet do
       end
 
       it "doesn't include the excluded route" do
-        is_expected.to include be_a(JSRailsRoutes::Route).and(have_attributes(name: /articles/))
-        is_expected.not_to include be_a(JSRailsRoutes::Route).and(have_attributes(name: /users/))
+        expect(subject).to include be_a(JSRailsRoutes::Route).and(have_attributes(name: /articles/))
+        expect(subject).not_to include be_a(JSRailsRoutes::Route).and(have_attributes(name: /users/))
       end
     end
   end

data/spec/js_rails_routes/route_spec.rb

@@ -19,6 +19,14 @@ RSpec.describe JSRailsRoutes::Route do
     it { is_expected.to eq 'articles' }
   end
 
+  describe '#name=' do
+    subject { route.name = value }
+
+    let(:value) { 'foo' }
+
+    it { expect { subject }.to change(route, :name).to(value) }
+  end
+
   describe '#path' do
     subject { route.path }
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: js_rails_routes
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.10.0
 platform: ruby
 authors:
 - Yuku Takahashi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-24 00:00:00.000000000 Z
+date: 2018-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -72,42 +72,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '3.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '3.8'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.58.1
+        version: 0.60.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.58.1
+        version: 0.60.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.27'
+        version: 1.30.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.27'
+        version: 1.30.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement