js-routes 0.9.8 → 0.9.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b27e547dc710d8afdc60c2196335c9bfafa2e279
-  data.tar.gz: 6dd7e82d07ba8f7326637e9ff37e6db477eea728
+  metadata.gz: 11383682f9433b305670ebe17feb5ac27ccb7626
+  data.tar.gz: 422793010efafcc0e4a205c0e3d04f5bdcfdf533
 SHA512:
-  metadata.gz: a886ba634317aba0a1319ea2ba180c5428772d35a7011a03a1b26215d127151fd6253a5935bd685670eab3cb6844d5eef9d1c110d0be2a3d482f14f18bdab9b5
-  data.tar.gz: 8624616cd6b8abf666e0a6b1e6e0669bf79f83453e3c2d268de308e75d18aa75a106aa3ba7b371686274b87fa867567c73021f018fe5c5ad3eefcb43f19bac28
+  metadata.gz: e75c78237118f839aedad8697e13c4f4364eec313c9ab6c84993f12bdfd98a08e8aae1914aa17f0318cd0130c9a763c3d145795a74b15df4ea55fd9fe6875c65
+  data.tar.gz: badb9598727f1b815a5b3ca7b4e746b723c6321de85e0233ee647d13052d929cc3a7663615d89e77a2e75df22417545872ad1c30b68315170a901f219a7310e8

data/CHANGELOG.md

@@ -0,0 +1,14 @@
+## master
+
+## v0.9.8
+
+* Support AMD/Require.js [#111](https://github.com/railsware/js-routes/pull/111)
+* Support trailing slash [#106](https://github.com/railsware/js-routes/pull/106)
+
+## v0.9.7
+
+* Depend on railties [#97](https://github.com/railsware/js-routes/pull/97)
+* Fix typeof error for IE [#95](https://github.com/railsware/js-routes/pull/95)
+* Fix testing on ruby-head [#92](https://github.com/railsware/js-routes/pull/92)
+* Correct thread safety issue in js-routes generation [#90](https://github.com/railsware/js-routes/pull/90)
+* Use the `of` operator to detect for `to_param` and `id` in objects [#87](https://github.com/railsware/js-routes/pull/87)

data/js-routes.gemspec

@@ -9,7 +9,6 @@ Gem::Specification.new do |s|
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Bogdan Gusiev"]
-  s.date = %q{2013-02-13}
   s.description = %q{Generates javascript file that defines all Rails named routes as javascript helpers}
   s.email = %q{agresso@gmail.com}
   s.extra_rdoc_files = [
@@ -24,7 +23,7 @@ Gem::Specification.new do |s|
 
   s.add_runtime_dependency(%q<railties>, [">= 3.2"])
   s.add_runtime_dependency(%q<sprockets-rails>)
-  s.add_development_dependency(%q<rspec>, [">= 2.14.0"])
+  s.add_development_dependency(%q<rspec>, [">= 3.0.0"])
   s.add_development_dependency(%q<bundler>, [">= 1.1.0"])
   s.add_development_dependency(%q<guard>, [">= 0"])
   s.add_development_dependency(%q<guard-coffeescript>, [">= 0"])

data/lib/js-routes.rb

@@ -1,2 +1 @@
 require 'js_routes'
-require 'js_routes/engine'

data/lib/js_routes.rb

@@ -1,4 +1,5 @@
 require 'uri'
+require 'js_routes/engine' if defined?(Rails)
 require 'js_routes/version'
 
 class JsRoutes
@@ -145,7 +146,7 @@ class JsRoutes
 
   def any_match?(route, parent_route, matchers)
     matchers = Array(matchers)
-    matchers.any? {|regex| [parent_route.try(:name), route.name].compact.join('') =~ regex}
+    matchers.any? {|regex| [parent_route.try(:name), route.name].compact.join('_') =~ regex}
   end
 
   def build_js(route, parent_route)

data/lib/js_routes/engine.rb

@@ -1,5 +1,5 @@
 class JsRoutes
-  class Engine < Rails::Engine
+  class Engine < ::Rails::Engine
     JS_ROUTES_ASSET = 'js-routes'
 
     initializer 'js-routes.dependent_on_routes', after: "sprockets.environment" do

data/lib/js_routes/version.rb

@@ -1,3 +1,3 @@
 class JsRoutes
-  VERSION = "0.9.8"
+  VERSION = "0.9.9"
 end

data/spec/js_routes/generated_javascript_spec.rb

@@ -10,13 +10,13 @@ describe JsRoutes do
   describe "generated js" do
     subject { JsRoutes.generate }
     it "should have correct function without arguments signature" do
-      should include("inboxes_path: function(options)")
+      is_expected.to include("inboxes_path: function(options)")
     end
     it "should have correct function with arguments signature" do
-      should include("inbox_message_path: function(_inbox_id, _id, options)")
+      is_expected.to include("inbox_message_path: function(_inbox_id, _id, options)")
     end
     it "should have correct function signature with unordered hash" do
-      should include("inbox_message_attachment_path: function(_inbox_id, _message_id, _id, options)")
+      is_expected.to include("inbox_message_attachment_path: function(_inbox_id, _message_id, _id, options)")
     end
 
     it "routes should be sorted in alphabetical order" do
@@ -26,31 +26,32 @@ describe JsRoutes do
 
   describe ".generate!" do
 
-    let(:name) {  "#{File.dirname(__FILE__)}/../routes.js" }
+    let(:name) { "#{File.dirname(__FILE__)}/../routes.js" }
 
     before(:each) do
       FileUtils.rm_f(name)
       JsRoutes.generate!({:file => name})
     end
 
+    after(:all) do
+      FileUtils.rm_f("#{File.dirname(__FILE__)}/../routes.js") # let(:name) is not available here
+    end
+
     it "should not generate file before initialization" do
       # This method is alread fixed in Rails master
       # But in 3.2 stable we need to hack it like this
       if Rails.application.instance_variable_get("@initialized")
         pending
       end
-      expect(File.exists?(name)).to be_false
+      expect(File.exists?(name)).to be_falsey
     end
 
-    after(:all) do
-      FileUtils.rm_f(name)
-    end
   end
 
   describe "compiled javascript asset" do
     subject { ERB.new(File.read("app/assets/javascripts/js-routes.js.erb")).result(binding) }
     it "should have js routes code" do
-      should include("inbox_message_path: function(_inbox_id, _id, options)")
+      is_expected.to include("inbox_message_path: function(_inbox_id, _id, options)")
     end
   end
 end

data/spec/js_routes/options_spec.rb

@@ -24,7 +24,16 @@ describe JsRoutes, "options" do
     it "should not exclude routes not under specified pattern" do
       expect(evaljs("Routes.inboxes_path()")).not_to be_nil
     end
+
+    context "for rails engine" do
+      let(:_options) { {:exclude => /^blog_app_posts/} }
+
+      it "should exclude specified engine route" do
+        expect(evaljs("Routes.blog_app_posts_path")).to be_nil
+      end
+    end
   end
+
   context "when include is specified" do
 
     let(:_options) { {:include => /^admin_/} }
@@ -36,6 +45,14 @@ describe JsRoutes, "options" do
     it "should not exclude routes not under specified pattern" do
       expect(evaljs("Routes.inboxes_path")).to be_nil
     end
+
+    context "for rails engine" do
+      let(:_options) { {:include => /^blog_app_posts/} }
+
+      it "should include specified engine route" do
+        expect(evaljs("Routes.blog_app_posts_path()")).not_to be_nil
+      end
+    end
   end
 
   context "when prefix with trailing slash is specified" do

data/spec/js_routes/zzz_last_post_rails_init_spec.rb

@@ -20,7 +20,7 @@ describe "after Rails initialization" do
   end
 
   it "should generate routes file" do
-    expect(File.exists?(NAME)).to be_true
+    expect(File.exists?(NAME)).to be_truthy
   end
 
   context "JsRoutes::Engine" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: js-routes
 version: !ruby/object:Gem::Version
-  version: 0.9.8
+  version: 0.9.9
 platform: ruby
 authors:
 - Bogdan Gusiev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-13 00:00:00.000000000 Z
+date: 2014-08-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.14.0
+        version: 3.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.14.0
+        version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -135,6 +135,7 @@ files:
 - ".rspec"
 - ".travis.yml"
 - Appraisals
+- CHANGELOG.md
 - Gemfile
 - Guardfile
 - LICENSE.txt