jp_post 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a3861e56e139d377bed716a3b77f53bff4338057
-  data.tar.gz: 07f22ff16e9259f70e93f00bfdd77f5313766409
+  metadata.gz: 8a409d14c5dd3c09ef990646299fed5c41a98344
+  data.tar.gz: 2c5b2351cbb499e2eb716e5e3c1823e764157a6e
 SHA512:
-  metadata.gz: 5b12b9b562939297d2906e4888372c008cd25596d56cef80b7a55c0596db622d2e93ea18f29cdbdd95c7d10185df5fbc0fb1f9290d83ef19e0b0cbe551c59176
-  data.tar.gz: ccca31830e4808aba44842b59a5880f0a8879f6268bb792ca7db01e976cf96b9b32d0226b1f60581485fdc23c7f07fc64cde5224214b1808e9ad6ce190013d52
+  metadata.gz: 18a5a258056c935e7754ffcc76cee2780d14358d5f9bf5b790b5015f807b9a16af140223d2861b7fbdea50fdfb08b31fc6adc63d4592456221f02214b0fadda0
+  data.tar.gz: fc07fc0bd2eeddad07179105ae2ead30c7c0dee057ec7f71d49100218f9cb9b0a1c926d796bbe6190216f2ac8b09643e908f5cadd5e07cd63901744829861b75

data/lib/jp_post/tracking.rb

@@ -16,14 +16,14 @@ module JpPost
       tracking_url = "https://trackings.post.japanpost.jp/services/srv/search/direct?reqCodeNo1=#{@tracking_number}&locale=en"
 
       @tracking_page = Nokogiri::HTML(Typhoeus.get(tracking_url).body)
-
-      raise RuntimeError, "No Tracking found." if @tracking_page.css(".indent table[summary='履歴情報']").empty?
     end
 
     # "Class of Goods" string from tracking site
     #
     # Returns classification String.
     def classification
+      return nil if tracking_is_empty
+      
       @delivery_status_details_box ||= @tracking_page.css(".indent table[summary='配達状況詳細']")
       classification = @delivery_status_details_box.css("tr:last .w_380").text.strip
       return classification
@@ -33,6 +33,8 @@ module JpPost
     #
     # Returns additional_services String.
     def additional_services
+      return nil if tracking_is_empty
+
       @delivery_status_details_box ||= @tracking_page.css(".indent table[summary='配達状況詳細']")
       additional_services = @delivery_status_details_box.css(".w_100").last.text.strip
       return additional_services
@@ -42,6 +44,8 @@ module JpPost
     #
     # Returns tracking history as Array.
     def history
+      return nil if tracking_is_empty
+
       @history_information_box ||= @tracking_page.css(".indent table[summary='履歴情報']")
       history_columns = @history_information_box.css("tr")
       history_columns = history_columns[2..history_columns.size] # remove header
@@ -70,5 +74,15 @@ module JpPost
       return history
     end
 
+    private
+
+    def tracking_is_empty
+      if @tracking_page.css(".indent table[summary='履歴情報']").empty?
+        return true
+      else
+        return false
+      end
+    end
+
   end
 end

data/lib/jp_post/version.rb

@@ -1,3 +1,3 @@
 module JpPost
-  VERSION = "1.0.1"
+  VERSION = "1.0.2"
 end

data/spec/jp_post/tracking_spec.rb

@@ -6,12 +6,6 @@ describe JpPost::Tracking do
       expect { JpPost::Tracking.new() }.to raise_error(ArgumentError)
     end
 
-    it "should not initialize with empty tracking number" do
-      VCR.use_cassette 'empty_tracking' do
-        expect { JpPost::Tracking.new("EL015307999123JP") }.to raise_error(RuntimeError)
-      end
-    end
-
     it "should initialize a tracking object" do
       VCR.use_cassette 'working_tracking' do
         package = JpPost::Tracking.new("EL015307999JP")
@@ -27,6 +21,13 @@ describe JpPost::Tracking do
         expect(package.classification).to be_kind_of(String)
       end
     end
+
+    it "should return nil with empty tracking number" do
+      VCR.use_cassette 'empty_tracking' do
+        package = JpPost::Tracking.new("EL015307999123JP")
+        expect(package.classification).to be_nil
+      end
+    end
   end
 
   describe "#history" do
@@ -36,6 +37,13 @@ describe JpPost::Tracking do
         expect(package.history).to be_kind_of(Array)
       end
     end
+
+    it "should return nil with empty tracking number" do
+      VCR.use_cassette 'empty_tracking' do
+        package = JpPost::Tracking.new("EL015307999123JP")
+        expect(package.history).to be_nil
+      end
+    end
   end
-  
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: jp_post
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Sebastian Szturo