journald-native 1.0.5 → 1.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f07112165499f340a1a856b2f5eb952ab67512c3
-  data.tar.gz: 084815636014a24e2cc2500853b15b2aba90f713
+  metadata.gz: 7074ca755c39b71b382f63b7befe21e0dc7e18ec
+  data.tar.gz: 585840efef3b5ee2b50f97e830ecf21df0ec811b
 SHA512:
-  metadata.gz: 846465074f639a88087fa6a7b164a7c177c49877fa7b0115392917fd5f229c0860450a7632cacda6c835518bba766fbc98260fa2c45a7f2cef403853283c02c5
-  data.tar.gz: 27e0430e831019f557f68e715a9bf60b9902c108617a103481a3251d514d66f3acc79620cc8dcb1a06be94c3003e83cd4fd3c405ff6a36ba8f5c80ad692809ef
+  metadata.gz: e19cdf3224ca356c47319c5dd6897cc364a8f4d87a1f9c7d9319a31be19be2b4298cbc1b869024e8f0846f48115947dc296afb9d809de368bc16ae18434cdb2a
+  data.tar.gz: 214828671762b128ae1875fffce35e8a3db25217db47e6bca8d4a127750c3ad1ca55d9c8999c623829dce3a8b998ffe70d2fe62395b3dedf75b3479d3487532a

data/README.md

@@ -44,9 +44,9 @@ Journald::Native.print Journald::LOG_WARNING, "message"
 Journald::Native.perror "message"
 ```
 
-It is not recommended to use ```print``` and ```perror``` as you may lose ```'\0'``` byte in your string due to
-C zero-terminated string format (all zero bytes in the middle will be removed) On the contrary ```send``` uses
-binary buffers and does not have this shortcoming.
+It is not recommended to use ```print``` and ```perror``` as you may get exception if your string contains
+```'\0'``` byte due to C zero-terminated string format. On the contrary ```send``` uses binary buffers and
+does not have this shortcoming.
 
 ### License
 

data/ext/journald_native/journald_native.cpp

@@ -17,34 +17,13 @@ inline auto r(Func f, Args... args) -> decltype(f(args...))
     return ruby_exception_wrapper::ruby_raisable_call(f, args...);
 }
 
-// Remove zeros from the string
-std::string create_safe_string(VALUE v_string)
-{
-    /* convert to string */
-    r(rb_string_value, &v_string);
-
-    char*  str = (char *)RSTRING_PTR(v_string);
-    size_t len = (size_t)RSTRING_LEN(v_string);
-
-    std::string safe_str;
-    safe_str.reserve(len);
-
-    for (size_t i = 0; i < len; i++) {
-        if (str[i]) {
-            safe_str += str[i];
-        }
-    }
-
-    return safe_str;
-}
-
 /* methods */
 inline VALUE native_print(VALUE v_self, VALUE v_priority, VALUE v_message)
 {
-    int  priority = NUM2INT(v_priority);
-    auto message  = create_safe_string(v_message);
+    int         priority = NUM2INT(v_priority);
+    std::string message  = r(rb_string_value_cstr, &v_message);
 
-    int  result   = sd_journal_print(priority, "%s", message.c_str());
+    int         result   = sd_journal_print(priority, "%s", message.c_str());
 
     return INT2NUM(result);
 }
@@ -67,9 +46,9 @@ inline VALUE native_send(int argc, VALUE* argv, VALUE v_self)
 
 inline VALUE native_perror(VALUE v_self, VALUE v_message)
 {
-    auto message = create_safe_string(v_message);
+    std::string message = r(rb_string_value_cstr, &v_message);
 
-    int  result  = sd_journal_perror(message.c_str());
+    int         result  = sd_journal_perror(message.c_str());
 
     return INT2NUM(result);
 }

data/lib/journald/native/version.rb

@@ -1,5 +1,5 @@
 module Journald
   module Native
-    VERSION = '1.0.5'
+    VERSION = '1.0.6'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: journald-native
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 1.0.6
 platform: ruby
 authors:
 - Anton Smirnov