josephholsten-rets4r 1.1.14 → 1.1.15

data/VERSION.yml

@@ -1,5 +1,5 @@
 --- 
 :build: 
 :minor: 1
-:patch: 14
+:patch: 15
 :major: 1

data/lib/rets4r/client/parsers/compact_nokogiri.rb

@@ -21,8 +21,10 @@ module RETS4R
             @delimiter = attrs.last.to_i.chr
           when 'COLUMNS'
             @columns_element = true
+            @string = ''
           when 'DATA'
             @data_element = true
+            @string = ''
           end
         end
 
@@ -30,20 +32,21 @@ module RETS4R
           case name
           when 'COLUMNS'
             @columns_element = false
+            @columns = @string.split(@delimiter)
           when 'DATA'
             @data_element = false
+            @results << @columns.zip(@string.split(@delimiter)).inject({}) do | h,(k,v) |
+              h[k] = v unless k.empty?
+              next h
+            end
           end
         end
 
         def characters string
           if @columns_element
-            @columns = string.split(@delimiter)
+            @string << string
           elsif @data_element
-            data = @columns.zip(string.split(@delimiter)).inject({}) do | h,(k,v) |
-              h[k] = v unless k.empty?
-              next h
-            end
-            @results << data
+            @string << string
           end
         end
       end

data/test/compact_nokogiri_test.rb

@@ -10,4 +10,10 @@ class CompactNokogiriTest < Test::Unit::TestCase
     assert_equal({"Third"=>"Datum3", "Second"=>"Datum2", "First"=>"Datum1"}, listings[0])
     assert_equal({"Third"=>"Datum6", "Second"=>"Datum5", "First"=>"Datum4"}, listings[1])
   end
+  def test_should_handle_big_data
+    file = File.expand_path(File.join('test', 'data', '1.5', 'bad_compact.xml'))
+    listings = RETS4R::Client::CompactNokogiriParser.new.parse_results(file)
+    assert_equal 1, listings.length
+    assert_equal 79, listings.first.keys.length
+  end
 end

data/test/data/1.5/bad_compact.xml

@@ -0,0 +1,7 @@
+<RETS ReplyCode="0" ReplyText="Operation Successful">
+<COUNT Records="38610" />
+<DELIMITER value="09" />
+<COLUMNS>	MLSNUM	AGENTLIST	AGENTLIST_FULLNAME	OFFICELIST	OFFICELIST_OFFICENAM1	INTERNETLIST_ALL	LISTSTATUSFLAG	PHOTOCOUNT	LISTSTATUS	BEDS	CARPORTCAP	NUMDININGAREAS	FIREPLACES	BATHSFULL	BATHSFULLLEVEL1	BATHSFULLLEVEL2	BATHSFULLLEVEL3	BATHSFULLBASEMENT	GARAGECAP	BATHSHALF	BATHSHALFLEVEL1	BATHSHALFLEVEL2	BATHSHALFLEVEL3	BATHSHALFBASEMENT	NUMLIVINGAREAS	NUMBARNS	NUMLAKES	NUMPONDS	NUMRESIDENCE	NUMSTOCKTANKS	STORIES	NUMWELLS	SCHOOLDISTRICT	AGENTSELL_FULLNAME	OFFICESELL_OFFICENAM2	STATE	STREETNAME	STREETTYPE	STREETNUM	STREETNUMDISPLAY	STREETDIRSUFFIX	STREETDIR	STYLE	SUBDIVISION	ACRES	INTERNETDISPLAYYN	ROOMBEDBATHDESC	STORIESBLDG	CITY	COMMONFEATURES	COUNTY	ACRESCULTIVATED	INTERIOR	LISTPRICE	SQFTPRICE	LOTNUM	LOTDESC	LOTDIM	LOTSIZE	LISTPRICELOW	ACRESPRICE	MAPBOOK	MAPCOORD	MAPPAGE	LISTPRICEORIG	GARAGEDESC	PROPTYPE	REMARKS	PROPSUBTYPE	PROPSUBTYPEDISPLAY	SQFTTOTAL	SQFTSOURCE	UTILITIES	UID	UIDPRP	TAXUNEXEMPT	UNITNUM	YEARBUILT	ZIPCODE	</COLUMNS>
+<DATA>	11322886	000533246	CD Boyd, II	FMAB	McClure, REALTORS	OMWS,immo,RCOM,SYND		8	act	4	0	2	1	3					2	0					2						2		Wylie ISD, Taylor Co.			TX	Thompson	PKWY	8317	8317			STYRANCH	Belle Vista Estates	0.361	Y	BBFJET-TUB,BBFLIN-CLO,BBFSEP-SHO,BBFW+I-CLO		Abilene		Taylor		INFBAY-WIN,INFCABLE-A,INFDECLTNG,INFHIGHSPD,INFLOFT,INFSOUND-W,INFVAUL-CL,INFWIND-CO	239000	84.6		LTDSUBDIV	87X182	LTS.5-.99A	0	662049	OT	none	9999	239000	PARATTACHE,PAROPENER,PARREAR,PARSIDE	RES	Custom home built in 05&apos;.  Growing neighborhood convienient to Wylie schools. Abundant living areas and and open space floor plan.Could be 5th BDRM, or upstair BDRM &amp; Bath could be another living area.  Perfect office next to Master. Gourmet sized kitchen, granite countertops, barell ceilings, wonderful storage space!!!!	S	RES-S	2825	TAX	STUASPHALT,UTLCITY-SE,UTLCITY-WA,STUCONCRET	3211078	3211078	5876		2005	79606-6652	</DATA>
+<MAXROWS />
+</RETS>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: josephholsten-rets4r
 version: !ruby/object:Gem::Version 
-  version: 1.1.14
+  version: 1.1.15
 platform: ruby
 authors: 
 - Scott Patterson
@@ -66,6 +66,7 @@ files:
 - lib/tasks/annotations.rake
 - lib/tasks/coverage.rake
 - test/compact_nokogiri_test.rb
+- test/data/1.5/bad_compact.xml
 - test/data/1.5/error.xml
 - test/data/1.5/invalid_compact.xml
 - test/data/1.5/login.xml