joiner 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 95831ffeed5e8c01635e9d2a9719daf72b7db24f
-  data.tar.gz: b76e140e99fa969a716e69f35396ff7a1f323cbb
+  metadata.gz: 7b7b02b7622a82eeefbf7a3abca876d752e809d0
+  data.tar.gz: 9b6809d20db5b15abb97f40a06349a8186d3f863
 SHA512:
-  metadata.gz: 94ff8d0bf4e2acce3ce4d3fd4f0fd6ad46bd2ce91936564a6ab970ce9a7db518dac9cbc4d25c41a6eeb06e060595d0285033477b0a560a1372d0cbdb3e61e8ec
-  data.tar.gz: a1927657a5db57b18891242ee5def0c1c9d1f111fa3b75eeeda9b404ba6f6d9319d849714ecd6373e33912376c7de0d0b4edb480da158b9368b01bed2a79c5cb
+  metadata.gz: 33aac1b4d121b51ed4a23f314478135f0514e583c880c06c4b8931ef1e0fb07211ee142813e13e6d230a94096dfa486c31f60fe48bcd22df6583c8d96d29177c
+  data.tar.gz: 8ca6904f2f5e37fbf49eeee879af83e261a650fae726a1263a46a3013105de0a1da8ccfe2665cac1cfe22ab9d227cc520319f8d965ad98ae416e0b8ce8f670a8

data/README.md

@@ -9,7 +9,7 @@ If this gem is used by anyone other than myself/Thinking Sphinx, I'll be surpris
 It's a gem - so you can either install it yourself, or add it to the appropriate Gemfile or gemspec.
 
 ```term
-gem install joiner --version 0.1.0
+gem install joiner --version 0.2.0
 ```
 
 ## Usage

data/joiner.gemspec

@@ -1,7 +1,7 @@
 # coding: utf-8
 Gem::Specification.new do |spec|
   spec.name          = 'joiner'
-  spec.version       = '0.1.0'
+  spec.version       = '0.2.0'
   spec.authors       = ['Pat Allan']
   spec.email         = ['pat@freelancing-gods.com']
   spec.summary       = %q{Builds ActiveRecord joins from association paths}

data/lib/joiner.rb

@@ -1,5 +1,6 @@
 module Joiner
-  #
+  class AssociationNotFound < StandardError
+  end
 end
 
 require 'joiner/joins'

data/lib/joiner/path.rb

@@ -25,7 +25,11 @@ class Joiner::Path
     klass = base
     path.collect { |reference|
       klass.reflect_on_association(reference).tap { |reflection|
-        return [] if reflection.nil?
+        if reflection.nil?
+          raise Joiner::AssociationNotFound,
+            "No association matching #{base.name}, #{path.join(', ')}"
+        end
+
         klass = reflection.klass
       }
     }

data/spec/acceptance/paths_spec.rb

@@ -34,10 +34,10 @@ describe 'Paths' do
       expect(path.model).to eq(User)
     end
 
-    it "returns nil if the path is invalid" do
+    it "raises an exception if the path is invalid" do
       path = Joiner::Path.new User, [:articles, :likes]
 
-      expect(path.model).to be_nil
+      expect { path.model }.to raise_error(Joiner::AssociationNotFound)
     end
   end
 end

data/spec/joiner/joins_spec.rb

@@ -0,0 +1,179 @@
+require 'spec_helper'
+
+describe Joiner::Joins do
+  JoinDependency = ::ActiveRecord::Associations::JoinDependency
+
+  let(:joins)     { Joiner::Joins.new model }
+  let(:model)     { model_double 'articles' }
+  let(:base)      {
+    double('base', :active_record => model, :join_base => join_base)
+  }
+  let(:join_base) { double('join base') }
+  let(:join)      { join_double 'users' }
+  let(:sub_join)  { join_double 'posts' }
+
+  def join_double(table_alias)
+    double 'join',
+      :join_type=         => nil,
+      :aliased_table_name => table_alias,
+      :reflection         => double('reflection'),
+      :conditions         => []
+  end
+
+  def model_double(table_name = nil)
+    double 'model', :quoted_table_name => table_name, :reflections => {}
+  end
+
+  before :each do
+    JoinDependency.stub :new => base
+    JoinDependency::JoinAssociation.stub(:new).and_return(join, sub_join)
+    model.reflections[:user] = join.reflection
+
+    join.stub :active_record => model_double
+    join.active_record.reflections[:posts] = sub_join.reflection
+  end
+
+  describe '#add_join_to' do
+    before :each do
+      JoinDependency::JoinAssociation.unstub :new
+    end
+
+    it "adds just one join for a stack with a single association" do
+      JoinDependency::JoinAssociation.should_receive(:new).
+        with(join.reflection, base, join_base).once.and_return(join)
+
+      joins.add_join_to([:user])
+    end
+
+    it "does not duplicate joins when given the same stack twice" do
+      JoinDependency::JoinAssociation.should_receive(:new).once.and_return(join)
+
+      joins.add_join_to([:user])
+      joins.add_join_to([:user])
+    end
+
+    context 'multiple joins' do
+      it "adds two joins for a stack with two associations" do
+        JoinDependency::JoinAssociation.should_receive(:new).
+          with(join.reflection, base, join_base).once.and_return(join)
+        JoinDependency::JoinAssociation.should_receive(:new).
+          with(sub_join.reflection, base, join).once.and_return(sub_join)
+
+        joins.add_join_to([:user, :posts])
+      end
+
+      it "extends upon existing joins when given stacks where parts are already mapped" do
+        JoinDependency::JoinAssociation.should_receive(:new).twice.
+          and_return(join, sub_join)
+
+        joins.add_join_to([:user])
+        joins.add_join_to([:user, :posts])
+      end
+    end
+
+    context 'join with conditions' do
+      let(:connection) { double }
+      let(:parent)     { double :aliased_table_name => 'qux' }
+
+      before :each do
+        JoinDependency::JoinAssociation.stub :new => join
+
+        join.stub :parent => parent
+        model.stub :connection => connection
+        connection.stub(:quote_table_name) { |table| "\"#{table}\"" }
+      end
+
+      it "leaves standard conditions untouched" do
+        join.stub :conditions => 'foo = bar'
+
+        joins.add_join_to [:user]
+
+        join.conditions.should == 'foo = bar'
+      end
+
+      it "modifies filtered polymorphic conditions" do
+        join.stub :conditions => '::ts_join_alias::.foo = bar'
+
+        joins.add_join_to [:user]
+
+        join.conditions.should == '"qux".foo = bar'
+      end
+
+      it "modifies filtered polymorphic conditions within arrays" do
+        join.stub :conditions => ['::ts_join_alias::.foo = bar']
+
+        joins.add_join_to [:user]
+
+        join.conditions.should == ['"qux".foo = bar']
+      end
+
+      it "does not modify conditions as hashes" do
+        join.stub :conditions => [{:foo => 'bar'}]
+
+        joins.add_join_to [:user]
+
+        join.conditions.should == [{:foo => 'bar'}]
+      end
+    end
+  end
+
+  describe '#alias_for' do
+    it "returns the model's table name when no stack is given" do
+      joins.alias_for([]).should == 'articles'
+    end
+
+    it "adds just one join for a stack with a single association" do
+      JoinDependency::JoinAssociation.unstub :new
+      JoinDependency::JoinAssociation.should_receive(:new).
+        with(join.reflection, base, join_base).once.and_return(join)
+
+      joins.alias_for([:user])
+    end
+
+    it "returns the aliased table name for the join" do
+      joins.alias_for([:user]).should == 'users'
+    end
+
+    it "does not duplicate joins when given the same stack twice" do
+      JoinDependency::JoinAssociation.unstub :new
+      JoinDependency::JoinAssociation.should_receive(:new).once.and_return(join)
+
+      joins.alias_for([:user])
+      joins.alias_for([:user])
+    end
+
+    context 'multiple joins' do
+      it "adds two joins for a stack with two associations" do
+        JoinDependency::JoinAssociation.unstub :new
+        JoinDependency::JoinAssociation.should_receive(:new).
+          with(join.reflection, base, join_base).once.and_return(join)
+        JoinDependency::JoinAssociation.should_receive(:new).
+          with(sub_join.reflection, base, join).once.and_return(sub_join)
+
+        joins.alias_for([:user, :posts])
+      end
+
+      it "returns the sub join's aliased table name" do
+        joins.alias_for([:user, :posts]).should == 'posts'
+      end
+
+      it "extends upon existing joins when given stacks where parts are already mapped" do
+        JoinDependency::JoinAssociation.unstub :new
+        JoinDependency::JoinAssociation.should_receive(:new).twice.
+          and_return(join, sub_join)
+
+        joins.alias_for([:user])
+        joins.alias_for([:user, :posts])
+      end
+    end
+  end
+
+  describe '#join_values' do
+    it "returns all joins that have been created" do
+      joins.alias_for([:user])
+      joins.alias_for([:user, :posts])
+
+      joins.join_values.should == [join, sub_join]
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: joiner
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Pat Allan
@@ -97,6 +97,7 @@ files:
 - spec/internal/config/database.yml
 - spec/internal/db/schema.rb
 - spec/internal/log/.gitignore
+- spec/joiner/joins_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/pat/joiner
 licenses:
@@ -131,4 +132,5 @@ test_files:
 - spec/internal/config/database.yml
 - spec/internal/db/schema.rb
 - spec/internal/log/.gitignore
+- spec/joiner/joins_spec.rb
 - spec/spec_helper.rb