job-iteration 1.1.4 → 1.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 21dc74805b967b6082859b0c9a07d955f9f77ca3e82f250ceaf4f2aecf4afd7b
-  data.tar.gz: 23ea1a3e03c8b0578dcf852449204f60e5391bdb92f26987da7d42f45b052595
+  metadata.gz: 6bea2b43448343cc53903fdd896e7affd5d168f6c758ddf4b53a9d86de2207b8
+  data.tar.gz: f74eabf96862da75494f80f6964c4e9a1611c6f46f66af23a6c8682ec595bcb1
 SHA512:
-  metadata.gz: b3b5b27d999f8ea00a443d01857f0483fef67edcd0b0525d8ef8003c8814b9efe1e34713d6f45d0aa2de68c79c2517be141595f37c2501265f04ea6a4da7e0af
-  data.tar.gz: e47797081fc96034f2fe21746528047cba4f2873a0e6a36a7a38f2265d38a1dcb045f66216c3e9579699d63a9b6416136cf456e630404bb6d5381c433ef7232c
+  metadata.gz: 0f32960627142f5fb14c8021e58347b491db9c75338eb323a6a7e3535569669f3f1a6f3482fd388ad471ece1293f5dee74d898384ce0f3d181c73c9adf480cb1
+  data.tar.gz: 31a7cebea521cc632716d6f612ff1979f3f5efe4742305d2823a364c06930b9a4ece7043315a2cbb88c37db41c6d90a18dba1713458ea450acae3dd41ea18b79

data/CHANGELOG.md

@@ -4,6 +4,10 @@
 
 #### Bug fix
 
+## v1.1.5 (February 27, 2020)
+
+- [47](https://github.com/Shopify/job-iteration/pull/47) -  Optional `sorbet-runtime` support for `JobIteration::Iteration` interface validation
+
 ## v1.1.4 (December 13, 2019)
 
 - [45](https://github.com/Shopify/job-iteration/pull/45) -  Add Throttle enumerator

data/Gemfile

@@ -23,3 +23,6 @@ gem 'mocha'
 gem 'rubocop', '~> 0.77.0'
 gem 'yard'
 gem 'rake'
+
+# for unit testing optional sorbet support
+gem 'sorbet-runtime'

data/lib/job-iteration/active_record_cursor.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
 module JobIteration
+  # Curious about how this works from the SQL perspective?
+  # Check "Pagination Done the Right way": https://bit.ly/2Rq7iPF
   class ActiveRecordCursor # @private
     include Comparable
 

data/lib/job-iteration/iteration.rb

@@ -176,7 +176,7 @@ module JobIteration
       end
 
       if respond_to?(:build_enumerator, true)
-        parameters = method(:build_enumerator).parameters
+        parameters = method_parameters(:build_enumerator)
         unless valid_cursor_parameter?(parameters)
           raise ArgumentError, "Iteration job (#{self.class}) #build_enumerator " \
           "expects the keyword argument `cursor`"
@@ -187,6 +187,17 @@ module JobIteration
       end
     end
 
+    def method_parameters(method_name)
+      method = method(method_name)
+
+      if defined?(T::Private::Methods)
+        signature = T::Private::Methods.signature_for_method(method)
+        method = signature.method if signature
+      end
+
+      method.parameters
+    end
+
     def iteration_instrumentation_tags
       { job_class: self.class.name }
     end

data/lib/job-iteration/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module JobIteration
-  VERSION = "1.1.4"
+  VERSION = "1.1.5"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: job-iteration
 version: !ruby/object:Gem::Version
-  version: 1.1.4
+  version: 1.1.5
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-12-13 00:00:00.000000000 Z
+date: 2020-02-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord