jlint 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b6813c93f52c5132c0563f58f28b5765881688eb
-  data.tar.gz: 9e33d6836d5419f85f930b838944b25512ac193e
+  metadata.gz: 1dc85e460dbf3ca0098ab8c8364a9fbfd06ef17c
+  data.tar.gz: 45c220242b42d9a3f9ced119354afba3fdfbdf73
 SHA512:
-  metadata.gz: 27c3d746cf4e26ec606298506de467807589cf2460159cd10d5f013fa3c55ea832b093f7b04fa7865233a700f62fa72150a5d11d1bb5a47c41251ce82bb1c11f
-  data.tar.gz: 8158c782278d8a1460a7c7b2dc0241d4e808a85f9c53c9c948355cd3fe97a1ab206ddb572a3682d47c62851a74c22cb3964958494d2f873a058ea5eea2326cf6
+  metadata.gz: 07083e17bec494f19545e54cc91b64bb62f90642c126f213a098eebbc74bf64aca321df8ed56c6fb2b88e97707b7b010a4ea10758d51525210ca371267e3eb04
+  data.tar.gz: 01566ea4227f4bb4d95d5abf2eff6b109967dbdfda7e27f1a1a690e900f6c10ec77d3d8c187c7bc1c377d47bb820fedd370ca4ce5dc34288e57d443aab596507

data/.gitignore

@@ -1 +1,3 @@
 jlint-0.0.1.gem
+.build
+.bundle

data/.travis.yml

@@ -0,0 +1,7 @@
+language: ruby
+rvm:
+  - 1.9.3
+  - 2.2.1
+before_install:
+  - sudo apt-get update -qq
+  - sudo apt-get install -y openjdk-7-jre

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    jlint (0.1.0)
+    jlint (0.1.3)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -1,5 +1,7 @@
 # Jlint
 
+![](https://travis-ci.org/zlx/jlint.svg?branch=master)
+
 Ruby Warp for CheckStyle: https://github.com/checkstyle/checkstyle
 
 Provide more friendly interface for Rubist

data/Rakefile

@@ -1,7 +1,8 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
 require 'rake/testtask'
 
+task default: :test
+
 Rake::TestTask.new do |t|
-  t.pattern = "test/jlint/test_*.rb"
+  t.pattern = 'test/jlint/test_*.rb'
 end
-

data/doc/sun_checks.xml

@@ -41,7 +41,7 @@
 
     <!-- Checks that a package-info.java file exists for each package.     -->
     <!-- See http://checkstyle.sf.net/config_javadoc.html#JavadocPackage -->
-    <module name="JavadocPackage"/>
+    <!--module name="JavadocPackage"/-->
 
     <!-- Checks whether files end with a new line.                        -->
     <!-- See http://checkstyle.sf.net/config_misc.html#NewlineAtEndOfFile -->
@@ -50,11 +50,11 @@
     <!-- Checks that property files contain the same keys.         -->
     <!-- See http://checkstyle.sf.net/config_misc.html#Translation -->
     <module name="Translation"/>
-    
+
     <!-- Checks for Size Violations.                    -->
     <!-- See http://checkstyle.sf.net/config_sizes.html -->
     <module name="FileLength"/>
-    
+
     <!-- Checks for whitespace                               -->
     <!-- See http://checkstyle.sf.net/config_whitespace.html -->
     <module name="FileTabCharacter"/>
@@ -154,7 +154,6 @@
         <module name="InnerAssignment"/>
         <module name="MagicNumber"/>
         <module name="MissingSwitchDefault"/>
-        <module name="RedundantThrows"/>
         <module name="SimplifyBooleanExpression"/>
         <module name="SimplifyBooleanReturn"/>
 

data/lib/jlint.rb

@@ -1,4 +1,6 @@
 require 'tempfile'
+require 'yaml'
+
 class Jlint
   def self.lint content
     new.lint content
@@ -32,7 +34,12 @@ class Jlint
   private
 
   def parse_lint command, config_path, file_path
-    parse `java -jar #{checkstyle_command} -c #{config_path} #{file_path}`
+    output = `java -jar #{checkstyle_command} -c #{config_path} #{file_path}`
+    if /Unable to create Checker|Error loading configuration file/ =~ output
+      raise output
+    else
+      parse output
+    end
   end
 
   def as_file content, format = ".java"
@@ -49,7 +56,7 @@ class Jlint
   end
 
   def checkstyle_command
-    File.join(File.dirname(__FILE__), '..', 'bin', 'checkstyle.jar')
+    File.join(File.dirname(__FILE__), '..', 'bin', 'current')
   end
 
   def checkstyle_config

data/lib/jlint/version.rb

@@ -1,3 +1,3 @@
 class Jlint
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
 end

data/test/jlint/test_jlint.rb

@@ -6,7 +6,7 @@ describe Jlint do
     file_path = File.join(File.dirname(__FILE__), "..", "support", "sample.java")
     result = Jlint.file_lint(file_path)
     assert result.is_a?(Array)
-    assert result.include?(["Missing package-info.java file.", 0])
+    assert_equal(result.to_yaml, File.read('test/support/sample_errors.yml'))
   end
 
   it "should lint for file content with newline" do
@@ -20,12 +20,12 @@ describe Jlint do
 }]
     result = Jlint.lint(content)
     assert result.is_a?(Array)
-    assert !result.include?(["File does not end with a newline.", 0])
-    assert result.include?(["Missing package-info.java file.", 0])
+    assert_equal(result.to_yaml, File.read('test/support/custom_config_errors.yml'))
   end
 
   it "should lint with custom config content" do
-    content = %Q[public class Sample {
+    content = %Q[import java.util.*;
+public class Sample {
   public static void Sample() {
   }
 
@@ -38,10 +38,51 @@ describe Jlint do
           "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
           "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
 <module name="Checker">
+  <module name="TreeWalker">
+    <module name="AvoidStarImport"/>
+  </module>
 </module>]
     result = Jlint.new(config_content).lint(content)
     assert result.is_a?(Array)
-    assert !result.include?(["Missing package-info.java file.", 0])
+    assert result.include?(["Using the '.*' form of import should be avoided - java.util.*.", 1])
+  end
+
+  it "should error on bad custom config content" do
+    content = %Q[public class Sample {
+  public static void Sample() {
+  }
+
+  public void hi(long name) {
+    system.out.printf("Hi, " + name);
+  }
+}]
+    config_content = %Q[<?xml version="1.0"?>
+<!DOCTYPE module PUBLIC
+          "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
+          "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
+<module name="Checker">
+  <module name="AvoidStarImport"/>
+</module>]
+    assert_raises(RuntimeError) { Jlint.new(config_content).lint(content) }
+  end
+
+  it "should error on bad XML" do
+    content = %Q[public class Sample {
+  public static void Sample() {
+  }
+
+  public void hi(long name) {
+    system.out.printf("Hi, " + name);
+  }
+}]
+    config_content = %Q[<?xml version="1.0"?>
+<!DOCTYPE module PUBLIC
+          "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
+          "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
+<module name="Checker">
+  <module name="AvoidStarImport"/>
+</module]
+    assert_raises(RuntimeError) { Jlint.new(config_content).lint(content) }
   end
 
 end

data/test/support/custom_config_errors.yml

@@ -0,0 +1,15 @@
+---
+- - Missing a Javadoc comment.
+  - 1
+- - Missing a Javadoc comment.
+  - 2
+- - Method Name 'Sample' must not equal the enclosing class name.
+  - 2
+- - Name 'Sample' must match pattern '^[a-z][a-zA-Z0-9]*$'.
+  - 2
+- - Method 'hi' is not designed for extension - needs to be abstract, final or empty.
+  - 5
+- - Missing a Javadoc comment.
+  - 5
+- - Parameter name should be final.
+  - 5

data/test/support/sample_errors.yml

@@ -0,0 +1,15 @@
+---
+- - Missing a Javadoc comment.
+  - 1
+- - Missing a Javadoc comment.
+  - 2
+- - Method Name 'Sample' must not equal the enclosing class name.
+  - 2
+- - Name 'Sample' must match pattern '^[a-z][a-zA-Z0-9]*$'.
+  - 2
+- - Method 'hi' is not designed for extension - needs to be abstract, final or empty.
+  - 5
+- - Missing a Javadoc comment.
+  - 5
+- - Parameter name should be final.
+  - 5

metadata

@@ -1,72 +1,75 @@
 --- !ruby/object:Gem::Specification
 name: jlint
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - soffolk
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-22 00:00:00.000000000 Z
+date: 2015-04-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: 'Ruby Warp for CheckStyle: https://github.com/checkstyle/checkstyle'
 email:
 - zlx.star@gmail.com
 executables:
-- checkstyle.jar
+- checkstyle-6.5-all.jar
+- current
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
+- ".travis.yml"
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile
-- bin/checkstyle.jar
+- bin/checkstyle-6.5-all.jar
+- bin/current
 - doc/google_checks.xml
 - doc/sun_checks.xml
 - jlint.gemspec
@@ -74,7 +77,9 @@ files:
 - lib/jlint/version.rb
 - test/jlint/test_jlint.rb
 - test/support/custom.xml
+- test/support/custom_config_errors.yml
 - test/support/sample.java
+- test/support/sample_errors.yml
 - test/test_helper.rb
 homepage: ''
 licenses:
@@ -86,23 +91,24 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: 'Ruby Warp for CheckStyle: https://github.com/checkstyle/checkstyle'
 test_files:
 - test/jlint/test_jlint.rb
 - test/support/custom.xml
+- test/support/custom_config_errors.yml
 - test/support/sample.java
+- test/support/sample_errors.yml
 - test/test_helper.rb
-has_rdoc: