jlint 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ac58a70f61ad72118a655e61ce7344dbe4aeb162
-  data.tar.gz: c62d20259cef8cf7f5aecc578d3c54a16111fc0a
+  metadata.gz: b6813c93f52c5132c0563f58f28b5765881688eb
+  data.tar.gz: 9e33d6836d5419f85f930b838944b25512ac193e
 SHA512:
-  metadata.gz: 4b3719d2be30d246557136348841b52f1d30b9781fe1a70e5011164beb09c7b4f531e33f1c68ea82b83af17acf3ffc9ffd105954b26ab435c9f3121fac6931bc
-  data.tar.gz: e28edb10669f82f1afb4018ec3f1981247c0c03869b015d6d101281eff71f95e781fb8fd1cf2f0c88b2b505f494e6c3ca9eda8212ac78e000efc48b274944440
+  metadata.gz: 27c3d746cf4e26ec606298506de467807589cf2460159cd10d5f013fa3c55ea832b093f7b04fa7865233a700f62fa72150a5d11d1bb5a47c41251ce82bb1c11f
+  data.tar.gz: 8158c782278d8a1460a7c7b2dc0241d4e808a85f9c53c9c948355cd3fe97a1ab206ddb572a3682d47c62851a74c22cb3964958494d2f873a058ea5eea2326cf6

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    jlint (0.0.1)
+    jlint (0.1.0)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -25,7 +25,14 @@ Or install it yourself as:
 ## Usage
 
 ```ruby
-  Jlint.lint(content, config)  # [message, line]
+  Jlint.lint(content)         #=> [[message, line], ...]
+  Jlint.file_lint(file_path)  #=> [[message, line], ...]
+
+# Default it use [sun checks]()
+# If Want to custom config
+
+  lint = Jlint.new(config_content)
+  lint.lint(content)          #=> [[message, line], ...]
 ```
 
 ## Contributing

data/lib/jlint.rb

@@ -1,10 +1,67 @@
-require 'jlint/base'
-module Jlint
-  def self.lint content, config
-    Base.new.lint content, config
+require 'tempfile'
+class Jlint
+  def self.lint content
+    new.lint content
   end
 
-  def self.file_lint file_path, config
-    Base.new.file_lint file_path, config
+  def self.file_lint file_path
+    new.file_lint file_path
+  end
+
+
+  def initialize custom_config = nil
+    @custom_config = custom_config
+  end
+
+  def lint content
+    as_file content do |file|
+      file_lint file.path
+    end
+  end
+
+  def file_lint file_path
+    if @custom_config
+      as_file @custom_config, ".xml" do |file|
+        parse_lint checkstyle_command, file.path, file_path
+      end
+    else
+      parse_lint checkstyle_command, checkstyle_config, file_path
+    end
+  end
+
+  private
+
+  def parse_lint command, config_path, file_path
+    parse `java -jar #{checkstyle_command} -c #{config_path} #{file_path}`
+  end
+
+  def as_file content, format = ".java"
+    file = Tempfile.new(["temp", format])
+    begin
+      file.puts content
+      file.rewind
+      file.close
+
+      yield file
+    ensure
+      file.unlink
+    end
+  end
+
+  def checkstyle_command
+    File.join(File.dirname(__FILE__), '..', 'bin', 'checkstyle.jar')
+  end
+
+  def checkstyle_config
+    File.join(File.dirname(__FILE__), '..', 'doc', 'sun_checks.xml')
+  end
+
+  def parse results
+    array = results.split("\n")
+    array.reject! { |s| s == 'Starting audit...' || s == 'Audit done.' }
+    array.map! do |msg|
+      msgs = msg.split(":")
+      [msgs.last.strip, msgs[1].to_i]
+    end
   end
 end

data/lib/jlint/version.rb

@@ -1,3 +1,3 @@
-module Jlint
-  VERSION = '0.1.0'
+class Jlint
+  VERSION = '0.1.2'
 end

data/test/jlint/test_jlint.rb

@@ -4,7 +4,7 @@ describe Jlint do
 
   it "should lint for file_path" do
     file_path = File.join(File.dirname(__FILE__), "..", "support", "sample.java")
-    result = Jlint.file_lint(file_path, "")
+    result = Jlint.file_lint(file_path)
     assert result.is_a?(Array)
     assert result.include?(["Missing package-info.java file.", 0])
   end
@@ -18,10 +18,30 @@ describe Jlint do
     system.out.printf("Hi, " + name);
   }
 }]
-    result = Jlint.lint(content, "")
+    result = Jlint.lint(content)
     assert result.is_a?(Array)
     assert !result.include?(["File does not end with a newline.", 0])
     assert result.include?(["Missing package-info.java file.", 0])
   end
 
+  it "should lint with custom config content" do
+    content = %Q[public class Sample {
+  public static void Sample() {
+  }
+
+  public void hi(long name) {
+    system.out.printf("Hi, " + name);
+  }
+}]
+    config_content = %Q[<?xml version="1.0"?>
+<!DOCTYPE module PUBLIC
+          "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
+          "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
+<module name="Checker">
+</module>]
+    result = Jlint.new(config_content).lint(content)
+    assert result.is_a?(Array)
+    assert !result.include?(["Missing package-info.java file.", 0])
+  end
+
 end

data/test/support/custom.xml

@@ -0,0 +1,6 @@
+<?xml version="1.0"?>
+<!DOCTYPE module PUBLIC
+          "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
+          "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
+<module name="Checker">
+</module>

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: jlint
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - soffolk
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-21 00:00:00.000000000 Z
+date: 2014-10-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -71,9 +71,9 @@ files:
 - doc/sun_checks.xml
 - jlint.gemspec
 - lib/jlint.rb
-- lib/jlint/base.rb
 - lib/jlint/version.rb
 - test/jlint/test_jlint.rb
+- test/support/custom.xml
 - test/support/sample.java
 - test/test_helper.rb
 homepage: ''
@@ -102,6 +102,7 @@ specification_version: 4
 summary: 'Ruby Warp for CheckStyle: https://github.com/checkstyle/checkstyle'
 test_files:
 - test/jlint/test_jlint.rb
+- test/support/custom.xml
 - test/support/sample.java
 - test/test_helper.rb
 has_rdoc: 

data/lib/jlint/base.rb

@@ -1,44 +0,0 @@
-require 'tempfile'
-
-module Jlint
-  class Base
-    def initialize
-    end
-
-    def lint content, config
-      file = Tempfile.new(["temp", ".java"])
-      begin
-        file.puts content
-        file.rewind
-        file.close
-
-        file_lint file.path, config
-      ensure
-        file.unlink
-      end
-    end
-
-    def file_lint file_path, config
-      parse `java -jar #{checkstyle_command} -c #{checkstyle_config} #{file_path}`
-    end
-
-    private
-
-    def checkstyle_command
-      File.join(File.dirname(__FILE__), '..', '..', 'bin', 'checkstyle.jar')
-    end
-
-    def checkstyle_config
-      File.join(File.dirname(__FILE__), '..', '..', 'doc', 'sun_checks.xml')
-    end
-
-    def parse results
-      array = results.split("\n")
-      array.reject! { |s| s == 'Starting audit...' || s == 'Audit done.' }
-      array.map! do |msg|
-        msgs = msg.split(":")
-        [msgs.last.strip, msgs[1].to_i]
-      end
-    end
-  end
-end