jiraSOAP 0.2.1 → 0.2.2

data/lib/jiraSOAP/remoteAPI.rb

@@ -148,11 +148,13 @@ module RemoteAPI
   # Gets ALL avatars for a given project use this method; if you
   # just want the default avatar, use {#get_project_avatar_for_key}.
   # @param [String] project_key
+  # @param [boolean] include_default_avatars
   # @return [[JIRA::Avatar]]
-  def get_project_avatars_for_key(project_key)
+  def get_project_avatars_for_key(project_key, include_default_avatars = false)
     response = invoke('soap:getProjectAvatars') { |msg|
       msg.add 'soap:in0', @auth_token
       msg.add 'soap:in1', project_key
+      msg.add 'soap:in2', include_default_avatars
     }
     response.document.xpath("#{RESPONSE_XPATH}/getProjectAvatarsReturn").map {
       |frag|
@@ -162,11 +164,15 @@ module RemoteAPI
 
   # This method is the equivalent of making an advanced search from the
   # web interface.
+  #
+  # During my own testing, I found that HTTP requests could timeout for really
+  # large requests (~2500 results). So I set a more reasonable upper limit;
+  # feel free to override it, but be aware of the potential issues.
   # @param [String] jql_query JQL query as a string
   # @param [Fixnum] max_results limit on number of returned results;
   #  the value may be overridden by the server if max_results is too large
   # @return [[JIRA::Issue]]
-  def get_issues_from_jql_search(jql_query, max_results = 500)
+  def get_issues_from_jql_search(jql_query, max_results = 2000)
     response = invoke('soap:getIssuesFromJqlSearch') { |msg|
       msg.add 'soap:in0', @auth_token
       msg.add 'soap:in1', jql_query
@@ -243,7 +249,7 @@ module RemoteAPI
       msg.add 'soap:in1', issue_key
     }
     frag = response.document.xpath '//getIssueReturn'
-    JIRA:Issue.issue_with_xml_fragment frag
+    JIRA::Issue.issue_with_xml_fragment frag
   end
 
   # @todo test this method

data/lib/jiraSOAP/remoteEntities.rb

@@ -14,8 +14,9 @@ class Priority
     priority.id          = frag.xpath('id').to_s
     priority.name        = frag.xpath('name').to_s
     priority.color       = frag.xpath('color').to_s
-    priority.icon        = URL.new frag.xpath('icon').to_s
     priority.description = frag.xpath('description').to_s
+    url                  = frag.xpath('icon').to_s
+    priority.icon        = URL.new url unless url.nil?
     priority
   end
 end
@@ -32,8 +33,9 @@ class Resolution
     resolution             = Resolution.new
     resolution.id          = frag.xpath('id').to_s
     resolution.name        = frag.xpath('name').to_s
-    resolution.icon        = URL.new frag.xpath('icon').to_s
     resolution.description = frag.xpath('description').to_s
+    url                    = frag.xpath('icon').to_s
+    resolution.icon        = url unless url.nil?
     resolution
   end
 end
@@ -100,9 +102,10 @@ class IssueType
     issue_type             = IssueType.new
     issue_type.id          = frag.xpath('id').to_s
     issue_type.name        = frag.xpath('name').to_s
-    issue_type.icon        = URL.new frag.xpath('icon').to_s
     issue_type.subtask     = frag.xpath('subtask').to_s == 'true'
     issue_type.description = frag.xpath('description').to_s
+    url                    = frag.xpath('icon').to_s
+    issue_type.icon        = URL.new url unless url.nil?
     issue_type
   end
 end
@@ -121,11 +124,13 @@ class Comment
     comment.id              = frag.xpath('id').to_s
     comment.original_author = frag.xpath('author').to_s
     comment.body            = frag.xpath('body').to_s
-    comment.create_date     = Time.xmlschema frag.xpath('created').to_s
     comment.group_level     = frag.xpath('updateAuthor').to_s
     comment.role_level      = frag.xpath('roleLevel').to_s
     comment.update_author   = frag.xpath('updateAuthor').to_s
-    comment.last_updated    = Time.xmlschema frag.xpath('updated').to_s
+    date = frag.xpath('created').to_s
+    comment.create_date     = Time.xmlschema date unless date.nil?
+    date = frag.xpath('updated').to_s
+    comment.last_updated    = Time.xmlschema date unless date.nil?
     comment
   end
 
@@ -155,8 +160,9 @@ class Status
     status             = Status.new
     status.id          = frag.xpath('id').to_s
     status.name        = frag.xpath('name').to_s
-    status.icon        = URL.new frag.xpath('icon').to_s
     status.description = frag.xpath('description').to_s
+    url                = frag.xpath('icon').to_s
+    status.icon        = URL.new url unless url.nil?
     status
   end
 end
@@ -184,7 +190,8 @@ class Version
     version.sequence     = frag.xpath('sequence').to_s.to_i
     version.released     = frag.xpath('released').to_s == 'true'
     version.archived     = frag.xpath('archived').to_s == 'true'
-    version.release_date = Time.xmlschema frag.xpath('releaseDate')
+    date = frag.xpath('releaseDate').to_s
+    version.release_date = Time.xmlschema date unless date.nil?
     version
   end
 
@@ -260,8 +267,6 @@ class Project
     project.id                    = frag.xpath('id').to_s
     project.name                  = frag.xpath('name').to_s
     project.key                   = frag.xpath('key').to_s
-    project.url                   = URL.new frag.xpath('url').to_s
-    project.project_url           = URL.new frag.xpath('projectUrl').to_s
     project.lead                  = frag.xpath('lead').to_s
     project.description           = frag.xpath('description').to_s
     project.issue_security_scheme =
@@ -270,6 +275,10 @@ class Project
       Scheme.scheme_with_xml_fragment frag.xpath 'notificationScheme'
     project.permission_scheme     =
       PermissionScheme.scheme_with_xml_fragment frag.xpath 'permissionScheme'
+    url                           = frag.xpath('url').to_s
+    project.url                   = URL.new url unless url.nil?
+    url                           = frag.xpath('projectUrl').to_s
+    project.project_url           = URL.new url unless url.nil?
     project
   end
 
@@ -352,17 +361,20 @@ class Issue
     issue.summary             = frag.xpath('summary').to_s
     issue.description         = frag.xpath('description').to_s
     issue.type_id             = frag.xpath('type').to_s
-    issue.last_updated        = Time.xmlschema frag.xpath('updated').to_s
     issue.votes               = frag.xpath('votes').to_s.to_i
     issue.status_id           = frag.xpath('status').to_s
     issue.assignee_name       = frag.xpath('assignee').to_s
     issue.reporter_name       = frag.xpath('reporter').to_s
     issue.priority_id         = frag.xpath('priority').to_s
     issue.project_name        = frag.xpath('project').to_s
-    issue.create_date         = Time.xmlschema frag.xpath('created').to_s
-    issue.due_date            = Time.xmlschema frag.xpath('duedate').to_s
     issue.resolution_id       = frag.xpath('resolution').to_s
     issue.environment         = frag.xpath('environment').to_s
+    date = frag.xpath('updated').to_s
+    issue.last_updated        = Time.xmlschema date unless date.nil?
+    date = frag.xpath('updated').to_s
+    issue.create_date         = Time.xmlschema date unless date.nil?
+    date = frag.xpath('updated').to_s
+    issue.due_date            = Time.xmlschema date unless date.nil?
     issue
   end
 
@@ -482,13 +494,14 @@ class AttachmentMetadata
   # @return [JIRA::Attachment,nil]
   def self.attachment_with_xml_fragment(frag)
     return if frag.nil?
-    attachment             = Attachment.new
+    attachment             = AttachmentMetadata.new
     attachment.id          = frag.xpath('id').to_s
     attachment.author      = frag.xpath('author').to_s
-    attachment.create_date = Time.xmlschema frag.xpath('created').to_s
     attachment.filename    = frag.xpath('filename').to_s
     attachment.file_size   = frag.xpath('filesize').to_s.to_i
     attachment.mime_type   = frag.xpath('mimetype').to_s
+    date = frag.xpath('created').to_s
+    attachment.create_date = Time.xmlschema date unless date.nil?
     attachment
   end
 end
@@ -504,13 +517,15 @@ class ServerInfo
   def self.server_info_with_xml_fragment(frag)
     return if frag.nil?
     server_info = ServerInfo.new
-    server_info.base_url     = URL.new frag.xpath('baseUrl').to_s
-    server_info.build_date   = Time.xmlschema frag.xpath('buildDate').to_s
     server_info.build_number = frag.xpath('buildNumber').to_s.to_i
     server_info.edition      = frag.xpath('edition').to_s
     server_info.version      = frag.xpath('version').to_s
+    date = frag.xpath('buildDate').to_s
+    server_info.build_date   = Time.xmlschema date unless date.nil?
     server_info.server_time  =
       TimeInfo.time_info_with_xml_fragment frag.xpath 'serverTime'
+    url                      = frag.xpath('baseUrl').to_s
+    server_info.base_url     = URL.new url unless url.nil?
     server_info
   end
 end

data/lib/jiraSOAP/url.rb

@@ -14,6 +14,13 @@ class URL
     @url = URI.parse url
   end
 
+  # The to_s method technically exists and so method_missing would not
+  # work its magic to redirect it to @url so we manually override.
+  # @return [String]
+  def to_s
+    @url.to_s
+  end
+
   # The magic of the hack, passing everything to the level beneath.
   def method_missing(method, *args)
     @url.send method, *args

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 2
-  - 1
-  version: 0.2.1
+  - 2
+  version: 0.2.2
 platform: ruby
 authors: 
 - Mark Rada
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-10-13 00:00:00 -04:00
+date: 2010-10-20 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency