jev-feels 1.1.1 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 23595f1ad313a8a80834c59a33c8c4e5216e25a52319ec98bad95d1d56980702
-  data.tar.gz: aa494f3e27c534918c7c8ece6b2be0eec941ae85501e016476795a761a7bf9c3
+  metadata.gz: a3eece3f0263fb96e25774fc923368f688a0d9f9fa20d753b2def6fea8bd218c
+  data.tar.gz: 3c2c4aba985b8110c1911d7e3de1a75df6c7556a40925739c7b79edc576cc1e7
 SHA512:
-  metadata.gz: 15b77459470ea59576b87b94f66b1e3ff2ebd22944b81f15ab927a98f359714b6a9e7c717c7de01dea71d0b892c0ac68cf6655aab03c3ca80f6344cfb66cd404
-  data.tar.gz: 19f2f042a791762bcc11341a82f87a8e08b9af0b8fb104f9bf432d45c7361b991b1bc922e57f0ad081864afff9079c0747c9729e7e48877797b8754ac9b6a87f
+  metadata.gz: 01c48dd2cf71d607b8fb0b6fd26c07ef29db4730c3875c21f8a41c75a6522ab32fcaedf12f1c2c270267f12b7b05b414112abc7df1a6d99e1b2792a59e7746cc
+  data.tar.gz: 5b2125b7d7055fed2b99dc65694043f42af4cc8071c4e516803e960304172ccf6a632a69f11f82ac52ca679258b8c003784a2c1be3e83791f0b2cfa3fd0c0043

data/CHANGELOG.md

@@ -1,5 +1,18 @@
 # Changelog
 
+## 1.1.2
+
+### Fixed
+
+- Enforce a maximum of 255 Choice options and 10 Score levels for named and ad-hoc questions.
+- Generate Score stub probabilities between adjacent levels so their weighted mean matches the supplied score; reject out-of-range scores when generating probabilities.
+- Preserve explicitly supplied stub probabilities and confidence.
+
+### Changed
+
+- Simplify response parsing to JSON number and string key types, and require a definition when parsing Choice answers.
+- Read HTTP error details from `detail.message`; remove error-message redaction and truncation.
+
 ## 1.1.1
 
 ### Fixed

data/README.md

@@ -85,7 +85,7 @@ Jev.define :urgent, "Requires immediate attention or action"
 Jev.define :spam, "Unsolicited or unwanted promotional content"
 ```
 
-A decision (`decide`):
+A decision (`decide`), with up to 255 choices:
 
 ```ruby
 Jev.define :support_team,
@@ -98,7 +98,7 @@ Jev.define :support_team,
   }
 ```
 
-A scale (`score`). Hash order is low to high:
+A scale (`score`), with 2 to 10 levels. Hash order is low to high:
 
 ```ruby
 Jev.define :severity,
@@ -297,6 +297,8 @@ end
 
 A full `decide` / `score` stub is a hash with `choice` or `score`, plus `confidence` and `probabilities`. To own the HTTP shape, set `config.transport`.
 
+When Score probabilities are omitted, the stub distributes probability between adjacent levels so their weighted mean equals the score. The score must be within the declared scale (`0..levels.size - 1`); otherwise it raises `ArgumentError`. Explicit probabilities and confidence are preserved; confidence defaults to `1.0`.
+
 Record real answers and replay them later. Replay never uses the network. The tape matches the request (state and questions), not a queue index. API keys and Authorization headers are not stored.
 
 ```ruby
@@ -330,7 +332,7 @@ end
 
 ## Errors
 
-All errors inherit from `Jev::Error`. HTTP failures are wrapped; the original exception is available as `cause`. API keys are redacted from messages.
+All errors inherit from `Jev::Error`. HTTP failures are wrapped; the original exception is available as `cause`.
 
 | Error                       | When                                          |
 | --------------------------- | --------------------------------------------- |
@@ -346,4 +348,4 @@ Malformed definitions (`choices:` and `levels:` together, empty Choice, too few
 
 ## What this talks to
 
-[Jev](https://docs.typesafe.ai/introduction.md) / TypeSafe System One. `POST https://api.typesafe.ai/v1/systemone`. That is an implementation detail. The public API is `Jev.feels` / `Jev.feels?` / `Jev.decide` / `Jev.score` / `Jev.measure` / `Jev.match`.
+[Jev](https://docs.typesafe.ai/introduction.md) / TypeSafe System One. `POST https://api.typesafe.ai/v1/systemone`. That is an implementation detail. The public API is `Jev.feels` / `Jev.feels?` / `Jev.decide` / `Jev.score` / `Jev.measure` / `Jev.match`.

data/lib/jev/definition.rb

@@ -48,6 +48,7 @@ module Jev
     def self.normalize_choices(choices)
       raise ArgumentError, "choices must be a Hash" unless choices.is_a?(Hash)
       raise ArgumentError, "choices cannot be empty" if choices.empty?
+      raise ArgumentError, "choices must have at most 255 entries" if choices.size > 255
 
       unique_keys(choices, "choice").freeze
     end
@@ -56,6 +57,7 @@ module Jev
     def self.normalize_levels(levels)
       raise ArgumentError, "levels must be a Hash" unless levels.is_a?(Hash)
       raise ArgumentError, "levels must have at least 2 entries" if levels.size < 2
+      raise ArgumentError, "levels must have at most 10 entries" if levels.size > 10
 
       unique_keys(levels, "level").freeze
     end

data/lib/jev/harness.rb

@@ -233,9 +233,13 @@ module Jev
       end
 
       def default_score_probabilities(criteria, score)
-        size = [criteria.size, 1].max
-        nearest = Float(score).round.clamp(0, size - 1)
-        size.times.to_h { |index| [index.to_s, index == nearest ? 1.0 : 0.0] }
+        score = Float(score)
+        maximum = criteria.size - 1
+        unless score.finite? && score.between?(0, maximum)
+          raise ArgumentError, "stub score must be between 0 and #{maximum}"
+        end
+
+        criteria.size.times.to_h { |index| [index.to_s, [1.0 - (index - score).abs, 0.0].max] }
       end
 
       def score_probability_hash(probabilities, definition)

data/lib/jev/result.rb

@@ -15,14 +15,9 @@ module Jev
     end
 
     def self.finite_unit(value, label)
-      raise InvalidResponseError, "Jev response is missing #{label}" unless value.is_a?(Numeric)
+      raise InvalidResponseError, "Jev response is missing #{label}" unless value.is_a?(Integer) || value.is_a?(Float)
 
-      value = Float(value)
-      raise InvalidResponseError, "Jev #{label} is not finite" unless value.finite?
-
-      value
-    rescue ArgumentError, TypeError, RangeError
-      raise InvalidResponseError, "Jev #{label} is not a real number"
+      Float(value)
     end
 
     class Noul
@@ -35,13 +30,12 @@ module Jev
 
       def self.parse(answer)
         noul = answer["noul"]
-        raise InvalidResponseError, "Jev response is missing a noul probability" unless noul.is_a?(Numeric)
-
-        noul = Float(noul)
-        raise InvalidResponseError, "Jev noul probability is not finite" unless noul.finite?
+        unless noul.is_a?(Integer) || noul.is_a?(Float)
+          raise InvalidResponseError, "Jev response is missing a noul probability"
+        end
 
         # ponytail: clamp out-of-range noul; raise if Jev starts returning uncalibrated values
-        new(probability: noul.clamp(0.0, 1.0))
+        new(probability: Float(noul).clamp(0.0, 1.0))
       end
 
       def type
@@ -63,7 +57,7 @@ module Jev
         freeze
       end
 
-      def self.parse(answer, definition = nil)
+      def self.parse(answer, definition)
         winner = choice_key(answer["choice"], definition)
         new(
           choice: winner,
@@ -73,12 +67,8 @@ module Jev
       end
 
       def self.choice_key(key, definition)
-        unless key.is_a?(String) || key.is_a?(Symbol)
-          raise InvalidResponseError, "Jev response is missing a valid choice"
-        end
-        if definition && !definition.choices.key?(key.to_sym)
-          raise InvalidResponseError, "Jev response has an unknown choice"
-        end
+        raise InvalidResponseError, "Jev response is missing a valid choice" unless key.is_a?(String)
+        raise InvalidResponseError, "Jev response has an unknown choice" unless definition.choices.key?(key.to_sym)
 
         key.to_sym
       end
@@ -132,29 +122,21 @@ module Jev
 
         raw.to_h do |key, value|
           index = level_index(key, names)
-          [names ? names.fetch(index) : index, Result.finite_unit(value, "score probability")]
+          [names.fetch(index), Result.finite_unit(value, "score probability")]
         end.freeze
       end
 
       def self.level_index(key, names)
-        index = parse_index(key)
-        if index.negative? || (names && index >= names.size)
-          raise InvalidResponseError, "Jev score probability has an unknown level"
-        end
-
-        index
-      end
-      private_class_method :level_index
-
-      def self.parse_index(key)
-        return key if key.is_a?(Integer)
         unless key.is_a?(String) && key.match?(/\A\d+\z/)
           raise InvalidResponseError, "Jev score probabilities are not keyed by level number"
         end
 
-        Integer(key, 10)
+        index = Integer(key, 10)
+        raise InvalidResponseError, "Jev score probability has an unknown level" if index >= names.size
+
+        index
       end
-      private_class_method :parse_index
+      private_class_method :level_index
 
       def self.named_level(probabilities, names)
         return unless names

data/lib/jev/transport.rb

@@ -20,7 +20,7 @@ module Jev
     rescue Timeout::Error
       raise RequestError, "Jev request timed out"
     rescue SystemCallError, SocketError, IOError, OpenSSL::SSL::SSLError => e
-      raise RequestError, redact("Jev request failed: #{e.message}")
+      raise RequestError, "Jev request failed: #{e.message}"
     end
 
     private
@@ -104,32 +104,20 @@ module Jev
     end
 
     def error_detail(raw)
-      text = extract_error_message(raw)
-      return if text.nil? || text.empty?
-
-      redact(text)[0, 200]
-    end
-
-    def extract_error_message(raw)
       parsed = JSON.parse(raw)
-      return raw.strip unless parsed.is_a?(Hash)
+      return unless parsed.is_a?(Hash)
+
+      detail = parsed["detail"]
+      return unless detail.is_a?(Hash)
 
-      message = parsed.values_at("error", "message", "detail").compact.first
-      message = message["message"] if message.is_a?(Hash)
-      message.to_s
+      message = detail["message"]
+      message if message.is_a?(String) && !message.empty?
     rescue JSON::ParserError
-      raw.strip
+      nil
     end
 
     def join_detail(prefix, detail)
       detail ? "#{prefix}: #{detail}" : prefix
     end
-
-    def redact(text)
-      key = @configuration.api_key
-      return text.to_s if key.nil? || key.empty?
-
-      text.to_s.gsub(key, "[FILTERED]")
-    end
   end
 end

data/lib/jev/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Jev
-  VERSION = "1.1.1"
+  VERSION = "1.1.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: jev-feels
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - Maxim Veysgeym