jets 1.8.7 → 1.8.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '0431191b2ee4bd922dfbb1d04ded0d27c80b9d7f5fbe5b8ed0d82fb818805f06'
-  data.tar.gz: 7be272e9d21a1d65d0bfe1cbcce921f8492f37af1763fb183e06909f17cb830a
+  metadata.gz: 861a45e5f15d787a51c9abde8cf094196eeb903cbb84423a183807a0ab68f2f7
+  data.tar.gz: 8776f51765339cbbdc800370a11e0d689efa35bb9f6c9ed9533ab722bad962fc
 SHA512:
-  metadata.gz: 3e57ef81615d661a25d12e0503fd77b5622cdf2f78c837835aefdb6e26a261882b29b4b8c6226c1ede13561680986064a91dbe3ccb18c4df895ab30d5448acf0
-  data.tar.gz: a67756c55f8c52ff1f90279da7ed9dc156f5dbba676c5139b7c951aa5dde01a77c61fc576f85fa60ad8be24658e405d162105cc98f4a0a5dfff89c9ca47f8167
+  metadata.gz: 194965a1c5e47f505134a2baba4d1c513ecaa5d4357a22da5ca1a071b98a2a6cc303aafa9dba58944d5c2057cb8bb38d45e2e5fa2033adbc43c99174b8e915f6
+  data.tar.gz: d87196c44fd909bf9d88eff7d6b21f9808a56d09d586fc8fd9ab4a3edabf59142046151872e09d2976eb7a10808b88e48de674016068ac7c0696a66638e61900

data/.gitignore

@@ -21,3 +21,4 @@ demo*
 /html
 spec/fixtures/apps/franky/dynamodb/migrate
 Gemfile.lock 
+.byebug_history

data/CHANGELOG.md

@@ -3,6 +3,11 @@
 All notable changes to this project will be documented in this file.
 This project *loosely tries* to adhere to [Semantic Versioning](http://semver.org/).
 
+## [1.8.8]
+- #206 cache aws service clients globally for lambda performance
+- #211 Jets controller rescue_from support http://rubyonjets.com/docs/rescue-from/
+- #212 fix s3 event function for long bucket names
+
 ## [1.8.7]
 - #204 from CodingAnarchy/boot-missing-env
 - #205 rename to rule_event

data/lib/jets/aws_services.rb

@@ -10,59 +10,60 @@ require "aws-sdk-sns"
 require "aws-sdk-sqs"
 
 module Jets::AwsServices
-  autoload :StackStatus, 'jets/aws_services/stack_status'
+  autoload :GlobalMemoist, 'jets/aws_services/global_memoist'
   autoload :S3Bucket, 'jets/aws_services/s3_bucket'
+  autoload :StackStatus, 'jets/aws_services/stack_status'
 
+  include GlobalMemoist
   include StackStatus
-  extend Memoist
 
   def apigateway
     Aws::APIGateway::Client.new
   end
-  memoize :apigateway
+  global_memoize :apigateway
 
   def cfn
     Aws::CloudFormation::Client.new
   end
-  memoize :cfn
+  global_memoize :cfn
 
   def dynamodb
     Aws::DynamoDB::Client.new
   end
-  memoize :dynamodb
+  global_memoize :dynamodb
 
   def lambda
     Aws::Lambda::Client.new
   end
-  memoize :lambda
+  global_memoize :lambda
 
   def logs
     Aws::CloudWatchLogs::Client.new
   end
-  memoize :logs
+  global_memoize :logs
 
   def s3
     Aws::S3::Client.new
   end
-  memoize :s3
+  global_memoize :s3
 
   def s3_resource
     Aws::S3::Resource.new
   end
-  memoize :s3_resource
+  global_memoize :s3_resource
 
   def sns
     Aws::SNS::Client.new
   end
-  memoize :sns
+  global_memoize :sns
 
   def sqs
     Aws::SQS::Client.new
   end
-  memoize :sqs
+  global_memoize :sqs
 
   def sts
     Aws::STS::Client.new
   end
-  memoize :sts
+  global_memoize :sts
 end

data/lib/jets/aws_services/global_memoist.rb

@@ -0,0 +1,57 @@
+# We cache the clients globally to avoid re-instantiating them again after the initial Lambda cold start.
+#
+# Based on: https://hashrocket.com/blog/posts/implementing-a-macro-in-ruby-for-memoization
+# Except we use a global variable for the cache. So we'll use the same client across
+# all instances as well as across Lambda executions after the cold-start. Example:
+#
+#   class Foo
+#     def s3
+#       Aws::S3::Client.new
+#     end
+#     global_memoize :s3
+#   end
+#
+#   foo1 = Foo.new
+#   foo2 = Foo.new
+#   foo1.s3
+#   foo2.s3 # same client as foo1
+#
+# A prewarmed request after a cold-start will still use the same s3 client instance since it uses the
+# global variable $__memo_methods as the cache.
+#
+module Jets::AwsServices
+  module GlobalMemoist
+    def self.included(klass)
+      klass.extend(Macros)
+    end
+
+    module Macros
+      def global_memoize(*methods)
+        const_defined?(:"GlobalMemoist#{self.object_id}") ?
+          const_get(:"GlobalMemoist#{self.object_id}") : const_set(:"GlobalMemoist#{self.object_id}", Module.new)
+        mod = const_get(:"GlobalMemoist#{self.object_id}")
+
+        mod.class_eval do
+          methods.each do |method|
+            define_method(method) do |skip_cache = false|
+              $__memo_methods ||= {}
+              if $__memo_methods.include?(method) && !skip_cache
+                $__memo_methods[method]
+              else
+                $__memo_methods[method] = super()
+              end
+            end
+          end
+        end
+        prepend mod
+      end
+
+      def global_memoize_class_method(*methods)
+        singleton_class.class_eval do
+          include GlobalMemoist
+          global_memoize(*methods)
+        end
+      end
+    end
+  end
+end

data/lib/jets/controller/base.rb

@@ -9,6 +9,7 @@ class Jets::Controller
     include Layout
     include Params
     include Rendering
+    include ActiveSupport::Rescuable
 
     delegate :headers, to: :request
     delegate :set_header, to: :response
@@ -37,19 +38,24 @@ class Jets::Controller
       t1 = Time.now
       log_info_start
 
-      if run_before_actions(break_if: -> { @rendered })
-        send(@meth)
+      begin
+        if run_before_actions(break_if: -> { @rendered })
+          send(@meth)
+          action_completed = true
+        else
+          Jets.logger.info "Filter chain halted as #{@last_callback_name} rendered or redirected"
+        end
+        
         triplet = ensure_render
-        run_after_actions
-      else
-        Jets.logger.info "Filter chain halted as #{@last_callback_name} rendered or redirected"
+        run_after_actions if action_completed
+      rescue Exception => exception
+        rescue_with_handler(exception) || raise
         triplet = ensure_render
       end
 
       took = Time.now - t1
       status = triplet[0]
       Jets.logger.info "Completed Status Code #{status} in #{took}s"
-
       triplet # status, headers, body
     end
 

data/lib/jets/controller/callbacks.rb

@@ -4,10 +4,8 @@ class Jets::Controller
   module Callbacks
     extend ActiveSupport::Concern
     included do
-      class_attribute :before_actions
-      self.before_actions = []
-      class_attribute :after_actions
-      self.after_actions = []
+      class_attribute :before_actions, default: []
+      class_attribute :after_actions, default: []
 
       class << self
         def before_action(meth, options={})

data/lib/jets/stack/main/extensions/lambda.rb

@@ -38,7 +38,7 @@ module Jets::Stack::Main::Dsl
       }
 
       function_name = "#{Jets.config.project_namespace}-#{class_namespace}-#{meth}"
-      function_name.size > MAX_FUNCTION_NAME_SIZE ? nil : function_name
+      function_name = function_name.size > MAX_FUNCTION_NAME_SIZE ? nil : function_name
       defaults[:function_name] = function_name if function_name
 
       props = defaults.merge(props)

data/lib/jets/version.rb

@@ -1,3 +1,3 @@
 module Jets
-  VERSION = "1.8.7"
+  VERSION = "1.8.8"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: jets
 version: !ruby/object:Gem::Version
-  version: 1.8.7
+  version: 1.8.8
 platform: ruby
 authors:
 - Tung Nguyen
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-02-19 00:00:00.000000000 Z
+date: 2019-03-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionmailer
@@ -494,6 +494,7 @@ files:
 - lib/jets/application.rb
 - lib/jets/aws_info.rb
 - lib/jets/aws_services.rb
+- lib/jets/aws_services/global_memoist.rb
 - lib/jets/aws_services/s3_bucket.rb
 - lib/jets/aws_services/stack_status.rb
 - lib/jets/booter.rb