jets 0.6.9 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 557604f70083b13e25eb88496bbc2709d715688386e6cea83fc6d84d9c830799
-  data.tar.gz: 618b800e673d812303e28411d8cc16304777141a195c2ddd3029f416ed755591
+  metadata.gz: 9aa29acf2df1aa6895322b3ca3b552ec19588dfbf30572c1c48669c49476fa5b
+  data.tar.gz: f8447813c033772d32e7799f6163cebfb5db60d2e44b7538a500e90c4750db6f
 SHA512:
-  metadata.gz: 25c15f2f3f7ecf2d5b40ade99d990d2548be2c03f4a4312616aecff04482ca6a193a100e0c4851572ee3692b91534811f431c51640aff718645e7447fa4950b9
-  data.tar.gz: 9e16e4ad95fd469021853e328e982c22eed8dff9e85feb7f77c1a216c407e7239715399255afa0770f813858129b45707e1563673a2dfe25046c009ac8bf8463
+  metadata.gz: 55c640eb1ce2bce89e4e8d22756491c0bef3d29a692ffa67ece43f8a9be202e0f79853347b02fba4e29272c98bbdda08f048cdffd0bfd4ce8ba6aa2898850ba3
+  data.tar.gz: ccd75d822e8289486b14839499c6bf69e907fcd7b8a22a138f25189bb31ae5d78db3adcf2763c31cb0acb6ece0a7892ed5d27a3353af10ec7d36533fc52f2463

data/CHANGELOG.md

@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 This project *loosely tries* to adhere to [Semantic Versioning](http://semver.org/), even before v1.0.
 
+## [0.7.0]
+- add managed_iam_policy concept, pull request #19
+- bump to 0.7.0, enough changes since 0.6.x
+
 ## [0.6.9]
 - add aws managed rule support, pull request #18
 

data/Gemfile.lock

@@ -11,7 +11,7 @@ GIT
 PATH
   remote: .
   specs:
-    jets (0.6.9)
+    jets (0.7.0)
       actionpack (>= 5.2.1)
       actionview (>= 5.2.1)
       activerecord (>= 5.2.1)

data/lib/jets/cfn/template_builders.rb

@@ -20,5 +20,6 @@ class Jets::Cfn
     # separate beasts:
     autoload :FunctionProperties, "jets/cfn/template_builders/function_properties" # sort of a builder
     autoload :IamPolicy, "jets/cfn/template_builders/iam_policy" # resource only
+    autoload :ManagedIamPolicy, "jets/cfn/template_builders/managed_iam_policy" # resource only
   end
 end

data/lib/jets/cfn/template_builders/base_child_builder.rb

@@ -20,10 +20,10 @@ class Jets::Cfn::TemplateBuilders
     end
 
     def add_functions
-      add_class_iam_policy if @app_klass.class_iam_policy
+      add_class_iam_policy
       @app_klass.tasks.each do |task|
         add_function(task)
-        add_iam_policy(task) if task.iam_policy
+        add_function_iam_policy(task)
       end
     end
 
@@ -38,13 +38,17 @@ class Jets::Cfn::TemplateBuilders
     end
 
     def add_class_iam_policy
+      return unless @app_klass.build_class_iam?
+
       map = Jets::Cfn::TemplateMappers::IamPolicy::ClassPolicyMapper.new(@app_klass)
       logical_id = map.logical_id
       properties = map.properties
       add_resource(logical_id, "AWS::IAM::Role", properties)
     end
 
-    def add_iam_policy(task)
+    def add_function_iam_policy(task)
+      return unless task.build_function_iam?
+
       map = Jets::Cfn::TemplateMappers::IamPolicy::FunctionPolicyMapper.new(task)
       logical_id = map.logical_id
       properties = map.properties

data/lib/jets/cfn/template_builders/function_properties/base_builder.rb

@@ -88,7 +88,7 @@ module Jets::Cfn::TemplateBuilders::FunctionProperties
       # klass is PostsController, HardJob, GameRule, Hello or HelloFunction
       klass = Jets::Klass.from_task(@task)
       class_properties = klass.class_properties
-      if klass.class_iam_policy
+      if klass.build_class_iam?
         map = Jets::Cfn::TemplateMappers::IamPolicy::ClassPolicyMapper.new(klass)
         class_properties[:Role] = "!GetAtt #{map.logical_id}.Arn"
       end
@@ -112,7 +112,7 @@ module Jets::Cfn::TemplateBuilders::FunctionProperties
     #
     def function_properties
       properties = @task.properties
-      if @task.iam_policy
+      if @task.build_function_iam?
         map = Jets::Cfn::TemplateMappers::IamPolicy::FunctionPolicyMapper.new(@task)
         properties[:Role] = "!GetAtt #{map.logical_id}.Arn"
       end

data/lib/jets/cfn/template_builders/iam_policy/application_policy.rb

@@ -6,7 +6,8 @@ module Jets::Cfn::TemplateBuilders::IamPolicy
   class ApplicationPolicy < BasePolicy
     def initialize
       setup
-      @definitions = Jets.config.iam_policy || [] # config.iam_policy contains definitions
+      @definitions = Jets.config.iam_policy # config.iam_policy contains definitions
+      @definitions = [@definitions].flatten if @definitions
     end
 
     # Example: PostsControllerPolicy or SleepJobPolicy

data/lib/jets/cfn/template_builders/managed_iam_policy.rb

@@ -0,0 +1,6 @@
+module Jets::Cfn::TemplateBuilders::ManagedIamPolicy
+  autoload :ApplicationPolicy, "jets/cfn/template_builders/managed_iam_policy/application_policy"
+  autoload :BasePolicy, "jets/cfn/template_builders/managed_iam_policy/base_policy"
+  autoload :ClassPolicy, "jets/cfn/template_builders/managed_iam_policy/class_policy"
+  autoload :FunctionPolicy, "jets/cfn/template_builders/managed_iam_policy/function_policy"
+end

data/lib/jets/cfn/template_builders/managed_iam_policy/application_policy.rb

@@ -0,0 +1,11 @@
+# Implements:
+#   initialize
+#
+module Jets::Cfn::TemplateBuilders::ManagedIamPolicy
+  class ApplicationPolicy < BasePolicy
+    def initialize
+      @definitions = Jets.config.managed_iam_policy # config.managed_iam_policy contains definitions
+      @definitions = [@definitions].flatten if @definitions
+    end
+  end
+end

data/lib/jets/cfn/template_builders/managed_iam_policy/base_policy.rb

@@ -0,0 +1,22 @@
+# Classes that inherit this Base class should implement:
+#
+#   initialize - each initializer has a different signature
+#
+module Jets::Cfn::TemplateBuilders::ManagedIamPolicy
+  class BasePolicy
+    extend Memoist
+    attr_reader :definitions
+
+    def arns
+      definitions.map { |definition| standardize(definition) }
+    end
+    memoize :arns # only process arns once
+
+    # AmazonEC2ReadOnlyAccess => arn:aws:iam::aws:policy/AmazonEC2ReadOnlyAccess
+    def standardize(definition)
+      return definition if definition.include?('iam::aws:policy')
+
+      "arn:aws:iam::aws:policy/#{definition}"
+    end
+  end
+end

data/lib/jets/cfn/template_builders/managed_iam_policy/class_policy.rb

@@ -0,0 +1,10 @@
+# Implements:
+#   initialize
+#
+module Jets::Cfn::TemplateBuilders::ManagedIamPolicy
+  class ClassPolicy < BasePolicy
+    def initialize(app_class)
+      @definitions = app_class.class_managed_iam_policy || [] # contains definitions
+    end
+  end
+end

data/lib/jets/cfn/template_builders/managed_iam_policy/function_policy.rb

@@ -0,0 +1,10 @@
+# Implements:
+#   initialize
+#
+module Jets::Cfn::TemplateBuilders::ManagedIamPolicy
+  class FunctionPolicy < BasePolicy
+    def initialize(task)
+      @definitions = task.managed_iam_policy || [] # managed_iam_policy contains definitions
+    end
+  end
+end

data/lib/jets/cfn/template_mappers/iam_policy/application_policy_mapper.rb

@@ -2,6 +2,7 @@
 #
 #   initialize
 #   iam_policy
+#   managed_iam_policy
 #   logical_id
 #   role_name
 #
@@ -9,11 +10,19 @@ module Jets::Cfn::TemplateMappers::IamPolicy
   class ApplicationPolicyMapper < BasePolicyMapper
     def initialize; end # does nothing
 
+    # Assume we always have at least some baseline iam policy permissions.
     def iam_policy
       Jets::Cfn::TemplateBuilders::IamPolicy::ApplicationPolicy.new
     end
     memoize :iam_policy
 
+    def managed_iam_policy
+      return unless Jets.config.managed_iam_policy
+
+      Jets::Cfn::TemplateBuilders::ManagedIamPolicy::ApplicationPolicy.new
+    end
+    memoize :managed_iam_policy
+
     # Example: PostsControllerLambdaFunction
     # Note there are is no "Show" action in the name
     def logical_id

data/lib/jets/cfn/template_mappers/iam_policy/base_policy_mapper.rb

@@ -2,6 +2,7 @@
 #
 #   initialize
 #   iam_policy
+#   managed_iam_policy
 #   logical_id
 #   role_name
 #
@@ -20,10 +21,14 @@ module Jets::Cfn::TemplateMappers::IamPolicy
           ]},
         Path: "/"
       }
+
       properties[:Policies] = [
         PolicyName: iam_policy.policy_name,
         PolicyDocument: iam_policy.policy_document,
-      ]
+      ] if iam_policy
+
+      properties[:ManagedPolicyArns] = managed_iam_policy.arns if managed_iam_policy
+
       properties[:RoleName] = role_name
       properties.deep_stringify_keys!
       properties

data/lib/jets/cfn/template_mappers/iam_policy/class_policy_mapper.rb

@@ -2,6 +2,7 @@
 #
 #   initialize
 #   iam_policy
+#   managed_iam_policy
 #   logical_id
 #   role_name
 #
@@ -13,10 +14,19 @@ module Jets::Cfn::TemplateMappers::IamPolicy
     end
 
     def iam_policy
+      return unless @app_class.class_iam_policy
+
       Jets::Cfn::TemplateBuilders::IamPolicy::ClassPolicy.new(@app_class)
     end
     memoize :iam_policy
 
+    def managed_iam_policy
+      return unless @app_class.class_managed_iam_policy
+
+      Jets::Cfn::TemplateBuilders::ManagedIamPolicy::ClassPolicy.new(@app_class)
+    end
+    memoize :managed_iam_policy
+
     # Example: PostsControllerLambdaFunction
     # Note there are is no "Show" action in the name
     # There should be no namespace in the logical_id.

data/lib/jets/cfn/template_mappers/iam_policy/function_policy_mapper.rb

@@ -2,6 +2,7 @@
 #
 #   initialize
 #   iam_policy
+#   managed_iam_policy
 #   logical_id
 #   role_name
 #
@@ -14,10 +15,19 @@ module Jets::Cfn::TemplateMappers::IamPolicy
     end
 
     def iam_policy
+      return unless @task.iam_policy
+
       Jets::Cfn::TemplateBuilders::IamPolicy::FunctionPolicy.new(@task)
     end
     memoize :iam_policy
 
+    def managed_iam_policy
+      return unless @task.managed_iam_policy
+
+      Jets::Cfn::TemplateBuilders::ManagedIamPolicy::FunctionPolicy.new(@task)
+    end
+    memoize :managed_iam_policy
+
     # Example: PostsControllerShowLambdaFunction
     # There should be no namespace in the logical_id.
     def logical_id

data/lib/jets/lambda/dsl.rb

@@ -80,7 +80,16 @@ module Jets::Lambda::Dsl
       end
       alias_method :props, :properties
 
-      # definitions: one more many definitions
+      # definitions: one or more definitions
+      def iam_policy(*definitions)
+        if definitions.empty?
+          @iam_policy
+        else
+          @iam_policy = definitions.flatten
+        end
+      end
+
+      # definitions: one or more definitions
       def class_iam_policy(*definitions)
         if definitions.empty?
           @class_iam_policy
@@ -89,15 +98,28 @@ module Jets::Lambda::Dsl
         end
       end
 
-      # definitions: one more many definitions
-      def iam_policy(*definitions)
+      # definitions: one or more definitions
+      def managed_iam_policy(*definitions)
         if definitions.empty?
-          @iam_policy
+          @managed_iam_policy
         else
-          @iam_policy = definitions.flatten
+          @managed_iam_policy = definitions.flatten
         end
       end
 
+      # definitions: one or more definitions
+      def class_managed_iam_policy(*definitions)
+        if definitions.empty?
+          @class_managed_iam_policy
+        else
+          @class_managed_iam_policy = definitions.flatten
+        end
+      end
+
+      def build_class_iam?
+        !!(class_iam_policy || class_managed_iam_policy)
+      end
+
       # meth is a Symbol
       def method_added(meth)
         return if %w[initialize method_missing].include?(meth.to_s)
@@ -111,7 +133,10 @@ module Jets::Lambda::Dsl
         # We adjust the class name when we build the functions later in
         # FunctionContstructor#adjust_tasks.
         all_tasks[meth] = Jets::Lambda::Task.new(self.name, meth,
-          properties: @properties, iam_policy: @iam_policy, lang: lang)
+          properties: @properties,
+          iam_policy: @iam_policy,
+          managed_iam_policy: @managed_iam_policy,
+          lang: lang)
 
         # Done storing options, clear out for the next added method.
         clear_properties
@@ -129,6 +154,7 @@ module Jets::Lambda::Dsl
       def clear_properties
         @properties = nil
         @iam_policy = nil
+        @managed_iam_policy = nil
       end
 
       # Returns the all tasks for this class with their method names as keys.

data/lib/jets/lambda/task.rb

@@ -1,6 +1,6 @@
 class Jets::Lambda::Task
   attr_accessor :class_name, :type
-  attr_reader :meth, :properties, :iam_policy, :lang
+  attr_reader :meth, :properties, :iam_policy, :managed_iam_policy, :lang
   def initialize(class_name, meth, options={})
     @class_name = class_name.to_s # use at EventsRuleMapper#full_task_name
     @meth = meth
@@ -8,9 +8,14 @@ class Jets::Lambda::Task
     @type = options[:type] || get_type  # controller, job, or function
     @properties = options[:properties] || {}
     @iam_policy = options[:iam_policy]
+    @managed_iam_policy = options[:managed_iam_policy]
     @lang = options[:lang] || :ruby
   end
 
+  def build_function_iam?
+    !!(@iam_policy || @managed_iam_policy)
+  end
+
   def name
     @meth
   end

data/lib/jets/version.rb

@@ -1,3 +1,3 @@
 module Jets
-  VERSION = "0.6.9"
+  VERSION = "0.7.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: jets
 version: !ruby/object:Gem::Version
-  version: 0.6.9
+  version: 0.7.0
 platform: ruby
 authors:
 - Tung Nguyen
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-08-28 00:00:00.000000000 Z
+date: 2018-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
@@ -446,6 +446,11 @@ files:
 - lib/jets/cfn/template_builders/iam_policy/function_policy.rb
 - lib/jets/cfn/template_builders/interface.rb
 - lib/jets/cfn/template_builders/job_builder.rb
+- lib/jets/cfn/template_builders/managed_iam_policy.rb
+- lib/jets/cfn/template_builders/managed_iam_policy/application_policy.rb
+- lib/jets/cfn/template_builders/managed_iam_policy/base_policy.rb
+- lib/jets/cfn/template_builders/managed_iam_policy/class_policy.rb
+- lib/jets/cfn/template_builders/managed_iam_policy/function_policy.rb
 - lib/jets/cfn/template_builders/parent_builder.rb
 - lib/jets/cfn/template_builders/rule_builder.rb
 - lib/jets/cfn/template_builders/templates/minimal-stack.yml