jemquarie 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c289fe5e228aaffc293c9c8ee06b376795c45529
-  data.tar.gz: 72287bf80cdaac015a1184d3d993d7c7f14e310f
+  metadata.gz: 34388f2aec3d3af4a4821cf685cc5fae4b6cd54e
+  data.tar.gz: 037df292b05aee50342735b33d205ab5d71119da
 SHA512:
-  metadata.gz: 6e194d5f02ac1b03f56957905abb3ef674c91546138e7f3f41a6d1f74dd25eaf3a0ebe1f2f8c1350476266de0e8429bf7cdd68c939f470d80ee72fbc37c3c232
-  data.tar.gz: 2ff5b231413c378e9232cda5fbb54d39008727e68e83f0d19b297010b746e8f606589e0ccf0e0b5e995a00c35e35a825ca019f71b3a1b2b1a931763cdabe2dc1
+  metadata.gz: 5eed3dd6865208966b511fdb72e34f7c97ab35b346a857080bb1210cf166aeac0e1fc6d4a69b96824261a84ec9f81cbcb7e091bbb005b43b5f4926e3dcd9a2fb
+  data.tar.gz: d3c8f58db1d1df2d16812f022dbe968b57f83c5e941a161f2e3c7f77cc2e31b0353ba390675899cf9e214615b06eceb267131c62b0458691ad578d5bf84f33e3

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    jemquarie (0.0.3)
+    jemquarie (0.0.4)
       activesupport (>= 3.0)
       savon (~> 2.0)
 

data/lib/jemquarie/parser/cash_transactions.rb

@@ -4,8 +4,10 @@ module Jemquarie
 
       def parse_cash_transactions_response(response)
         body = response.body
-        return {:error => "Invalid credentials"} unless body[:generate_xml_extract_response] && body[:generate_xml_extract_response][:result] && body[:generate_xml_extract_response][:result].is_a?(String)
+        return {:error => "Invalid Authentication Code or Authentication Password"} unless
+          body[:generate_xml_extract_response] && body[:generate_xml_extract_response][:result] && body[:generate_xml_extract_response][:result].is_a?(String)
         result = Hash.from_xml(Nokogiri::XML.fragment(body[:generate_xml_extract_response][:result]).to_s)
+        return {error: result["XMLExtract"]["RequestDetails"]["RequestErrorDetails"]} if result["XMLExtract"]["RequestDetails"]["RequestStatus"] == "Failure"
         transactions = []
         return transactions unless result["XMLExtract"] && result["XMLExtract"]["yourclientsTransactions"] && result["XMLExtract"]["yourclientsTransactions"]["yourclientsTransaction"]
         xml_transactions = if result["XMLExtract"]["yourclientsTransactions"]["yourclientsTransaction"].is_a?(Hash)

data/lib/jemquarie/version.rb

@@ -1,3 +1,3 @@
 module Jemquarie
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/files/wrong_account_number.xml

@@ -0,0 +1,19 @@
+<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
+  <soapenv:Body>
+    <ns1:GenerateXMLExtractResponse xmlns:ns1="wrapwebservices" soapenv:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/">
+      <result xsi:type="xsd:string">&lt;?xml version="1.0" ?&gt;
+&lt;XMLExtract&gt;
+  &lt;RequestDetails&gt;
+    &lt;RequestStatus&gt;Failure&lt;/RequestStatus&gt;
+    &lt;RequestErrorNumber&gt;V0001&lt;/RequestErrorNumber&gt;
+    &lt;RequestErrorDetails&gt;Invalid Account Number&lt;/RequestErrorDetails&gt;
+  &lt;/RequestDetails&gt;
+  &lt;XMLEntityDetails&gt;
+    &lt;XMLEntityName&gt;your.clients Transactions&lt;/XMLEntityName&gt;
+    &lt;XMLEntityVersion&gt;V1.4&lt;/XMLEntityVersion&gt;
+  &lt;/XMLEntityDetails&gt;
+&lt;/XMLExtract&gt;
+</result>
+    </ns1:GenerateXMLExtractResponse>
+  </soapenv:Body>
+</soapenv:Envelope>

data/spec/files/wrong_authentication.xml

@@ -0,0 +1,19 @@
+<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
+  <soapenv:Body>
+    <ns1:GenerateXMLExtractResponse xmlns:ns1="wrapwebservices" soapenv:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/">
+      <result xsi:type="xsd:string">&lt;?xml version="1.0" ?&gt;
+&lt;XMLExtract&gt;
+  &lt;RequestDetails&gt;
+    &lt;RequestStatus&gt;Failure&lt;/RequestStatus&gt;
+    &lt;RequestErrorNumber&gt;E0005&lt;/RequestErrorNumber&gt;
+    &lt;RequestErrorDetails&gt;Invalid Authentication Code or Authentication Password&lt;/RequestErrorDetails&gt;
+  &lt;/RequestDetails&gt;
+  &lt;XMLEntityDetails&gt;
+    &lt;XMLEntityName&gt;your.clients Transactions&lt;/XMLEntityName&gt;
+    &lt;XMLEntityVersion&gt;V1.4&lt;/XMLEntityVersion&gt;
+  &lt;/XMLEntityDetails&gt;
+&lt;/XMLExtract&gt;
+</result>
+    </ns1:GenerateXMLExtractResponse>
+  </soapenv:Body>
+</soapenv:Envelope>

data/spec/lib/importer_spec.rb

@@ -56,6 +56,23 @@ describe Jemquarie::Importer do
     end
   end
 
+  describe "no data" do
+    let(:importer) do
+      Jemquarie::Importer.new('valid_code', 'valid_password')
+    end
+    before(:each) do
+      FakeWeb.register_uri(:post, Jemquarie::Jemquarie::BASE_URI,
+        body: File.read('spec/files/no_data.xml'),
+        content_type: 'text/xml'
+      )
+      @result = importer.cash_transactions(Date.parse("01/01/2000"), Date.today, '12345')
+    end
+    it "should return an empty array" do
+      expect(@result).to be_kind_of Array
+      expect(@result).to eq([])
+    end
+  end
+
   describe "do not allow more than 2 days without an account number" do
     let(:importer) do
       Jemquarie::Importer.new('valid_code', 'valid_password')
@@ -68,7 +85,7 @@ describe Jemquarie::Importer do
     end
   end
 
-  describe "wrong auth" do
+  describe "non auth" do
     let(:importer) do
       Jemquarie::Importer.new('invalid_code', 'or_invalid_password')
     end
@@ -81,24 +98,41 @@ describe Jemquarie::Importer do
     end
     it "should return wrong authentication" do
       expect(@result).to be_kind_of Hash
-      expect(@result[:error]).to eq("Invalid credentials")
+      expect(@result[:error]).to eq("Invalid Authentication Code or Authentication Password")
     end
   end
 
-  describe "no data" do
+  describe "wrong auth" do
     let(:importer) do
-      Jemquarie::Importer.new('valid_code', 'valid_password')
+      Jemquarie::Importer.new('invalid_code', 'or_invalid_password')
     end
     before(:each) do
       FakeWeb.register_uri(:post, Jemquarie::Jemquarie::BASE_URI,
-        body: File.read('spec/files/no_data.xml'),
+        body: File.read('spec/files/wrong_authentication.xml'),
         content_type: 'text/xml'
       )
       @result = importer.cash_transactions(Date.parse("01/01/2000"), Date.today, '12345')
     end
-    it "should return an empty array" do
-      expect(@result).to be_kind_of Array
-      expect(@result).to eq([])
+    it "should return wrong authentication" do
+      expect(@result).to be_kind_of Hash
+      expect(@result[:error]).to eq("Invalid Authentication Code or Authentication Password")
+    end
+  end
+
+  describe "non existing account number" do
+    let(:importer) do
+      Jemquarie::Importer.new('valid_code', 'valid_password')
+    end
+    before(:each) do
+      FakeWeb.register_uri(:post, Jemquarie::Jemquarie::BASE_URI,
+        body: File.read('spec/files/wrong_account_number.xml'),
+        content_type: 'text/xml'
+      )
+      @result = importer.cash_transactions(Date.parse("01/01/2000"), Date.today, 'invalid')
+    end
+    it "should return wrong account number" do
+      expect(@result).to be_kind_of Hash
+      expect(@result[:error]).to eq("Invalid Account Number")
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: jemquarie
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Claudio Contin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-22 00:00:00.000000000 Z
+date: 2014-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
@@ -118,6 +118,8 @@ files:
 - spec/files/non_authenticated.xml
 - spec/files/single_transaction.xml
 - spec/files/transactions.xml
+- spec/files/wrong_account_number.xml
+- spec/files/wrong_authentication.xml
 - spec/lib/importer_spec.rb
 - spec/lib/jemquarie_spec.rb
 - spec/spec_helper.rb
@@ -150,6 +152,8 @@ test_files:
 - spec/files/non_authenticated.xml
 - spec/files/single_transaction.xml
 - spec/files/transactions.xml
+- spec/files/wrong_account_number.xml
+- spec/files/wrong_authentication.xml
 - spec/lib/importer_spec.rb
 - spec/lib/jemquarie_spec.rb
 - spec/spec_helper.rb