jeff 0.2.2 → 0.2.4

data/README.md

@@ -22,7 +22,7 @@ Customise default headers and parameters.
 class Client
   headers 'User-Agent' => 'Client'
   params  'Service'    => 'SomeService',
-          'Tag'        => Proc.new { tag }
+          'Tag'        => -> { tag }
 
   attr_accessor :tag
 end
@@ -80,7 +80,7 @@ class Logger
       $stderr.puts [
         params[:scheme],
         '://',
-        params[:host]
+        params[:host],
         '/',
         params[:path],
         '?',
@@ -95,9 +95,21 @@ client.get query:        {},
            instrumentor: Logger
 ```
 
-For more detailed configuration options, check out the [excon README][excon].
+### Miscellaneous
 
-[aws]:   http://aws.amazon.com/
-[excon]: https://github.com/geemus/excon
-[sign]:  http://docs.amazonwebservices.com/general/latest/gr/signature-version-2.html
-[jeff]:  http://f.cl.ly/items/0a3R3J0k1R2f423k1q2l/jeff.jpg
+HTTP connections are persistent.
+
+By default, Jeff will retry failed requests 4 times.
+
+For more detailed configuration options, check out [excon][excon].
+
+## Compatibility
+
+**Jeff** is Ruby 1.9-compatible. It is tested against [MRI 1.9.3 plus JRuby and
+Rubinius in 1.9 mode][travis].
+
+[aws]:    http://aws.amazon.com/
+[excon]:  https://github.com/geemus/excon
+[sign]:   http://docs.amazonwebservices.com/general/latest/gr/signature-version-2.html
+[jeff]:   http://f.cl.ly/items/0a3R3J0k1R2f423k1q2l/jeff.jpg
+[travis]: http://travis-ci.org/#!/hakanensari/jeff

data/lib/jeff.rb

@@ -19,13 +19,14 @@ module Jeff
 
   # Returns an Excon::Connection.
   def connection
-    @connection ||= Excon.new endpoint, :headers => default_headers
+    @connection ||= Excon.new endpoint, headers:    default_headers,
+                                        idempotent: true
   end
 
   # Returns the Hash default request parameters.
   def default_params
     self.class.params.reduce({}) do |a, (k, v)|
-      a.update k => (v.is_a?(Proc) ? instance_eval(&v) : v)
+      a.update k => (v.is_a?(Proc) ? instance_exec(&v) : v)
     end
   end
 
@@ -138,10 +139,10 @@ module Jeff
     # Returns the Hash parameters.
     def params(hsh = nil)
       @params ||= {
-        'AWSAccessKeyId'   => Proc.new { key },
+        'AWSAccessKeyId'   => -> { key },
         'SignatureVersion' => '2',
         'SignatureMethod'  => 'HmacSHA256',
-        'Timestamp'        => Proc.new { Time.now.utc.iso8601 }
+        'Timestamp'        => -> { Time.now.utc.iso8601 }
       }
       @params.update hsh if hsh
 

data/lib/jeff/version.rb

@@ -1,3 +1,3 @@
 module Jeff
-  VERSION = '0.2.2'
+  VERSION = '0.2.4'
 end

data/spec/jeff_spec.rb

@@ -137,5 +137,23 @@ describe Jeff do
         end
       end
     end
+
+    context 'given a failed request' do
+      before do
+        has_run = false
+        Excon.stub({ method: :get }) do |params|
+          if has_run
+            { status: 200 }
+          else
+            has_run = true
+            raise Excon::Errors::SocketError.new Exception.new 'Mock Error'
+          end
+        end
+      end
+
+      it 'should retry' do
+        client.get(mock: true).status.should be 200
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: jeff
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-07-04 00:00:00.000000000 Z
+date: 2012-07-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: excon
@@ -122,12 +122,18 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: 13761434509478082
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: 13761434509478082
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23