java_bin 0.1.1 → 0.1.2

data/CHANGELOG

@@ -0,0 +1,18 @@
+0.1.2 (2010/01/12)
+  * fix memory leak error (extern string).
+
+  Example.
+    # OK
+    x.times {
+      @parser = JavaBin.parser.new
+      @parser.parse(xxx...)
+    }
+
+    # BAD!
+    @parser = JavaBin.parser.new
+    x.times {
+      @parser.parse(xxx...)
+    }
+
+  * fix segv problem (extern string).
+  * ruby 1.8.7/1.9.2pre1 all green.

data/TODO

@@ -1,3 +1,4 @@
+* ChangeLogを準備
 * 他のgemの依存関係
 ** rsolr/solr-rubyのmonkey-patch
 * hashのキーをsymbolにする

data/VERSION

@@ -1 +1 @@
-0.1.1
+0.1.2

data/ext/java_bin/ext/parser.c

@@ -329,6 +329,14 @@ static VALUE rb_cParser_parse(VALUE self, VALUE data) {
   ptr->current  = 1;   /* VERSIONをとばした */
   ptr->tag_byte = 0;
 
+  /*
+   * 参照文字列既に確保している場合は解放
+   * HINT. インスタンスを使いまわす時に発生する
+   */
+  if (ptr->cache) {
+    free(ptr->cache);
+  }
+
   /* 参照文字列の準備 */
   ptr->cache = NULL;
   ptr->cache_index = 0;

data/java_bin.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{java_bin}
-  s.version = "0.1.1"
+  s.version = "0.1.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["kennyj"]
@@ -21,6 +21,7 @@ Gem::Specification.new do |s|
   s.files = [
     ".document",
      ".gitignore",
+     "CHANGELOG",
      "LICENSE",
      "README.rdoc",
      "Rakefile",
@@ -49,8 +50,8 @@ Gem::Specification.new do |s|
   s.rubygems_version = %q{1.3.5}
   s.summary = %q{Solr JavaBin format implementation for Ruby.}
   s.test_files = [
-    "test/test_java_bin_parser.rb",
-     "test/xxx_performance.rb",
+    "test/xxx_performance.rb",
+     "test/test_java_bin_parser.rb",
      "test/helper.rb"
   ]
 

data/test/test_java_bin_parser.rb

@@ -76,6 +76,16 @@ class TestJavaBinParser < Test::Unit::TestCase
     assert (jb_et * 2) < r_et if @parser.is_a? JavaBin::Ext::Parser
   end
 
+  def test_memory_allocate
+    (TIMES * 5).times {
+      @parser.parse([1, 0].pack("C*"))
+    }
+    (TIMES * 5).times {
+      @parser = JavaBin.parser.new
+      @parser.parse([1, 0].pack("C*"))
+    }
+  end
+
   def test_null
     assert_nil @parser.parse([1, 0].pack("C*"))
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: java_bin
 version: !ruby/object:Gem::Version 
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors: 
 - kennyj
@@ -26,6 +26,7 @@ extra_rdoc_files:
 files: 
 - .document
 - .gitignore
+- CHANGELOG
 - LICENSE
 - README.rdoc
 - Rakefile
@@ -77,6 +78,6 @@ signing_key:
 specification_version: 3
 summary: Solr JavaBin format implementation for Ruby.
 test_files: 
-- test/test_java_bin_parser.rb
 - test/xxx_performance.rb
+- test/test_java_bin_parser.rb
 - test/helper.rb