jasmine_selenium_runner 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 71c49524cded239d450de93167e2e595e783d265
-  data.tar.gz: 61c45501e41dbda1c35b7fbc8f07f881c6a956c1
+  metadata.gz: 8c72efde02f61e3edfbd9b908dbc9b61bf7d31ea
+  data.tar.gz: cb60cac460be62c9563be2ab87ab802393a42788
 SHA512:
-  metadata.gz: f5e1c6a43f07697730c1309809aca6da84d9552df5e9224a6251ef1c86d3d0625a1b75b428ace67a64b7379708ed1c6258fd21869b4f846f41a343f250fd2b2b
-  data.tar.gz: 314d392cdc9071ceab94f0a5c5ef02769d1dc52ac40640f6f30ff450ccdc853f33caf0511f066cce74d725cf188c57d95bd5ff53ffe554ee918e5ecbd2ae8698
+  metadata.gz: f119b0c6d31d03918b9bc59a6e6c037dac94ee4732d80c4a4d4c80d84b243f0fcf6a51190d6636006ad18e01bfd688dfeab30ecf13219be6696312a4845bf9cd
+  data.tar.gz: de2708d84c3159b4362e3d6a883e39e99933ca6fd86a6daa175f7d79c7fe631a4d70c426e8b7163b7f1ae896f99347569d12c06501c4c3e2904844167c28fc93

data/jasmine-selenium-runner.gemspec

@@ -22,7 +22,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake"
   spec.add_development_dependency 'rspec'
   spec.add_development_dependency 'rails', '> 3.0'
-  spec.add_dependency 'jasmine', '~> 2.0.0.alpha'
+  spec.add_dependency 'jasmine', '~> 2.0'
   spec.add_dependency 'selenium-webdriver', '~> 2.35'
   spec.add_dependency 'sauce-connect'
 end

data/lib/jasmine/runners/selenium.rb

@@ -50,23 +50,33 @@ module Jasmine
       def get_results
         index = 0
         spec_results = []
+        failed_suite_results = []
 
         loop do
-          slice = results_without_circular_references(index)
+          slice = results_without_circular_references('spec', index)
           spec_results << slice
           index += result_batch_size
           break if slice.size < result_batch_size
         end
-        spec_results.flatten
+
+        index = 0
+        loop do
+          slice = results_without_circular_references('suite', index)
+          failed_suite_results << slice.select(&:failed?)
+          index += result_batch_size
+          break if slice.size < result_batch_size
+        end
+
+        spec_results.flatten + failed_suite_results.flatten
       end
 
-      def results_without_circular_references(starting_index)
+      def results_without_circular_references(result_type, starting_index)
         slice = driver.execute_script(<<-JS)
-          var specResults = jsApiReporter.specResults(#{starting_index}, #{result_batch_size})
-          for (var i = 0; i < specResults.length; i++) {
-            var expectations = specResults[i].failedExpectations;
-            if (specResults[i].passedExpectations) {
-              expectations = expectations.concat(specResults[i].passedExpectations);
+          var results = jsApiReporter.#{result_type}Results(#{starting_index}, #{result_batch_size})
+          for (var i = 0; i < results.length; i++) {
+            var expectations = results[i].failedExpectations;
+            if (results[i].passedExpectations) {
+              expectations = expectations.concat(results[i].passedExpectations);
             }
             for (var j = 0; j < expectations.length; j++) {
               var expectation = expectations[j];
@@ -74,7 +84,7 @@ module Jasmine
               try { JSON.stringify(expectation.actual); } catch (e) { expectation.actual = '<circular actual>'; }
             }
           }
-          return specResults;
+          return results;
         JS
         Jasmine::Result.map_raw_results(slice)
       end

data/lib/jasmine/runners/selenium/version.rb

@@ -1,7 +1,7 @@
 module Jasmine
   module Runners
     class Selenium
-      VERSION = "0.2.0"
+      VERSION = "0.2.1"
     end
   end
 end

data/spec/fixtures/after_all_failure_spec.js

@@ -0,0 +1,9 @@
+describe('failing afterAll', function() {
+  afterAll(function() {
+    throw 'afterAll go boom';
+  });
+
+  it('is fine otherwise', function() {
+  });
+});
+

data/spec/selenium_runner_integration_spec.rb

@@ -13,6 +13,7 @@ describe Jasmine::Runners::Selenium do
 source 'https://rubygems.org'
 gem 'jasmine_selenium_runner', :path => '#{project_root}'
 gem 'jasmine', :git => 'https://github.com/pivotal/jasmine-gem.git'
+gem 'jasmine-core', :git => 'https://github.com/pivotal/jasmine.git'
 GEMFILE
       end
       Bundler.with_clean_env do
@@ -33,6 +34,7 @@ GEMFILE
 source 'https://rubygems.org'
 gem 'jasmine_selenium_runner', :path => '#{project_root}'
 gem 'jasmine', :git => 'https://github.com/pivotal/jasmine-gem.git'
+gem 'jasmine-core', :git => 'https://github.com/pivotal/jasmine.git'
 GEMFILE
       end
       Bundler.with_clean_env do
@@ -46,6 +48,28 @@ GEMFILE
     end
   end
 
+  it "reports failures in afterAll" do
+    in_temp_dir do |dir, project_root|
+      File.open(File.join(dir, 'Gemfile'), 'w') do |file|
+        file.write <<-GEMFILE
+source 'https://rubygems.org'
+gem 'jasmine_selenium_runner', :path => '#{project_root}'
+gem 'jasmine', :git => 'https://github.com/pivotal/jasmine-gem.git'
+gem 'jasmine-core', :git => 'https://github.com/pivotal/jasmine.git'
+GEMFILE
+      end
+      Bundler.with_clean_env do
+        `bundle`
+        `bundle exec jasmine init`
+        `bundle exec jasmine examples`
+        FileUtils.cp(File.join(project_root, 'spec', 'fixtures', 'after_all_failure_spec.js'), File.join(dir, 'spec', 'javascripts'))
+        ci_output = `bundle exec rake -E "require 'jasmine_selenium_runner'" --trace jasmine:ci`
+        expect(ci_output).to match(/afterAll go boom/)
+        expect(ci_output).to match(/[1-9][0-9]* specs, 1 failure/)
+      end
+    end
+  end
+
   it "permits rake jasmine:ci task to be run using Sauce", :sauce => true do
     in_temp_dir do |dir, project_root|
       File.open(File.join(dir, 'Gemfile'), 'w') do |file|
@@ -53,6 +77,7 @@ GEMFILE
 source 'https://rubygems.org'
 gem 'jasmine_selenium_runner', :path => '#{project_root}'
 gem 'jasmine', :git => 'https://github.com/pivotal/jasmine-gem.git'
+gem 'jasmine-core', :git => 'https://github.com/pivotal/jasmine.git'
 GEMFILE
       end
       Bundler.with_clean_env do
@@ -118,6 +143,7 @@ YAML
       Dir.chdir File.join(dir, 'rails-test')
       File.open('Gemfile', 'a') { |f|
         f.puts "gem 'jasmine', :git => 'https://github.com/pivotal/jasmine-gem.git'"
+        f.puts "gem 'jasmine-core', :git => 'https://github.com/pivotal/jasmine.git'"
         f.puts "gem 'jasmine_selenium_runner', :path => '#{project_root}'"
       }
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: jasmine_selenium_runner
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Rajan Agaskar
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-18 00:00:00.000000000 Z
+date: 2014-11-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -73,14 +73,14 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.0.0.alpha
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.0.0.alpha
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: selenium-webdriver
   requirement: !ruby/object:Gem::Requirement
@@ -134,6 +134,7 @@ files:
 - lib/jasmine_selenium_runner/firebug/firebug.rb
 - lib/jasmine_selenium_runner/railtie.rb
 - lib/jasmine_selenium_runner/tasks/jasmine_selenium_runner.rake
+- spec/fixtures/after_all_failure_spec.js
 - spec/fixtures/contains_circular_references_spec.js
 - spec/fixtures/is_in_firefox_spec.js
 - spec/fixtures/is_in_ie_spec.js
@@ -165,6 +166,7 @@ signing_key:
 specification_version: 4
 summary: Run your jasmine tests in a real live browser!
 test_files:
+- spec/fixtures/after_all_failure_spec.js
 - spec/fixtures/contains_circular_references_spec.js
 - spec/fixtures/is_in_firefox_spec.js
 - spec/fixtures/is_in_ie_spec.js