japan_net_bank 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: cd538ad48dafa976c3d3069c46106b088c5b878a
-  data.tar.gz: 6989fa4c0a5b0cfbbed9f5bc1eb59ea097855f70
+SHA256:
+  metadata.gz: d0770dc9e2afa8e4654c0c742dc05e38af018f53d0cd9af2bcee36bc7ba08932
+  data.tar.gz: d89409cf9243ff092e3326d54cfafebf3e75bb1b8e500104ad0f13aaa922d302
 SHA512:
-  metadata.gz: 5168634c95e753c781c6639e2bc66fc51b7ece55b21358368b8eadda0aab6a9ace5f60491a4d643aae057df2924e9e30f9bef899b445cffbc75e857116b08ac8
-  data.tar.gz: a44d06e82af35dfe02c95dd9c56e1b45ecad0b331970e463e911934365c312df8014fa098b3b9d55fa87d27284ce4e2f364d492526becd153837358231c15b70
+  metadata.gz: 429a566832224066df5b8143e67448e4b04ab452db1234ef5d181424d13dbf457aadb7275ba62b30dc7f2b5aae0fcf14ff2734c87ef28ec1b65c951ffc88895d
+  data.tar.gz: ffa3b3f730940902c483eff3a5ab94f7e6241eb9357fc57620038e2827d8e762f7f54df8a265a3e73e337f7a61762af17a13765598048e92150e9d47c729865c

data/.github/workflows/testing.yml

@@ -0,0 +1,18 @@
+name: Testing
+on:
+  - push
+jobs:
+  rspec:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: ['2.6', '2.7']
+    name: Rspec with Ruby ${{ matrix.ruby }}
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+      - run: |
+          bundle install --path vendor/bundle --quiet --jobs 4 --retry 3
+          bundle exec rspec

data/japan_net_bank.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_runtime_dependency "activemodel"
-  spec.add_development_dependency "bundler", "~> 1.5"
+  spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
   spec.add_development_dependency "pry"

data/lib/japan_net_bank/transfer.rb

@@ -104,10 +104,10 @@ module JapanNetBank
       append_row(row)
     end
 
-    def to_csv
+    def to_csv(opts = {})
       JapanNetBank::Transfer::CSV.generate do |csv|
         @rows.each do |row|
-          csv << row.to_a
+          csv << row.to_a(**opts)
         end
 
         csv << trailer_row if @rows_count > 0

data/lib/japan_net_bank/transfer/csv.rb

@@ -4,9 +4,9 @@ module JapanNetBank
   class Transfer
     class CSV
       def self.generate
-        csv = ::CSV.new('', row_sep: "\r\n")
-        yield(csv)
-        csv.string
+        ::CSV.generate(row_sep: "\r\n", encoding: Encoding::Shift_JIS) do |csv|
+          yield(csv)
+        end
       end
 
       def self.parse(csv_string)

data/lib/japan_net_bank/transfer/row.rb

@@ -31,15 +31,17 @@ module JapanNetBank
         raise ArgumentError, errors.full_messages unless valid?
       end
 
-      def to_a
+      def to_a(name_length_limit: 48)
+        name = convert_to_hankaku_katakana(@name).slice(0, name_length_limit)
+
         [
-            @record_type,
-            @bank_code,
-            @branch_code,
-            account_type_code,
-            @number,
-            convert_to_hankaku_katakana(@name).encode('Shift_JIS'),
-            @amount.to_s,
+          @record_type,
+          @bank_code,
+          @branch_code,
+          account_type_code,
+          @number,
+          name.encode('Shift_JIS'),
+          @amount.to_s,
         ]
       end
 

data/lib/japan_net_bank/version.rb

@@ -1,3 +1,3 @@
 module JapanNetBank
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/spec/japan_net_bank/transfer_spec.rb

@@ -158,12 +158,60 @@ describe JapanNetBank::Transfer do
   end
 
   describe '#to_csv' do
-    it 'CSV 文字列を取得できる' do
+    it 'Shift JIS の CSV 文字列を取得できる' do
       row_array1        = JapanNetBank::Transfer::Row.new(row_hash1).to_a.join(',')
       row_array2        = JapanNetBank::Transfer::Row.new(row_hash2).to_a.join(',')
       trailer_row_array = [JapanNetBank::Transfer::Row::RECORD_TYPE_TRAILER, nil, nil, nil, nil, 2, 4800].join(',')
 
-      expect(transfer.to_csv).to eq row_array1 + "\r\n" + row_array2 + "\r\n" + trailer_row_array + "\r\n"
+      csv = transfer.to_csv
+
+      expect(csv).to eq row_array1 + "\r\n" + row_array2 + "\r\n" + trailer_row_array + "\r\n"
+      expect(csv.encoding).to eq Encoding::Shift_JIS
+    end
+
+    describe 'name_length_limit オプション' do
+      context '指定した場合' do
+        let(:row_hashes) do
+          common = {
+            bank_code:    '0123',
+            branch_code:  '012',
+            account_type: 'ordinary',
+            number:       '0123456',
+            amount:       3200,
+          }
+
+          names = ['サトウハナコ', 'カ)ニホンシヨウジ', 'タブチ']
+
+          names.map {|name| common.merge(name: name) }
+        end
+
+        it '口座名義の長さを制限できる' do
+          csv = transfer.to_csv(name_length_limit: 2)
+
+          expect(csv).to include ',' + 'ｻﾄ'.encode('Shift_JIS') + ','
+          expect(csv).to include ',' + 'ｶ)'.encode('Shift_JIS') + ','
+          expect(csv).to include ',' + 'ﾀﾌ'.encode('Shift_JIS') + ','
+        end
+      end
+
+      context '無指定の場合' do
+        let(:row_hashes) do
+          [{
+            bank_code:    '0123',
+            branch_code:  '012',
+            account_type: 'ordinary',
+            number:       '0123456',
+            name:         'ア' * 50,
+            amount:       3200,
+          }]
+        end
+
+        it '48 文字で切る' do
+          csv = transfer.to_csv
+
+          expect(csv).to include ',' + ('ｱ' * 48).encode('Shift_JIS') + ','
+        end
+      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: japan_net_bank
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - INOUE Takuya
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-01 00:00:00.000000000 Z
+date: 2020-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -28,16 +28,16 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -87,9 +87,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/testing.yml"
 - ".gitignore"
 - ".rspec"
-- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -105,7 +105,6 @@ files:
 - spec/japan_net_bank/transfer_spec.rb
 - spec/japan_net_bank_spec.rb
 - spec/spec_helper.rb
-- wercker.yml
 homepage: https://github.com/pepabo/japan_net_bank
 licenses:
 - MIT
@@ -125,8 +124,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: A toolkit for generating Japan Net Bank CSV to transfer.

data/.travis.yml

@@ -1,3 +0,0 @@
-language: ruby
-rvm:
-  - 2.1.1

data/wercker.yml

@@ -1,31 +0,0 @@
-box: wercker/rvm
-# Build definition
-build:
-  # The steps that will be executed on build
-  # See the Ruby section on the wercker devcenter:
-  # http://devcenter.wercker.com/articles/languages/ruby.html
-  steps:
-    - rvm-use:
-        version: 2.1.1
-
-    # A step that executes `bundle install` command
-    - bundle-install
-
-    # A custom script step, name value is used in the UI
-    # and the code value contains the command that get executed
-    - script:
-        name: echo ruby information
-        code: |
-            echo "ruby version $(ruby --version) running"
-            echo "from location $(which ruby)"
-            echo -p "gem list: $(gem list)"
-    - script:
-       name: rake spec
-       code: bundle exec rake spec
-
-  after-steps:
-    - 2get/ikachan-notify@0.0.2:
-        url: http://irc.paperboy.co.jp:4979/privmsg
-        channel: "#kiteco"
-        passed-message: "%02[CI]%0f $WERCKER_APPLICATION_NAME: $WERCKER_BUILD_URL build of $WERCKER_GIT_BRANCH %02%0301,03PASSED%0f"
-        failed-message: "%02[CI]%0f $WERCKER_APPLICATION_NAME: $WERCKER_BUILD_URL build of $WERCKER_GIT_BRANCH %02%0301,04FAILED%0f"