janova-clearance 0.8.8 → 0.9.1

data/CHANGELOG.md

@@ -1,9 +1,18 @@
-0.8.8 (12/21/2010) - Janova version
+0.9.1 (Janova fork)
 ------------------
-* Updated the Email Format Validation Regex in Clearance::User::Validations to be a more thorough regex (Robert Stevenson)
+
+* Refactored the Clearance::User::Validations module to use the regex that comes from http://www.regular-expressions.info/email.html (with the addition of ^ and $ as well as the case-insensitive flag at the end).
+
+0.8.9 (unreleased)
+------------------
+
+* Removed unnecessary db index. (Rich Thornett, doctorzaius)
+* [#79] Allow customization of cookie duration. (Ron Newman, Dan Croak)
+* [#77] rake generator:cleanup needed to be... cleaned up. (Ron Newman)
 
 0.8.8 (02/25/2010)
 ------------------
+
 * Fixed sign_in and sign_out not setting current_user (Joe Ferris)
 
 0.8.7 (02/21/2010)

data/README.md

@@ -3,7 +3,7 @@ Clearance
 
 Rails authentication with email & password.
 
-[We have clearance, Clarence.](http://www.youtube.com/v/mNRXJEE3Nz8)
+[We have clearance, Clarence.](http://www.youtube.com/watch?v=fVq4_HhBK8Y)
 
 Help
 ----
@@ -20,23 +20,27 @@ Fork away and create a [Github Issue](http://github.com/thoughtbot/clearance/iss
 Installation
 ------------
 
-Clearance is a Rails engine. It works with versions of Rails greater than 2.3.
+Clearance is a Rails engine. The latest stable version (0.8.8) works with versions of Rails 2.x.
 
-Install it as a gem however you like to install gems. Gem Bundler example:
+Install it as a gem however you like to install gems. Also, uninstall old versions:
 
-    gem "clearance"
+    sudo gem uninstall thoughtbot-clearance
+    sudo gem uninstall clearance
+    sudo gem install clearance
 
-Make sure the development database exists and run the generator:
+Make sure the development database exists, then run the generator:
 
-    script/generate clearance
+    script/rails generate clearance
 
 This:
 
 * inserts Clearance::User into your User model
 * inserts Clearance::Authentication into your ApplicationController
-* inserts Clearance::Routes.draw(map) into your config.routes.rb
 * created a migration that either creates a users table or adds only missing columns
-* prints further instructions
+
+There is a release candidate which features Rails 3 support. To install this version:
+
+    gem install clearance --prerelease
 
 Usage
 -----
@@ -65,14 +69,14 @@ To change any of provided actions, subclass a Clearance controller...
       end
     end
 
-and add your route above (before) Clearance routes in config/routes.rb:
+and add your route in config/routes.rb:
 
-    map.resource :session, :controller => 'sessions'
+    resource :session, :controller => 'sessions'
 
-See lib/clearance/routes.rb for all the routes Clearance provides.
+See config/routes.rb for all the routes Clearance provides.
 
 Actions that redirect (create, update, and destroy) in Clearance controllers
-can be overriden by re-defining url_after_(action) methods as seen above.
+can be overridden by re-defining url_after_(action) methods as seen above.
 
 Optional Cucumber features
 --------------------------
@@ -83,33 +87,27 @@ opinion is that you should test its integration with your app using
 
 Run the Cucumber generator and Clearance feature generator:
 
-    script/generate cucumber
-    script/generate clearance_features
-
-All of the files generated should be new with the exception of the
-features/support/paths.rb file. If you have not modified your paths.rb then you
-will be okay to replace it with this one. If you need to keep your paths.rb
-file then add these locations in your paths.rb manually:
-
-  def path_to(page_name)
-    case page_name
-    when /the sign up page/i
-     new_user_path
-    when /the sign in page/i
-     new_session_path
-    when /the password reset request page/i
-     new_password_path
-    end
-  end
+    script/rails generate cucumber
+    script/rails generate clearance_features
+
+Edit your Gemfile to include:
+
+    gem 'factory_girl_rails'
+
+Edit your config/enviroments/cucumber.rb to include the following:
+
+    config.action_mailer.default_url_options = { :host => 'localhost:3000' }
+
+Then run rake!
 
 Optional Formtastic views
 -------------------------
 
-We use & recommend [Formtastic](http://github.com/justinfrench/formtastic].
+We use & recommend [Formtastic](http://github.com/justinfrench/formtastic).
 
 Clearance has another generator to generate Formastic views:
 
-    script/generate clearance_views
+    script/rails generate clearance_views
 
 Its implementation is designed so other view styles (Haml?) can be generated.
 
@@ -117,8 +115,8 @@ Authors
 -------
 
 Clearance was extracted out of [Hoptoad](http://hoptoadapp.com). We merged the
-authentication code from two of thoughtbot client Rails apps and have since
-used it each time we need authentication.
+authentication code from two of thoughtbot's client Rails apps and have since
+used it each time we needed authentication.
 
 The following people have improved the library. Thank you!
 
@@ -126,4 +124,5 @@ Dan Croak, Mike Burns, Jason Morrison, Joe Ferris, Eugene Bolshakov,
 Nick Quaranto, Josh Nichols, Mike Breen, Marcel Görner, Bence Nagy, Ben Mabey,
 Eloy Duran, Tim Pope, Mihai Anca, Mark Cornick, Shay Arnett, Joshua Clayton,
 Mustafa Ekim, Jon Yurek, Anuj Dutta, Chad Pytel, Ben Orenstein, Bobby Wilson,
-Matthew Ford, Ryan McGeary, Claudio Poli, Joseph Holsten, and Peter Haza.
+Matthew Ford, Ryan McGeary, Claudio Poli, Joseph Holsten, Peter Haza,
+Ron Newman, and Rich Thornett.

data/Rakefile

@@ -1,38 +1,97 @@
 # encoding: utf-8
 
+ENV['BUNDLE_GEMFILE'] = File.dirname(__FILE__) + '/test/rails_root/Gemfile'
+
 require 'rake'
 require 'rake/testtask'
 require 'cucumber/rake/task'
+require 'spec/rake/spectask'
 
 namespace :test do
   Rake::TestTask.new(:basic => ["generator:cleanup",
-                                "generator:clearance",
-                                "generator:clearance_features"]) do |task|
+                                "generator:clearance"]) do |task|
     task.libs << "lib"
     task.libs << "test"
-    task.pattern = "test/**/*_test.rb"
+    task.pattern = "test/*/*_test.rb"
     task.verbose = false
   end
 
-  Rake::TestTask.new(:views => ["generator:clearance_views"]) do |task|
+  Rake::TestTask.new(:views => ["generator:cleanup",
+                                "generator:clearance",
+                                "generator:clearance_views"]) do |task|
     task.libs << "lib"
     task.libs << "test"
-    task.pattern = "test/**/*_test.rb"
+    task.pattern = "test/*/*_test.rb"
     task.verbose = false
   end
 
-  Cucumber::Rake::Task.new(:features) do |t|
+
+  Cucumber::Rake::Task.new(:features => ["generator:cleanup",
+                                         "generator:clearance",
+                                         "generator:clearance_features"]) do |t|
     t.cucumber_opts   = "--format progress"
     t.profile = 'features'
   end
 
-  Cucumber::Rake::Task.new(:features_for_views) do |t|
+  Cucumber::Rake::Task.new(:features_for_views => ["generator:cleanup",
+                                                   "generator:clearance",
+                                                   "generator:clearance_features",
+                                                   "generator:clearance_views"]) do |t|
     t.cucumber_opts   = "--format progress"
     t.profile = 'features_for_views'
   end
 end
 
-generators = %w(clearance clearance_features clearance_views)
+namespace :spec do
+  Spec::Rake::SpecTask.new(:basic => %w(spec:generator:cleanup spec:generator:clearance)) do |task|
+    task.spec_files = FileList['spec/*/*_spec.rb']
+  end
+
+  Spec::Rake::SpecTask.new(:views => %w(spec:generator:cleanup spec:generator:clearance spec:generator:clearance_views)) do |task|
+    task.spec_files = FileList['spec/*/*_spec.rb']
+  end
+
+  Cucumber::Rake::Task.new(:features => %w(spec:generator:cleanup spec:generator:clearance spec:generator:clearance_features)) do |task|
+    task.cucumber_opts = '--format progress'
+    task.profile = 'features_with_rspec'
+  end
+
+  Cucumber::Rake::Task.new(:features_for_views => %w(spec:generator:cleanup spec:generator:clearance spec:generator:clearance_features spec:generator:clearance_views)) do |task|
+    task.cucumber_opts = '--format progress'
+    task.profile = 'features_for_views_with_rspec'
+  end
+
+  namespace :generator do
+    task :cleanup do
+      FileList["spec/rails_root/db/**/*"].each do |each|
+        FileUtils.rm_rf(each)
+      end
+
+      FileUtils.rm_rf("spec/rails_root/vendor/plugins/clearance")
+      FileUtils.rm_rf("spec/rails_root/app/views/passwords")
+      FileUtils.rm_rf("spec/rails_root/app/views/sessions")
+      FileUtils.rm_rf("spec/rails_root/app/views/users")
+      FileUtils.mkdir_p("spec/rails_root/vendor/plugins")
+      clearance_root = File.expand_path(File.dirname(__FILE__))
+      system("ln -s #{clearance_root} spec/rails_root/vendor/plugins/clearance")
+      FileList["spec/rails_root/features/*.feature"].each do |each|
+        FileUtils.rm_rf(each)
+      end
+    end
+
+    task :clearance do
+      system "cd spec/rails_root && bundle install && ./script/rails generate clearance && rake db:migrate db:test:prepare"
+    end
+
+    task :clearance_features do
+      system "cd spec/rails_root && ./script/rails generate clearance_features"
+    end
+
+    task :clearance_views do
+      system "cd spec/rails_root && ./script/rails generate clearance_views"
+    end
+  end
+end
 
 namespace :generator do
   desc "Cleans up the test app before running the generator"
@@ -41,47 +100,34 @@ namespace :generator do
       FileUtils.rm_rf(each)
     end
 
-    FileUtils.rm_rf("test/rails_root/vendor/plugins/clearance")
+    FileUtils.rm_rf("test/rails_root/app/views/passwords")
+    FileUtils.rm_rf("test/rails_root/app/views/sessions")
+    FileUtils.rm_rf("test/rails_root/app/views/users")
     FileUtils.mkdir_p("test/rails_root/vendor/plugins")
     clearance_root = File.expand_path(File.dirname(__FILE__))
-    system("ln -s #{clearance_root} test/rails_root/vendor/plugins/clearance")
+    FileList["test/rails_root/features/*.feature"].each do |each|
+      FileUtils.rm_rf(each)
+    end
   end
 
   desc "Run the clearance generator"
   task :clearance do
-    system "cd test/rails_root && ./script/generate clearance -f && rake db:migrate db:test:prepare"
+    system "cd test/rails_root && bundle install && ./script/rails generate clearance && rake db:migrate db:test:prepare"
   end
 
   desc "Run the clearance features generator"
   task :clearance_features do
-    system "cd test/rails_root && ./script/generate clearance_features -f"
+    system "cd test/rails_root && ./script/rails generate clearance_features"
   end
 
   desc "Run the clearance views generator"
   task :clearance_views do
-    system "cd test/rails_root && ./script/generate clearance_views -f"
+    system "cd test/rails_root && ./script/rails generate clearance_views"
   end
 end
 
 desc "Run the test suite"
 task :default => ['test:basic', 'test:features',
-                  'test:views', 'test:features_for_views']
-
-require 'jeweler'
-
-Jeweler::Tasks.new do |gem|
-  gem.name        = "janova-clearance"
-  gem.summary     = "Rails authentication with email & password."
-  gem.description = "Rails authentication with email & password."
-  gem.email       = "support@janova.us"
-  gem.homepage    = "http://github.com/janova/clearance"
-  gem.authors     = ["Dan Croak", "Mike Burns", "Jason Morrison",
-                     "Joe Ferris", "Eugene Bolshakov", "Nick Quaranto",
-                     "Josh Nichols", "Mike Breen", "Marcel Görner",
-                     "Bence Nagy", "Ben Mabey", "Eloy Duran",
-                     "Tim Pope", "Mihai Anca", "Mark Cornick",
-                     "Shay Arnett", "Jon Yurek", "Chad Pytel"]
-  gem.files       = FileList["[A-Z]*", "{app,config,generators,lib,shoulda_macros,rails}/**/*"]
-end
-
-Jeweler::GemcutterTasks.new
+                  'test:views', 'test:features_for_views',
+                  'spec:basic', 'spec:features',
+                  'spec:views', 'spec:features_for_views']

data/VERSION

@@ -1 +1 @@
-0.8.8
+0.9.1

data/app/controllers/clearance/confirmations_controller.rb

@@ -7,8 +7,6 @@ class Clearance::ConfirmationsController < ApplicationController
   before_filter :forbid_missing_token,               :only => [:new, :create]
   before_filter :forbid_non_existent_user,           :only => [:new, :create]
 
-  filter_parameter_logging :token
-
   def new
     create
   end

data/app/controllers/clearance/passwords_controller.rb

@@ -4,7 +4,6 @@ class Clearance::PasswordsController < ApplicationController
   skip_before_filter :authenticate,        :only => [:new, :create, :edit, :update]
   before_filter :forbid_missing_token,     :only => [:edit, :update]
   before_filter :forbid_non_existent_user, :only => [:edit, :update]
-  filter_parameter_logging :password, :password_confirmation
 
   def new
     render :template => 'passwords/new'
@@ -13,7 +12,7 @@ class Clearance::PasswordsController < ApplicationController
   def create
     if user = ::User.find_by_email(params[:password][:email])
       user.forgot_password!
-      ::ClearanceMailer.deliver_change_password user
+      ::ClearanceMailer.change_password(user).deliver
       flash_notice_after_create
       redirect_to(url_after_create)
     else

data/app/controllers/clearance/sessions_controller.rb

@@ -3,7 +3,6 @@ class Clearance::SessionsController < ApplicationController
 
   skip_before_filter :authenticate, :only => [:new, :create, :destroy]
   protect_from_forgery :except => :create
-  filter_parameter_logging :password
 
   def new
     render :template => 'sessions/new'
@@ -21,7 +20,7 @@ class Clearance::SessionsController < ApplicationController
         flash_success_after_create
         redirect_back_or(url_after_create)
       else
-        ::ClearanceMailer.deliver_confirmation(@user)
+        ::ClearanceMailer.confirmation(@user).deliver
         flash_notice_after_create
         redirect_to(sign_in_url)
       end

data/app/controllers/clearance/users_controller.rb

@@ -3,7 +3,6 @@ class Clearance::UsersController < ApplicationController
 
   skip_before_filter :authenticate, :only => [:new, :create]
   before_filter :redirect_to_root,  :only => [:new, :create], :if => :signed_in?
-  filter_parameter_logging :password
 
   def new
     @user = ::User.new(params[:user])

data/app/models/clearance_mailer.rb

@@ -1,21 +1,21 @@
 class ClearanceMailer < ActionMailer::Base
 
   def change_password(user)
+    @user = user
     from       Clearance.configuration.mailer_sender
-    recipients user.email
+    recipients @user.email
     subject    I18n.t(:change_password,
                       :scope   => [:clearance, :models, :clearance_mailer],
                       :default => "Change your password")
-    body       :user => user
   end
 
   def confirmation(user)
+    @user = user
     from       Clearance.configuration.mailer_sender
-    recipients user.email
+    recipients @user.email
     subject    I18n.t(:confirmation,
                       :scope   => [:clearance, :models, :clearance_mailer],
                       :default => "Account confirmation")
-    body      :user => user
   end
 
 end

data/app/views/passwords/edit.html.erb

@@ -6,7 +6,7 @@
 
 <%= error_messages_for :user %>
 
-<% form_for(:user,
+<%= form_for(:user,
             :url => user_password_path(@user, :token => @user.confirmation_token),
             :html => { :method => :put }) do |form| %>
   <div class="password_field">

data/app/views/passwords/new.html.erb

@@ -4,7 +4,7 @@
   We will email you a link to change your password.
 </p>
 
-<% form_for :password, :url => passwords_path do |form| %>
+<%= form_for :password, :url => passwords_path do |form| %>
   <div class="text_field">
     <%= form.label :email, "Email address" %>
     <%= form.text_field :email %>
@@ -12,4 +12,4 @@
   <div class="submit_field">
     <%= form.submit "Reset password", :disable_with => "Please wait..." %>
   </div>
-<% end %>
+<% end %>

data/app/views/sessions/new.html.erb

@@ -1,6 +1,6 @@
 <h2>Sign in</h2>
 
-<% form_for :session, :url => session_path do |form| %>
+<%= form_for :session, :url => session_path do |form| %>
   <div class="text_field">
     <%= form.label :email %>
     <%= form.text_field :email %>

data/app/views/users/_form.html.erb

@@ -10,4 +10,4 @@
 <div class="password_field">
   <%= form.label :password_confirmation, "Confirm password" %>
   <%= form.password_field :password_confirmation %>
-</div>
+</div>

data/app/views/users/new.html.erb

@@ -1,6 +1,6 @@
 <h2>Sign up</h2>
 
-<% form_for @user do |form| %>
+<%= form_for @user do |form| %>
   <%= render :partial => '/users/form', :object => form %>
   <%= form.submit 'Sign up', :disable_with => 'Please wait...' %>
 <% end %>