jan 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 237a9da38380537a517fe197d1d4a68c0b09723f
-  data.tar.gz: d2c6fa1db69b4a3eb649ac5762130bb261643763
+  metadata.gz: 08c3cfeccb0e7c251771a361c3a06fcd54b98937
+  data.tar.gz: c20f6fd40652e7dbe919637f0d267fd6bc5fc394
 SHA512:
-  metadata.gz: 16a99d572b13b34529c0c00c9df7c73bf2e5b68e54b257a4f5ffd59499e45dc700cc7164c2cf40ae010760edf19ff905e379e9debd1fa7e856bcd8b440e0e2c3
-  data.tar.gz: a322ccaad173dc7bf4e16eef9e35f93bbdccee3efd7807dda49c35e35171dbbb9bc46a518d8f41abd4714c9fd891017220757688d153d625582046b78d9f50ae
+  metadata.gz: 6e9eae526ddf5131d130e4f53063734c79cde4c504941c5112308718a24cbb56aeb6585356313a621bb9786c82d58c8749f0dcf4a2088cb4b6a8d59cb1bb55e4
+  data.tar.gz: 3187307e507e10caf0e8107cec9905829206ab037840e5601ad6a7c689d5b3b8388c07b3ab8c509dbe4dd000790349fb2605abe400976cf2cbeca6ad2b84cae3

data/lib/jan/check_digit_calculator.rb

@@ -1,6 +1,6 @@
 require "jan/parser"
 
-class Jan
+class Jan < ::String
   module CheckDigitCalculator
     module_function
 

data/lib/jan/parser.rb

@@ -1,4 +1,4 @@
-class Jan
+class Jan < ::String
   module Parser
     module_function
 
@@ -19,7 +19,7 @@ class Jan
     end
 
     def instore_code?(code)
-      InstorePrefixes.include?(code[0..1])
+      InstoreCodePrefixes.include?(code[0..1])
     end
   end
 end

data/lib/jan/random.rb

@@ -1,7 +1,7 @@
 require "jan/parser"
 require "jan/check_digit_calculator"
 
-class Jan
+class Jan < ::String
   module Random
     module_function
 
@@ -12,7 +12,7 @@ class Jan
     end
 
     def instore_code(size=13)
-      build(size - 2, InstorePrefixes.sample)
+      build(size - 2, InstoreCodePrefixes.sample)
     end
 
     def build(size, code="")

data/lib/jan/validator.rb

@@ -1,7 +1,7 @@
 require "jan/parser"
 require "jan/check_digit_calculator"
 
-class Jan
+class Jan < ::String
   module Validator
     module_function
 

data/lib/jan/version.rb

@@ -1,3 +1,3 @@
-class Jan
-  VERSION = "0.0.3"
+class Jan < ::String
+  VERSION = "0.0.4"
 end

data/lib/jan.rb

@@ -1,35 +1,33 @@
-require "jan/version"
-require "jan/parser"
 require "jan/check_digit_calculator"
-require "jan/validator"
+require "jan/parser"
 require "jan/random"
+require "jan/validator"
+require "jan/version"
 
-class Jan
-  InstorePrefixes = %w(02 20 21 22 23 24 25 26 27 28 29)
-
-  attr_accessor :code
+class Jan < ::String
+  InstoreCodePrefixes = %w(02 20 21 22 23 24 25 26 27 28 29)
 
   def initialize(code)
-    @code = code
+    super(code.to_s)
   end
 
   def valid?
-    Validator.validate(@code)
+    Validator.validate(self)
   end
 
   def check_digit
-    Parser.check_digit(@code)
+    Parser.check_digit(self)
   end
 
   def even_digits
-    Parser.even_digits(@code)
+    Parser.even_digits(self)
   end
 
   def odd_digits
-    Parser.odd_digits(@code)
+    Parser.odd_digits(self)
   end
 
   def instore_code?
-    Parser.instore_code?(@code)
+    Parser.instore_code?(self)
   end
 end

data/spec/jan_spec.rb

@@ -1,67 +1,57 @@
 require "spec_helper"
 
 describe Jan do
+  describe "#initialize" do
+    let(:jan_code){ "4901085089347" }
+    subject{ described_class.new(jan_code) }
+    it{ is_expected.to be_an_instance_of(described_class) }
+    it{ is_expected.to be_a(String) }
+    it("should equals to given string"){ is_expected.to eq(jan_code) }
+  end
+
   describe "#valid?" do
     context "valid codes" do
-      valid_codes.each do |code|
-        it "#{code} should be valid" do
-          jan = Jan.new(code)
-          expect(jan.valid?).to be true
-        end
+      valid_codes.each do |valid_code|
+        subject{ described_class.new(valid_code) }
+        it("#{valid_code} should be valid"){ is_expected.to be_valid }
       end
     end
 
     context "invalid codes" do
-      invalid_codes.each do |code|
-        it "#{code} should be invalid" do
-          jan = Jan.new(code)
-          expect(jan.valid?).to be false
-        end
+      invalid_codes.each do |invalid_code|
+        subject{ described_class.new(invalid_code) }
+        it("#{invalid_code} should be invalid"){ is_expected.not_to be_valid }
       end
     end
   end
 
   describe "#check_digit" do
-    it "should return last digit" do
-      jan = Jan.new("4901277241126")
-      expect(jan.check_digit).to eq(6)
-    end
+    let(:jan){ described_class.new("4901277241126") }
+    subject{ jan.check_digit }
+    it("should return last digit"){ is_expected.to eq(6) }
   end
 
   describe "#even_digits" do
-    it "should return digits in even number-th position" do
-      jan = Jan.new("4901277241126")
-      expect(jan.even_digits).to eq([9,1,7,2,1,2])
-    end
+    let(:jan){ described_class.new("4901277241126") }
+    subject{ jan.even_digits }
+    it("should return digits in even number-th position"){ is_expected.to eq([9,1,7,2,1,2]) }
   end
 
   describe "#odd_digits" do
-    it "should return digits in odd number-th position except check digit" do
-      jan = Jan.new("4901277241126")
-      expect(jan.odd_digits).to eq([4,0,2,7,4,1])
-    end
-  end
-
-  describe "#instore_code?" do
-    it "should return digits in odd number-th position except check digit" do
-      jan = Jan.new("4901277241126")
-      expect(jan.odd_digits).to eq([4,0,2,7,4,1])
-    end
+    let(:jan){ described_class.new("4901277241126") }
+    subject{ jan.odd_digits }
+    it("should return digits in odd number-th position except check digit"){ is_expected.to eq([4,0,2,7,4,1]) }
   end
 
   describe "#instore_code?" do
     context "instore code" do
-      it "should be true" do
-        jan = Jan.new("2101085089347")
-        expect(jan).to be_instore_code
-      end
+      subject{ described_class.new("2101085089347") }
+      it("should be true"){ is_expected.to be_instore_code }
     end
 
     context "global code" do
-      it "should be false" do
-        jan = Jan.new("4901085089347")
-        expect(jan).not_to be_instore_code
-      end
+      subject{ described_class.new("4901085089347") }
+      it("should be false"){ is_expected.not_to be_instore_code }
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: jan
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - OSA Shunsuke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-14 00:00:00.000000000 Z
+date: 2014-09-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler