jahuty 3.3.0 → 3.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 93d706c72d12cb61d951cc71b8add1ac154ed8b8bc57374e3d558e2b4bd8d420
-  data.tar.gz: e64a1355073ba942c5aef652032e8268e4d3a065b8cb3f5a7594d590957edc18
+  metadata.gz: b7f9dd15bdc516d3e7249bba915822f742642f59c7209f47151b963ba34b53d1
+  data.tar.gz: 11bb09b250f358f13d5cafb3a585a1db525ddf988b6fea70dd19c7586a5a77a3
 SHA512:
-  metadata.gz: 33d77db35616e1ae68f3b1ad0063e51ccfc526e35f2ef04e07851f506e5103e73af9d0d27252abf817de4ce2664206cf3edd7f9972275b96aaa582c8c38d0a7b
-  data.tar.gz: b572333f5df0d13b18ecbf29f9d22b06400622cdf9ab5408a6963f21fe154ea0fbb67cee881b3efb89cc7417ef1ef1abcd733b0681f7d72261f8ac357e175bc1
+  metadata.gz: 42ee47a4e2e936a10c4e14bee9990db9c170e53e852d257190cf7636d8c27ce6e7f4da04eeb1cf1ea333e00f65ffc7ed1847b0a47ec4c7ea024d067ee9bca196
+  data.tar.gz: e1ec48bb180b4f81145f4a6b939bc3a9fe64a792bbb7a513b705b49e61b4ac379dfbc0c38fb12880122282d12816d90c8798ca6b283bb8fce6befe5777eb3174

data/CHANGELOG.md

@@ -5,27 +5,33 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## 3.3.0 - 2020-04-29
+## 3.3.1 - 2021-05-02
+
+### Fixed
+
+- Fixed [#19](https://github.com/jahuty/jahuty-ruby/issues/19) where renders were cached without regard for their content version.
+
+## 3.3.0 - 2021-04-29
 
 - Add the `prefer_latest` configuration option to the client and render methods. This setting allows you to render a snippet's _latest_ content instead of the default _published_ content.
 
-## 3.2.1 - 2020-03-16
+## 3.2.1 - 2021-03-16
 
-* Fix issue with double-enveloping the `params` query string parameter.
-* Add system tests for params, caching, problems, and collections.
+- Fix issue with double-enveloping the `params` query string parameter.
+- Add system tests for params, caching, problems, and collections.
 
-## 3.2.0 - 2020-03-08
+## 3.2.0 - 2021-03-08
 
-* Added collections to the library with `all_renders` method. This was a rather large change and required adding new objects like `Action::Show`, refactoring old ones like `Resource::Factory`, and removing some objects like `Cache::Manager` and `Service::Factory` which added unnecessary complexity.
-* Added `snippet_id` to `Resource::Render` to help keep track of a render's parent snippet.
+- Added collections to the library with `all_renders` method. This was a rather large change and required adding new objects like `Action::Show`, refactoring old ones like `Resource::Factory`, and removing some objects like `Cache::Manager` and `Service::Factory` which added unnecessary complexity.
+- Added `snippet_id` to `Resource::Render` to help keep track of a render's parent snippet.
 
-## 3.1.1 - 2020-02-26
+## 3.1.1 - 2021-02-26
 
 - Add support for extra, unused attributes returned by the API to support evolution.
 - Fix the `method redefined` warnings in `cache/manager_spec.rb` and `cache/facade_spec.rb`.
 - Fix the `expect { }.not_to raise_error(SpecificErrorClass)` false positives warnings in `resource/render_spec.rb`.
 
-## 3.1.0 - 2020-01-04
+## 3.1.0 - 2021-01-04
 
 - Add caching support for any cache implementation that supports `get/set` or `read/write` methods.
 - Default to using in-memory [mini-cache](https://github.com/derrickreimer/mini_cache) storage.

data/lib/jahuty/service/snippet.rb

@@ -15,13 +15,13 @@ module Jahuty
       def all_renders(tag, params: {}, expires_in: @expires_in, prefer_latest: @prefer_latest)
         renders = index_renders tag: tag, params: params, prefer_latest: prefer_latest
 
-        cache_renders renders: renders, params: params, expires_in: expires_in
+        cache_renders renders: renders, params: params, expires_in: expires_in, latest: prefer_latest
 
         renders
       end
 
       def render(snippet_id, params: {}, expires_in: @expires_in, prefer_latest: @prefer_latest)
-        key = cache_key snippet_id: snippet_id, params: params
+        key = cache_key snippet_id: snippet_id, params: params, latest: prefer_latest
 
         render = @cache.read(key)
 
@@ -38,17 +38,16 @@ module Jahuty
 
       private
 
-      def cache_key(snippet_id:, params: {})
+      def cache_key(snippet_id:, params: {}, latest: false)
         fingerprint = Digest::MD5.new
         fingerprint << "snippets/#{snippet_id}/render/"
         fingerprint << params.to_json
+        fingerprint << '/latest' if latest
 
         "jahuty_#{fingerprint.hexdigest}"
       end
 
-      def cache_renders(renders:, params:, expires_in: nil)
-        expires_in ||= @expires_in
-
+      def cache_renders(renders:, params:, expires_in: @expires_in, latest: false)
         return if renders.nil?
 
         return unless cacheable?(expires_in)
@@ -59,7 +58,7 @@ module Jahuty
           local_params = params[render.snippet_id.to_s] || {}
           render_params = ::Jahuty::Util.deep_merge global_params, local_params
 
-          key = cache_key snippet_id: render.snippet_id, params: render_params
+          key = cache_key snippet_id: render.snippet_id, params: render_params, latest: latest
 
           @cache.write key, render, expires_in: expires_in
         end

data/lib/jahuty/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Jahuty
-  VERSION = '3.3.0'
+  VERSION = '3.3.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: jahuty
 version: !ruby/object:Gem::Version
-  version: 3.3.0
+  version: 3.3.1
 platform: ruby
 authors:
 - Jack Clayton
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-04-29 00:00:00.000000000 Z
+date: 2021-05-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday