izi_lightup 1.0.15 → 1.0.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2e7e30e1ff97cc6b16730239bcf02e5f358bc82044955814691b1e6316f276cf
-  data.tar.gz: 7fd8a0f1c1a3307d24b7b4ea3097d96097a00b0f852a03e1162022f56a7ff742
+  metadata.gz: f573f7d4f976500f7b282e1ffd0f4451d5f21819fd00db8eb194f94ac04fce96
+  data.tar.gz: c22e4553b330af4fa7552bd8824abf415a8716379d40fd27401b479b900d7b96
 SHA512:
-  metadata.gz: 1241aa88ea51a93c0f758c562e874b9ece8ae5deb0529f3caeaf97e680cda17956872c1bd531fd3da86ba7a5c540049ab18bcc3bfe920a887dcc9b3ebf7ec91f
-  data.tar.gz: aac72a7034f95f5986933b918cde5316c9d6b8744246b5e914d6f4427be83e2c0f4f5ad416db96a6e19a03a35ee32b37b21815a9f5ebe66e9fb25381fe56fe2b
+  metadata.gz: a937fbf2e756c1f4266921c6e47f3700bcd586c628e0137010e7f5baebe13e7c7b2a0bc2b528c37f21d87b5972f3a55fa828e37b05554d81669e1acd8f554dc6
+  data.tar.gz: 02a4203383a8f675719a4593c419019e8323de9840eda5bff1640f41cc75dd4e9c03f03a9a71c4d2e8bf239443d0a882afb76c5ba154a24af6998ab0fac3ba3b

data/lib/izi_lightup/smart_picture.rb

@@ -19,7 +19,7 @@ module IziLightup
             next unless version_name == :default || item.data.respond_to?(version_name)
 
             version = version_name == :default ? item.data : item.data.public_send(version_name)
-            next unless version&.file&.exists? && version&.url&.present?
+            next unless version_exists?(version)
 
             url = version.url
             dimensions = safe_dimentions(item, version)
@@ -37,15 +37,29 @@ module IziLightup
 
       private
 
-      def safe_dimentions(item, version)
-        dimensions = nil
+      def version_exists?(version)
+        return true if version&.url&.present? && version.url =~ /https?:/
+
+        version&.file&.exists? && version&.url&.present?
+      end
+
+      def fallback_dimentions(item)
+        [item&.width, item&.height].compact
+      end
+
+      def safe_dimentions_extract(item, version)
         begin
-          dimensions = version.dimensions
+          version.dimensions
         rescue MiniMagick::Error => _e
-          dimensions = [item&.width, item&.height].compact
+          fallback_dimentions(item)
         end
+      end
+
+      def safe_dimentions(item, version)
+        dimensions = fallback_dimentions(item) if version.url =~ /https?:/
+        dimensions ||= safe_dimentions_extract(item, version)
 
-        return {} if dimensions.blank?
+        return {} if dimensions.blank? || (dimensions.size != 2)
 
         %i[width height].zip(dimensions).to_h
       end

data/lib/izi_lightup/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module IziLightup
-  VERSION = '1.0.15'
+  VERSION = '1.0.16'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: izi_lightup
 version: !ruby/object:Gem::Version
-  version: 1.0.15
+  version: 1.0.16
 platform: ruby
 authors:
 - IzikAJ
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-01-27 00:00:00.000000000 Z
+date: 2021-02-16 00:00:00.000000000 Z
 dependencies: []
 description: |-
   Utils to speed up page load by using critical css &