iulianu-iban-tools 0.0.2 → 0.0.3

data/README

@@ -15,7 +15,7 @@ USAGE
 
  ### Advanced usage, gives more detailed error messages
 
- IBANTools::IBAN.new("XQ75 BADCODE 666").validate
+ IBANTools::IBAN.new("XQ75 BADCODE 666").validation_errors
  => [:unknown_country_code, :bad_check_digits]
 
  ### Pretty print, canonicalize, and extract fields from an IBAN code

data/lib/iban-tools/iban.rb

@@ -4,23 +4,23 @@ module IBANTools
   class IBAN
 
     def self.valid?( code, rules = nil )
-      new(code).validate(rules).empty?
+      new(code).validation_errors(rules).empty?
     end
 
     def initialize( code )
       @code = IBAN.canonicalize_code(code)
     end
 
-    def validate( rules = nil )
+    def validation_errors( rules = nil )
       errors = []
       return [:too_short] if @code.size < 5
       return [:bad_chars] unless @code =~ /^[A-Z0-9]+$/
-      errors += validate_against_rules( rules || IBAN.default_rules )
+      errors += validation_errors_against_rules( rules || IBAN.default_rules )
       errors << :bad_check_digits unless valid_check_digits?
       errors
     end
 
-    def validate_against_rules( rules )
+    def validation_errors_against_rules( rules )
       errors = []
       return [:unknown_country_code] if rules[country_code].nil?
       errors << :bad_length if rules[country_code]["length"] != @code.size
@@ -52,16 +52,18 @@ module IBANTools
     end
 
     def numerify
-      (@code[4..-1] + @code[0..3]).chars.map do |ch|
-      	case ch
-	      when '0'..'9'
-          ch
-        when 'A'..'Z'
-          (ch[0] - ?A + 10).to_s
+      numerified = ""
+      (@code[4..-1] + @code[0..3]).each_byte do |byte|
+      	numerified += case byte
+	      when ?0..?9
+          byte.chr
+        when ?A..?Z
+          (byte - ?A + 10).to_s
         else
-          raise RuntimeError.new("Unexpected char '#{ch}' in IBAN code '#{prettify}'")
+          raise RuntimeError.new("Unexpected byte '#{byte.chr}' in IBAN code '#{prettify}'")
         end
-      end.join
+      end
+      numerified
     end
 
     def to_s
@@ -79,7 +81,7 @@ module IBANTools
 
     # Load and cache the default rules from rules.yml
     def self.default_rules
-      @default_rules = IBANRules.defaults
+      @default_rules ||= IBANRules.defaults
     end
 
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: iulianu-iban-tools
 version: !ruby/object:Gem::Version 
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors: 
 - Iulian Dogariu