itunes_validator 0.4.4 → 0.4.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 723220c4d8ec1994c0e2f2cdc7ccdd2ac7a2e1d5
-  data.tar.gz: ad2bb0d8a6cd2cb6cccc130d1acae23dbc7d81c4
+  metadata.gz: a478903ae40c548da09c811f5ff575ee3d718357
+  data.tar.gz: b45ee4e98c5405679cbae5650cf05b5b405413aa
 SHA512:
-  metadata.gz: 363a8c8239f61173794eb64bc8660212a4159d370cd13c79ec3f33a2a1ecf4a2856db27b899f15fbc4c504308e5af91bc963cddd40ce62cd9541537356e5d737
-  data.tar.gz: aae61512aecd1452d9479a6d77da8c4197ee23de60e15cceb866a83323d37c0d48e74f7ddd951379e2f12d74084f9a50332011633a0cdb7fdf9c2b2314ea720b
+  metadata.gz: ce700a4fcb9283f6bcd128431513043019e66bebd2c9fc578a3849441219598f325f67e5e5a4cc5f6b757a02da3fac611f438ee7fa9970dac400332c3edd645f
+  data.tar.gz: e32aabe97755ae41ac6d8b3febc427c95c07d26eddf1e11cfd886a9174128a092cf3f6ab99706a3ce9aed23e8897c654c46a91f43fd2d89ebe3b19ea3c1e9473

data/lib/itunes_validator.rb

@@ -2,5 +2,5 @@ require_relative 'itunes_validator/client'
 require_relative 'itunes_validator/receipt'
 
 module ItunesValidator
-  VERSION = '0.4.4'
+  VERSION = '0.4.5'
 end

data/lib/itunes_validator/client.rb

@@ -20,22 +20,18 @@ module ItunesValidator
     end
 
     def validate(receipt_data)
-      raise ParameterError unless receipt_data
+      raise ParameterError unless (receipt_data && !receipt_data.strip.empty?)
 
-      post_body = {}
-      post_body['receipt-data'] = receipt_data
-      post_body['password'] = @shared_secret if @shared_secret
+      post_body = { 'receipt-data' => receipt_data }
+      post_body['password'] = @shared_secret if @shared_secret && !@shared_secret.strip.empty?
 
       receipt_info = latest_receipt_info = nil
 
       uri = URI(APPSTORE_VERIFY_URL_PRODUCTION)
       begin
-        h = Net::HTTP::Proxy(*@proxy) if @proxy
-        h = Net::HTTP unless h
-        h.start(uri.host, uri.port, {use_ssl: true}) do |http|
-          req = Net::HTTP::Post.new(uri.request_uri)
-          req['Accept'] = 'application/json'
-          req['Content-Type'] = 'application/json'
+        h = @proxy ? Net::HTTP::Proxy(*@proxy) : Net::HTTP
+        h.start(uri.host, uri.port, use_ssl: true) do |http|
+          req = Net::HTTP::Post.new(uri.request_uri, {'Accept' => 'application/json', 'Content-Type'=>'applications/json'})
           req.body = post_body.to_json
 
           response = http.request(req)
@@ -43,19 +39,19 @@ module ItunesValidator
           response_body = JSON.parse(response.body)
 
           case itunes_status = response_body['status'].to_i
-          when 0
-            receipt_info = response_body['receipt']
-            latest_receipt_info = response_body['latest_receipt_info']
-          else
-            raise ItunesValidationError.new(itunes_status)
+            when 0
+              receipt_info = response_body['receipt']
+              latest_receipt_info = response_body['latest_receipt_info']
+            else
+              raise ItunesValidationError.new(itunes_status)
           end
         end
       rescue ItunesCommunicationError
       rescue ItunesValidationError => e
         case e.code
-        when 21007
-          uri = URI(APPSTORE_VERIFY_URL_SANDBOX)
-          retry
+          when 21007
+            uri = URI(APPSTORE_VERIFY_URL_SANDBOX)
+            retry
         end
       end
 

data/test/test_itunes_validator.rb

@@ -81,6 +81,12 @@ class TestItunesValidator < Test::Unit::TestCase
     assert_raises(ItunesValidator::ParameterError) do
       ItunesValidator.validate(nil)
     end
+    assert_raises(ItunesValidator::ParameterError) do
+      ItunesValidator.validate('')
+    end
+    assert_raises(ItunesValidator::ParameterError) do
+      ItunesValidator.validate(' ')
+    end
   end
 
   def test_invalid_parameters_no_receipt

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: itunes_validator
 version: !ruby/object:Gem::Version
-  version: 0.4.4
+  version: 0.4.5
 platform: ruby
 authors:
 - Scott Talbot
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-24 00:00:00.000000000 Z
+date: 2013-10-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake