itrp-client 1.1.1 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c3cc5dc93a1f84864b1550821fca09d2305b220e
-  data.tar.gz: 8586c686d6519573534a9991288bb7bfe3ac7bf8
+  metadata.gz: a3f55cdbfd736e209d4e107fd750fecb819d34bb
+  data.tar.gz: 4b883ab29f9afb6b1fa055c95645fe43384d3c9f
 SHA512:
-  metadata.gz: 2e7b2e85e0ab75834e490f0917cb7dd7e1fbae1fe0126519771349d244bec66e2422f9c483cd813bfb648e7745dfe5fefc13d710ff8531268c4c45ef7cec1c06
-  data.tar.gz: e51bdaf000aca2f5b471428ca9575d488516766ea2626cfcc92400917b25b76468c53d3476023ae731bca7401c10699839d16efec78716019f14c2b3ff0207fa
+  metadata.gz: c53088678d9bdb63533a8380a83440adc2e10231719539af9415fd8944a882fb53e6ce0d4909b2cba7cc95b10ef7a95aab91a1fc3d64aafa76c33b83b8b4ed0f
+  data.tar.gz: ea7aa517b1cf619bc4e6118e16b8e7a2949cc95b78109f5972c799be79127601ad4a230a47362803536c7aa6b544c395c73a3bcb28e64ca34b2c9b01a5a12cf1

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    itrp-client (1.1.0)
+    itrp-client (1.1.1)
       activesupport
       gem_config
       mime-types

data/lib/itrp/client.rb

@@ -310,17 +310,17 @@ module Itrp
   Client.send(:prepend, SendWithRateLimitBlock)
 
   module SendWithRetries
-    # Wraps the _send method with retries when the server does not responsd, see +initialize+ option +:retries+
+    # Wraps the _send method with retries when the server does not respond, see +initialize+ option +:retries+
     def _send(request, domain = @domain, port = @port, ssl = @ssl)
       retries = 0
       sleep_time = 2
       total_retry_time = 0
       begin
         _response = super(request, domain, port, ssl)
-        @logger.warn { "Request failed, retry ##{retries += 1} in #{sleep_time} seconds: #{_response.message}" } and sleep(sleep_time) if _response.empty? && option(:max_retry_time) > 0
+        @logger.warn { "Request failed, retry ##{retries += 1} in #{sleep_time} seconds: #{_response.message}" } and sleep(sleep_time) if (_response.raw.code.to_s != '204' && _response.empty?) && option(:max_retry_time) > 0
         total_retry_time += sleep_time
         sleep_time *= 2
-      end while _response.empty? && total_retry_time < option(:max_retry_time)
+      end while (_response.raw.code.to_s != '204' && _response.empty?) && total_retry_time < option(:max_retry_time)
       _response
     end
   end

data/lib/itrp/client/response.rb

@@ -50,7 +50,7 @@ module Itrp
 
     # +true+ if the server did not respond at all
     def empty?
-      @response.body.nil?
+      @response.body.blank?
     end
 
     # +true+ if no 'message' is given (and the JSON could be parsed)

data/lib/itrp/client/version.rb

@@ -1,5 +1,5 @@
 module Itrp
   class Client
-    VERSION = '1.1.1'
+    VERSION = '1.1.2'
   end
 end

data/spec/lib/itrp/client_spec.rb

@@ -218,9 +218,11 @@ describe Itrp::Client do
   context 'delete' do
     it 'should send delete requests with parameters and headers' do
       client = Itrp::Client.new(api_token: 'secret', max_retry_time: -1)
-      stub = stub_request(:delete, 'https://api.itrp.com/v1/people?id=value').with(basic_auth: ['secret', 'x']).with(headers: {'X-ITRP-Custom' => 'custom'}).to_return(body: {id: 101}.to_json)
-      client.delete('people', {id: 'value'}, {'X-ITRP-Custom' => 'custom'})
+      stub = stub_request(:delete, 'https://api.itrp.com/v1/people?id=value').with(basic_auth: ['secret', 'x']).with(headers: {'X-ITRP-Custom' => 'custom'}).to_return(body: '', status: 204)
+      response = client.delete('people', {id: 'value'}, {'X-ITRP-Custom' => 'custom'})
       expect(stub).to have_been_requested
+      expect(response.valid?).to be_truthy
+      expect(response.json).to eq({})
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: itrp-client
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - ITRP
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-16 00:00:00.000000000 Z
+date: 2017-03-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gem_config
@@ -171,7 +171,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Client for accessing the ITRP REST API