itest5ch 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 86a8195d9e6ada1f2c79881c16c2c8cebaa8b0e5ecfaaee7cba362b37b690186
-  data.tar.gz: 7706d01fbd21c45d087bb2a246821fdb7144d91bb7b29811431b7a2d9109eb99
+  metadata.gz: f251ffea58aa4e5c48a3cbd23bee8ad24606c35b2a16b54cd222eb9b316f8c46
+  data.tar.gz: 96dca691f9944e501d58d3778b74d71e206a9084703a53afcafdab42e12d298e
 SHA512:
-  metadata.gz: 43681bd069b97857699bd6f20ca707e38bda2b03955dbad3c82d4942e30ee02530e095a84e00b1c8ff3ad0a7a9d48115b41fff6fe2cf3b68d14c1e37d27fc00f
-  data.tar.gz: 9f83f6bd52b8096e497e8f44ea4a5094f402b65f711a6a0344fc281c9a92f537e0bb8678181553f11d0a6a4d23787a8cebe9c373868ed14e6756b2a3c399f248
+  metadata.gz: 5de1b52879f6e4e7aa7b51eedf5965d44f86e9b3ba15b34ac0330725809f107063c12a36725d7abd4e5c82efec3d4996137d032eb5c90f8bfe7fad1d4d5d75c0
+  data.tar.gz: 44ed76e9b5db2382e6d72d755c6e21c9125408cebc42cc48a9415aeefd1a8da5ec5db61c43b96b711be4c906b271f27e89b32ec87096563194d572a3f94d91ce

data/.circleci/config.yml

@@ -6,7 +6,7 @@ version: 2.1
 
 orbs:
   codeclimate: sue445/codeclimate@volatile
-  ruby-orbs:   sue445/ruby-orbs@volatile
+  slack:       circleci/slack@3
 
 executors:
   ruby:
@@ -27,6 +27,12 @@ executors:
       CC_TEST_REPORTER_ID: d91e7c9665019f1574eb4c5a3de1547c80bc3062e3c297282f106501a3c5c694
     working_directory: ~/app
 
+commands:
+  bundle_install:
+    steps:
+      - run: bundle config --local path vendor/bundle
+      - run: bundle install --jobs=4 --retry=3
+
 jobs:
   rspec:
     parameters:
@@ -40,15 +46,12 @@ jobs:
       - run: ruby --version
       - run: bundle --version
       - run: gem --version
-      - ruby-orbs/bundle-install:
-          cache_key_prefix: "v2-rspec"
-          with_gemfile_lock: false
-          gemspec_name: "itest5ch"
-          update_always: true
+      - bundle_install
       - codeclimate/with-cc-test-reporter:
           after_build_args: "--coverage-input-type simplecov"
           steps:
             - run: bundle exec rspec
+      - slack/notify-on-failure
 
   rubocop:
     executor:
@@ -56,24 +59,19 @@ jobs:
 
     steps:
       - checkout
-      - ruby-orbs/bundle-install:
-          cache_key_prefix: "v2-rubocop"
-          with_gemfile_lock: false
-          gemspec_name: "itest5ch"
-          update_always: true
-
+      - bundle_install
       - run: bundle exec rubocop
+      - slack/notify-on-failure
 
 build_jobs: &build_jobs
   - rspec:
-      name:    "rspec:2.5"
-      version: "2.5"
-  - rspec:
-      name:    "rspec:2.6"
-      version: "2.6"
-  - rspec:
-      name:    "rspec:2.7"
-      version: "2.7"
+      matrix:
+        parameters:
+          version:
+            - "2.5"
+            - "2.6"
+            - "2.7"
+            - "3.0"
   - rubocop
 
 workflows:
@@ -85,7 +83,7 @@ workflows:
   weekly_build:
     triggers:
       - schedule:
-          cron: "00 19 * * 5" # JST 4:00 (Sat)
+          cron: "00 10 * * 5" # JST 19:00 (Fri)
           filters:
             branches:
               only: master

data/.rubocop.yml

@@ -7,6 +7,8 @@ AllCops:
   TargetRubyVersion: 2.5
   # uncomment if use rails cops
   # TargetRailsVersion: 5.1
+  NewCops: enable
+  SuggestExtensions: false
 
 require:
   - rubocop-performance
@@ -18,3 +20,6 @@ Layout/HashAlignment:
 RSpec/FilePath:
   Exclude:
     - spec/integration_spec.rb
+
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 ## master
-[full changelog](http://github.com/sue445/itest5ch/compare/v2.0.0...master)
+[full changelog](http://github.com/sue445/itest5ch/compare/v2.0.1...master)
+
+## v2.0.1
+[full changelog](http://github.com/sue445/itest5ch/compare/v2.0.0...v2.0.1)
+
+* Upgrade rubocop gems
+  * https://github.com/sue445/itest5ch/pull/79
 
 ## v2.0.0
 [full changelog](http://github.com/sue445/itest5ch/compare/v1.0.0...v2.0.0)

data/Gemfile

@@ -4,7 +4,3 @@ git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in itest5ch.gemspec
 gemspec
-
-group :development do
-  gem "onkcop", github: "sue445/onkcop", require: false, branch: "develop"
-end

data/README.md

@@ -3,7 +3,7 @@
 5ch (a.k.a. 2ch) reader via http://itest.5ch.net/
 
 [![Gem Version](https://badge.fury.io/rb/itest5ch.svg)](https://badge.fury.io/rb/itest5ch)
-[![CircleCI](https://circleci.com/gh/sue445/itest5ch/tree/master.svg)](https://circleci.com/gh/sue445/itest5ch/tree/master)
+[![CircleCI](https://circleci.com/gh/sue445/itest5ch/tree/master.svg?style=svg)](https://circleci.com/gh/sue445/itest5ch/tree/master)
 [![Coverage Status](https://coveralls.io/repos/github/sue445/itest5ch/badge.svg)](https://coveralls.io/github/sue445/itest5ch)
 [![Maintainability](https://api.codeclimate.com/v1/badges/14a81b3f7da11e475242/maintainability)](https://codeclimate.com/github/sue445/itest5ch/maintainability)
 

data/bin/console

@@ -6,5 +6,5 @@ require "itest5ch"
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
 
-require "pry"
-Pry.start
+require "irb"
+IRB.start

data/itest5ch.gemspec

@@ -28,16 +28,16 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "activesupport"
   spec.add_development_dependency "bundler", ">= 1.16"
   spec.add_development_dependency "coveralls"
-  spec.add_development_dependency "pry-byebug"
+  spec.add_development_dependency "onkcop", "1.0.0.0"
   spec.add_development_dependency "rake", ">= 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "rspec-its"
   spec.add_development_dependency "rspec-parameterized"
-  spec.add_development_dependency "rubocop", "0.78.0"
-  spec.add_development_dependency "rubocop-performance", "1.5.2"
-  spec.add_development_dependency "rubocop-rspec", "1.37.1"
+  spec.add_development_dependency "rubocop", "1.8.0"
   spec.add_development_dependency "rubocop_auto_corrector"
-  spec.add_development_dependency "simplecov"
+  spec.add_development_dependency "rubocop-performance", "1.9.2"
+  spec.add_development_dependency "rubocop-rspec", "2.1.0"
+  spec.add_development_dependency "simplecov", "< 0.18.0"
   spec.add_development_dependency "unparser", ">= 0.4.5"
   spec.add_development_dependency "webmock"
   spec.add_development_dependency "yard"

data/lib/itest5ch/board_list_page.rb

@@ -19,20 +19,20 @@ module Itest5ch
 
     private
 
-    def get_boards(ul)
-      ul.search("/li").select {|li| board_element?(li) }.each_with_object([]) do |li, boards|
-        url = URI.join(BOARDS_URL, li.at("/a")["href"]).to_s
-        name = li.inner_text.strip
+      def get_boards(ul)
+        ul.search("/li").select {|li| board_element?(li) }.each_with_object([]) do |li, boards|
+          url = URI.join(BOARDS_URL, li.at("/a")["href"]).to_s
+          name = li.inner_text.strip
 
-        boards << Board.new(url, name: name)
+          boards << Board.new(url, name: name)
+        end
       end
-    end
 
-    def board_element?(li)
-      return false unless li["class"].include?("pure-menu-item")
-      return false if li["class"].include?("pure-menu-selected")
+      def board_element?(li)
+        return false unless li["class"].include?("pure-menu-item")
+        return false if li["class"].include?("pure-menu-selected")
 
-      true
-    end
+        true
+      end
   end
 end

data/lib/itest5ch/http_methods.rb

@@ -12,7 +12,7 @@ module Itest5ch
       options["User-Agent"] = Itest5ch.config.user_agent if Itest5ch.config.user_agent
       options["Referer"] = referer if referer
 
-      URI.open(url, options).read
+      URI.parse(url).open(options).read
     end
 
     # @param url [String]

data/lib/itest5ch/thread.rb

@@ -119,55 +119,55 @@ module Itest5ch
 
     private
 
-    # @param hash [Hash]
-    def initialize_with_hash(hash)
-      assert_required_keys!(hash, :subdomain, :board, :dat)
-
-      @subdomain = hash[:subdomain]
-      @board     = hash[:board]
-      @dat       = hash[:dat]
-      @name      = hash[:name]
-    end
-
-    # @param url [String]
-    def initialize_with_string(url)
-      if (m = url.match(%r{https?://itest\.5ch\.net/(.+)/test/read\.cgi/([^/]+)/([0-9]+)}))
-        @subdomain = m[1]
-        @board     = m[2]
-        @dat       = m[3].to_i
-        return
+      # @param hash [Hash]
+      def initialize_with_hash(hash)
+        assert_required_keys!(hash, :subdomain, :board, :dat)
+
+        @subdomain = hash[:subdomain]
+        @board     = hash[:board]
+        @dat       = hash[:dat]
+        @name      = hash[:name]
       end
 
-      if (m = url.match(%r{https?://(.+)\.5ch\.net/test/read\.cgi/([^/]+)/([0-9]+)}))
-        @subdomain = m[1]
-        @board     = m[2]
-        @dat       = m[3].to_i
-        return
+      # @param url [String]
+      def initialize_with_string(url)
+        if (m = url.match(%r{https?://itest\.5ch\.net/(.+)/test/read\.cgi/([^/]+)/([0-9]+)}))
+          @subdomain = m[1]
+          @board     = m[2]
+          @dat       = m[3].to_i
+          return
+        end
+
+        if (m = url.match(%r{https?://(.+)\.5ch\.net/test/read\.cgi/([^/]+)/([0-9]+)}))
+          @subdomain = m[1]
+          @board     = m[2]
+          @dat       = m[3].to_i
+          return
+        end
+
+        raise ArgumentError, "'#{url}' is invalid url format"
       end
 
-      raise ArgumentError, "'#{url}' is invalid url format"
-    end
-
-    # @return [Hash]
-    def fetch_data
-      get_json(json_url, referer: smartphone_url)
-    end
+      # @return [Hash]
+      def fetch_data
+        get_json(json_url, referer: smartphone_url)
+      end
 
-    # @return [String] random 10 char string
-    def rand
-      SecureRandom.hex(5)
-    end
+      # @return [String] random 10 char string
+      def rand
+        SecureRandom.hex(5)
+      end
 
-    # @param unixtime [Integer]
-    #
-    # @return [ActiveSupport::TimeWithZone] When `Time.zone` is initialized
-    # @return [Time] When `Time.zone` is not initialized or without activesupport
-    def time_at(unixtime)
-      if Time.respond_to?(:zone) && Time.zone.respond_to?(:at)
-        Time.zone.at(unixtime)
-      else
-        Time.at(unixtime)
+      # @param unixtime [Integer]
+      #
+      # @return [ActiveSupport::TimeWithZone] When `Time.zone` is initialized
+      # @return [Time] When `Time.zone` is not initialized or without activesupport
+      def time_at(unixtime)
+        if Time.respond_to?(:zone) && Time.zone.respond_to?(:at)
+          Time.zone.at(unixtime)
+        else
+          Time.at(unixtime)
+        end
       end
-    end
   end
 end

data/lib/itest5ch/version.rb

@@ -1,3 +1,3 @@
 module Itest5ch
-  VERSION = "2.0.0".freeze
+  VERSION = "2.0.1".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: itest5ch
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - sue445
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-01-01 00:00:00.000000000 Z
+date: 2021-01-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hpricot
@@ -81,19 +81,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry-byebug
+  name: onkcop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.0.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.0.0.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -156,70 +156,70 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.78.0
+        version: 1.8.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.78.0
+        version: 1.8.0
 - !ruby/object:Gem::Dependency
-  name: rubocop-performance
+  name: rubocop_auto_corrector
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.5.2
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.5.2
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop-rspec
+  name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.37.1
+        version: 1.9.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.37.1
+        version: 1.9.2
 - !ruby/object:Gem::Dependency
-  name: rubocop_auto_corrector
+  name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.1.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.18.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.18.0
 - !ruby/object:Gem::Dependency
   name: unparser
   requirement: !ruby/object:Gem::Requirement
@@ -296,7 +296,7 @@ homepage: https://github.com/sue445/itest5ch
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -311,8 +311,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.2.3
+signing_key:
 specification_version: 4
 summary: 5ch (a.k.a. 2ch) reader via itest.5ch.net
 test_files: []