item_list 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 438e2853650eeb72e42c08abe83346368e4ff33d
-  data.tar.gz: 1575e3bb987a0b9848a92314ac2dcdd9925ac92e
+  metadata.gz: ee2c24c2b427582794c42d3c0a784ef61c572248
+  data.tar.gz: 945f1a5d0f7999b9e20a7bf76e521dc031e99253
 SHA512:
-  metadata.gz: ca6908a7f2855a3d442525e7b00a03ca7b0480ea1e597053e7ef227e599d2fb387c0334814740d8f06561f9226c4d4153f0d11748da638951887172c605f96bb
-  data.tar.gz: 52f371844f4e4667834eaaa51b04489305639563b9188d5bf3d4282abc1a996127f7dad61e5e64a2549182a7a97dc1789d2d1b2823147829d04f02d024cc92f5
+  metadata.gz: a4ba181c737e0b37528635db1667a24b071dc11c94f6bf4ec7a2b6bd6f692dae3c41e5579a1f327107efc7f97d9f776247dc25f6d7ac6ffa050a59bf38e468e0
+  data.tar.gz: 65c2a501e3e517c64e990c09c8201b2e6604deb71646f3872c10b0f1c92d084d5aa7461dc81b595a0fcabcfbc7e65931197f15f85054c08a9d594b27be98d2b1

data/Gemfile

@@ -1,6 +1,6 @@
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in item_list.gemspec
 gemspec

data/Rakefile

@@ -1,6 +1,6 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/bin/console

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
-require "bundler/setup"
-require "item_list"
+require 'bundler/setup'
+require 'item_list'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -10,5 +10,5 @@ require "item_list"
 # require "pry"
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start(__FILE__)

data/item_list.gemspec

@@ -1,29 +1,32 @@
 # coding: utf-8
-lib = File.expand_path("../lib", __FILE__)
+
+lib = File.expand_path('../lib', __FILE__)
+
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require "item_list/version"
+require 'item_list/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "item_list"
+  spec.name          = 'item_list'
   spec.version       = ItemList::VERSION
-  spec.authors       = ["Austin Rowsell"]
-  spec.email         = ["andyrow123@hotmail.co.uk"]
+  spec.authors       = ['Austin Rowsell']
+  spec.email         = ['andyrow123@hotmail.co.uk']
 
-  spec.summary       = "Create an item list form an array of objects"
-  spec.description   = "Create an item list form an array of objects"
-  spec.homepage      = "https://github.com/andyrow123/item_list"
-  spec.license       = "MIT"
+  spec.summary       = 'Create an item list form an array of objects'
+  spec.description   = 'Create an item list form an array of objects'
+  spec.homepage      = 'https://github.com/andyrow123/item_list'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
   end
-  spec.bindir        = "exe"
+  spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_development_dependency "bundler", "~> 1.15"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "rspec", "~> 3.0"
-  spec.add_development_dependency "simplecov", "~> 0.14.1"
-  spec.add_development_dependency "simplecov-console", "~> 0.4.1"
+  spec.add_development_dependency 'bundler', '~> 1.15'
+  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rubocop', '~> 0.48.1'
+  spec.add_development_dependency 'rspec', '~> 3.0'
+  spec.add_development_dependency 'simplecov', '~> 0.14.1'
+  spec.add_development_dependency 'simplecov-console', '~> 0.4.1'
 end

data/lib/item_list/version.rb

@@ -1,3 +1,3 @@
 module ItemList
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/lib/item_list_printer.rb

@@ -1,15 +1,16 @@
 require 'item_printer'
 
+# ItemListPrinter
 module ItemListPrinter
   def self.to_string(items, item_printer = ItemPrinter)
-    items.each_with_index.map { |item, index|
-      item_printer.to_string(item, index + 1)
-    }.join("\n")
+    items.each_with_index
+         .map { |item, index| item_printer.to_string(item, index + 1) }
+         .join("\n")
   end
 
   def self.to_summary(items, keys, item_printer = ItemPrinter)
-    items.each_with_index.map { |item, index|
-      item_printer.to_summary(item, keys, index + 1)
-    }.join("\n")
+    items.each_with_index
+         .map { |item, index| item_printer.to_summary(item, keys, index + 1) }
+         .join("\n")
   end
-end
+end

data/lib/item_printer.rb

@@ -1,15 +1,13 @@
+##
+# This module takes in an item and returns a string.
 module ItemPrinter
   def self.to_string(item, index)
     str = "#{index}. "
-    str << item.keys.map { |key|
-      "#{item[key]}          "
-    }.join
+    str << item.keys.map { |key| item[key].to_s }.join(' ')
   end
 
   def self.to_summary(item, keys, index)
     str = "#{index}. "
-    str << keys.map { |key|
-      "#{item[key]}          "
-    }.join
+    str << keys.map { |key| item[key].to_s }.join(' ')
   end
-end
+end

data/lib/list.rb

@@ -1,5 +1,6 @@
 require 'item_list_printer'
 
+# List
 class List
   attr_reader :items
 
@@ -8,13 +9,13 @@ class List
   end
 
   def add(item)
-    fail 'Already exists in list' if found?(item)
+    raise 'Already exists in list' if found?(item)
     @items << item
     'Success'
   end
 
   def remove(item)
-    fail 'Not found in list' unless found?(item)
+    raise 'Not found in list' unless found?(item)
     @items.delete(item)
     'Success'
   end
@@ -32,7 +33,7 @@ class List
   end
 
   def find(item)
-    all.select { |arr| arr == item }
+    all.detect { |arr| arr == item }
   end
 
   private

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: item_list
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Austin Rowsell
@@ -38,6 +38,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.48.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.48.1
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement