itax_code 2.0.3 → 2.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6055ffa03056e37ff605e5273139c5cea2e996e8e1e0f05abf5756ddcb313387
-  data.tar.gz: 5f7670f8a377c36470b2e9cd579aea1eedaaebc585b457ca3ca2bda4444d161e
+  metadata.gz: 28b67a1393b6940ab8824514b430ecfee7cb9a7eca1208b6f6656b25049d933b
+  data.tar.gz: 8d2b668cb365b5831cfa2c384ab3b1525fb50f289e7c470310bcb4c963d88217
 SHA512:
-  metadata.gz: dc8016fd81f3524b133a66779db88cee832f7069debd04ddafd5cbcde0039ddaeee24726d1c7da6417be387cdef395eb0d0c739168ca03aaacd067d8b2884229
-  data.tar.gz: 878dc4e0fba9a272474c78ae98a23c0565db0eb1a32009e84c1cbf6489b03418405c0d25d00d09aa8c3188310a4e0ba3b30052792f0dd5a55c4f3226ff3500fd
+  metadata.gz: cda714e70c20caefb01d356b281fac5dd8eb600149ecaaba77ad40dc58240e69bedc63d7259e0b4578724be756f960af07584977f3e90b9539cdb65be1c4167e
+  data.tar.gz: 877e5c56c488137c377a7a93fe4de8bf1b7ff7f49fbd23a1ed6ce483628d2b919edc2bed32d87eb9cace9987a55743c4f3fb5537a390ac6e1b1cbd93bdc49728

data/.github/workflows/test.yml

@@ -37,7 +37,7 @@ jobs:
           ruby-version: 3.2
       - run: bundle install
       - name: Test & publish code coverage
-        uses: paambaati/codeclimate-action@v5.0.0
+        uses: paambaati/codeclimate-action@v6.0.0
         env:
           CC_TEST_REPORTER_ID: ${{secrets.CC_TEST_REPORTER_ID}}
         with:

data/.rubocop.yml

@@ -45,6 +45,11 @@ Metrics/MethodLength:
   Enabled: true
   CountAsOne: ['array', 'hash']
 
+Metrics/ModuleLength:
+  Enabled: true
+  Exclude:
+    - 'lib/itax_code/utils.rb'
+
 Style/Documentation:
   Enabled: false
 

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## [2.0.4](https://github.com/matteoredz/itax-code/compare/v2.0.3...v2.0.4) (2024-05-02)
+
+
+### Continuous Integration
+
+* update paambaati/codeclimate-action to v6.0.0 ([#55](https://github.com/matteoredz/itax-code/issues/55)) ([e7aad01](https://github.com/matteoredz/itax-code/commit/e7aad0168aa18df97235171082e9bd40287dee84))
+
+
+### Code Refactoring
+
+* converted Utils class in module ([#53](https://github.com/matteoredz/itax-code/issues/53)) ([99dddee](https://github.com/matteoredz/itax-code/commit/99dddee715b3bc5deccd27c6734832e7f9ec7cd0))
+
 ## [2.0.3](https://github.com/matteoredz/itax-code/compare/v2.0.2...v2.0.3) (2024-02-20)
 
 

data/lib/itax_code/encoder.rb

@@ -22,7 +22,7 @@ module ItaxCode
     # @option data [String]       :gender     The user gender
     # @option data [String, Date] :birthdate  The user birthdate
     # @option data [String]       :birthplace The user birthplace
-    def initialize(data = {}, utils = Utils.new)
+    def initialize(data = {}, utils = Utils)
       @utils = utils
 
       @surname    = data[:surname]

data/lib/itax_code/omocode.rb

@@ -8,7 +8,7 @@ module ItaxCode
     #
     # @param [String] tax_code
     # @param [Utils]  utils
-    def initialize(tax_code, utils = Utils.new)
+    def initialize(tax_code, utils = Utils)
       @tax_code = tax_code
       @utils    = utils
     end

data/lib/itax_code/parser.rb

@@ -15,7 +15,7 @@ module ItaxCode
 
     # @param [String] tax_code
     # @param [Utils]  utils
-    def initialize(tax_code, utils = Utils.new)
+    def initialize(tax_code, utils = Utils)
       @tax_code = tax_code&.upcase
       @utils    = utils
 

data/lib/itax_code/utils.rb

@@ -4,148 +4,152 @@ require "csv"
 require "itax_code/transliterator"
 
 module ItaxCode
-  class Utils
-    def blank?(obj)
-      obj.respond_to?(:empty?) ? !!obj.empty? : !obj
-    end
-
-    def present?(obj)
-      !blank?(obj)
-    end
-
-    def slugged(string)
-      transliterated = transliterate(string.downcase.strip)
-      transliterated.gsub(/[^\w-]+/, "-").gsub(/-{2,}/, "-").gsub(/^-+|-+$/, "")
-    end
-
-    def transliterate(string)
-      return string if string.ascii_only?
-
-      transliterator = Transliterator.new
-      transliterator.transliterate(string.unicode_normalize(:nfc))
-    end
-
-    def tax_code_sections_regex
-      /^([A-Z]{3})([A-Z]{3})
-        (([A-Z\d]{2})([ABCDEHLMPRST]{1})([A-Z\d]{2}))
-        ([A-Z]{1}[A-Z\d]{3})
-        ([A-Z]{1})$/x
-    end
-
-    def months
-      %w[A B C D E H L M P R S T]
-    end
+  module Utils
+    class << self
+      def blank?(obj)
+        obj.respond_to?(:empty?) ? !!obj.empty? : !obj
+      end
 
-    def consonants
-      %w[b c d f g h j k l m n p q r s t v w x y z]
-    end
+      def present?(obj)
+        !blank?(obj)
+      end
 
-    def vowels
-      %w[a e i o u]
-    end
+      def slugged(string)
+        transliterated = transliterate(string.downcase.strip)
+        transliterated.gsub(/[^\w-]+/, "-").gsub(/-{2,}/, "-").gsub(/^-+|-+$/, "")
+      end
 
-    def cin
-      {
-        "0" => [0, 1],
-        "1" => [1, 0],
-        "2" => [2, 5],
-        "3" => [3, 7],
-        "4" => [4, 9],
-        "5" => [5, 13],
-        "6" => [6, 15],
-        "7" => [7, 17],
-        "8" => [8, 19],
-        "9" => [9, 21],
-        "A" => [0, 1],
-        "B" => [1, 0],
-        "C" => [2, 5],
-        "D" => [3, 7],
-        "E" => [4, 9],
-        "F" => [5, 13],
-        "G" => [6, 15],
-        "H" => [7, 17],
-        "I" => [8, 19],
-        "J" => [9, 21],
-        "K" => [10, 2],
-        "L" => [11, 4],
-        "M" => [12, 18],
-        "N" => [13, 20],
-        "O" => [14, 11],
-        "P" => [15, 3],
-        "Q" => [16, 6],
-        "R" => [17, 8],
-        "S" => [18, 12],
-        "T" => [19, 14],
-        "U" => [20, 16],
-        "V" => [21, 10],
-        "W" => [22, 22],
-        "X" => [23, 25],
-        "Y" => [24, 24],
-        "Z" => [25, 23]
-      }
-    end
+      def transliterate(string)
+        return string if string.ascii_only?
 
-    def cin_remainders
-      ("A".."Z").to_a
-    end
+        transliterator = Transliterator.new
+        transliterator.transliterate(string.unicode_normalize(:nfc))
+      end
 
-    def omocodia
-      {
-        "0": "L", "1": "M", "2": "N", "3": "P", "4": "Q",
-        "5": "R", "6": "S", "7": "T", "8": "U", "9": "V"
-      }
-    end
+      def tax_code_sections_regex
+        /^([A-Z]{3})([A-Z]{3})
+          (([A-Z\d]{2})([ABCDEHLMPRST]{1})([A-Z\d]{2}))
+          ([A-Z]{1}[A-Z\d]{3})
+          ([A-Z]{1})$/x
+      end
 
-    def omocodia_digits
-      omocodia.keys.join
-    end
+      def months
+        %w[A B C D E H L M P R S T]
+      end
 
-    def omocodia_letters
-      omocodia.values.join
-    end
+      def omocodia_indexes
+        [6, 7, 9, 10, 12, 13, 14].reverse
+      end
 
-    def omocodia_indexes
-      [6, 7, 9, 10, 12, 13, 14].reverse
-    end
+      def omocodia_indexes_combos
+        (1..omocodia_indexes.size).flat_map do |index|
+          omocodia_indexes.combination(index).to_a
+        end
+      end
 
-    def omocodia_indexes_combos
-      (1..omocodia_indexes.size).flat_map do |index|
-        omocodia_indexes.combination(index).to_a
+      def omocodia_encode(val)
+        val.tr omocodia_digits, omocodia_letters
       end
-    end
 
-    def omocodia_encode(val)
-      val.tr omocodia_digits, omocodia_letters
-    end
+      def omocodia_decode(val)
+        val.tr omocodia_letters, omocodia_digits
+      end
 
-    def omocodia_decode(val)
-      val.tr omocodia_letters, omocodia_digits
-    end
+      def extract_consonants(str)
+        str.select { |c| consonants.include? c }.join
+      end
 
-    def extract_consonants(str)
-      str.select { |c| consonants.include? c }.join
-    end
+      def extract_vowels(str)
+        str.select { |c| vowels.include? c }.join
+      end
 
-    def extract_vowels(str)
-      str.select { |c| vowels.include? c }.join
-    end
+      def encode_cin(code)
+        cin_tot = 0
 
-    def encode_cin(code)
-      cin_tot = 0
+        code[0..14].each_char.with_index do |char, i|
+          cin_tot += cin[char][((i + 1) % 2).to_i]
+        end
 
-      code[0..14].each_char.with_index do |char, i|
-        cin_tot += cin[char][((i + 1) % 2).to_i]
+        cin_remainders[cin_tot % 26]
       end
 
-      cin_remainders[cin_tot % 26]
-    end
+      def cities
+        CSV.foreach("#{__dir__}/data/cities.csv", headers: true)
+      end
 
-    def cities
-      CSV.foreach("#{__dir__}/data/cities.csv", headers: true)
-    end
+      def countries
+        CSV.foreach("#{__dir__}/data/countries.csv", headers: true)
+      end
 
-    def countries
-      CSV.foreach("#{__dir__}/data/countries.csv", headers: true)
+      private
+
+        def omocodia_letters
+          omocodia.values.join
+        end
+
+        def omocodia_digits
+          omocodia.keys.join
+        end
+
+        def consonants
+          %w[b c d f g h j k l m n p q r s t v w x y z]
+        end
+
+        def vowels
+          %w[a e i o u]
+        end
+
+        def cin
+          {
+            "0" => [0, 1],
+            "1" => [1, 0],
+            "2" => [2, 5],
+            "3" => [3, 7],
+            "4" => [4, 9],
+            "5" => [5, 13],
+            "6" => [6, 15],
+            "7" => [7, 17],
+            "8" => [8, 19],
+            "9" => [9, 21],
+            "A" => [0, 1],
+            "B" => [1, 0],
+            "C" => [2, 5],
+            "D" => [3, 7],
+            "E" => [4, 9],
+            "F" => [5, 13],
+            "G" => [6, 15],
+            "H" => [7, 17],
+            "I" => [8, 19],
+            "J" => [9, 21],
+            "K" => [10, 2],
+            "L" => [11, 4],
+            "M" => [12, 18],
+            "N" => [13, 20],
+            "O" => [14, 11],
+            "P" => [15, 3],
+            "Q" => [16, 6],
+            "R" => [17, 8],
+            "S" => [18, 12],
+            "T" => [19, 14],
+            "U" => [20, 16],
+            "V" => [21, 10],
+            "W" => [22, 22],
+            "X" => [23, 25],
+            "Y" => [24, 24],
+            "Z" => [25, 23]
+          }
+        end
+
+        def cin_remainders
+          ("A".."Z").to_a
+        end
+
+        def omocodia
+          {
+            "0": "L", "1": "M", "2": "N", "3": "P", "4": "Q",
+            "5": "R", "6": "S", "7": "T", "8": "U", "9": "V"
+          }
+        end
     end
   end
 end

data/lib/itax_code/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ItaxCode
-  VERSION = "2.0.3"
+  VERSION = "2.0.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: itax_code
 version: !ruby/object:Gem::Version
-  version: 2.0.3
+  version: 2.0.4
 platform: ruby
 authors:
 - Matteo Rossi
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-02-20 00:00:00.000000000 Z
+date: 2024-05-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: csv