itamae 1.10.5 → 1.10.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 93fef6667e949b9833a0d5f44b09982bbb0c6415ec44c57baa8e0f27eab322e8
-  data.tar.gz: b772ed894784fdbb1c739f4b75a6af0bc0adb5a88b009fd87d0dbca8d39e8077
+  metadata.gz: 970a26489acd9ea22bf195f85ab44de09e0dcc9a332903b8b5a604eec57369dc
+  data.tar.gz: d31dd215ffcc046c7f1f6d3010b304b02797d049ef482c6e16c19d801812fae3
 SHA512:
-  metadata.gz: 38cb17e76859562485e7f2520fb6eacafd442b3e73cd30c4b8b1c0bf883f9c838c5d57c9978314a08fde591bfdac6b1ee5d52ad26c40b4374744e8cc22d5d716
-  data.tar.gz: 16d2e0043cbc92b65882c4d5d3684cd82e60fe09d59f7c30f7e995942475b4bbd74383cde73c4188fc387966a654578d3a540865d65e04e5210d6772c1770a43
+  metadata.gz: 879ee326cf3867a88b80d6ea2f4f54e37d62c97834628169e76488439e95a4795e44b80883abe550128452967b633f5bfe772e432aaf7cccaae331a8abc1dd26
+  data.tar.gz: e127f11a419f00b80ac3e019d48121972f66f65535d8e16ef92d7f1c627ef75c409c977d812cff7a8a1462febc5941ab77a606a5e2b8ba5f2b5c5a6ccdb1b993

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 ## Unreleased
-[full changelog](https://github.com/itamae-kitchen/itamae/compare/v1.10.5...master)
+[full changelog](https://github.com/itamae-kitchen/itamae/compare/v1.10.6...master)
+
+## v1.10.6
+[full changelog](https://github.com/itamae-kitchen/itamae/compare/v1.10.5...v1.10.6)
+
+Improvements
+
+- [Don't use `sudo` when `--no-sudo` is passed](https://github.com/itamae-kitchen/itamae/pull/302)
 
 ## v1.10.5
 [full changelog](https://github.com/itamae-kitchen/itamae/compare/v1.10.4...v1.10.5)

data/lib/itamae/backend.rb

@@ -188,7 +188,7 @@ module Itamae
         end
 
         user = options[:user]
-        if user
+        if user && use_sudo?
           command = "cd ~#{user.shellescape} ; #{command}"
           command = "sudo -H -u #{user.shellescape} -- #{shell.shellescape} -c #{command.shellescape}"
         end
@@ -196,6 +196,11 @@ module Itamae
         command
       end
 
+      def use_sudo?
+        return true unless @options.key?(:sudo)
+        !!@options[:sudo]
+      end
+
       def shell
         @options[:shell] || '/bin/sh'
       end

data/lib/itamae/version.rb

@@ -1,3 +1,3 @@
 module Itamae
-  VERSION = "1.10.5"
+  VERSION = "1.10.6"
 end

data/spec/unit/lib/itamae/backend_spec.rb

@@ -17,38 +17,38 @@ module Itamae
 
       describe ".send_file" do
         context "the source file doesn't exist" do
-          subject { -> { itamae_backend.send_file("src", "dst") } }
-          it { expect(subject).to raise_error(Itamae::Backend::SourceNotExistError, "The file 'src' doesn't exist.") }
+          subject { itamae_backend.send_file("src", "dst") }
+          it { expect{ subject }.to raise_error(Itamae::Backend::SourceNotExistError, "The file 'src' doesn't exist.") }
         end
 
         context "the source file exist, but it is not a regular file" do
           before { Dir.mkdir("src")  }
-          subject { -> { itamae_backend.send_file("src", "dst") } }
-          it { expect(subject).to raise_error(Itamae::Backend::SourceNotExistError, "'src' is not a file.") }
+          subject { itamae_backend.send_file("src", "dst") }
+          it { expect{ subject }.to raise_error(Itamae::Backend::SourceNotExistError, "'src' is not a file.") }
         end
 
         context "the source file is a regular file" do
           before { FileUtils.touch("src")  }
-          subject { -> { itamae_backend.send_file("src", "dst") } }
+          subject { itamae_backend.send_file("src", "dst") }
           it { expect { subject }.not_to raise_error }
         end
       end
 
       describe ".send_directory" do
         context "the source directory doesn't exist" do
-          subject { -> { itamae_backend.send_directory("src", "dst") } }
-          it { expect(subject).to raise_error(Itamae::Backend::SourceNotExistError, "The directory 'src' doesn't exist.") }
+          subject { itamae_backend.send_directory("src", "dst") }
+          it { expect{ subject }.to raise_error(Itamae::Backend::SourceNotExistError, "The directory 'src' doesn't exist.") }
         end
 
         context "the source directory exist, but it is not a directory" do
           before { FileUtils.touch("src")  }
-          subject { -> { itamae_backend.send_directory("src", "dst") } }
-          it { expect(subject).to raise_error(Itamae::Backend::SourceNotExistError, "'src' is not a directory.") }
+          subject { itamae_backend.send_directory("src", "dst") }
+          it { expect{ subject }.to raise_error(Itamae::Backend::SourceNotExistError, "'src' is not a directory.") }
         end
 
         context "the source directory is a directory" do
           before { Dir.mkdir("src")  }
-          subject { -> { itamae_backend.send_directory("src", "dst") } }
+          subject { itamae_backend.send_directory("src", "dst") }
           it { expect { subject }.not_to raise_error }
         end
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: itamae
 version: !ruby/object:Gem::Version
-  version: 1.10.5
+  version: 1.10.6
 platform: ruby
 authors:
 - Ryota Arai
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-27 00:00:00.000000000 Z
+date: 2019-10-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
@@ -329,7 +329,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.1
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Simple Configuration Management Tool