isomorfeus-speednode 0.5.2 → 0.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 676da9269c67e955ccfe546dbbbc82bf079e796d1070dd8d699c6523dbc537ba
-  data.tar.gz: b78918192805e28a455e9c5d45594fdc3b683d93ddc6f0a38f13207afecb808a
+  metadata.gz: 11a836ac72dbce40b8926276342a91f3c7d3999b562f5be8670102e9b2196751
+  data.tar.gz: 1110a497795537221829ea361959a1b9c00e1570447744141b047efedecf2685
 SHA512:
-  metadata.gz: b933335621ed51658ade944312fea14e1a8b89ec71585e4b99a46fe3a2dc6c94ccc073f6013281ed19ad07d889e91a09bfad75784c9f5004c8a35e3124b4dd2f
-  data.tar.gz: 17c4dd51349c07013c961d714daee25f06c524edae7bb876cc0c78f7eda9519ea8be8c966840b86a08f019ef6b44540b31af09d52e5e8fd36c2576a84b702c44
+  metadata.gz: 0c4f86cf44a01774584782e12c94cb8bd4677c348f914aca3740c697297be2f843da12642683932bb5bd7470c7c1e87009373429644cfe871c11b50082d594df
+  data.tar.gz: 3ef559f6eecf237c5fb4a46ef3eadd243d8f482fef64170391fcaeeaed373a900401dfe4259d6d7bebf62200529ad54e8efc69f4c6cd887c022b02f701d91092

data/README.md

@@ -53,7 +53,7 @@ Evaluation in a permissive context:
 ExecJS.permissive_eval('1+1')
 ```
 
-### Storing scripts for repeated execution
+### Precompiling and Storing scripts for repeated execution
 
 Scripts can be precompiled and stored for repeated execution, which leads to a significant performance improvement, especially for larger scripts:
 ```ruby
@@ -61,6 +61,7 @@ context = ExecJS.compile('Test = "test"')
 context.add_script(key: 'super', source: some_large_javascript) # will compile and store the script
 context.eval_script(:key: 'super') # will run the precompiled script in the context
 ```
+For the actual performance benefit see below.
 
 ### Async function support
 
@@ -95,21 +96,24 @@ Attaching and calling ruby methods to/from permissive contexts is not that fast.
 
 Highly scientific, maybe.
 
-1000 rounds using node 16.6.2.:
+1000 rounds using node 16.14.0 on linux (ctx = using context, scsc = using precompiled scripts):
 ```
 standard ExecJS CoffeeScript eval benchmark:
-                                          user     system      total        real
-Isomorfeus Speednode Node.js (V8) Windows 0.079000   0.031000   0.110000 (  0.518821)
-Isomorfeus Speednode Node.js (V8) Linux   0.092049   0.039669   0.131718 (  0.546846)
-mini_racer (V8) 0.4.0 Linux only          0.776317   0.062923   0.839240 (  0.480490)
-Node.js (V8) Linux                        0.330156   0.354536  52.523972 ( 51.203355)
-
-evel overhead benchmark:
-                                          user     system      total        real
-Isomorfeus Speednode Node.js (V8) Windows 0.032000   0.031000   0.063000 (  0.227634)
-Isomorfeus Speednode Node.js (V8) Linux   0.085135   0.022002   0.107137 (  0.153055)
-mini_racer (V8) 0.4.0 Linux only          0.083562   0.115612   0.199174 (  0.128455)
-Node.js (V8) Linux                        0.273238   0.265101  30.169976 ( 29.636668)
+                                            user     system      total        real
+Isomorfeus Speednode Node.js (V8):      0.086443   0.061089   0.147532 (  0.567715)
+Isomorfeus Speednode Node.js (V8) ctx:  0.080821   0.047469   0.128290 (  0.468664)
+Isomorfeus Speednode Node.js (V8) scsc: 0.089423   0.046541   0.135964 (  0.381198) <- fastest
+mini_racer (V8):                        0.723352   0.179944   0.903296 (  0.513696)
+mini_racer (V8) ctx:                    0.475681   0.226101   0.701782 (  0.429463)
+
+eval overhead benchmark:
+                                            user     system      total        real
+Isomorfeus Speednode Node.js (V8):      0.028312   0.062895   0.091207 (  0.199176)
+Isomorfeus Speednode Node.js (V8) ctx:  0.061245   0.027093   0.088338 (  0.183092)
+Isomorfeus Speednode Node.js (V8) scsc: 0.061062   0.019203   0.080265 (  0.107898) <- fastest
+mini_racer (V8):                        0.103914   0.092251   0.196165 (  0.125081)
+mini_racer (V8) ctx:                    0.120440   0.060329   0.180769 (  0.112695)
+
 ```
 minify discourse benchmark from mini_racer:
 ```

data/lib/isomorfeus/speednode/attach_pipe.rb

@@ -10,9 +10,9 @@ module Isomorfeus
       ERROR_IO_PENDING      = 997
       ERROR_PIPE_CONNECTED  = 535
       ERROR_SUCCESS         = 0
-      
+
       FILE_FLAG_OVERLAPPED  = 0x40000000
-      
+
       INFINITE              = 0xFFFFFFFF
       INVALID_HANDLE_VALUE  = FFI::Pointer.new(-1).address
 
@@ -91,7 +91,7 @@ module Isomorfeus
         overlap[:hEvent] = @events[0]
 
         @pipe = { overlap: overlap, instance: nil, request: FFI::Buffer.new(1, BUFFER_SIZE), bytes_read: 0, reply: FFI::Buffer.new(1, BUFFER_SIZE), bytes_to_write: 0, state: nil, pending_io: false }
-        @pipe[:instance] = CreateNamedPipe(@full_pipe_name, 
+        @pipe[:instance] = CreateNamedPipe(@full_pipe_name,
                                           PIPE_ACCESS_DUPLEX | FILE_FLAG_OVERLAPPED,
                                           PIPE_TYPE_MESSAGE | PIPE_READMODE_MESSAGE | PIPE_WAIT,
                                           4,
@@ -102,7 +102,7 @@ module Isomorfeus
         raise "CreateNamedPipe failed with #{GetLastError()}" if @pipe[:instance] == INVALID_HANDLE_VALUE
         @pipe[:pending_io] = connect_to_new_client
         @pipe[:state] = @pipe[:pending_io] ? CONNECTING_STATE : READING_STATE
-        
+
         @events_pointer.write_array_of_ulong_long(@events)
         nil
       end
@@ -194,9 +194,9 @@ module Isomorfeus
       def disconnect_and_reconnect
         FlushFileBuffers(@pipe[:instance])
         STDERR.puts("DisconnectNamedPipe failed with #{GetLastError()}") if !DisconnectNamedPipe(@pipe[:instance])
-    
+
         @pipe[:pending_io] = connect_to_new_client
-        
+
         @pipe[:state] = @pipe[:pending_io] ? CONNECTING_STATE : READING_STATE
       end
 
@@ -207,7 +207,7 @@ module Isomorfeus
         connected = ConnectNamedPipe(@pipe[:instance], @pipe[:overlap].to_ptr)
         last_error = GetLastError()
         raise "ConnectNamedPipe failed with #{last_error} - #{connected}" if connected != 0
-        
+
         case last_error
         when ERROR_IO_PENDING
           pending_io = true

data/lib/isomorfeus/speednode/attach_socket.rb

@@ -29,9 +29,8 @@ module Isomorfeus
             rescue Errno::EAGAIN, Errno::EWOULDBLOCK
             end
           end
-          sleep 0.005
           ret = begin
-                  IO.select([@socket], nil, nil, 1) || next
+                  IO.select([@socket], nil, nil, nil) || next
                 rescue Errno::EBADF
                 end
         end
@@ -43,4 +42,4 @@ module Isomorfeus
       end
     end
   end
-end
+end

data/lib/isomorfeus/speednode/runner.js

@@ -243,6 +243,18 @@ function massageStackTrace(stack) {
 
 let socket_path = process.env.SOCKET_PATH;
 if (!socket_path) { throw 'No SOCKET_PATH given!'; };
+let debug_contexts = [];
+let commands_swapped = false;
+
+function swap_commands(c) {
+  c.oexec = c.exec;
+  c.exec = c.execd;
+  c.oeval = c.eval;
+  c.eval = c.evald;
+  c.oevsc = c.evsc;
+  c.evsc = c.evscd;
+  commands_swapped = true;
+}
 
 let commands = {
     attach: function(input) {
@@ -258,6 +270,14 @@ let commands = {
       let result = vm.runInContext(input.source, context, getContextOptions(input.context));
       return formatResult(result);
     },
+    created: function (input) {
+      debug_contexts.push(input.context);
+      if (!commands_swapped) {
+        swap_commands(commands);
+        let result = eval(input.source);
+        return formatResult(result);
+      } else { return formatResult(true) }
+    },
     createp: function (input) {
       let context = createPermissiveContext(input.context, input.options);
       let result = vm.runInContext(input.source, context, getContextOptions(input.context));
@@ -276,12 +296,30 @@ let commands = {
         let result = vm.runInContext(input.source, getContext(input.context), getContextOptions(input.context));
         return formatResult(result);
     },
+    execd: function(input) {
+      if (debug_contexts.includes(input.context)) {
+        let result = eval(input.source);
+        return formatResult(result);
+      } else {
+        return commands.oexec(input);
+      }
+    },
     eval: function (input) {
       if (input.source.match(/^\s*{/)) { input.source = "(" + input.source + ")"; }
       else if (input.source.match(/^\s*function\s*\(/)) { input.source = "(" + input.source + ")"; }
       let result = vm.runInContext(input.source, getContext(input.context), getContextOptions(input.context));
       return formatResult(result);
     },
+    evald: function(input) {
+      if (debug_contexts.includes(input.context)) {
+        if (input.source.match(/^\s*{/)) { input.source = "(" + input.source + ")"; }
+        else if (input.source.match(/^\s*function\s*\(/)) { input.source = "(" + input.source + ")"; }
+        let result = eval(input.source);
+        return formatResult(result);
+      } else {
+        return commands.oeval(input);
+      }
+    },
     scsc: function (input) {
       if (!scripts[input.context]) { scripts[input.context] = {}; }
       scripts[input.context][input.key] = new vm.Script(input.source);
@@ -291,6 +329,14 @@ let commands = {
       let result = scripts[input.context][input.key].runInContext(getContext(input.context));
       return formatResult(result);
     },
+    evscd: function(input) {
+      if (debug_contexts.includes(input.context)) {
+        let result = scripts[input.context][input.key].runInThisContext();
+        return formatResult(result);
+      } else {
+        return commands.oevsc(input);
+      }
+    }
     // ctxo: function (input) {
     //   return formatResult(getContextOptions(input.context));
     // },
@@ -304,7 +350,7 @@ let server = net.createServer(function(s) {
         if (data[data.length - 1] !== 4) { return; }
 
         let request = received_data.join('').toString('utf8');
-        request = request.substr(0, request.length - 1);
+        request = request.substring(0, request.length - 1);
         received_data = [];
 
         let input, result;
@@ -317,7 +363,7 @@ let server = net.createServer(function(s) {
           return;
         }
 
-        try { result = commands[input.cmd].apply(null, input.args); }
+        try { result = commands[input.cmd](input.args); }
         catch (err) {
           outputJSON = JSON.stringify(['err', ['', err].join(''), massageStackTrace(err.stack)]);
           s.write([outputJSON, "\x04"].join(''));

data/lib/isomorfeus/speednode/runtime/context.rb

@@ -3,13 +3,17 @@ module Isomorfeus
     class Runtime < ExecJS::Runtime
       class Context < ::ExecJS::Runtime::Context
         def self.finalize(runtime, uuid)
-          proc { runtime.vm.delete_context(uuid) }
+          proc do
+            runtime.vm.delete_context(uuid) rescue nil # if delete_context fails, the vm exited before probably
+          end
         end
 
         def initialize(runtime, source = "", options = {})
           @runtime = runtime
           @uuid = SecureRandom.uuid
           @permissive = !!options.delete(:permissive)
+          @debug = @permissive ? !!options.delete(:debug) { false } : false
+          @debug = false unless ENV['NODE_OPTIONS']&.include?('--inspect')
           @vm = @runtime.vm
           @context = nil
           @timeout = options[:timeout] ? options[:timeout]/1000 : 600
@@ -24,8 +28,14 @@ module Isomorfeus
           rescue
             source = source.force_encoding('UTF-8')
           end
-
-          @permissive ? raw_createp(source, options) : raw_create(source, options)
+          if @debug && @permissive
+            raw_created(source, options)
+          elsif @permissive
+            raw_createp(source, options)
+          else
+            raw_create(source, options)
+          end
+          self.add_script(key: :_internal_exec_fin, source: '!global.__LastExecutionFinished')
         end
 
         # def options
@@ -108,6 +118,14 @@ module Isomorfeus
           extract_result(result)
         end
 
+        def raw_created(source, options)
+          return if @context
+          source = encode(source)
+          result = @vm.created(@uuid, source, options)
+          @context = true
+          extract_result(result)
+        end
+
         def raw_createp(source, options)
           return if @context
           source = encode(source)
@@ -140,7 +158,7 @@ module Isomorfeus
 
         def await_result
           start_time = Time.now
-          while !execution_finished? && !timed_out?(start_time)
+          while eval_script(key: :_internal_exec_fin) && !timed_out?(start_time)
             sleep 0.005
           end
           result = exec <<~JAVASCRIPT
@@ -166,13 +184,9 @@ module Isomorfeus
           extract_result(result)
         end
 
-        def execution_finished?
-          eval 'global.__LastExecutionFinished'
-        end
-
         def timed_out?(start_time)
           if (Time.now - start_time) > @timeout
-            raise "Command Execution timed out!"
+            raise "IsomorfeusSpeednode: Command Execution timed out!"
           end
           false
         end

data/lib/isomorfeus/speednode/runtime/vm.rb

@@ -63,7 +63,7 @@ module Isomorfeus
         end
 
         def self.exit_node(socket, socket_dir, socket_path, pid)
-          VMCommand.new(socket, "exit", [0]).execute
+          VMCommand.new(socket, "exit", 0).execute rescue nil
           socket.close
           File.unlink(socket_path) if File.exist?(socket_path)
           Dir.rmdir(socket_dir) if socket_dir && Dir.exist?(socket_dir)
@@ -99,6 +99,10 @@ module Isomorfeus
           command('create', {'context' => context, 'source' => source, 'options' => options})
         end
 
+        def created(context, source, options)
+          command('created', {'context' => context, 'source' => source, 'options' => options})
+        end
+
         def createp(context, source, options)
           command('createp', {'context' => context, 'source' => source, 'options' => options})
         end
@@ -110,7 +114,7 @@ module Isomorfeus
 
         def delete_context(context)
           @mutex.synchronize do
-            VMCommand.new(@socket, "deleteContext", [context]).execute rescue nil
+            VMCommand.new(@socket, "deleteContext", context).execute rescue nil
           end
         rescue ThreadError
           nil
@@ -139,7 +143,7 @@ module Isomorfeus
           end
           @pid = Process.spawn({"SOCKET_PATH" => @socket_path}, @options[:binary], @options[:source_maps], @options[:runner_path])
 
-          retries = 100
+          retries = 500
 
           if ExecJS.windows?
             timeout_or_connected = false
@@ -166,15 +170,6 @@ module Isomorfeus
 
           @started = true
 
-          at_exit do
-            begin
-              self.class.exit_node(@socket, @socket_dir, @socket_path, @pid) unless @socket.closed?
-            rescue
-              # do nothing
-            end
-          end
-
-          ObjectSpace.define_finalizer(self, self.class.finalize(@socket, @socket_dir, @socket_path, @pid))
           Kernel.at_exit { self.class.finalize(@socket, @socket_dir, @socket_path, @pid).call }
         end
 
@@ -204,10 +199,10 @@ module Isomorfeus
           @responder.run
         end
 
-        def command(cmd, *arguments)
+        def command(cmd, argument)
           @mutex.synchronize do
             start_without_synchronization unless @started
-            VMCommand.new(@socket, cmd, arguments).execute
+            VMCommand.new(@socket, cmd, argument).execute
           end
         end
       end

data/lib/isomorfeus/speednode/version.rb

@@ -1,5 +1,5 @@
 module Isomorfeus
   module Speednode
-    VERSION = '0.5.2'
+    VERSION = '0.5.3'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: isomorfeus-speednode
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 0.5.3
 platform: ruby
 authors:
 - Jan Biedermann
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-02-19 00:00:00.000000000 Z
+date: 2022-03-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: execjs
@@ -151,7 +151,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.3
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: A fast ExecJS runtime based on nodejs, tuned for Isomorfeus.